2026-08-23 09:12:59 -07:00
|
|
|
use std::path::{Path, PathBuf};
|
2026-08-23 13:13:35 -07:00
|
|
|
use std::sync::atomic::{AtomicBool, Ordering};
|
|
|
|
|
use std::sync::{Arc, OnceLock};
|
2026-08-23 09:12:59 -07:00
|
|
|
use std::time::{Duration, SystemTime};
|
|
|
|
|
|
2026-08-23 08:30:48 -07:00
|
|
|
use base64::engine::general_purpose::STANDARD as BASE64;
|
|
|
|
|
use base64::Engine as _;
|
2026-06-30 13:48:04 -07:00
|
|
|
use bollard::container::{DownloadFromContainerOptions, LogOutput, UploadToContainerOptions};
|
|
|
|
|
use bollard::exec::{CreateExecOptions, StartExecResults};
|
2026-03-06 06:32:53 -08:00
|
|
|
use futures_util::StreamExt;
|
|
|
|
|
use serde::Serialize;
|
2026-08-23 09:12:59 -07:00
|
|
|
use tauri::{AppHandle, Manager, State};
|
2026-03-06 06:32:53 -08:00
|
|
|
|
|
|
|
|
use crate::docker::client::get_docker;
|
2026-08-23 08:30:48 -07:00
|
|
|
use crate::docker::exec::{
|
2026-08-23 13:13:35 -07:00
|
|
|
build_single_file_tar, container_user_ids, exec_oneshot_as, exec_oneshot_streams_as,
|
|
|
|
|
now_epoch_secs, OUTPUT_LIMIT_MARKER,
|
2026-08-23 08:30:48 -07:00
|
|
|
};
|
2026-03-06 06:32:53 -08:00
|
|
|
use crate::AppState;
|
|
|
|
|
|
2026-08-23 08:30:48 -07:00
|
|
|
#[derive(Debug, PartialEq, Serialize)]
|
2026-03-06 06:32:53 -08:00
|
|
|
pub struct FileEntry {
|
|
|
|
|
pub name: String,
|
|
|
|
|
pub path: String,
|
2026-08-23 08:30:48 -07:00
|
|
|
/// Whether the entry behaves as a directory — *dereferenced*, so a symlink
|
|
|
|
|
/// pointing at one is navigable rather than a dead row.
|
2026-03-06 06:32:53 -08:00
|
|
|
pub is_directory: bool,
|
2026-08-23 08:30:48 -07:00
|
|
|
/// Whether the entry itself is a symlink, which `is_directory` no longer
|
|
|
|
|
/// tells you now that it follows the link.
|
|
|
|
|
pub is_symlink: bool,
|
2026-03-06 06:32:53 -08:00
|
|
|
pub size: u64,
|
|
|
|
|
pub modified: String,
|
|
|
|
|
pub permissions: String,
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 08:30:48 -07:00
|
|
|
/// What a viewer read out of the container.
|
|
|
|
|
#[derive(Debug, Serialize)]
|
|
|
|
|
pub struct FileContents {
|
|
|
|
|
/// Base64 rather than a byte vec: Tauri serialises `Vec<u8>` over IPC as a
|
|
|
|
|
/// JSON array of numbers, which is roughly 4x the bytes and pathological at
|
|
|
|
|
/// MB scale.
|
|
|
|
|
pub contents_base64: String,
|
|
|
|
|
/// True when the file is larger than the cap and only a prefix came back.
|
|
|
|
|
pub truncated: bool,
|
|
|
|
|
/// The file's real size, from the tar header — not the length of what was
|
|
|
|
|
/// returned.
|
|
|
|
|
pub size: u64,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Hard ceiling on a single viewer read, whatever the caller asks for. The tar
|
|
|
|
|
/// path buffers the whole payload in host RAM, so a caller-supplied cap is not
|
|
|
|
|
/// something to take on trust.
|
|
|
|
|
const MAX_READ_BYTES: u64 = 8 * 1024 * 1024;
|
|
|
|
|
|
|
|
|
|
/// Ceiling on a single upload, mirroring the terminal drop path's guard. The
|
|
|
|
|
/// file is packed into an in-memory tar before it goes anywhere.
|
|
|
|
|
const MAX_UPLOAD_BYTES: u64 = 256 * 1024 * 1024;
|
|
|
|
|
|
2026-03-06 06:32:53 -08:00
|
|
|
#[tauri::command]
|
|
|
|
|
pub async fn list_container_files(
|
|
|
|
|
project_id: String,
|
|
|
|
|
path: String,
|
|
|
|
|
state: State<'_, AppState>,
|
|
|
|
|
) -> Result<Vec<FileEntry>, String> {
|
2026-08-23 11:34:04 -07:00
|
|
|
// Before anything else: an unvalidated `path` here is not a listing bug, it
|
|
|
|
|
// is an argument-injection one. See the module's path-validation section.
|
|
|
|
|
validate_container_path("Folder", &path)?;
|
|
|
|
|
|
2026-03-06 06:32:53 -08:00
|
|
|
let project = state
|
|
|
|
|
.projects_store
|
|
|
|
|
.get(&project_id)
|
|
|
|
|
.ok_or_else(|| format!("Project {} not found", project_id))?;
|
|
|
|
|
|
|
|
|
|
let container_id = project
|
|
|
|
|
.container_id
|
|
|
|
|
.as_ref()
|
|
|
|
|
.ok_or_else(|| "Container not running".to_string())?;
|
|
|
|
|
|
2026-08-23 11:34:04 -07:00
|
|
|
// `exec_oneshot` discards the exit code, which is how a `find` that listed
|
|
|
|
|
// nothing at all reached the UI as a cheerful "Empty directory". The status
|
|
|
|
|
// only decides what an *empty* result means, though: `find` also exits
|
|
|
|
|
// non-zero when a single child vanished mid-scan, and the rows it did
|
|
|
|
|
// print are still the right answer.
|
2026-08-23 13:13:35 -07:00
|
|
|
//
|
|
|
|
|
// The two streams are taken apart rather than merged: `find`'s diagnostics
|
|
|
|
|
// are the error message, its `-printf` records are the listing, and the
|
|
|
|
|
// parser should never be handed the former.
|
|
|
|
|
let (records, diagnostics, code) =
|
|
|
|
|
exec_oneshot_streams_as(container_id, "claude", list_argv(&path), Vec::new())
|
|
|
|
|
.await
|
|
|
|
|
.map_err(|e| describe_listing_failure(&path, e))?;
|
|
|
|
|
|
|
|
|
|
let entries = parse_find_output(&path, &records);
|
2026-08-23 11:34:04 -07:00
|
|
|
if code != 0 && entries.is_empty() {
|
|
|
|
|
// `find`'s own words — "Permission denied", "No such file or directory"
|
2026-08-23 13:13:35 -07:00
|
|
|
// — are the whole diagnosis.
|
|
|
|
|
let detail = diagnostics.trim();
|
2026-08-23 11:34:04 -07:00
|
|
|
return Err(if detail.is_empty() {
|
|
|
|
|
format!("Could not list {} (exit {})", path, code)
|
|
|
|
|
} else {
|
|
|
|
|
detail.to_string()
|
|
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
if code != 0 {
|
|
|
|
|
log::warn!(
|
|
|
|
|
"find exited {} listing {}; returning the {} entries it did print",
|
|
|
|
|
code,
|
|
|
|
|
path,
|
|
|
|
|
entries.len()
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
Ok(entries)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// The argv `list_container_files` runs, in one place so the format and the
|
|
|
|
|
/// parser can be pinned together.
|
|
|
|
|
///
|
|
|
|
|
/// `%y` is the entry's own type, `%Y` the type it *dereferences* to. Both are
|
|
|
|
|
/// printed: `%Y` is what decides navigability (a symlinked directory reports
|
|
|
|
|
/// `l` under `%y`, which used to make it an unopenable row), while `%y` is the
|
|
|
|
|
/// only way left to tell the user it is a link at all. `%Y` is `N` for a broken
|
|
|
|
|
/// link and `L` for a loop, neither of which is `d`.
|
|
|
|
|
///
|
|
|
|
|
/// `%f` comes *last* and records are terminated by NUL, both because of what a
|
|
|
|
|
/// filename is allowed to contain: a tab in a name used to shift every column
|
|
|
|
|
/// after it (a crafted name rendered as a directory row), and a newline in a
|
|
|
|
|
/// name could forge a whole extra row. With the name last there is nothing left
|
|
|
|
|
/// to shift, and NUL is the one byte a Linux filename cannot hold.
|
|
|
|
|
///
|
|
|
|
|
/// The separators are passed as the two-character escapes `\t` and `\0` for
|
|
|
|
|
/// `find` itself to expand: a literal NUL cannot travel in argv, which would
|
|
|
|
|
/// truncate the format string at the terminator.
|
|
|
|
|
fn list_argv(path: &str) -> Vec<String> {
|
|
|
|
|
vec![
|
2026-03-06 06:32:53 -08:00
|
|
|
"find".to_string(),
|
2026-08-23 11:34:04 -07:00
|
|
|
path.to_string(),
|
2026-03-06 08:38:48 -08:00
|
|
|
"-mindepth".to_string(),
|
|
|
|
|
"1".to_string(),
|
2026-03-06 06:32:53 -08:00
|
|
|
"-maxdepth".to_string(),
|
|
|
|
|
"1".to_string(),
|
|
|
|
|
"-printf".to_string(),
|
2026-08-23 11:34:04 -07:00
|
|
|
"%y\\t%Y\\t%s\\t%T@\\t%m\\t%f\\0".to_string(),
|
|
|
|
|
]
|
2026-08-23 08:30:48 -07:00
|
|
|
}
|
|
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
/// Turn a listing exec's failure into something the person looking at the
|
|
|
|
|
/// folder can act on.
|
|
|
|
|
///
|
|
|
|
|
/// One case is worth naming: a directory with more entries than
|
|
|
|
|
/// [`crate::docker::exec::MAX_ONESHOT_OUTPUT`] will hold. Roughly 100k names is
|
|
|
|
|
/// the point where a `find` record set passes 8 MiB, and what the panel showed
|
|
|
|
|
/// was "Command output exceeded 8388608 bytes and was abandoned" — a true
|
|
|
|
|
/// statement about a buffer, and no help at all about a directory.
|
|
|
|
|
fn describe_listing_failure(path: &str, error: String) -> String {
|
|
|
|
|
if error.starts_with(OUTPUT_LIMIT_MARKER) {
|
|
|
|
|
return format!(
|
|
|
|
|
"{} holds too many entries for this panel to list. Open it in a terminal, or look at a subfolder.",
|
|
|
|
|
path
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
error
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 11:34:04 -07:00
|
|
|
/// Turn `find -printf '%y\t%Y\t%s\t%T@\t%m\t%f\0'` output into sorted entries.
|
2026-08-23 08:30:48 -07:00
|
|
|
///
|
|
|
|
|
/// Split out from the command so it can be tested without a container: it is
|
|
|
|
|
/// the half where a format change silently mis-types every row.
|
2026-08-23 11:34:04 -07:00
|
|
|
///
|
|
|
|
|
/// Records are NUL-terminated and the name is the *last* field, so the split is
|
|
|
|
|
/// capped at six pieces: whatever tabs a filename contains land inside the name
|
|
|
|
|
/// instead of shifting the type, size and permission columns along one.
|
2026-08-23 08:30:48 -07:00
|
|
|
fn parse_find_output(dir: &str, output: &str) -> Vec<FileEntry> {
|
2026-03-06 06:32:53 -08:00
|
|
|
let mut entries: Vec<FileEntry> = output
|
2026-08-23 11:34:04 -07:00
|
|
|
.split('\0')
|
|
|
|
|
.filter(|record| !record.trim().is_empty())
|
|
|
|
|
.filter_map(|record| {
|
|
|
|
|
let mut parts = record.splitn(6, '\t');
|
|
|
|
|
let own_type = parts.next()?;
|
|
|
|
|
let deref_type = parts.next()?;
|
|
|
|
|
let size_field = parts.next()?;
|
|
|
|
|
let mtime_field = parts.next()?;
|
|
|
|
|
let mode_field = parts.next()?;
|
|
|
|
|
let name = parts.next()?.to_string();
|
|
|
|
|
if name.is_empty() {
|
2026-03-06 06:32:53 -08:00
|
|
|
return None;
|
|
|
|
|
}
|
2026-08-23 11:34:04 -07:00
|
|
|
let is_symlink = own_type == "l";
|
|
|
|
|
let is_directory = deref_type == "d";
|
|
|
|
|
let size = size_field.parse::<u64>().unwrap_or(0);
|
|
|
|
|
let modified_epoch = mtime_field.parse::<f64>().unwrap_or(0.0);
|
|
|
|
|
let permissions = mode_field.to_string();
|
2026-03-06 06:32:53 -08:00
|
|
|
|
|
|
|
|
// Convert epoch to ISO-ish string
|
|
|
|
|
let modified = {
|
|
|
|
|
let secs = modified_epoch as i64;
|
|
|
|
|
let dt = chrono::DateTime::from_timestamp(secs, 0)
|
|
|
|
|
.unwrap_or_default();
|
|
|
|
|
dt.format("%Y-%m-%d %H:%M:%S").to_string()
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
Some(FileEntry {
|
2026-08-23 08:30:48 -07:00
|
|
|
name: name.clone(),
|
|
|
|
|
path: join_path(dir, &name),
|
2026-03-06 06:32:53 -08:00
|
|
|
is_directory,
|
2026-08-23 08:30:48 -07:00
|
|
|
is_symlink,
|
2026-03-06 06:32:53 -08:00
|
|
|
size,
|
|
|
|
|
modified,
|
|
|
|
|
permissions,
|
|
|
|
|
})
|
|
|
|
|
})
|
|
|
|
|
.collect();
|
|
|
|
|
|
|
|
|
|
// Sort: directories first, then alphabetical
|
|
|
|
|
entries.sort_by(|a, b| {
|
|
|
|
|
b.is_directory
|
|
|
|
|
.cmp(&a.is_directory)
|
|
|
|
|
.then_with(|| a.name.to_lowercase().cmp(&b.name.to_lowercase()))
|
|
|
|
|
});
|
|
|
|
|
|
2026-08-23 08:30:48 -07:00
|
|
|
entries
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Join a container directory and a child name without doubling the separator.
|
|
|
|
|
fn join_path(dir: &str, name: &str) -> String {
|
|
|
|
|
if dir.ends_with('/') {
|
|
|
|
|
format!("{}{}", dir, name)
|
|
|
|
|
} else {
|
|
|
|
|
format!("{}/{}", dir, name)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// The directory holding `path`. `/` is its own parent.
|
|
|
|
|
fn parent_dir(path: &str) -> String {
|
|
|
|
|
let trimmed = path.trim_end_matches('/');
|
|
|
|
|
match trimmed.rfind('/') {
|
|
|
|
|
None | Some(0) => "/".to_string(),
|
|
|
|
|
Some(i) => trimmed[..i].to_string(),
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Validate the *new name* half of a rename, or a new folder's name.
|
|
|
|
|
///
|
|
|
|
|
/// This is user-typed text that ends up in `mv`/`mkdir` argv, and the operation
|
|
|
|
|
/// is deliberately a rename rather than a move: a name carrying `/` would
|
|
|
|
|
/// relocate the entry, and `..` would walk it out of the directory entirely.
|
|
|
|
|
/// A leading `-` is left alone because every call site passes `--` first.
|
|
|
|
|
fn validate_entry_name(name: &str) -> Result<(), String> {
|
|
|
|
|
if name.is_empty() {
|
|
|
|
|
return Err("Name cannot be empty".to_string());
|
|
|
|
|
}
|
|
|
|
|
if name.contains('/') {
|
|
|
|
|
return Err(
|
|
|
|
|
"Name cannot contain '/' — this renames inside the folder, it does not move."
|
|
|
|
|
.to_string(),
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
// Can't survive argv anyway; caught here so the failure is legible.
|
|
|
|
|
if name.contains('\0') {
|
|
|
|
|
return Err("Name cannot contain a null byte".to_string());
|
|
|
|
|
}
|
|
|
|
|
if name == "." || name == ".." {
|
|
|
|
|
return Err("\".\" and \"..\" are not valid names".to_string());
|
|
|
|
|
}
|
|
|
|
|
if name.len() > 255 {
|
|
|
|
|
return Err("Name is too long (255 bytes maximum)".to_string());
|
|
|
|
|
}
|
|
|
|
|
Ok(())
|
2026-03-06 06:32:53 -08:00
|
|
|
}
|
|
|
|
|
|
2026-08-23 11:34:04 -07:00
|
|
|
// ─────────────────────────────────────────────────────────────────────────────
|
|
|
|
|
// Path validation
|
|
|
|
|
// ─────────────────────────────────────────────────────────────────────────────
|
|
|
|
|
//
|
|
|
|
|
// `validate_entry_name` above covers the *new name* half of rename and mkdir.
|
|
|
|
|
// The paths themselves — `path`, `from_path`, `parent_path`, `container_dir`,
|
|
|
|
|
// `container_path`, `host_path` — arrived over IPC entirely unchecked, and both
|
|
|
|
|
// ends of the trip are real: a container path under `/workspace/{mount_name}`
|
|
|
|
|
// is a host bind mount, i.e. the user's actual repository, and a host path is
|
|
|
|
|
// the host.
|
|
|
|
|
//
|
|
|
|
|
// The listing command is the reason this section exists. `find` ends its list
|
|
|
|
|
// of starting points at the first argument beginning with `-`, so a `path` of
|
|
|
|
|
// `-delete` supplied zero starting points (it defaults to `.`, and the exec
|
|
|
|
|
// inherits the container's WorkingDir — the bind-mounted project) and an
|
|
|
|
|
// expression of `-delete -mindepth 1 -maxdepth 1 -printf …`. Verified against a
|
|
|
|
|
// live container on findutils 4.9.0 and again on 4.10.0: it deletes files and
|
|
|
|
|
// empty directories out of the bind mount, and `exec_oneshot` threw away the
|
|
|
|
|
// exit status, so the panel reported an empty folder afterwards. A `--`
|
|
|
|
|
// separator is *not* the fix — `find` has no such convention for starting
|
|
|
|
|
// points — but requiring the path to be absolute is, and it is the same check
|
|
|
|
|
// that stops `..` traversal.
|
|
|
|
|
|
|
|
|
|
/// `PATH_MAX` on Linux. Nothing legitimate comes close; a path longer than this
|
|
|
|
|
/// cannot name a file in the container anyway.
|
|
|
|
|
const MAX_CONTAINER_PATH_LEN: usize = 4096;
|
|
|
|
|
|
|
|
|
|
/// Container roots this panel may *create, rename or upload into*.
|
|
|
|
|
///
|
|
|
|
|
/// Reads are deliberately not restricted this way (see
|
|
|
|
|
/// [`validate_container_path`]): the Files tab is a browser, `/etc/os-release`
|
|
|
|
|
/// and `/usr/lib` are legitimate things to look at, and for reading, the
|
|
|
|
|
/// container user's own permissions are the boundary that matters.
|
|
|
|
|
///
|
|
|
|
|
/// Writes are restricted, because a write here lands in one of exactly two
|
|
|
|
|
/// places worth protecting and nowhere else is worth reaching:
|
|
|
|
|
/// * `/workspace` — the project bind mounts, i.e. host files;
|
|
|
|
|
/// * `/home/claude` — the persisted home volume (settings, skills, session
|
|
|
|
|
/// history), which users legitimately reorganise from this panel, so it
|
|
|
|
|
/// cannot be excluded even though `.claude/.credentials.json` lives there;
|
|
|
|
|
/// * `/tmp` — where terminal drops and pasted images are staged.
|
|
|
|
|
/// Everything else is either read-only image content or a system directory
|
|
|
|
|
/// where the container user's `mv` fails anyway. Refusing up front turns a
|
|
|
|
|
/// confusing "Permission denied" into a clear sentence, and keeps a caller out
|
|
|
|
|
/// of `/etc` in a container that happens to run as root.
|
|
|
|
|
const CONTAINER_WRITE_ROOTS: &[&str] = &["/workspace", "/home/claude", "/tmp"];
|
|
|
|
|
|
|
|
|
|
/// Structural validation for any container path arriving over IPC.
|
|
|
|
|
///
|
|
|
|
|
/// `what` names the parameter in the error, because these messages are shown to
|
|
|
|
|
/// a user who is looking at a folder, not at argv.
|
|
|
|
|
fn validate_container_path(what: &str, path: &str) -> Result<(), String> {
|
|
|
|
|
if path.is_empty() {
|
|
|
|
|
return Err(format!("{} path cannot be empty", what));
|
|
|
|
|
}
|
|
|
|
|
if !path.starts_with('/') {
|
|
|
|
|
// Absoluteness is what makes the string a *path* rather than an
|
|
|
|
|
// argument: `-delete` is refused right here, and so is anything that
|
|
|
|
|
// would otherwise be resolved against a working directory nobody chose.
|
|
|
|
|
return Err(format!(
|
|
|
|
|
"{} path must be absolute (start with \"/\"): {}",
|
|
|
|
|
what, path
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
if path.contains('\0') {
|
|
|
|
|
return Err(format!("{} path cannot contain a null byte", what));
|
|
|
|
|
}
|
|
|
|
|
// Rejected rather than normalised: a `..` in a path the UI built is a bug,
|
|
|
|
|
// and a `..` in a path the UI did not build is an attempt to leave the
|
|
|
|
|
// folder the user is looking at.
|
|
|
|
|
if path.split('/').any(|segment| segment == "..") {
|
|
|
|
|
return Err(format!("{} path cannot contain \"..\": {}", what, path));
|
|
|
|
|
}
|
|
|
|
|
if path.len() > MAX_CONTAINER_PATH_LEN {
|
|
|
|
|
return Err(format!("{} path is too long ({} bytes maximum)", what, MAX_CONTAINER_PATH_LEN));
|
|
|
|
|
}
|
|
|
|
|
Ok(())
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// [`validate_container_path`] plus containment in [`CONTAINER_WRITE_ROOTS`],
|
|
|
|
|
/// for every path this module is about to change something at.
|
2026-08-23 13:13:35 -07:00
|
|
|
///
|
|
|
|
|
/// **Lexical, and only lexical.** `/workspace/link/x` is "under `/workspace`"
|
|
|
|
|
/// as a string no matter what `/workspace/link` points at, so this on its own
|
|
|
|
|
/// does not keep an operation inside the write roots — [`resolve_container_dir`]
|
|
|
|
|
/// is what asks the container where the path actually goes.
|
|
|
|
|
///
|
|
|
|
|
/// Worth being clear about what that resolution is and is not for. It is not a
|
|
|
|
|
/// containment boundary: the container user has a shell, and anything this
|
|
|
|
|
/// panel could be tricked into writing through a symlink it could write
|
|
|
|
|
/// directly. What it buys is that the *panel* keeps its promise — the roots
|
|
|
|
|
/// named in the refusal are the roots it writes to — and that a mis-aimed drop
|
|
|
|
|
/// cannot quietly land outside them.
|
2026-08-23 11:34:04 -07:00
|
|
|
fn validate_container_write_path(what: &str, path: &str) -> Result<(), String> {
|
|
|
|
|
validate_container_path(what, path)?;
|
|
|
|
|
if CONTAINER_WRITE_ROOTS
|
|
|
|
|
.iter()
|
|
|
|
|
.any(|root| is_under_root(path, root))
|
|
|
|
|
{
|
|
|
|
|
return Ok(());
|
|
|
|
|
}
|
|
|
|
|
Err(format!(
|
|
|
|
|
"{} path is outside the folders this panel can change ({}): {}",
|
|
|
|
|
what,
|
|
|
|
|
CONTAINER_WRITE_ROOTS.join(", "),
|
|
|
|
|
path
|
|
|
|
|
))
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
/// Resolve a container *directory* and check where it really lands.
|
|
|
|
|
///
|
|
|
|
|
/// `realpath -m` because the path is being written into rather than read: `-m`
|
|
|
|
|
/// wants no component to exist, which is what makes it usable for the parent of
|
|
|
|
|
/// a `mkdir`. The resolved answer goes back through
|
|
|
|
|
/// [`validate_container_write_path`], so a symlink out of `/workspace` is
|
|
|
|
|
/// refused by the same sentence a literal `/etc` would be.
|
|
|
|
|
///
|
|
|
|
|
/// The caller keeps operating on the path the *user* typed rather than on the
|
|
|
|
|
/// resolved one: they name the same directory, and the unresolved form is the
|
|
|
|
|
/// one the listing shows and the UI navigates back to. What is validated and
|
|
|
|
|
/// what is operated on can therefore drift if a link is swapped in between —
|
|
|
|
|
/// this is a container-side TOCTOU with the same shape as H4's, and unlike H4's
|
|
|
|
|
/// it costs nothing, because both sides of the window are already inside the
|
|
|
|
|
/// container's own trust boundary.
|
|
|
|
|
///
|
|
|
|
|
/// A `realpath` that cannot run at all (an image without coreutils) is logged
|
|
|
|
|
/// and the lexical answer stands: failing every write closed would break the
|
|
|
|
|
/// panel outright for a risk the container user does not need this code path to
|
|
|
|
|
/// take.
|
|
|
|
|
async fn resolve_container_dir(container_id: &str, what: &str, dir: &str) -> Result<(), String> {
|
|
|
|
|
validate_container_write_path(what, dir)?;
|
|
|
|
|
|
|
|
|
|
let (output, code) = exec_oneshot_as(
|
|
|
|
|
container_id,
|
|
|
|
|
"claude",
|
|
|
|
|
vec![
|
|
|
|
|
"realpath".to_string(),
|
|
|
|
|
"-m".to_string(),
|
|
|
|
|
"--".to_string(),
|
|
|
|
|
dir.to_string(),
|
|
|
|
|
],
|
|
|
|
|
Vec::new(),
|
|
|
|
|
)
|
|
|
|
|
.await?;
|
|
|
|
|
|
|
|
|
|
let resolved = output.trim();
|
|
|
|
|
if code != 0 || resolved.is_empty() {
|
|
|
|
|
log::warn!(
|
|
|
|
|
"Could not resolve {} in the container (exit {}); using the literal path",
|
|
|
|
|
dir,
|
|
|
|
|
code
|
|
|
|
|
);
|
|
|
|
|
return Ok(());
|
|
|
|
|
}
|
|
|
|
|
if resolved == dir {
|
|
|
|
|
return Ok(());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
validate_container_write_path(what, resolved).map_err(|e| {
|
|
|
|
|
format!("{} leads to {} — {}", dir, resolved, e)
|
|
|
|
|
})
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 11:34:04 -07:00
|
|
|
/// Whether `path` is `root` itself or something beneath it.
|
|
|
|
|
///
|
|
|
|
|
/// Compared by whole segments, so `/workspace-backup` is not "under"
|
|
|
|
|
/// `/workspace` — a plain `starts_with` is the classic way to get that wrong.
|
|
|
|
|
fn is_under_root(path: &str, root: &str) -> bool {
|
|
|
|
|
let path = path.trim_end_matches('/');
|
|
|
|
|
let root = root.trim_end_matches('/');
|
|
|
|
|
path == root || path.strip_prefix(root).is_some_and(|rest| rest.starts_with('/'))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// What a host path is about to be used for. The two directions differ over
|
|
|
|
|
/// hidden names — see [`validate_host_path`].
|
|
|
|
|
#[derive(Clone, Copy, Debug, PartialEq)]
|
|
|
|
|
enum HostPathUse {
|
|
|
|
|
/// Host bytes are about to be read *into* the container.
|
|
|
|
|
Read,
|
|
|
|
|
/// Container bytes are about to be written *onto* the host.
|
|
|
|
|
Write,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Host directories nothing in this app has any business reading a file out of
|
|
|
|
|
/// or writing one into.
|
|
|
|
|
///
|
|
|
|
|
/// Defence in depth, not the boundary: most of these are root-owned and the
|
|
|
|
|
/// write would fail anyway. They are listed so that a build running with more
|
|
|
|
|
/// privilege than usual still cannot be talked into replacing a system file,
|
|
|
|
|
/// and so the refusal is a sentence rather than an errno. Compared after
|
2026-08-23 13:13:35 -07:00
|
|
|
/// [`normalize_host_path`] and lowercasing, which is what makes the Windows
|
|
|
|
|
/// entries work.
|
2026-08-23 11:34:04 -07:00
|
|
|
const HOST_SYSTEM_ROOTS: &[&str] = &[
|
2026-08-23 13:13:35 -07:00
|
|
|
"/bin", "/boot", "/dev", "/etc", "/lib", "/lib32", "/lib64", "/libx32", "/opt", "/proc",
|
|
|
|
|
"/root", "/sbin", "/snap", "/srv", "/sys", "/usr", "/var",
|
|
|
|
|
// macOS keeps its own copies of the same idea. Its `/etc` and `/var` are
|
|
|
|
|
// symlinks into `/private`, and the check now runs on the *resolved* path
|
|
|
|
|
// (see [`resolve_host_path`]), so the resolved spellings have to be here
|
|
|
|
|
// too. `/private/tmp` deliberately is not: that is what an entirely
|
|
|
|
|
// ordinary `/tmp/report.pdf` resolves to on a Mac.
|
|
|
|
|
"/system", "/library", "/applications", "/private/etc", "/private/var",
|
2026-08-23 11:34:04 -07:00
|
|
|
// Windows.
|
|
|
|
|
"c:/windows", "c:/program files", "c:/program files (x86)", "c:/programdata",
|
|
|
|
|
];
|
|
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
/// Places that sit *under* a [`HOST_SYSTEM_ROOTS`] entry and are nonetheless
|
|
|
|
|
/// entirely ordinary, because a real system puts real user data there.
|
|
|
|
|
///
|
|
|
|
|
/// Both of these only started to matter once the check ran on the *resolved*
|
|
|
|
|
/// path: `/home` is a symlink to `/var/home` on rpm-ostree systems (Fedora
|
|
|
|
|
/// Silverblue and friends), and a Mac's per-user temp directory resolves into
|
|
|
|
|
/// `/private/var/folders`. Without these, saving a download to your own home
|
|
|
|
|
/// directory on Silverblue is "that is a system location".
|
|
|
|
|
const HOST_SYSTEM_ROOT_EXCEPTIONS: &[&str] = &["/var/home", "/var/folders", "/private/var/folders"];
|
|
|
|
|
|
|
|
|
|
/// Directory *tails* whose contents the OS runs on the user's behalf at login.
|
|
|
|
|
///
|
|
|
|
|
/// The same defence-in-depth footing as [`HOST_SYSTEM_ROOTS`], and the same
|
|
|
|
|
/// caveat in stronger form: this is a list of places that happen to be known,
|
|
|
|
|
/// not a description of the ones that exist. See [`validate_host_path`] for why
|
|
|
|
|
/// the write policy cannot be finished here.
|
|
|
|
|
const HOST_AUTORUN_DIRS: &[&[&str]] = &[
|
|
|
|
|
&["library", "launchagents"],
|
|
|
|
|
&["library", "launchdaemons"],
|
|
|
|
|
&["library", "startupitems"],
|
|
|
|
|
&["start menu", "programs", "startup"],
|
|
|
|
|
];
|
|
|
|
|
|
|
|
|
|
/// Length of a `C:` drive prefix at the head of `path`, or 0.
|
|
|
|
|
fn drive_prefix_len(path: &str) -> usize {
|
|
|
|
|
let b = path.as_bytes();
|
|
|
|
|
if b.len() >= 2 && b[0].is_ascii_alphabetic() && b[1] == b':' {
|
|
|
|
|
2
|
|
|
|
|
} else {
|
|
|
|
|
0
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Whether `path` is written in Windows form, and so whether `\` separates its
|
|
|
|
|
/// components. On Linux a backslash is an ordinary filename character, which is
|
|
|
|
|
/// why this is a question rather than an unconditional substitution.
|
|
|
|
|
fn is_windows_style_path(path: &str) -> bool {
|
|
|
|
|
cfg!(windows) || path.starts_with("\\\\") || drive_prefix_len(path) > 0
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// `path` with its separators unified and any Win32 verbatim/device prefix
|
|
|
|
|
/// removed — the form every rule below is expressed against.
|
|
|
|
|
///
|
|
|
|
|
/// `\\?\C:\Windows` and `\\?\UNC\server\share` name the *same locations* as
|
|
|
|
|
/// `C:\Windows` and `\\server\share`; the prefix only turns off Win32 path
|
|
|
|
|
/// parsing. Stripping it is what stops four characters being a bypass of
|
|
|
|
|
/// [`HOST_SYSTEM_ROOTS`] — and it has to run on our own output as well, because
|
|
|
|
|
/// `std::fs::canonicalize` hands back exactly that spelling on Windows.
|
|
|
|
|
fn normalize_host_path(path: &str) -> String {
|
|
|
|
|
let mut s = if is_windows_style_path(path) {
|
|
|
|
|
path.replace('\\', "/")
|
|
|
|
|
} else {
|
|
|
|
|
path.to_string()
|
|
|
|
|
};
|
|
|
|
|
// Slicing by byte index is safe here only because a prefix matched
|
|
|
|
|
// case-insensitively as ASCII is ASCII, so its end is a char boundary.
|
|
|
|
|
for prefix in ["//?/unc/", "//./unc/"] {
|
|
|
|
|
if s.len() >= prefix.len() && s.as_bytes()[..prefix.len()].eq_ignore_ascii_case(prefix.as_bytes()) {
|
|
|
|
|
return format!("//{}", &s[prefix.len()..]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
for prefix in ["//?/", "//./"] {
|
|
|
|
|
if s.len() >= prefix.len() && s.as_bytes()[..prefix.len()].eq_ignore_ascii_case(prefix.as_bytes()) {
|
|
|
|
|
s = s[prefix.len()..].to_string();
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
s
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// The named components of a host path, with the drive letter, the separators
|
|
|
|
|
/// and any `.` dropped.
|
|
|
|
|
fn host_path_names(path: &str) -> Vec<String> {
|
|
|
|
|
let norm = normalize_host_path(path);
|
|
|
|
|
norm[drive_prefix_len(&norm)..]
|
|
|
|
|
.split('/')
|
|
|
|
|
.filter(|s| !s.is_empty() && *s != ".")
|
|
|
|
|
.map(|s| s.to_string())
|
|
|
|
|
.collect()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Whether `path` names a location at all, on whichever platform wrote it.
|
|
|
|
|
///
|
|
|
|
|
/// Deliberately not [`Path::is_absolute`], which answers for the *host*
|
|
|
|
|
/// platform: under it a Windows path on Linux is simply "not absolute", every
|
|
|
|
|
/// Windows rule below goes unreached, and the tests that thought they were
|
|
|
|
|
/// exercising them were only ever exercising this line.
|
|
|
|
|
fn is_absolute_host_path(path: &str) -> bool {
|
|
|
|
|
let norm = normalize_host_path(path);
|
|
|
|
|
norm.starts_with('/') || norm[drive_prefix_len(&norm)..].starts_with('/')
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// A UNC path rewritten as the local path it actually reaches, when the share
|
|
|
|
|
/// is an administrative one: `\\host\C$\Windows` *is* `C:\Windows`, and
|
|
|
|
|
/// `\\host\ADMIN$` is the Windows directory itself. An ordinary file share has
|
|
|
|
|
/// no local equivalent and gets `None` — [`HOST_SYSTEM_ROOTS`] cannot reason
|
|
|
|
|
/// about someone else's server, and says so rather than guessing.
|
|
|
|
|
fn admin_share_target(norm_lower: &str) -> Option<String> {
|
|
|
|
|
let mut parts = norm_lower.strip_prefix("//")?.splitn(3, '/');
|
|
|
|
|
let _server = parts.next()?;
|
|
|
|
|
let share = parts.next()?;
|
|
|
|
|
let tail = parts.next().unwrap_or("");
|
|
|
|
|
let b = share.as_bytes();
|
|
|
|
|
if b.len() == 2 && b[0].is_ascii_alphabetic() && b[1] == b'$' {
|
|
|
|
|
Some(format!("{}:/{}", b[0] as char, tail))
|
|
|
|
|
} else if share == "admin$" {
|
|
|
|
|
Some(format!("c:/windows/{}", tail))
|
|
|
|
|
} else {
|
|
|
|
|
None
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// The [`HOST_SYSTEM_ROOTS`] entry `path` falls under, if any.
|
|
|
|
|
///
|
|
|
|
|
/// Pure, and platform-independent on purpose: this is the whole of the Windows
|
|
|
|
|
/// policy, so it is also the whole of what the tests have to be able to drive
|
|
|
|
|
/// from a Linux CI box.
|
|
|
|
|
fn host_system_root_for(path: &str) -> Option<&'static str> {
|
|
|
|
|
let norm = normalize_host_path(path).to_lowercase();
|
|
|
|
|
if HOST_SYSTEM_ROOT_EXCEPTIONS
|
|
|
|
|
.iter()
|
|
|
|
|
.any(|allowed| is_under_root(&norm, allowed))
|
|
|
|
|
{
|
|
|
|
|
return None;
|
|
|
|
|
}
|
|
|
|
|
let admin = admin_share_target(&norm);
|
|
|
|
|
HOST_SYSTEM_ROOTS.iter().copied().find(|root| {
|
|
|
|
|
is_under_root(&norm, root) || admin.as_deref().is_some_and(|p| is_under_root(p, root))
|
|
|
|
|
})
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Whether these directory components end in one of [`HOST_AUTORUN_DIRS`].
|
|
|
|
|
fn is_autorun_dir(names: &[String]) -> bool {
|
|
|
|
|
HOST_AUTORUN_DIRS.iter().any(|tail| {
|
|
|
|
|
names.len() >= tail.len()
|
|
|
|
|
&& names[names.len() - tail.len()..]
|
|
|
|
|
.iter()
|
|
|
|
|
.zip(tail.iter())
|
|
|
|
|
.all(|(have, want)| have.eq_ignore_ascii_case(want))
|
|
|
|
|
})
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Structural and policy checks on a host path *as written*, returning it as a
|
|
|
|
|
/// [`PathBuf`].
|
2026-08-23 11:34:04 -07:00
|
|
|
///
|
|
|
|
|
/// The `save()`/`open()` dialog the Files pane puts in front of these commands
|
|
|
|
|
/// is a UI convention, not a boundary — every one of them is a single `invoke`
|
|
|
|
|
/// away from any code running in the webview, with a container-controlled
|
2026-08-23 13:13:35 -07:00
|
|
|
/// payload on one side. So the backend has its own policy:
|
2026-08-23 11:34:04 -07:00
|
|
|
///
|
2026-08-23 13:13:35 -07:00
|
|
|
/// * absolute, no `..`, no NUL — judged on the path's own components, so a
|
|
|
|
|
/// Windows path is judged as one wherever this runs;
|
|
|
|
|
/// * nothing under [`HOST_SYSTEM_ROOTS`] or in a login-item directory;
|
|
|
|
|
/// * no *hidden* path components. The interesting targets for "write a
|
|
|
|
|
/// container-controlled file to an arbitrary host path" are mostly dot
|
|
|
|
|
/// directories — `~/.ssh/authorized_keys`, `~/.config/autostart/`,
|
|
|
|
|
/// `~/.claude/` — and the interesting targets for the reverse, reading a
|
|
|
|
|
/// host file into the container, are the same ones plus `~/.aws/credentials`.
|
|
|
|
|
/// A download is refused a hidden *name* too (creating `~/.bashrc` is escape
|
|
|
|
|
/// all by itself); an upload only cares about hidden *directories*, because
|
|
|
|
|
/// dragging a project's own `.env` into the container is an ordinary thing
|
|
|
|
|
/// to do and its parent is not hidden.
|
2026-08-23 11:34:04 -07:00
|
|
|
///
|
2026-08-23 13:13:35 -07:00
|
|
|
/// **This is a lexical check on a string, and lexical is not enough on its own.**
|
|
|
|
|
/// A path whose components are all visible can still lead somewhere hidden, so
|
|
|
|
|
/// nothing calls this directly any more: [`resolve_host_path`] resolves the
|
|
|
|
|
/// symlinks first and then applies this to the answer. Keeping the two apart is
|
|
|
|
|
/// what lets the policy stay pure and testable while the thing it judges is the
|
|
|
|
|
/// path that will really be opened.
|
|
|
|
|
///
|
|
|
|
|
/// **And the policy itself is a denylist, which is losing by construction.**
|
|
|
|
|
/// `~/Library/LaunchAgents`, `%AppData%\…\Startup`, `~/bin` and `/opt` are only
|
|
|
|
|
/// refused because someone thought of them; the next persistence directory is
|
|
|
|
|
/// not. The honest fix is not a longer list — it is for the *backend* to own the
|
|
|
|
|
/// file dialog (`tauri-plugin-dialog` can be driven from Rust) so that the only
|
|
|
|
|
/// host paths these commands accept are ones the user just pointed at, and no
|
|
|
|
|
/// path arrives over IPC at all. That is a frontend change as well as this one.
|
|
|
|
|
/// Until then: this list is defence in depth, and the dialog is the boundary.
|
2026-08-23 11:34:04 -07:00
|
|
|
fn validate_host_path(path: &str, use_for: HostPathUse) -> Result<PathBuf, String> {
|
|
|
|
|
if path.trim().is_empty() {
|
|
|
|
|
return Err("No host path was given".to_string());
|
|
|
|
|
}
|
|
|
|
|
if path.contains('\0') {
|
|
|
|
|
return Err("Host path cannot contain a null byte".to_string());
|
|
|
|
|
}
|
2026-08-23 13:13:35 -07:00
|
|
|
if !is_absolute_host_path(path) {
|
2026-08-23 11:34:04 -07:00
|
|
|
return Err(format!("Host path must be absolute: {}", path));
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
let names = host_path_names(path);
|
|
|
|
|
if names.iter().any(|n| n == "..") {
|
2026-08-23 11:34:04 -07:00
|
|
|
return Err(format!("Host path cannot contain \"..\": {}", path));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// The final component is the file itself; everything before it is a
|
|
|
|
|
// directory the path passes *through*.
|
|
|
|
|
let hidden_limit = match use_for {
|
|
|
|
|
HostPathUse::Write => names.len(),
|
|
|
|
|
HostPathUse::Read => names.len().saturating_sub(1),
|
|
|
|
|
};
|
|
|
|
|
if let Some(hidden) = names[..hidden_limit].iter().find(|n| n.starts_with('.')) {
|
|
|
|
|
return Err(format!(
|
|
|
|
|
"\"{}\" is a hidden {} — Triple-C will not {} there. Choose a visible location.",
|
|
|
|
|
hidden,
|
|
|
|
|
if names.last() == Some(hidden) { "file" } else { "folder" },
|
|
|
|
|
if use_for == HostPathUse::Write { "save" } else { "read" }
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
let dirs = &names[..names.len().saturating_sub(1)];
|
|
|
|
|
if use_for == HostPathUse::Write && is_autorun_dir(dirs) {
|
|
|
|
|
return Err(format!(
|
|
|
|
|
"{} is a startup folder — Triple-C will not save there. Choose an ordinary location.",
|
|
|
|
|
dirs.last().map(String::as_str).unwrap_or(path)
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if let Some(root) = host_system_root_for(path) {
|
2026-08-23 11:34:04 -07:00
|
|
|
return Err(format!(
|
|
|
|
|
"{} is a system location — Triple-C will not {} files there.",
|
|
|
|
|
root,
|
|
|
|
|
if use_for == HostPathUse::Write { "write" } else { "read" }
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
Ok(PathBuf::from(path))
|
2026-08-23 11:34:04 -07:00
|
|
|
}
|
|
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
/// The host path a command is really going to open: every symlink in it
|
|
|
|
|
/// resolved by the OS, and [`validate_host_path`]'s policy applied a second
|
|
|
|
|
/// time to the answer.
|
|
|
|
|
///
|
|
|
|
|
/// H4, and the reason the lexical check alone was not a check. Nothing here
|
|
|
|
|
/// used to call `canonicalize`, so the rules above were being applied to a
|
|
|
|
|
/// string rather than to a location: with `~/Downloads/pub` a symlink to
|
|
|
|
|
/// `~/.ssh`, a `host_path` of `~/Downloads/pub/authorized_keys` has no hidden
|
|
|
|
|
/// component, is under no system root, and lands in `~/.ssh` anyway. The
|
|
|
|
|
/// container can plant that link *and know where to plant it* —
|
|
|
|
|
/// `/proc/self/mountinfo` inside a Triple-C container spells the host's
|
|
|
|
|
/// project paths out verbatim. The same trick worked in the other direction,
|
|
|
|
|
/// reading `~/.ssh/id_rsa` into the container through a visible name.
|
|
|
|
|
///
|
|
|
|
|
/// A write resolves the *parent* and keeps the caller's leaf, because the leaf
|
|
|
|
|
/// is never followed: the partial file is created with `create_new`
|
|
|
|
|
/// (`O_EXCL`, which refuses a symlink outright) and [`finish_download`]
|
|
|
|
|
/// finishes with a rename, which replaces a link rather than writing through
|
|
|
|
|
/// it. A read resolves the whole path, because the whole path is opened.
|
|
|
|
|
///
|
|
|
|
|
/// What this does **not** close by itself is the swap between resolving and
|
|
|
|
|
/// opening; [`verify_opened_path`] is the other half.
|
|
|
|
|
async fn resolve_host_path(path: &str, use_for: HostPathUse) -> Result<PathBuf, String> {
|
|
|
|
|
let candidate = validate_host_path(path, use_for)?;
|
|
|
|
|
|
|
|
|
|
let resolved = match use_for {
|
|
|
|
|
HostPathUse::Read => tokio::fs::canonicalize(&candidate)
|
|
|
|
|
.await
|
|
|
|
|
.map_err(|e| format!("Cannot access {}: {}", candidate.display(), e))?,
|
|
|
|
|
HostPathUse::Write => {
|
|
|
|
|
let parent = candidate
|
|
|
|
|
.parent()
|
|
|
|
|
.ok_or_else(|| format!("{} does not name a file", candidate.display()))?;
|
|
|
|
|
let name = candidate
|
|
|
|
|
.file_name()
|
|
|
|
|
.ok_or_else(|| format!("{} does not name a file", candidate.display()))?;
|
|
|
|
|
let dir = tokio::fs::canonicalize(parent)
|
|
|
|
|
.await
|
|
|
|
|
.map_err(|e| format!("Cannot save into {}: {}", parent.display(), e))?;
|
|
|
|
|
let joined = dir.join(name);
|
|
|
|
|
// Windows hands out 8.3 aliases, and `BASHRC~1` is a perfectly
|
|
|
|
|
// ordinary-looking name for `.bashrc`. So a leaf that already
|
|
|
|
|
// exists is judged under the name the filesystem gives it as well
|
|
|
|
|
// as the one the caller typed. Only the *name* is taken from the
|
|
|
|
|
// canonical form: a destination that is a symlink gets replaced by
|
|
|
|
|
// the rename, never followed, so its target is not what is at risk.
|
|
|
|
|
if let Ok(full) = tokio::fs::canonicalize(&joined).await {
|
|
|
|
|
let real = full.file_name().map(|n| n.to_string_lossy().to_string());
|
|
|
|
|
if real.as_deref().is_some_and(|n| n.starts_with('.')) {
|
|
|
|
|
return Err(format!(
|
|
|
|
|
"\"{}\" is a hidden file — Triple-C will not save there. Choose a visible location.",
|
|
|
|
|
real.unwrap_or_default()
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
joined
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
validate_host_path(&resolved.to_string_lossy(), use_for).map_err(|e| {
|
|
|
|
|
if resolved == candidate {
|
|
|
|
|
e
|
|
|
|
|
} else {
|
|
|
|
|
format!("{} resolves to {} — {}", path, resolved.display(), e)
|
|
|
|
|
}
|
|
|
|
|
})?;
|
|
|
|
|
|
|
|
|
|
Ok(resolved)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Confirm that the handle we are holding is the file we validated.
|
|
|
|
|
///
|
|
|
|
|
/// The other half of H4. `resolve_host_path` answers "where does this path lead
|
|
|
|
|
/// *now*", and a component can be replaced between that answer and the `open`
|
|
|
|
|
/// that acts on it — the classic TOCTOU, and a live one here because the
|
|
|
|
|
/// attacker owns a directory the path passes through. On Linux the kernel will
|
|
|
|
|
/// simply say where an open descriptor ended up, so we ask it and compare;
|
|
|
|
|
/// anything else is refused before a byte of payload is written or read.
|
|
|
|
|
///
|
|
|
|
|
/// Elsewhere — macOS, Windows — there is no equivalent that needs no new
|
|
|
|
|
/// dependency, so this is a no-op and the guarantee is the weaker one:
|
|
|
|
|
/// resolve-then-open, plus `O_EXCL` on the create, plus a rename whose source
|
|
|
|
|
/// must exist at the resolved path under a name carrying 32 random bits.
|
|
|
|
|
pub(crate) fn verify_opened_path(file: &std::fs::File, expected: &Path) -> Result<(), String> {
|
|
|
|
|
#[cfg(target_os = "linux")]
|
|
|
|
|
{
|
|
|
|
|
use std::os::fd::AsRawFd;
|
|
|
|
|
if let Ok(actual) = std::fs::read_link(format!("/proc/self/fd/{}", file.as_raw_fd())) {
|
|
|
|
|
if actual != expected {
|
|
|
|
|
return Err(format!(
|
|
|
|
|
"Refusing to use {}: while it was being opened it became {}.",
|
|
|
|
|
expected.display(),
|
|
|
|
|
actual.display()
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
#[cfg(not(target_os = "linux"))]
|
|
|
|
|
{
|
|
|
|
|
let _ = (file, expected);
|
|
|
|
|
}
|
|
|
|
|
Ok(())
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// [`resolve_host_path`] for a host file about to be read into a container,
|
2026-08-23 11:34:04 -07:00
|
|
|
/// handed back as a `String`.
|
|
|
|
|
///
|
|
|
|
|
/// Public because the terminal's drag-and-drop drop target
|
|
|
|
|
/// (`terminal_commands::upload_host_file_to_terminal`) is the same primitive as
|
|
|
|
|
/// the Files pane's upload and must not have a different policy.
|
2026-08-23 13:13:35 -07:00
|
|
|
pub async fn resolve_host_read_path(path: &str) -> Result<String, String> {
|
|
|
|
|
Ok(resolve_host_path(path, HostPathUse::Read)
|
|
|
|
|
.await?
|
2026-08-23 11:34:04 -07:00
|
|
|
.to_string_lossy()
|
|
|
|
|
.to_string())
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Where a download is written before it becomes the file the user asked for.
|
|
|
|
|
///
|
|
|
|
|
/// Same directory as the destination, so the last step is a rename within one
|
|
|
|
|
/// filesystem: atomic, and the destination is not touched *at all* until the
|
|
|
|
|
/// whole transfer has succeeded. That ordering is the fix for the worst part of
|
|
|
|
|
/// the old code, which created (i.e. truncated) the destination first and then
|
|
|
|
|
/// deleted it when the stream failed — turning "your download failed" into
|
|
|
|
|
/// "your download failed and the file that used to be there is gone".
|
|
|
|
|
///
|
|
|
|
|
/// A rename also handles an existing destination better than an `open` would:
|
|
|
|
|
/// it replaces a symlink rather than following it out of the vetted directory.
|
|
|
|
|
///
|
|
|
|
|
/// Deliberately not a hidden name: if a crash leaves one behind, it should be
|
|
|
|
|
/// visible next to the file it was going to become.
|
|
|
|
|
fn partial_download_path(dest: &Path) -> Result<PathBuf, String> {
|
|
|
|
|
let name = dest
|
|
|
|
|
.file_name()
|
|
|
|
|
.ok_or_else(|| format!("{} does not name a file", dest.display()))?;
|
|
|
|
|
let mut partial = name.to_os_string();
|
|
|
|
|
partial.push(format!(
|
|
|
|
|
".triple-c-part-{}",
|
|
|
|
|
&uuid::Uuid::new_v4().simple().to_string()[..8]
|
|
|
|
|
));
|
|
|
|
|
Ok(dest.with_file_name(partial))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Move a finished partial file onto the destination the user chose.
|
|
|
|
|
///
|
|
|
|
|
/// A plain rename is the whole story on Unix: atomic, and it replaces an
|
|
|
|
|
/// existing file. Windows refuses to rename onto an existing path, so the
|
|
|
|
|
/// destination is removed and the rename retried — deliberately *only here*,
|
|
|
|
|
/// after the payload is completely written and only for a destination the user
|
|
|
|
|
/// picked in a save dialog that already asked about overwriting. That is the
|
|
|
|
|
/// difference from the old code, which deleted the destination on the *failure*
|
|
|
|
|
/// path, when the replacement did not exist.
|
|
|
|
|
async fn finish_download(partial: &Path, dest: &Path) -> Result<(), String> {
|
|
|
|
|
match tokio::fs::rename(partial, dest).await {
|
|
|
|
|
Ok(()) => Ok(()),
|
|
|
|
|
Err(_) if tokio::fs::try_exists(dest).await.unwrap_or(false) => {
|
|
|
|
|
tokio::fs::remove_file(dest)
|
|
|
|
|
.await
|
|
|
|
|
.map_err(|e| format!("Failed to replace {}: {}", dest.display(), e))?;
|
|
|
|
|
tokio::fs::rename(partial, dest)
|
|
|
|
|
.await
|
|
|
|
|
.map_err(|e| format!("Failed to save {}: {}", dest.display(), e))
|
|
|
|
|
}
|
|
|
|
|
Err(e) => Err(format!("Failed to save {}: {}", dest.display(), e)),
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Ceiling on one "Save to host…" download, checked against the size the tar
|
|
|
|
|
/// entry declares — i.e. before a byte of payload is read.
|
|
|
|
|
///
|
|
|
|
|
/// The transfer itself is streamed, so this is not a memory bound any more; it
|
|
|
|
|
/// is the bound on how much of the user's disk a single mis-aimed or hostile
|
|
|
|
|
/// download can consume before anyone notices. Comfortably past any file this
|
|
|
|
|
/// panel is used for, and the message names Backup as the way to take a whole
|
|
|
|
|
/// tree instead.
|
|
|
|
|
const MAX_DOWNLOAD_BYTES: u64 = 8 * 1024 * 1024 * 1024;
|
|
|
|
|
|
|
|
|
|
/// Refuse an oversize download by its declared size. Split out so the ceiling
|
|
|
|
|
/// and its wording are testable without a container.
|
|
|
|
|
fn check_download_size(size: u64) -> Result<(), String> {
|
|
|
|
|
if size > MAX_DOWNLOAD_BYTES {
|
|
|
|
|
return Err(format!(
|
|
|
|
|
"{:.1} GB is too large to save ({} GB limit) — use Backup for a whole tree, or read it from the mounted project directly.",
|
|
|
|
|
size as f64 / (1024.0 * 1024.0 * 1024.0),
|
|
|
|
|
MAX_DOWNLOAD_BYTES / (1024 * 1024 * 1024)
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
Ok(())
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
/// The host half of "Save to host…": work out where the file is really going,
|
|
|
|
|
/// fill a partial file beside it, and rename that into place.
|
|
|
|
|
///
|
|
|
|
|
/// Split out from the command because it is the half that carries the security,
|
|
|
|
|
/// and because it is then something a test can drive. `fill` never sees the path
|
|
|
|
|
/// the caller asked for — only the resolved partial — and every failure path
|
|
|
|
|
/// deletes exactly what `fill` created and nothing else. Returns the resolved
|
|
|
|
|
/// destination alongside the byte count, because after [`resolve_host_path`]
|
|
|
|
|
/// that is not necessarily the path the caller named.
|
|
|
|
|
async fn save_to_host<F, Fut>(host_path: &str, fill: F) -> Result<(PathBuf, u64), String>
|
|
|
|
|
where
|
|
|
|
|
F: FnOnce(PathBuf, Arc<AtomicBool>) -> Fut,
|
|
|
|
|
Fut: std::future::Future<Output = Result<u64, String>>,
|
|
|
|
|
{
|
|
|
|
|
// Resolved, not merely inspected: this is the path that will be opened,
|
|
|
|
|
// with every symlink in its directories already followed. See H4 in
|
|
|
|
|
// [`resolve_host_path`].
|
|
|
|
|
let dest = resolve_host_path(host_path, HostPathUse::Write).await?;
|
|
|
|
|
|
|
|
|
|
// Written beside the destination and renamed on success, so a failure
|
|
|
|
|
// anywhere below leaves whatever was already at `dest` untouched.
|
|
|
|
|
let partial = partial_download_path(&dest)?;
|
|
|
|
|
|
|
|
|
|
// Set once `fill` has actually created the file, and read on every failure
|
|
|
|
|
// path. Without it the cleanup deleted `partial` whichever way the transfer
|
|
|
|
|
// failed — including the one failure that means "something was already
|
|
|
|
|
// there": 32 bits of UUID make a collision vanishingly unlikely, but
|
|
|
|
|
// "vanishingly unlikely" is not a reason to delete a file this app did not
|
|
|
|
|
// create.
|
|
|
|
|
let created = Arc::new(AtomicBool::new(false));
|
|
|
|
|
|
|
|
|
|
match fill(partial.clone(), Arc::clone(&created)).await {
|
|
|
|
|
Ok(written) => {
|
|
|
|
|
if let Err(e) = finish_download(&partial, &dest).await {
|
|
|
|
|
if created.load(Ordering::SeqCst) {
|
|
|
|
|
let _ = tokio::fs::remove_file(&partial).await;
|
|
|
|
|
}
|
|
|
|
|
return Err(e);
|
|
|
|
|
}
|
|
|
|
|
Ok((dest, written))
|
|
|
|
|
}
|
|
|
|
|
Err(e) => {
|
|
|
|
|
// Only ever our own partial file — never the user's destination,
|
|
|
|
|
// and never a file that was already sitting at the partial's name.
|
|
|
|
|
if created.load(Ordering::SeqCst) {
|
|
|
|
|
let _ = tokio::fs::remove_file(&partial).await;
|
|
|
|
|
}
|
|
|
|
|
Err(e)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2026-03-06 06:32:53 -08:00
|
|
|
#[tauri::command]
|
|
|
|
|
pub async fn download_container_file(
|
|
|
|
|
project_id: String,
|
|
|
|
|
container_path: String,
|
|
|
|
|
host_path: String,
|
|
|
|
|
state: State<'_, AppState>,
|
|
|
|
|
) -> Result<(), String> {
|
2026-08-23 11:34:04 -07:00
|
|
|
validate_container_path("File", &container_path)?;
|
|
|
|
|
|
2026-03-06 06:32:53 -08:00
|
|
|
let project = state
|
|
|
|
|
.projects_store
|
|
|
|
|
.get(&project_id)
|
|
|
|
|
.ok_or_else(|| format!("Project {} not found", project_id))?;
|
|
|
|
|
|
|
|
|
|
let container_id = project
|
|
|
|
|
.container_id
|
2026-08-23 13:13:35 -07:00
|
|
|
.clone()
|
2026-03-06 06:32:53 -08:00
|
|
|
.ok_or_else(|| "Container not running".to_string())?;
|
|
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
let source = container_path.clone();
|
|
|
|
|
let (dest, written) = save_to_host(&host_path, move |partial, created| async move {
|
|
|
|
|
stream_container_file_to_host(&container_id, &source, &partial, created).await
|
|
|
|
|
})
|
|
|
|
|
.await?;
|
2026-08-23 08:30:48 -07:00
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
log::info!(
|
|
|
|
|
"Saved {} bytes from {} to {}",
|
|
|
|
|
written,
|
|
|
|
|
container_path,
|
|
|
|
|
dest.display()
|
|
|
|
|
);
|
|
|
|
|
Ok(())
|
2026-08-23 11:34:04 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Copy one regular file out of a container straight onto a host path,
|
|
|
|
|
/// streaming, and return the number of bytes written.
|
|
|
|
|
///
|
|
|
|
|
/// The old download path called [`fetch_container_file`] with no cap, which
|
|
|
|
|
/// buffered the entire transfer in host RAM twice (the tar, then the extracted
|
|
|
|
|
/// bytes) and only refused a *directory* after that buffer had been filled — so
|
|
|
|
|
/// `container_path = "/"` pulled the whole container filesystem into memory
|
|
|
|
|
/// before erroring, and a 40 GB sparse file was an out-of-memory kill.
|
|
|
|
|
///
|
|
|
|
|
/// Nothing here holds more than a few chunks at a time: Docker's tar stream is
|
|
|
|
|
/// pumped through a small bounded channel into a blocking task, which is where
|
|
|
|
|
/// the `tar` crate (synchronous, and the only thing that correctly understands
|
|
|
|
|
/// PAX/GNU long-name and large-size members) reads the header, refuses anything
|
|
|
|
|
/// that is not a regular file *before creating the host file*, checks the
|
|
|
|
|
/// declared size against [`MAX_DOWNLOAD_BYTES`], and only then copies payload to
|
|
|
|
|
/// disk.
|
|
|
|
|
async fn stream_container_file_to_host(
|
|
|
|
|
container_id: &str,
|
|
|
|
|
container_path: &str,
|
|
|
|
|
dest: &Path,
|
2026-08-23 13:13:35 -07:00
|
|
|
created: Arc<AtomicBool>,
|
2026-08-23 11:34:04 -07:00
|
|
|
) -> Result<u64, String> {
|
|
|
|
|
let docker = get_docker()?;
|
|
|
|
|
|
|
|
|
|
let mut stream = docker.download_from_container(
|
|
|
|
|
container_id,
|
|
|
|
|
Some(DownloadFromContainerOptions {
|
|
|
|
|
path: container_path.to_string(),
|
|
|
|
|
}),
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
// Four chunks of backpressure: the feeder stops pulling from the socket as
|
|
|
|
|
// soon as the writer stops consuming, which is what bounds memory here.
|
|
|
|
|
let (tx, rx) = tokio::sync::mpsc::channel::<Result<Vec<u8>, String>>(4);
|
|
|
|
|
let feeder = tokio::spawn(async move {
|
|
|
|
|
while let Some(chunk) = stream.next().await {
|
|
|
|
|
let failed = chunk.is_err();
|
|
|
|
|
let item = chunk
|
|
|
|
|
.map(|bytes| bytes.to_vec())
|
|
|
|
|
.map_err(|e| format!("Failed to download file: {}", e));
|
|
|
|
|
// A closed receiver means the reader is done (or gave up) — dropping
|
|
|
|
|
// the stream cancels the rest of the transfer.
|
|
|
|
|
if tx.send(item).await.is_err() || failed {
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
let reader = ChannelReader::new(rx);
|
|
|
|
|
let dest = dest.to_path_buf();
|
|
|
|
|
let label = container_path.to_string();
|
|
|
|
|
|
|
|
|
|
let result = tokio::task::spawn_blocking(move || -> Result<u64, String> {
|
|
|
|
|
let mut archive = tar::Archive::new(reader);
|
|
|
|
|
let mut entries = archive
|
|
|
|
|
.entries()
|
|
|
|
|
.map_err(|e| format!("Failed to read tar entries: {}", e))?;
|
|
|
|
|
let mut entry = match entries.next() {
|
|
|
|
|
Some(entry) => entry.map_err(|e| format!("Failed to read tar entry: {}", e))?,
|
|
|
|
|
None => return Err(format!("{} not found in the container", label)),
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
// Type first, size second, host file third. That order is the fix.
|
|
|
|
|
let entry_type = entry.header().entry_type();
|
|
|
|
|
if entry_type.is_dir() {
|
|
|
|
|
return Err(format!(
|
|
|
|
|
"{} is a folder — download its files individually, or use Backup to archive a whole tree.",
|
|
|
|
|
label
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
if entry_type.is_symlink() || entry_type.is_hard_link() {
|
|
|
|
|
return Err(format!("{} is a link — save its target instead.", label));
|
|
|
|
|
}
|
|
|
|
|
if !entry_type.is_file() {
|
|
|
|
|
return Err(format!("{} is not a regular file.", label));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// `entry.size()`, not `header().size()`: the ustar header's size field
|
|
|
|
|
// is 12 octal digits, i.e. it tops out just under 8 GiB, and Docker's Go
|
|
|
|
|
// tar writer puts anything larger in a preceding PAX record instead.
|
|
|
|
|
// Reading the raw header field made a 9 GiB file look like an 8 GiB one
|
|
|
|
|
// and a 40 GiB file look like nothing at all — verified against a real
|
|
|
|
|
// container, where the ceiling below simply did not fire.
|
|
|
|
|
let size = entry.size();
|
|
|
|
|
check_download_size(size)?;
|
|
|
|
|
|
|
|
|
|
let mut file = std::fs::OpenOptions::new()
|
|
|
|
|
.write(true)
|
|
|
|
|
.create_new(true)
|
|
|
|
|
.open(&dest)
|
|
|
|
|
.map_err(|e| format!("Failed to create {}: {}", dest.display(), e))?;
|
2026-08-23 13:13:35 -07:00
|
|
|
// From here on the file is ours, so the caller may delete it on failure.
|
|
|
|
|
created.store(true, Ordering::SeqCst);
|
|
|
|
|
// `create_new` is `O_EXCL`, so this open cannot have followed a symlink
|
|
|
|
|
// at the final component — but a *directory* on the way could have been
|
|
|
|
|
// swapped since the path was resolved, so ask the kernel where the
|
|
|
|
|
// descriptor actually landed before writing a byte into it.
|
|
|
|
|
verify_opened_path(&file, &dest)?;
|
2026-08-23 11:34:04 -07:00
|
|
|
// `take` as well as the header check: the header is container-controlled
|
|
|
|
|
// and a stream that keeps going past it must not keep filling the disk.
|
|
|
|
|
let mut capped = std::io::Read::take(&mut entry, MAX_DOWNLOAD_BYTES);
|
|
|
|
|
let written = std::io::copy(&mut capped, &mut file)
|
|
|
|
|
.map_err(|e| format!("Failed to write {}: {}", dest.display(), e))?;
|
|
|
|
|
Ok(written)
|
|
|
|
|
})
|
|
|
|
|
.await;
|
|
|
|
|
|
|
|
|
|
// The blocking side is finished with the stream either way.
|
|
|
|
|
feeder.abort();
|
|
|
|
|
|
|
|
|
|
result.map_err(|e| format!("Download task panicked: {}", e))?
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// A blocking [`std::io::Read`] over an async channel of chunks.
|
|
|
|
|
///
|
|
|
|
|
/// The bridge between Docker's async byte stream and the `tar` crate, which is
|
|
|
|
|
/// synchronous. It holds one chunk at a time; the channel's capacity is the
|
|
|
|
|
/// whole memory budget of a download.
|
|
|
|
|
struct ChannelReader {
|
|
|
|
|
rx: tokio::sync::mpsc::Receiver<Result<Vec<u8>, String>>,
|
|
|
|
|
current: Vec<u8>,
|
|
|
|
|
pos: usize,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl ChannelReader {
|
|
|
|
|
fn new(rx: tokio::sync::mpsc::Receiver<Result<Vec<u8>, String>>) -> Self {
|
|
|
|
|
Self {
|
|
|
|
|
rx,
|
|
|
|
|
current: Vec::new(),
|
|
|
|
|
pos: 0,
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl std::io::Read for ChannelReader {
|
|
|
|
|
fn read(&mut self, buf: &mut [u8]) -> std::io::Result<usize> {
|
|
|
|
|
loop {
|
|
|
|
|
if self.pos < self.current.len() {
|
|
|
|
|
let n = (self.current.len() - self.pos).min(buf.len());
|
|
|
|
|
buf[..n].copy_from_slice(&self.current[self.pos..self.pos + n]);
|
|
|
|
|
self.pos += n;
|
|
|
|
|
return Ok(n);
|
|
|
|
|
}
|
|
|
|
|
match self.rx.blocking_recv() {
|
|
|
|
|
Some(Ok(chunk)) => {
|
|
|
|
|
self.current = chunk;
|
|
|
|
|
self.pos = 0;
|
|
|
|
|
}
|
|
|
|
|
Some(Err(e)) => return Err(std::io::Error::other(e)),
|
|
|
|
|
// Stream finished: EOF, which is also how a tar with no trailing
|
|
|
|
|
// zero blocks (a cancelled transfer) ends.
|
|
|
|
|
None => return Ok(0),
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2026-08-23 08:30:48 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// One regular file's bytes, pulled out of a container.
|
|
|
|
|
struct FetchedFile {
|
|
|
|
|
bytes: Vec<u8>,
|
|
|
|
|
/// The size the tar header declared, i.e. the file's real size — which is
|
|
|
|
|
/// not `bytes.len()` once `max_bytes` has cut the read short.
|
|
|
|
|
size: u64,
|
|
|
|
|
truncated: bool,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Fetch a single regular file from a container as exact bytes.
|
|
|
|
|
///
|
|
|
|
|
/// Shared by the "Save to host…" download and the viewer, so both get the same
|
|
|
|
|
/// answer. It deliberately goes through Docker's archive endpoint rather than
|
|
|
|
|
/// `exec_oneshot`: that reader runs every chunk through `String::from_utf8_lossy`
|
|
|
|
|
/// and merges stderr into stdout, so it would both corrupt any non-UTF-8 file
|
|
|
|
|
/// and be able to splice diagnostics into what the caller believes is content.
|
|
|
|
|
///
|
2026-08-23 11:34:04 -07:00
|
|
|
/// The transfer is abandoned once the cap (plus enough slack for the tar
|
|
|
|
|
/// framing) is in hand, so previewing a huge file does not pull the whole thing
|
|
|
|
|
/// across the socket.
|
|
|
|
|
///
|
|
|
|
|
/// `max_bytes` is deliberately not optional. It used to be, and the download
|
|
|
|
|
/// command passed `None`: the cap below then did nothing and the whole file —
|
|
|
|
|
/// or the whole *directory tree*, since the type check happens after the read —
|
|
|
|
|
/// landed in host RAM twice. Downloads now stream (see
|
|
|
|
|
/// [`stream_container_file_to_host`]); everything still using this function
|
|
|
|
|
/// buffers, so everything still using it must name a ceiling.
|
2026-08-23 08:30:48 -07:00
|
|
|
async fn fetch_container_file(
|
|
|
|
|
container_id: &str,
|
|
|
|
|
container_path: &str,
|
2026-08-23 11:34:04 -07:00
|
|
|
max_bytes: u64,
|
2026-08-23 08:30:48 -07:00
|
|
|
) -> Result<FetchedFile, String> {
|
2026-03-06 06:32:53 -08:00
|
|
|
let docker = get_docker()?;
|
|
|
|
|
|
|
|
|
|
let mut stream = docker.download_from_container(
|
|
|
|
|
container_id,
|
|
|
|
|
Some(DownloadFromContainerOptions {
|
2026-08-23 08:30:48 -07:00
|
|
|
path: container_path.to_string(),
|
2026-03-06 06:32:53 -08:00
|
|
|
}),
|
|
|
|
|
);
|
|
|
|
|
|
2026-08-23 08:30:48 -07:00
|
|
|
// A tar member is a 512-byte header plus payload padded to 512. 8 KiB of
|
|
|
|
|
// slack past the payload cap guarantees the header and the whole capped
|
|
|
|
|
// prefix are present even with the stream cut short.
|
|
|
|
|
const TAR_SLACK: u64 = 8 * 1024;
|
2026-08-23 11:34:04 -07:00
|
|
|
let stop_after = max_bytes.saturating_add(TAR_SLACK);
|
2026-08-23 08:30:48 -07:00
|
|
|
|
|
|
|
|
let mut tar_bytes: Vec<u8> = Vec::new();
|
2026-03-06 06:32:53 -08:00
|
|
|
while let Some(chunk) = stream.next().await {
|
|
|
|
|
let chunk = chunk.map_err(|e| format!("Failed to download file: {}", e))?;
|
|
|
|
|
tar_bytes.extend_from_slice(&chunk);
|
2026-08-23 11:34:04 -07:00
|
|
|
if tar_bytes.len() as u64 >= stop_after {
|
2026-08-23 08:30:48 -07:00
|
|
|
// Dropping the stream cancels the rest of the transfer.
|
|
|
|
|
break;
|
|
|
|
|
}
|
2026-03-06 06:32:53 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
let mut archive = tar::Archive::new(&tar_bytes[..]);
|
2026-08-23 08:30:48 -07:00
|
|
|
let mut entries = archive
|
2026-03-06 06:32:53 -08:00
|
|
|
.entries()
|
2026-08-23 08:30:48 -07:00
|
|
|
.map_err(|e| format!("Failed to read tar entries: {}", e))?;
|
|
|
|
|
let mut entry = match entries.next() {
|
|
|
|
|
Some(entry) => entry.map_err(|e| format!("Failed to read tar entry: {}", e))?,
|
|
|
|
|
None => return Err(format!("{} not found in the container", container_path)),
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
// Docker tars whatever the path names, so a directory arrives as a whole
|
|
|
|
|
// tree. Reading only its first member used to write a silently wrong file;
|
|
|
|
|
// say so instead.
|
|
|
|
|
let entry_type = entry.header().entry_type();
|
|
|
|
|
if entry_type.is_dir() {
|
|
|
|
|
return Err(format!(
|
|
|
|
|
"{} is a folder — download its files individually, or use Backup to archive a whole tree.",
|
|
|
|
|
container_path
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
if entry_type.is_symlink() || entry_type.is_hard_link() {
|
|
|
|
|
return Err(format!("{} is a link — open its target instead.", container_path));
|
2026-03-06 06:32:53 -08:00
|
|
|
}
|
2026-08-23 08:30:48 -07:00
|
|
|
if !entry_type.is_file() {
|
|
|
|
|
return Err(format!("{} is not a regular file.", container_path));
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 11:34:04 -07:00
|
|
|
// `entry.size()` rather than the raw header field: see
|
|
|
|
|
// `stream_container_file_to_host`. A file past the ustar 8 GiB octal limit
|
|
|
|
|
// carries its real size in a PAX record, and reading the header field
|
|
|
|
|
// instead reported it as 0 — an empty preview of a very large file.
|
|
|
|
|
let size = entry.size();
|
|
|
|
|
let truncated = size > max_bytes;
|
|
|
|
|
let want = max_bytes.min(size);
|
2026-08-23 08:30:48 -07:00
|
|
|
|
|
|
|
|
let mut bytes = Vec::with_capacity(want.min(1024 * 1024) as usize);
|
|
|
|
|
std::io::Read::read_to_end(&mut std::io::Read::take(&mut entry, want), &mut bytes)
|
|
|
|
|
.map_err(|e| format!("Failed to read file contents: {}", e))?;
|
|
|
|
|
|
|
|
|
|
Ok(FetchedFile {
|
|
|
|
|
bytes,
|
|
|
|
|
size,
|
|
|
|
|
truncated,
|
|
|
|
|
})
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Read a file out of the container for the in-app viewer.
|
|
|
|
|
///
|
|
|
|
|
/// `max_bytes` is the caller's ceiling (the viewer asks for more when it is
|
|
|
|
|
/// about to decode an image, which is what usually goes over a text-sized cap);
|
|
|
|
|
/// it is clamped to [`MAX_READ_BYTES`] regardless, because the whole payload is
|
|
|
|
|
/// buffered in host RAM on the way through.
|
|
|
|
|
#[tauri::command]
|
|
|
|
|
pub async fn read_container_file(
|
|
|
|
|
project_id: String,
|
|
|
|
|
path: String,
|
|
|
|
|
max_bytes: Option<u64>,
|
|
|
|
|
state: State<'_, AppState>,
|
|
|
|
|
) -> Result<FileContents, String> {
|
2026-08-23 11:34:04 -07:00
|
|
|
validate_container_path("File", &path)?;
|
|
|
|
|
|
2026-08-23 08:30:48 -07:00
|
|
|
let project = state
|
|
|
|
|
.projects_store
|
|
|
|
|
.get(&project_id)
|
|
|
|
|
.ok_or_else(|| format!("Project {} not found", project_id))?;
|
|
|
|
|
|
|
|
|
|
let container_id = project
|
|
|
|
|
.container_id
|
|
|
|
|
.as_ref()
|
|
|
|
|
.ok_or_else(|| "Container not running".to_string())?;
|
|
|
|
|
|
|
|
|
|
let cap = max_bytes.unwrap_or(MAX_READ_BYTES).min(MAX_READ_BYTES);
|
2026-08-23 11:34:04 -07:00
|
|
|
let fetched = fetch_container_file(container_id, &path, cap).await?;
|
2026-08-23 08:30:48 -07:00
|
|
|
|
|
|
|
|
Ok(FileContents {
|
|
|
|
|
contents_base64: BASE64.encode(&fetched.bytes),
|
|
|
|
|
truncated: fetched.truncated,
|
|
|
|
|
size: fetched.size,
|
|
|
|
|
})
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 09:12:59 -07:00
|
|
|
// ─────────────────────────────────────────────────────────────────────────────
|
|
|
|
|
// Drag-out staging
|
|
|
|
|
// ─────────────────────────────────────────────────────────────────────────────
|
|
|
|
|
//
|
|
|
|
|
// Dragging a file onto the host desktop hands the OS a *host* path, and the
|
|
|
|
|
// files in this panel live inside a container, where nothing on the desktop can
|
|
|
|
|
// reach them. So a drag-out is really a copy-then-drag: materialise the file
|
|
|
|
|
// into a host temp directory first, then start the native drag on that copy.
|
|
|
|
|
//
|
|
|
|
|
// The copy is the reason this section carries a lifecycle. A staging directory
|
|
|
|
|
// nobody empties is a disk leak with a gesture attached to it, so there are two
|
|
|
|
|
// halves and both matter: `clear_drag_staging` on exit, and
|
|
|
|
|
// `reap_drag_staging` at startup for whatever a crash left behind.
|
|
|
|
|
|
|
|
|
|
/// Ceiling on one staged copy. Deliberately the same 256 MiB as
|
|
|
|
|
/// [`MAX_UPLOAD_BYTES`] — it is the same whole-file-through-host-RAM round trip,
|
|
|
|
|
/// only in the other direction.
|
|
|
|
|
const MAX_DRAG_STAGE_BYTES: u64 = 256 * 1024 * 1024;
|
|
|
|
|
|
|
|
|
|
/// Name of the app-owned directory inside the OS temp dir. Everything staged by
|
|
|
|
|
/// any Triple-C process lives under it, so housekeeping has exactly one place to
|
|
|
|
|
/// look and never walks the rest of the user's temp dir.
|
|
|
|
|
const DRAG_STAGE_DIR_NAME: &str = "triple-c-drag-out";
|
|
|
|
|
|
|
|
|
|
/// How long *another* process's leftover staging directory may sit before
|
|
|
|
|
/// startup housekeeping deletes it.
|
|
|
|
|
///
|
|
|
|
|
/// Only ever applied to directories this process does not own (see
|
|
|
|
|
/// [`drag_stage_session_dir`]), so it is not a limit on how long a staged file
|
|
|
|
|
/// survives in a live session — it is the crash-recovery threshold, and it is
|
|
|
|
|
/// generous because a second Triple-C running right now would also look like a
|
|
|
|
|
/// leftover.
|
|
|
|
|
const DRAG_STAGE_MAX_AGE: Duration = Duration::from_secs(24 * 60 * 60);
|
|
|
|
|
|
|
|
|
|
/// This process's own sub-directory name, stable for the life of the process.
|
|
|
|
|
///
|
|
|
|
|
/// Per-process rather than shared so exit cleanup can delete *ours* outright
|
|
|
|
|
/// without reaching into a directory another instance may be dragging out of.
|
|
|
|
|
fn drag_stage_session() -> &'static str {
|
|
|
|
|
static SESSION: OnceLock<String> = OnceLock::new();
|
|
|
|
|
SESSION.get_or_init(|| uuid::Uuid::new_v4().to_string())
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// The app-owned staging root inside `temp_dir`.
|
|
|
|
|
///
|
|
|
|
|
/// Takes the temp dir rather than reading it, because on Windows it is neither
|
|
|
|
|
/// `/tmp` nor a constant — Tauri's path API is the only thing that knows it —
|
|
|
|
|
/// and because a pure function is what the tests can drive.
|
|
|
|
|
pub fn drag_stage_root(temp_dir: &Path) -> PathBuf {
|
|
|
|
|
temp_dir.join(DRAG_STAGE_DIR_NAME)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// This process's staging directory: `<temp>/triple-c-drag-out/<session>`.
|
|
|
|
|
pub fn drag_stage_session_dir(temp_dir: &Path) -> PathBuf {
|
|
|
|
|
drag_stage_root(temp_dir).join(drag_stage_session())
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// The per-file sub-directory a staged copy lives in, derived from the
|
|
|
|
|
/// container path.
|
|
|
|
|
///
|
|
|
|
|
/// Filenames are only unique within a directory, so `a/notes.txt` and
|
|
|
|
|
/// `b/notes.txt` would otherwise be the same host path — and the second drag
|
|
|
|
|
/// would silently rewrite the first one's contents under the first one's cached
|
|
|
|
|
/// path. A digest of the full container path separates them while staying
|
|
|
|
|
/// *deterministic*, so re-staging the same file reuses its slot instead of
|
|
|
|
|
/// growing a new one every drag.
|
|
|
|
|
fn drag_stage_slot(container_path: &str) -> String {
|
|
|
|
|
use sha2::{Digest, Sha256};
|
|
|
|
|
let digest = Sha256::digest(container_path.as_bytes());
|
|
|
|
|
digest[..8].iter().map(|b| format!("{:02x}", b)).collect()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// The name the staged copy is given on the host.
|
|
|
|
|
///
|
|
|
|
|
/// The whole point is that what lands on the desktop is called `notes.txt` and
|
|
|
|
|
/// not `tmp1234`, so the container's basename is kept verbatim wherever it can
|
|
|
|
|
/// be. Only the characters Windows refuses outright are substituted — a Linux
|
|
|
|
|
/// file really can be called `a:b`, and the staged copy has to exist on NTFS.
|
|
|
|
|
/// A name that is not a filename at all (empty, `.`, `..`) is rejected rather
|
|
|
|
|
/// than invented: that means the caller passed something that never named a
|
|
|
|
|
/// file, and quietly inventing a name would stage the wrong thing.
|
|
|
|
|
fn stage_file_name(container_path: &str) -> Result<String, String> {
|
|
|
|
|
let base = container_path
|
|
|
|
|
.trim_end_matches('/')
|
|
|
|
|
.rsplit('/')
|
|
|
|
|
.next()
|
|
|
|
|
.unwrap_or("");
|
|
|
|
|
|
|
|
|
|
let cleaned: String = base
|
|
|
|
|
.chars()
|
|
|
|
|
.map(|c| match c {
|
|
|
|
|
'<' | '>' | ':' | '"' | '/' | '\\' | '|' | '?' | '*' => '_',
|
|
|
|
|
c if (c as u32) < 0x20 => '_',
|
|
|
|
|
c => c,
|
|
|
|
|
})
|
|
|
|
|
.collect();
|
|
|
|
|
// Windows also silently drops a trailing dot or space, which would make the
|
|
|
|
|
// path we hand back not the path that exists.
|
|
|
|
|
let cleaned = cleaned.trim_end_matches([' ', '.']);
|
|
|
|
|
|
|
|
|
|
if cleaned.is_empty() || cleaned == "." || cleaned == ".." {
|
|
|
|
|
return Err(format!("{} does not name a file", container_path));
|
|
|
|
|
}
|
|
|
|
|
Ok(cleaned.to_string())
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Reject an oversize file *by its real size*, before anything is written.
|
|
|
|
|
///
|
|
|
|
|
/// Split out so the ceiling and its wording are testable without a container.
|
|
|
|
|
/// The message names the fallback, because "too large" with no way forward is
|
|
|
|
|
/// the one thing a size cap must not be.
|
|
|
|
|
fn check_stage_size(size: u64) -> Result<(), String> {
|
|
|
|
|
if size > MAX_DRAG_STAGE_BYTES {
|
|
|
|
|
return Err(format!(
|
|
|
|
|
"{:.0} MB is too large to drag out (limit {} MB) — use \"Save to host…\" instead.",
|
|
|
|
|
size as f64 / (1024.0 * 1024.0),
|
|
|
|
|
MAX_DRAG_STAGE_BYTES / (1024 * 1024)
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
Ok(())
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Whether a leftover staging directory is old enough to delete.
|
|
|
|
|
///
|
|
|
|
|
/// A modification time in the *future* (a clock step, a copied temp dir) makes
|
|
|
|
|
/// `duration_since` fail, and that answers "not stale" — housekeeping deleting
|
|
|
|
|
/// something it cannot date is worse than leaving it for the next startup.
|
|
|
|
|
fn drag_stage_is_stale(modified: SystemTime, now: SystemTime, max_age: Duration) -> bool {
|
|
|
|
|
now.duration_since(modified)
|
|
|
|
|
.map(|age| age >= max_age)
|
|
|
|
|
.unwrap_or(false)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Delete every staging directory except this process's own, once it is older
|
|
|
|
|
/// than [`DRAG_STAGE_MAX_AGE`]. Called from startup housekeeping.
|
|
|
|
|
pub async fn reap_drag_staging(temp_dir: PathBuf) {
|
|
|
|
|
let root = drag_stage_root(&temp_dir);
|
|
|
|
|
let keep = drag_stage_session_dir(&temp_dir);
|
|
|
|
|
let now = SystemTime::now();
|
|
|
|
|
|
|
|
|
|
let mut dir = match tokio::fs::read_dir(&root).await {
|
|
|
|
|
Ok(dir) => dir,
|
|
|
|
|
// Nothing staged yet is the normal case, not a problem.
|
|
|
|
|
Err(_) => return,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
let mut reaped = 0usize;
|
|
|
|
|
while let Ok(Some(entry)) = dir.next_entry().await {
|
|
|
|
|
let path = entry.path();
|
|
|
|
|
if path == keep {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
let stale = match entry.metadata().await.and_then(|m| m.modified()) {
|
|
|
|
|
Ok(modified) => drag_stage_is_stale(modified, now, DRAG_STAGE_MAX_AGE),
|
|
|
|
|
Err(_) => false,
|
|
|
|
|
};
|
|
|
|
|
if !stale {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
if tokio::fs::remove_dir_all(&path).await.is_ok() {
|
|
|
|
|
reaped += 1;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if reaped > 0 {
|
|
|
|
|
log::info!("Startup housekeeping removed {} stale drag-out staging directory(ies)", reaped);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Delete this process's staging directory. Called from the shutdown teardown.
|
|
|
|
|
pub async fn clear_drag_staging(temp_dir: PathBuf) {
|
|
|
|
|
let dir = drag_stage_session_dir(&temp_dir);
|
|
|
|
|
if let Err(e) = tokio::fs::remove_dir_all(&dir).await {
|
|
|
|
|
if e.kind() != std::io::ErrorKind::NotFound {
|
|
|
|
|
log::warn!("Failed to clear drag-out staging at {}: {}", dir.display(), e);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
// Best effort: leave no empty root behind either. Fails harmlessly while
|
|
|
|
|
// another instance still has a directory in there.
|
|
|
|
|
let _ = tokio::fs::remove_dir(drag_stage_root(&temp_dir)).await;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Copy a container file onto the host so it can be dragged to the desktop, and
|
|
|
|
|
/// return the absolute host path.
|
|
|
|
|
///
|
|
|
|
|
/// Reuses [`fetch_container_file`] rather than extracting a second way, so a
|
|
|
|
|
/// dragged file, a downloaded file and a previewed file are byte-identical and
|
|
|
|
|
/// refuse folders and links with the same words. The fetch is capped at
|
|
|
|
|
/// [`MAX_DRAG_STAGE_BYTES`], so an oversize file is recognised from the tar
|
|
|
|
|
/// header without being pulled across the socket in full.
|
|
|
|
|
#[tauri::command]
|
|
|
|
|
pub async fn stage_container_file_for_drag(
|
|
|
|
|
app: AppHandle,
|
|
|
|
|
project_id: String,
|
|
|
|
|
path: String,
|
|
|
|
|
state: State<'_, AppState>,
|
|
|
|
|
) -> Result<String, String> {
|
2026-08-23 11:34:04 -07:00
|
|
|
validate_container_path("File", &path)?;
|
|
|
|
|
|
2026-08-23 09:12:59 -07:00
|
|
|
let project = state
|
|
|
|
|
.projects_store
|
|
|
|
|
.get(&project_id)
|
|
|
|
|
.ok_or_else(|| format!("Project {} not found", project_id))?;
|
|
|
|
|
|
|
|
|
|
let container_id = project
|
|
|
|
|
.container_id
|
|
|
|
|
.as_ref()
|
|
|
|
|
.ok_or_else(|| "Container not running".to_string())?;
|
|
|
|
|
|
|
|
|
|
// Before the transfer: a path that cannot become a host filename is not
|
|
|
|
|
// worth a round trip.
|
|
|
|
|
let file_name = stage_file_name(&path)?;
|
|
|
|
|
|
2026-08-23 11:34:04 -07:00
|
|
|
let fetched = fetch_container_file(container_id, &path, MAX_DRAG_STAGE_BYTES).await?;
|
|
|
|
|
// `size` is the tar entry's, i.e. the file's real size, which is exactly
|
2026-08-23 09:12:59 -07:00
|
|
|
// what a truncated fetch does not tell you from `bytes.len()`.
|
|
|
|
|
check_stage_size(fetched.size)?;
|
|
|
|
|
|
|
|
|
|
let temp_dir = app
|
|
|
|
|
.path()
|
|
|
|
|
.temp_dir()
|
|
|
|
|
.map_err(|e| format!("No host temporary directory available: {}", e))?;
|
|
|
|
|
let dir = drag_stage_session_dir(&temp_dir).join(drag_stage_slot(&path));
|
|
|
|
|
tokio::fs::create_dir_all(&dir)
|
|
|
|
|
.await
|
|
|
|
|
.map_err(|e| format!("Failed to create the drag staging directory: {}", e))?;
|
|
|
|
|
|
|
|
|
|
let dest = dir.join(&file_name);
|
|
|
|
|
tokio::fs::write(&dest, &fetched.bytes)
|
|
|
|
|
.await
|
|
|
|
|
.map_err(|e| format!("Failed to stage {} on the host: {}", file_name, e))?;
|
|
|
|
|
|
|
|
|
|
Ok(dest.to_string_lossy().to_string())
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 08:30:48 -07:00
|
|
|
/// Rename an entry in place. `to_path` is the **new name**, not a destination
|
|
|
|
|
/// path — moving between directories is deliberately not offered here, so the
|
|
|
|
|
/// name is validated to carry no `/`.
|
|
|
|
|
///
|
|
|
|
|
/// Runs through `exec_oneshot_as` rather than `exec_oneshot` because the exit
|
|
|
|
|
/// code is the only reliable signal: `exec_oneshot` discards the status, so a
|
|
|
|
|
/// permission failure (renaming under `/etc` or `/usr`, which the container
|
|
|
|
|
/// user genuinely cannot do) would return `Ok` with the error text as its
|
|
|
|
|
/// "output". Returns the new full path.
|
|
|
|
|
#[tauri::command]
|
|
|
|
|
pub async fn rename_container_path(
|
|
|
|
|
project_id: String,
|
|
|
|
|
from_path: String,
|
|
|
|
|
to_path: String,
|
|
|
|
|
state: State<'_, AppState>,
|
|
|
|
|
) -> Result<String, String> {
|
|
|
|
|
let project = state
|
|
|
|
|
.projects_store
|
|
|
|
|
.get(&project_id)
|
|
|
|
|
.ok_or_else(|| format!("Project {} not found", project_id))?;
|
2026-03-06 06:32:53 -08:00
|
|
|
|
2026-08-23 08:30:48 -07:00
|
|
|
let container_id = project
|
|
|
|
|
.container_id
|
|
|
|
|
.as_ref()
|
|
|
|
|
.ok_or_else(|| "Container not running".to_string())?;
|
|
|
|
|
|
2026-08-23 11:34:04 -07:00
|
|
|
// The name is checked by `validate_entry_name`; the path it is applied to
|
|
|
|
|
// was checked by nothing at all, which is how an `invoke` naming
|
|
|
|
|
// `/home/claude/.claude/.credentials.json` used to move the OAuth
|
|
|
|
|
// credential out from under Claude Code.
|
|
|
|
|
validate_container_write_path("Item", &from_path)?;
|
2026-08-23 13:13:35 -07:00
|
|
|
// The *parent* is resolved, never the item itself: `realpath` would follow
|
|
|
|
|
// a symlink to its target, and renaming a link has always meant renaming
|
|
|
|
|
// the link. `/` as a parent means a one-component path, which has no
|
|
|
|
|
// directory component to resolve.
|
|
|
|
|
let parent = parent_dir(&from_path);
|
|
|
|
|
if parent != "/" {
|
|
|
|
|
resolve_container_dir(container_id, "Item", &parent).await?;
|
|
|
|
|
}
|
2026-08-23 11:34:04 -07:00
|
|
|
|
2026-08-23 08:30:48 -07:00
|
|
|
let new_name = to_path.trim();
|
|
|
|
|
validate_entry_name(new_name)?;
|
|
|
|
|
|
|
|
|
|
let dest = join_path(&parent_dir(&from_path), new_name);
|
|
|
|
|
if dest == from_path {
|
|
|
|
|
return Ok(dest);
|
2026-03-06 06:32:53 -08:00
|
|
|
}
|
|
|
|
|
|
2026-08-23 08:30:48 -07:00
|
|
|
// `mv -n` refuses to clobber, but GNU coreutils makes that refusal *silent*
|
|
|
|
|
// and exits 0 — so `-n` on its own would report a rename that never
|
|
|
|
|
// happened. The existence check is what turns it into an error the user
|
|
|
|
|
// sees; `-n` stays as the belt-and-braces against the race between them.
|
|
|
|
|
let (_, exists) = exec_oneshot_as(
|
|
|
|
|
container_id,
|
|
|
|
|
"claude",
|
|
|
|
|
vec!["test".to_string(), "-e".to_string(), dest.clone()],
|
|
|
|
|
Vec::new(),
|
|
|
|
|
)
|
|
|
|
|
.await?;
|
|
|
|
|
if exists == 0 {
|
|
|
|
|
return Err(format!("\"{}\" already exists in this folder", new_name));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
let (output, code) = exec_oneshot_as(
|
|
|
|
|
container_id,
|
|
|
|
|
"claude",
|
|
|
|
|
vec![
|
|
|
|
|
"mv".to_string(),
|
|
|
|
|
"-n".to_string(),
|
|
|
|
|
"--".to_string(),
|
|
|
|
|
from_path.clone(),
|
|
|
|
|
dest.clone(),
|
|
|
|
|
],
|
|
|
|
|
Vec::new(),
|
|
|
|
|
)
|
|
|
|
|
.await?;
|
|
|
|
|
|
|
|
|
|
if code != 0 {
|
|
|
|
|
// Surface `mv`'s own words: "Permission denied" is the common case
|
|
|
|
|
// outside /workspace and a generic message would hide why.
|
|
|
|
|
let detail = output.trim();
|
|
|
|
|
return Err(if detail.is_empty() {
|
|
|
|
|
format!("Rename failed (exit {})", code)
|
|
|
|
|
} else {
|
|
|
|
|
detail.to_string()
|
|
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
Ok(dest)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Create a directory under `parent_path`. Fails rather than succeeding
|
|
|
|
|
/// silently if the name is taken — `mkdir` without `-p` is what gives that.
|
|
|
|
|
#[tauri::command]
|
|
|
|
|
pub async fn create_container_directory(
|
|
|
|
|
project_id: String,
|
|
|
|
|
parent_path: String,
|
|
|
|
|
name: String,
|
|
|
|
|
state: State<'_, AppState>,
|
|
|
|
|
) -> Result<String, String> {
|
|
|
|
|
let project = state
|
|
|
|
|
.projects_store
|
|
|
|
|
.get(&project_id)
|
|
|
|
|
.ok_or_else(|| format!("Project {} not found", project_id))?;
|
|
|
|
|
|
|
|
|
|
let container_id = project
|
|
|
|
|
.container_id
|
|
|
|
|
.as_ref()
|
|
|
|
|
.ok_or_else(|| "Container not running".to_string())?;
|
|
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
resolve_container_dir(container_id, "Folder", &parent_path).await?;
|
2026-08-23 11:34:04 -07:00
|
|
|
|
2026-08-23 08:30:48 -07:00
|
|
|
let name = name.trim();
|
|
|
|
|
validate_entry_name(name)?;
|
|
|
|
|
let dest = join_path(&parent_path, name);
|
|
|
|
|
|
|
|
|
|
let (output, code) = exec_oneshot_as(
|
|
|
|
|
container_id,
|
|
|
|
|
"claude",
|
|
|
|
|
vec!["mkdir".to_string(), "--".to_string(), dest.clone()],
|
|
|
|
|
Vec::new(),
|
|
|
|
|
)
|
|
|
|
|
.await?;
|
|
|
|
|
|
|
|
|
|
if code != 0 {
|
|
|
|
|
let detail = output.trim();
|
|
|
|
|
return Err(if detail.is_empty() {
|
|
|
|
|
format!("Could not create folder (exit {})", code)
|
|
|
|
|
} else {
|
|
|
|
|
detail.to_string()
|
|
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
Ok(dest)
|
2026-03-06 06:32:53 -08:00
|
|
|
}
|
|
|
|
|
|
2026-06-30 14:04:19 -07:00
|
|
|
/// Create a `.tar.gz` backup of the container and stream it to a host file.
|
|
|
|
|
/// The archive contains:
|
|
|
|
|
/// - the workspace (default /workspace), minus regenerable build artifacts
|
2026-07-01 06:18:08 -07:00
|
|
|
/// (node_modules, target), under `workspace/`, and
|
2026-06-30 14:04:19 -07:00
|
|
|
/// - a sanitized copy of the home config under `home-claude/`: ~/.claude.json
|
2026-08-09 10:31:18 -07:00
|
|
|
/// with secret-bearing keys removed (`mcpServers` — Claude Code's own native
|
|
|
|
|
/// MCP config — and `settings` are kept) and ~/.claude/ minus the OAuth
|
|
|
|
|
/// `.credentials.json`, so settings and skills set up via Claude Code
|
|
|
|
|
/// survive a Reset.
|
2026-06-30 14:28:00 -07:00
|
|
|
/// `.git` is kept in full so the backup faithfully preserves git history,
|
|
|
|
|
/// including unpushed commits. Build + gzip happen inside the container so a
|
|
|
|
|
/// large workspace isn't streamed in full. The container must be RUNNING (the
|
|
|
|
|
/// backup runs via `docker exec`). Returns the number of bytes written.
|
2026-06-30 13:48:04 -07:00
|
|
|
#[tauri::command]
|
|
|
|
|
pub async fn download_container_backup(
|
|
|
|
|
project_id: String,
|
|
|
|
|
host_path: String,
|
|
|
|
|
container_path: Option<String>,
|
|
|
|
|
state: State<'_, AppState>,
|
|
|
|
|
) -> Result<u64, String> {
|
2026-08-23 11:34:04 -07:00
|
|
|
// `host_path` reached `File::create` unchecked, which truncated whatever was
|
|
|
|
|
// there before the exec had even started — and the error path then deleted
|
|
|
|
|
// it, so a backup of a non-existent container path took the user's file with
|
|
|
|
|
// it. Validate first, write to a partial file second, rename last.
|
2026-08-23 13:13:35 -07:00
|
|
|
let dest = resolve_host_path(&host_path, HostPathUse::Write).await?;
|
2026-08-23 11:34:04 -07:00
|
|
|
|
2026-06-30 13:48:04 -07:00
|
|
|
let project = state
|
|
|
|
|
.projects_store
|
|
|
|
|
.get(&project_id)
|
|
|
|
|
.ok_or_else(|| format!("Project {} not found", project_id))?;
|
|
|
|
|
|
|
|
|
|
let container_id = project
|
|
|
|
|
.container_id
|
|
|
|
|
.as_ref()
|
|
|
|
|
.ok_or_else(|| "No container exists for this project yet — start it first".to_string())?;
|
|
|
|
|
|
|
|
|
|
let docker = get_docker()?;
|
2026-06-30 14:28:00 -07:00
|
|
|
|
|
|
|
|
// The backup runs inside the container via `docker exec`, which requires it
|
|
|
|
|
// to be running. Fail with a clear message rather than a raw Docker error.
|
|
|
|
|
let running = docker
|
|
|
|
|
.inspect_container(container_id, None)
|
|
|
|
|
.await
|
|
|
|
|
.ok()
|
|
|
|
|
.and_then(|info| info.state)
|
|
|
|
|
.and_then(|s| s.running)
|
|
|
|
|
.unwrap_or(false);
|
|
|
|
|
if !running {
|
|
|
|
|
return Err("Start the project before backing up — the backup runs inside the running container.".to_string());
|
|
|
|
|
}
|
|
|
|
|
|
2026-06-30 13:48:04 -07:00
|
|
|
let path = container_path.unwrap_or_else(|| "/workspace".to_string());
|
2026-08-23 11:34:04 -07:00
|
|
|
// Read-only source: `tar -C` it, so absoluteness and `..` are what matter.
|
|
|
|
|
validate_container_path("Backup", &path)?;
|
2026-06-30 13:48:04 -07:00
|
|
|
|
2026-06-30 14:04:19 -07:00
|
|
|
// Stage a sanitized home config, then tar+gzip workspace + staged config to
|
|
|
|
|
// stdout. mktemp/jq output go nowhere near stdout, so the only thing the
|
|
|
|
|
// exec emits on stdout is the archive itself. --ignore-failed-read keeps a
|
2026-06-30 14:28:00 -07:00
|
|
|
// transient unreadable file from aborting the whole backup. If jq can't
|
|
|
|
|
// parse ~/.claude.json we substitute an empty object — never the raw file —
|
|
|
|
|
// so secrets can't leak through the sanitization fallback.
|
2026-07-01 06:18:08 -07:00
|
|
|
// The `--transform` nests the workspace under `workspace/` (parallel to
|
|
|
|
|
// `home-claude/`) so an extracted archive has both clearly labeled instead
|
2026-07-01 06:33:02 -07:00
|
|
|
// of scattering the workspace files into the extraction dir. Rewriting the
|
|
|
|
|
// leading `.` (rather than `./`) also renames tar's root member from `./` to
|
|
|
|
|
// `workspace`, so the archive carries a proper `workspace/` dir entry rather
|
|
|
|
|
// than a bare `./` that would stamp the source root's mode/mtime onto the
|
|
|
|
|
// extraction directory. `flags=rh` rewrites regular member names AND
|
|
|
|
|
// hardlink target names (so an intra-workspace hardlink pair still resolves
|
|
|
|
|
// on extract) while leaving symlink targets untouched (rewriting those would
|
|
|
|
|
// corrupt relative/absolute links).
|
2026-06-30 14:04:19 -07:00
|
|
|
let script = r#"set -e
|
|
|
|
|
STAGE=$(mktemp -d)
|
2026-06-30 14:59:48 -07:00
|
|
|
trap 'rm -rf "$STAGE"' EXIT
|
2026-06-30 14:04:19 -07:00
|
|
|
mkdir -p "$STAGE/home-claude"
|
|
|
|
|
if [ -f "$HOME/.claude.json" ]; then
|
2026-06-30 14:28:00 -07:00
|
|
|
if ! jq 'del(.primaryApiKey, .oauthAccount, .customApiKeyResponses)' "$HOME/.claude.json" \
|
|
|
|
|
> "$STAGE/home-claude/.claude.json" 2>/dev/null; then
|
|
|
|
|
echo "warning: could not sanitize .claude.json; omitting it from backup" >&2
|
|
|
|
|
printf '{}' > "$STAGE/home-claude/.claude.json"
|
|
|
|
|
fi
|
2026-06-30 14:04:19 -07:00
|
|
|
fi
|
|
|
|
|
if [ -d "$HOME/.claude" ]; then
|
|
|
|
|
cp -a "$HOME/.claude" "$STAGE/home-claude/.claude" 2>/dev/null || true
|
|
|
|
|
rm -f "$STAGE/home-claude/.claude/.credentials.json"
|
|
|
|
|
fi
|
|
|
|
|
tar czf - --ignore-failed-read \
|
2026-06-30 14:28:00 -07:00
|
|
|
--exclude='*/node_modules' --exclude='*/target' \
|
2026-07-01 06:33:02 -07:00
|
|
|
--transform='flags=rh;s,^\.,workspace,' \
|
2026-06-30 14:04:19 -07:00
|
|
|
-C "$TC_BACKUP_SRC" . \
|
2026-06-30 14:59:48 -07:00
|
|
|
-C "$STAGE" home-claude"#;
|
2026-06-30 14:04:19 -07:00
|
|
|
|
|
|
|
|
let cmd = vec!["sh".to_string(), "-c".to_string(), script.to_string()];
|
2026-06-30 13:48:04 -07:00
|
|
|
|
|
|
|
|
let exec = docker
|
|
|
|
|
.create_exec(
|
|
|
|
|
container_id,
|
|
|
|
|
CreateExecOptions {
|
|
|
|
|
attach_stdout: Some(true),
|
|
|
|
|
attach_stderr: Some(true),
|
|
|
|
|
cmd: Some(cmd),
|
2026-06-30 14:04:19 -07:00
|
|
|
env: Some(vec![
|
|
|
|
|
"HOME=/home/claude".to_string(),
|
|
|
|
|
format!("TC_BACKUP_SRC={}", path),
|
|
|
|
|
]),
|
2026-06-30 13:48:04 -07:00
|
|
|
user: Some("claude".to_string()),
|
|
|
|
|
..Default::default()
|
|
|
|
|
},
|
|
|
|
|
)
|
|
|
|
|
.await
|
|
|
|
|
.map_err(|e| format!("Failed to create backup exec: {}", e))?;
|
|
|
|
|
|
|
|
|
|
let result = docker
|
|
|
|
|
.start_exec(&exec.id, None)
|
|
|
|
|
.await
|
|
|
|
|
.map_err(|e| format!("Failed to start backup exec: {}", e))?;
|
|
|
|
|
|
|
|
|
|
let mut output = match result {
|
|
|
|
|
StartExecResults::Attached { output, .. } => output,
|
|
|
|
|
StartExecResults::Detached => return Err("Backup exec started detached".to_string()),
|
|
|
|
|
};
|
|
|
|
|
|
2026-06-30 14:37:33 -07:00
|
|
|
use tokio::io::AsyncWriteExt;
|
2026-08-23 11:34:04 -07:00
|
|
|
let partial = partial_download_path(&dest)?;
|
2026-08-23 13:13:35 -07:00
|
|
|
// Opened synchronously so the descriptor can be checked against the path
|
|
|
|
|
// that was resolved a moment ago (H4): `create_new` is `O_EXCL`, so this
|
|
|
|
|
// cannot have followed a symlink at the final component, but a directory
|
|
|
|
|
// on the way could have been swapped since.
|
|
|
|
|
let open_at = partial.clone();
|
|
|
|
|
let file = tokio::task::spawn_blocking(move || -> Result<std::fs::File, String> {
|
|
|
|
|
let file = std::fs::OpenOptions::new()
|
|
|
|
|
.write(true)
|
|
|
|
|
.create_new(true)
|
|
|
|
|
.open(&open_at)
|
|
|
|
|
.map_err(|e| format!("Failed to create backup file: {}", e))?;
|
|
|
|
|
verify_opened_path(&file, &open_at)?;
|
|
|
|
|
Ok(file)
|
|
|
|
|
})
|
|
|
|
|
.await
|
|
|
|
|
.map_err(|e| format!("Backup task panicked: {}", e))??;
|
|
|
|
|
let file = tokio::fs::File::from_std(file);
|
2026-06-30 14:37:33 -07:00
|
|
|
let mut writer = tokio::io::BufWriter::new(file);
|
2026-06-30 13:48:04 -07:00
|
|
|
let mut total: u64 = 0;
|
|
|
|
|
let mut stderr_text = String::new();
|
2026-06-30 14:28:00 -07:00
|
|
|
let mut stream_err: Option<String> = None;
|
2026-06-30 13:48:04 -07:00
|
|
|
|
|
|
|
|
while let Some(msg) = output.next().await {
|
2026-06-30 14:28:00 -07:00
|
|
|
match msg {
|
|
|
|
|
Ok(LogOutput::StdOut { message }) => {
|
2026-06-30 14:37:33 -07:00
|
|
|
if let Err(e) = writer.write_all(&message).await {
|
2026-06-30 14:28:00 -07:00
|
|
|
stream_err = Some(format!("Failed to write backup file: {}", e));
|
|
|
|
|
break;
|
|
|
|
|
}
|
2026-06-30 13:48:04 -07:00
|
|
|
total += message.len() as u64;
|
|
|
|
|
}
|
2026-06-30 14:28:00 -07:00
|
|
|
Ok(LogOutput::StdErr { message }) => {
|
2026-06-30 13:48:04 -07:00
|
|
|
stderr_text.push_str(&String::from_utf8_lossy(&message));
|
|
|
|
|
}
|
2026-06-30 14:28:00 -07:00
|
|
|
Ok(_) => {}
|
|
|
|
|
Err(e) => {
|
|
|
|
|
stream_err = Some(format!("Backup stream error: {}", e));
|
|
|
|
|
break;
|
|
|
|
|
}
|
2026-06-30 13:48:04 -07:00
|
|
|
}
|
|
|
|
|
}
|
2026-06-30 14:28:00 -07:00
|
|
|
if stream_err.is_none() {
|
2026-06-30 14:37:33 -07:00
|
|
|
if let Err(e) = writer.flush().await {
|
2026-06-30 14:28:00 -07:00
|
|
|
stream_err = Some(format!("Failed to finalize backup file: {}", e));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
drop(writer);
|
2026-06-30 13:48:04 -07:00
|
|
|
|
2026-06-30 14:28:00 -07:00
|
|
|
// The tar pipeline can abort mid-stream (producing a truncated archive) and
|
|
|
|
|
// still have sent bytes, so a non-zero exit must be treated as failure even
|
2026-06-30 14:59:48 -07:00
|
|
|
// when `total > 0`. Poll until the exec actually reports finished so the
|
|
|
|
|
// exit code is reliably populated; if it can't be determined we fall back to
|
|
|
|
|
// the `total == 0` check below.
|
|
|
|
|
let exit_code = crate::docker::exec::wait_for_exec_exit(&exec.id).await;
|
2026-06-30 14:28:00 -07:00
|
|
|
|
2026-06-30 14:59:48 -07:00
|
|
|
if stream_err.is_none() && exit_code.is_some_and(|c| c != 0) {
|
2026-06-30 14:28:00 -07:00
|
|
|
stream_err = Some(format!(
|
|
|
|
|
"Backup command failed (exit {}){}",
|
2026-06-30 14:59:48 -07:00
|
|
|
exit_code.unwrap_or(-1),
|
2026-06-30 14:28:00 -07:00
|
|
|
if stderr_text.trim().is_empty() {
|
|
|
|
|
String::new()
|
|
|
|
|
} else {
|
|
|
|
|
format!(": {}", stderr_text.trim())
|
|
|
|
|
}
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
if stream_err.is_none() && total == 0 {
|
|
|
|
|
stream_err = Some(format!(
|
2026-06-30 13:48:04 -07:00
|
|
|
"Backup produced no data{}",
|
|
|
|
|
if stderr_text.trim().is_empty() {
|
|
|
|
|
String::new()
|
|
|
|
|
} else {
|
|
|
|
|
format!(": {}", stderr_text.trim())
|
|
|
|
|
}
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
|
2026-06-30 14:28:00 -07:00
|
|
|
if let Some(err) = stream_err {
|
2026-08-23 11:34:04 -07:00
|
|
|
// Only our own partial archive is deleted — never whatever the user
|
|
|
|
|
// already had at `dest`, which has not been touched yet.
|
|
|
|
|
let _ = tokio::fs::remove_file(&partial).await;
|
2026-06-30 14:28:00 -07:00
|
|
|
return Err(err);
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 11:34:04 -07:00
|
|
|
if let Err(e) = finish_download(&partial, &dest).await {
|
|
|
|
|
let _ = tokio::fs::remove_file(&partial).await;
|
|
|
|
|
return Err(e);
|
|
|
|
|
}
|
|
|
|
|
|
2026-06-30 13:48:04 -07:00
|
|
|
log::info!(
|
|
|
|
|
"Wrote {} byte backup for project {} to {}",
|
|
|
|
|
total,
|
|
|
|
|
project_id,
|
2026-08-23 11:34:04 -07:00
|
|
|
dest.display()
|
2026-06-30 13:48:04 -07:00
|
|
|
);
|
|
|
|
|
Ok(total)
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 11:34:04 -07:00
|
|
|
/// Marker on the "there is already a file called that" refusal, so the frontend
|
|
|
|
|
/// can tell it apart from every other upload failure and raise a
|
|
|
|
|
/// Replace/Skip prompt instead of reporting a dead end.
|
|
|
|
|
///
|
|
|
|
|
/// A marker in the string rather than a typed error because these commands
|
|
|
|
|
/// return `Result<_, String>` throughout; changing that shape is a bigger edit
|
|
|
|
|
/// than this bug is worth. The token and the "full container path" shape are a
|
|
|
|
|
/// contract with `app/src/lib/uploadErrors.ts` — `isFileExistsError` looks for
|
|
|
|
|
/// exactly this, and the prompt names the file.
|
|
|
|
|
pub const UPLOAD_EXISTS_MARKER: &str = "FILE_EXISTS";
|
|
|
|
|
|
|
|
|
|
/// The refusal itself. Split out so the marker and the sentence after it are
|
|
|
|
|
/// testable without a container.
|
|
|
|
|
fn upload_exists_error(dest: &str) -> String {
|
|
|
|
|
format!("{}: {} already exists", UPLOAD_EXISTS_MARKER, dest)
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
/// The argv that claims an upload destination inside the container, but only if
|
|
|
|
|
/// nothing is there.
|
|
|
|
|
///
|
|
|
|
|
/// `set -C` is the shell's noclobber: under it `>` opens with `O_CREAT|O_EXCL`,
|
|
|
|
|
/// so "is it taken?" and "take it" are a single syscall and there is no window
|
|
|
|
|
/// between them. That is the whole point — the file this guard exists for is
|
|
|
|
|
/// `~/.claude/.credentials.json`, which Claude Code writes from inside the
|
|
|
|
|
/// container at a moment nobody schedules, and a `test -e` followed by an
|
|
|
|
|
/// upload is two operations with exactly that moment in between.
|
|
|
|
|
///
|
|
|
|
|
/// The path travels as a separate argv element and is read back as `$0`, so no
|
|
|
|
|
/// part of it is ever parsed as script. `sh -c` with an interpolated path would
|
|
|
|
|
/// be the same class of bug as the `find` argv above, and is refused for the
|
|
|
|
|
/// same reason.
|
|
|
|
|
fn upload_reservation_argv(dest: &str) -> Vec<String> {
|
|
|
|
|
vec![
|
|
|
|
|
"sh".to_string(),
|
|
|
|
|
"-c".to_string(),
|
|
|
|
|
"set -C; : > \"$0\"".to_string(),
|
|
|
|
|
dest.to_string(),
|
|
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Create `dest` exclusively, or say why not.
|
|
|
|
|
///
|
|
|
|
|
/// The two failures that land here are very different and the frontend treats
|
|
|
|
|
/// them differently: "the name is taken" is the refusal it offers a Replace
|
|
|
|
|
/// for, everything else (a read-only mount, a missing directory) is a dead end.
|
|
|
|
|
/// The exit status alone cannot tell them apart, so the taken case is confirmed
|
|
|
|
|
/// rather than assumed.
|
|
|
|
|
async fn reserve_upload_destination(container_id: &str, dest: &str) -> Result<(), String> {
|
|
|
|
|
let (output, code) = exec_oneshot_as(
|
|
|
|
|
container_id,
|
|
|
|
|
"claude",
|
|
|
|
|
upload_reservation_argv(dest),
|
|
|
|
|
Vec::new(),
|
|
|
|
|
)
|
|
|
|
|
.await?;
|
|
|
|
|
if code == 0 {
|
|
|
|
|
return Ok(());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
let (_, exists) = exec_oneshot_as(
|
|
|
|
|
container_id,
|
|
|
|
|
"claude",
|
|
|
|
|
vec!["test".to_string(), "-e".to_string(), dest.to_string()],
|
|
|
|
|
Vec::new(),
|
|
|
|
|
)
|
|
|
|
|
.await?;
|
|
|
|
|
if exists == 0 {
|
|
|
|
|
return Err(upload_exists_error(dest));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
let detail = output.trim();
|
|
|
|
|
Err(if detail.is_empty() {
|
|
|
|
|
format!("Could not create {} (exit {})", dest, code)
|
|
|
|
|
} else {
|
|
|
|
|
detail.to_string()
|
|
|
|
|
})
|
|
|
|
|
}
|
|
|
|
|
|
2026-03-06 06:32:53 -08:00
|
|
|
#[tauri::command]
|
|
|
|
|
pub async fn upload_file_to_container(
|
|
|
|
|
project_id: String,
|
|
|
|
|
host_path: String,
|
|
|
|
|
container_dir: String,
|
2026-08-23 11:34:04 -07:00
|
|
|
// Absent or false means refuse a collision; the frontend re-invokes with
|
|
|
|
|
// `true` once the user has answered Replace. Defaulting to refusal is the
|
|
|
|
|
// point — the safe behaviour is what you get by not asking.
|
|
|
|
|
overwrite: Option<bool>,
|
2026-03-06 06:32:53 -08:00
|
|
|
state: State<'_, AppState>,
|
|
|
|
|
) -> Result<(), String> {
|
2026-08-23 11:34:04 -07:00
|
|
|
// An upload writes into `/workspace/{mount_name}`, i.e. the user's real
|
|
|
|
|
// project directory, so the destination gets the write-root check; the
|
|
|
|
|
// source is a host file being read *into* the container, so it gets the
|
|
|
|
|
// host-read policy.
|
|
|
|
|
validate_container_write_path("Folder", &container_dir)?;
|
2026-08-23 13:13:35 -07:00
|
|
|
let host_path = resolve_host_read_path(&host_path).await?;
|
2026-08-23 11:34:04 -07:00
|
|
|
|
2026-03-06 06:32:53 -08:00
|
|
|
let project = state
|
|
|
|
|
.projects_store
|
|
|
|
|
.get(&project_id)
|
|
|
|
|
.ok_or_else(|| format!("Project {} not found", project_id))?;
|
|
|
|
|
|
|
|
|
|
let container_id = project
|
|
|
|
|
.container_id
|
|
|
|
|
.as_ref()
|
|
|
|
|
.ok_or_else(|| "Container not running".to_string())?;
|
|
|
|
|
|
|
|
|
|
let docker = get_docker()?;
|
|
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
// Deferred to here rather than sitting with the lexical check above,
|
|
|
|
|
// because resolving the destination needs the container it lives in.
|
|
|
|
|
resolve_container_dir(container_id, "Folder", &container_dir).await?;
|
|
|
|
|
|
2026-08-23 08:30:48 -07:00
|
|
|
let meta = tokio::fs::metadata(&host_path)
|
|
|
|
|
.await
|
|
|
|
|
.map_err(|e| format!("Cannot access {}: {}", host_path, e))?;
|
|
|
|
|
|
|
|
|
|
// A directory here used to reach `std::fs::read`, whose "Is a directory"
|
|
|
|
|
// error says nothing about what to do. Recursive upload is a bigger feature
|
|
|
|
|
// than this panel needs; refuse clearly instead.
|
|
|
|
|
if meta.is_dir() {
|
|
|
|
|
return Err(format!(
|
|
|
|
|
"{} is a folder — drop or upload its files individually.",
|
|
|
|
|
host_path
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
if meta.len() > MAX_UPLOAD_BYTES {
|
|
|
|
|
return Err(format!(
|
|
|
|
|
"File too large to upload ({:.0} MB; limit {} MB). Mount it into the project instead.",
|
|
|
|
|
meta.len() as f64 / (1024.0 * 1024.0),
|
|
|
|
|
MAX_UPLOAD_BYTES / (1024 * 1024)
|
|
|
|
|
));
|
|
|
|
|
}
|
2026-03-06 06:32:53 -08:00
|
|
|
|
|
|
|
|
let file_name = std::path::Path::new(&host_path)
|
|
|
|
|
.file_name()
|
|
|
|
|
.ok_or_else(|| "Invalid file path".to_string())?
|
|
|
|
|
.to_string_lossy()
|
|
|
|
|
.to_string();
|
|
|
|
|
|
2026-08-23 11:34:04 -07:00
|
|
|
let dest = join_path(&container_dir, &file_name);
|
|
|
|
|
|
2026-08-23 08:30:48 -07:00
|
|
|
// Own the file as the container user and keep the host's mtime. A default
|
|
|
|
|
// tar header would land it root:root with a 1970-01-01 timestamp — i.e.
|
|
|
|
|
// not editable by Claude Code, and misleading in the listing.
|
|
|
|
|
let (uid, gid) = container_user_ids(container_id).await;
|
|
|
|
|
let mtime = meta
|
|
|
|
|
.modified()
|
|
|
|
|
.ok()
|
|
|
|
|
.and_then(|t| t.duration_since(std::time::UNIX_EPOCH).ok())
|
|
|
|
|
.map(|d| d.as_secs())
|
|
|
|
|
.unwrap_or_else(now_epoch_secs);
|
|
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
// Reading is a second open of a path that was resolved a moment ago, so the
|
|
|
|
|
// descriptor is checked before its bytes are trusted (H4) and the size
|
|
|
|
|
// ceiling is applied to *it* rather than to the `metadata` call above,
|
|
|
|
|
// which described whatever the path meant at the time. `std::fs::read` plus
|
|
|
|
|
// the tar build are synchronous and can be hundreds of MB, so they run on a
|
|
|
|
|
// blocking thread rather than stalling an async worker (the same discipline
|
|
|
|
|
// as `upload_host_file_to_container`).
|
2026-08-23 08:30:48 -07:00
|
|
|
let read_path = host_path.clone();
|
2026-08-23 13:13:35 -07:00
|
|
|
let tar_name = file_name.clone();
|
2026-08-23 08:30:48 -07:00
|
|
|
let tar_buf = tokio::task::spawn_blocking(move || -> Result<Vec<u8>, String> {
|
2026-08-23 13:13:35 -07:00
|
|
|
let file = std::fs::File::open(&read_path)
|
2026-08-23 08:30:48 -07:00
|
|
|
.map_err(|e| format!("Failed to read host file: {}", e))?;
|
2026-08-23 13:13:35 -07:00
|
|
|
verify_opened_path(&file, Path::new(&read_path))?;
|
|
|
|
|
let mut file_data = Vec::new();
|
|
|
|
|
std::io::Read::read_to_end(
|
|
|
|
|
&mut std::io::Read::take(file, MAX_UPLOAD_BYTES.saturating_add(1)),
|
|
|
|
|
&mut file_data,
|
|
|
|
|
)
|
|
|
|
|
.map_err(|e| format!("Failed to read host file: {}", e))?;
|
|
|
|
|
if file_data.len() as u64 > MAX_UPLOAD_BYTES {
|
|
|
|
|
return Err(format!(
|
|
|
|
|
"File too large to upload (limit {} MB). Mount it into the project instead.",
|
|
|
|
|
MAX_UPLOAD_BYTES / (1024 * 1024)
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
build_single_file_tar(&tar_name, &file_data[..], 0o644, uid, gid, mtime)
|
2026-08-23 08:30:48 -07:00
|
|
|
})
|
|
|
|
|
.await
|
|
|
|
|
.map_err(|e| format!("Upload task panicked: {}", e))??;
|
2026-03-06 06:32:53 -08:00
|
|
|
|
2026-08-23 13:13:35 -07:00
|
|
|
// Nothing in this stack checked whether the destination already existed:
|
|
|
|
|
// there was no probe, and `noOverwriteDirNonDir` only stops a directory
|
|
|
|
|
// being replaced by a non-directory (and vice versa) — Docker's extractor
|
|
|
|
|
// overwrites a file with a file quite happily. So dragging a host
|
|
|
|
|
// `.credentials.json` onto the folder holding the container's one destroyed
|
|
|
|
|
// it with no prompt and no undo, while `create_container_directory`
|
|
|
|
|
// deliberately omits `-p` and `rename_container_path` refuses an existing
|
|
|
|
|
// destination. Silence here was an inconsistency, not a policy: refuse by
|
|
|
|
|
// default, and say so in the words the frontend turns into a Replace/Skip
|
|
|
|
|
// prompt.
|
|
|
|
|
//
|
|
|
|
|
// The refusal has to be the *creation*, not a probe before it. A `test -e`
|
|
|
|
|
// and then an upload is two operations with a gap in between, and the file
|
|
|
|
|
// the gap is about is `.credentials.json` — written by Claude Code, inside
|
|
|
|
|
// the container, at a moment nobody controls. [`upload_reservation_argv`]
|
|
|
|
|
// closes that gap by making the check and the creation one `O_EXCL` open.
|
|
|
|
|
let reserved = if overwrite.unwrap_or(false) {
|
|
|
|
|
false
|
|
|
|
|
} else {
|
|
|
|
|
reserve_upload_destination(container_id, &dest).await?;
|
|
|
|
|
true
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
let uploaded = docker
|
2026-03-06 06:32:53 -08:00
|
|
|
.upload_to_container(
|
|
|
|
|
container_id,
|
|
|
|
|
Some(UploadToContainerOptions {
|
|
|
|
|
path: container_dir,
|
2026-08-23 13:13:35 -07:00
|
|
|
// Not the race-closer this comment used to claim it was: all
|
|
|
|
|
// Docker refuses here is a directory being replaced by a file
|
|
|
|
|
// and vice versa. It stays because that is worth refusing —
|
|
|
|
|
// the reservation above is what makes a file-over-file upload
|
|
|
|
|
// wait for an answer.
|
2026-08-23 11:34:04 -07:00
|
|
|
no_overwrite_dir_non_dir: "true".to_string(),
|
2026-03-06 06:32:53 -08:00
|
|
|
}),
|
|
|
|
|
tar_buf.into(),
|
|
|
|
|
)
|
2026-08-23 13:13:35 -07:00
|
|
|
.await;
|
|
|
|
|
|
|
|
|
|
if let Err(e) = uploaded {
|
|
|
|
|
if reserved {
|
|
|
|
|
// The placeholder is ours and it is empty. Leaving a 0-byte file
|
|
|
|
|
// where the user had nothing would be a worse outcome than the
|
|
|
|
|
// failed upload, and it would make the next attempt look like a
|
|
|
|
|
// collision.
|
|
|
|
|
let _ = exec_oneshot_as(
|
|
|
|
|
container_id,
|
|
|
|
|
"claude",
|
|
|
|
|
vec!["rm".to_string(), "-f".to_string(), "--".to_string(), dest.clone()],
|
|
|
|
|
Vec::new(),
|
|
|
|
|
)
|
|
|
|
|
.await;
|
|
|
|
|
}
|
|
|
|
|
return Err(format!("Failed to upload file to container: {}", e));
|
|
|
|
|
}
|
2026-03-06 06:32:53 -08:00
|
|
|
|
|
|
|
|
Ok(())
|
|
|
|
|
}
|
2026-08-23 08:30:48 -07:00
|
|
|
|
|
|
|
|
#[cfg(test)]
|
|
|
|
|
mod tests {
|
|
|
|
|
use super::*;
|
|
|
|
|
|
2026-08-23 11:34:04 -07:00
|
|
|
/// A record as `find -printf '%y\t%Y\t%s\t%T@\t%m\t%f\0'` emits it —
|
|
|
|
|
/// fields first, name last, NUL-terminated.
|
2026-08-23 08:30:48 -07:00
|
|
|
fn line(name: &str, own: &str, deref: &str, size: &str) -> String {
|
2026-08-23 11:34:04 -07:00
|
|
|
format!("{}\t{}\t{}\t1700000000.0000000000\t644\t{}\0", own, deref, size, name)
|
2026-08-23 08:30:48 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn parses_a_plain_file_row() {
|
|
|
|
|
let entries = parse_find_output("/workspace", &line("notes.txt", "f", "f", "42"));
|
|
|
|
|
assert_eq!(entries.len(), 1);
|
|
|
|
|
assert_eq!(entries[0].name, "notes.txt");
|
|
|
|
|
assert_eq!(entries[0].path, "/workspace/notes.txt");
|
|
|
|
|
assert!(!entries[0].is_directory);
|
|
|
|
|
assert!(!entries[0].is_symlink);
|
|
|
|
|
assert_eq!(entries[0].size, 42);
|
|
|
|
|
assert_eq!(entries[0].permissions, "644");
|
|
|
|
|
assert_eq!(entries[0].modified, "2023-11-14 22:13:20");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_symlink_to_a_directory_is_navigable_and_still_flagged_as_a_link() {
|
|
|
|
|
// The bug this guards: `%y` reports `l`, so keying `is_directory` off it
|
|
|
|
|
// made every symlinked directory an unopenable row.
|
|
|
|
|
let entries = parse_find_output("/workspace", &line("app", "l", "d", "12"));
|
|
|
|
|
assert!(entries[0].is_directory);
|
|
|
|
|
assert!(entries[0].is_symlink);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_broken_symlink_is_not_a_directory() {
|
|
|
|
|
// `%Y` is `N` when the target is missing, `L` on a loop.
|
|
|
|
|
for deref in ["N", "L", "?"] {
|
|
|
|
|
let entries = parse_find_output("/workspace", &line("dangling", "l", deref, "9"));
|
|
|
|
|
assert!(!entries[0].is_directory, "deref type {} became a directory", deref);
|
|
|
|
|
assert!(entries[0].is_symlink);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn directories_sort_first_then_case_insensitively() {
|
|
|
|
|
let output = [
|
|
|
|
|
line("Zeta", "f", "f", "1"),
|
|
|
|
|
line("alpha", "f", "f", "1"),
|
|
|
|
|
line("src", "d", "d", "4096"),
|
|
|
|
|
]
|
2026-08-23 11:34:04 -07:00
|
|
|
.concat();
|
2026-08-23 08:30:48 -07:00
|
|
|
let entries = parse_find_output("/workspace", &output);
|
|
|
|
|
let names: Vec<&str> = entries.iter().map(|e| e.name.as_str()).collect();
|
|
|
|
|
assert_eq!(names, vec!["src", "alpha", "Zeta"]);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn short_and_blank_rows_are_dropped_rather_than_mis_parsed() {
|
2026-08-23 11:34:04 -07:00
|
|
|
let output = format!("\0 \0broken\ttoo\tshort\0{}", line("ok", "f", "f", "1"));
|
2026-08-23 08:30:48 -07:00
|
|
|
let entries = parse_find_output("/workspace", &output);
|
|
|
|
|
assert_eq!(entries.len(), 1);
|
|
|
|
|
assert_eq!(entries[0].name, "ok");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn the_root_directory_does_not_get_a_doubled_separator() {
|
|
|
|
|
let entries = parse_find_output("/", &line("etc", "d", "d", "4096"));
|
|
|
|
|
assert_eq!(entries[0].path, "/etc");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn unparseable_size_and_mtime_fall_back_instead_of_dropping_the_row() {
|
2026-08-23 11:34:04 -07:00
|
|
|
let output = "f\tf\t-\t-\t644\tweird";
|
2026-08-23 08:30:48 -07:00
|
|
|
let entries = parse_find_output("/workspace", output);
|
|
|
|
|
assert_eq!(entries.len(), 1);
|
|
|
|
|
assert_eq!(entries[0].size, 0);
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 11:34:04 -07:00
|
|
|
#[test]
|
|
|
|
|
fn the_listing_argv_puts_the_name_last_and_terminates_records_with_nul() {
|
|
|
|
|
// Pinned together with the parser: these two only work as a pair, and
|
|
|
|
|
// the separators must reach `find` as escapes — a literal NUL cannot
|
|
|
|
|
// travel in argv.
|
|
|
|
|
let argv = list_argv("/workspace");
|
|
|
|
|
assert_eq!(argv[0], "find");
|
|
|
|
|
assert_eq!(argv[1], "/workspace");
|
|
|
|
|
let format = argv.last().unwrap();
|
|
|
|
|
assert!(format.ends_with("%f\\0"), "{}", format);
|
|
|
|
|
assert!(!format.contains('\0'));
|
|
|
|
|
assert!(!format.contains('\n'));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_tab_in_a_filename_cannot_forge_the_type_and_size_columns() {
|
|
|
|
|
// The bug this guards: with the name first, `evil.txt\td\td\t4096…`
|
|
|
|
|
// rendered as a *directory* of the attacker's chosen size. The name is
|
|
|
|
|
// last now, so the tabs stay inside it.
|
|
|
|
|
let entries = parse_find_output(
|
|
|
|
|
"/workspace",
|
|
|
|
|
&line("evil.txt\td\td\t4096", "f", "f", "3"),
|
|
|
|
|
);
|
|
|
|
|
assert_eq!(entries.len(), 1);
|
|
|
|
|
assert_eq!(entries[0].name, "evil.txt\td\td\t4096");
|
|
|
|
|
assert!(!entries[0].is_directory);
|
|
|
|
|
assert_eq!(entries[0].size, 3);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_newline_in_a_filename_cannot_forge_a_whole_row() {
|
|
|
|
|
// A filename may contain a newline, so a line-terminated format let one
|
|
|
|
|
// name print two rows. NUL is the byte a filename cannot contain.
|
|
|
|
|
let entries = parse_find_output("/workspace", &line("two\nlines", "f", "f", "5"));
|
|
|
|
|
assert_eq!(entries.len(), 1);
|
|
|
|
|
assert_eq!(entries[0].name, "two\nlines");
|
|
|
|
|
assert_eq!(entries[0].path, "/workspace/two\nlines");
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 08:30:48 -07:00
|
|
|
#[test]
|
|
|
|
|
fn parent_dir_walks_up_one_level_and_stops_at_root() {
|
|
|
|
|
assert_eq!(parent_dir("/workspace/app/src"), "/workspace/app");
|
|
|
|
|
assert_eq!(parent_dir("/workspace/app/src/"), "/workspace/app");
|
|
|
|
|
assert_eq!(parent_dir("/workspace"), "/");
|
|
|
|
|
assert_eq!(parent_dir("/"), "/");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_rename_target_may_not_relocate_the_entry() {
|
|
|
|
|
// The whole point of the validator: this is argv for `mv`, and a name
|
|
|
|
|
// with a separator in it would be a move, not a rename.
|
|
|
|
|
assert!(validate_entry_name("sub/dir").is_err());
|
|
|
|
|
assert!(validate_entry_name("../escape").is_err());
|
|
|
|
|
assert!(validate_entry_name("/etc/passwd").is_err());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn dot_and_dotdot_and_empty_are_refused() {
|
|
|
|
|
assert!(validate_entry_name("").is_err());
|
|
|
|
|
assert!(validate_entry_name(".").is_err());
|
|
|
|
|
assert!(validate_entry_name("..").is_err());
|
|
|
|
|
assert!(validate_entry_name("\0").is_err());
|
|
|
|
|
assert!(validate_entry_name(&"x".repeat(256)).is_err());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn ordinary_names_including_awkward_ones_are_allowed() {
|
|
|
|
|
// Nothing goes through a shell, so metacharacters are just characters —
|
|
|
|
|
// and a leading `-` is safe because every call site passes `--` first.
|
|
|
|
|
for name in [".hidden", "a b.txt", "$(whoami)", "it's", "-rf", "…unicode…"] {
|
|
|
|
|
assert!(validate_entry_name(name).is_ok(), "{} was refused", name);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn the_viewer_cap_is_never_larger_than_the_hard_ceiling() {
|
|
|
|
|
// The frontend picks a cap per file type; Rust still gets the last word
|
|
|
|
|
// because the whole payload is buffered in host RAM.
|
|
|
|
|
assert_eq!(Some(u64::MAX).unwrap().min(MAX_READ_BYTES), MAX_READ_BYTES);
|
|
|
|
|
assert!(MAX_READ_BYTES < MAX_UPLOAD_BYTES);
|
|
|
|
|
}
|
2026-08-23 09:12:59 -07:00
|
|
|
|
2026-08-23 11:34:04 -07:00
|
|
|
// ── Path validation ─────────────────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_listing_path_that_is_really_an_argument_is_refused() {
|
|
|
|
|
// C2. `find` ends its starting-point list at the first argument
|
|
|
|
|
// beginning with `-`, so `path = "-delete"` listed nothing and ran
|
|
|
|
|
// `-delete` over the exec's working directory — the bind-mounted
|
|
|
|
|
// project. Verified deleting on findutils 4.9.0. `--` does not help;
|
|
|
|
|
// absoluteness does.
|
|
|
|
|
for path in ["-delete", "-exec", "--", "-mindepth"] {
|
|
|
|
|
let err = validate_container_path("Folder", path).unwrap_err();
|
|
|
|
|
assert!(err.contains("absolute"), "{} → {}", path, err);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_container_path_must_be_absolute_and_traversal_free() {
|
|
|
|
|
assert!(validate_container_path("Folder", "/workspace").is_ok());
|
|
|
|
|
assert!(validate_container_path("Folder", "/home/claude/.claude").is_ok());
|
|
|
|
|
// A name that merely *starts* with a dot-dot is not traversal.
|
|
|
|
|
assert!(validate_container_path("Folder", "/workspace/..hidden").is_ok());
|
|
|
|
|
|
|
|
|
|
assert!(validate_container_path("Folder", "").is_err());
|
|
|
|
|
assert!(validate_container_path("Folder", "workspace/app").is_err());
|
|
|
|
|
assert!(validate_container_path("Folder", "/workspace/../etc").is_err());
|
|
|
|
|
assert!(validate_container_path("Folder", "/workspace/..").is_err());
|
|
|
|
|
assert!(validate_container_path("Folder", "/work\0space").is_err());
|
|
|
|
|
assert!(validate_container_path("Folder", &format!("/{}", "x".repeat(4096))).is_err());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn only_the_folders_the_app_owns_can_be_written_to() {
|
|
|
|
|
for path in ["/workspace", "/workspace/app/src", "/home/claude", "/tmp/x"] {
|
|
|
|
|
assert!(validate_container_write_path("Item", path).is_ok(), "{}", path);
|
|
|
|
|
}
|
|
|
|
|
// Reading these is fine — changing them is not this panel's business,
|
|
|
|
|
// and outside /workspace it would be a permission error anyway.
|
|
|
|
|
for path in ["/", "/etc/passwd", "/usr/lib", "/home/other", "/workspace-backup/x"] {
|
|
|
|
|
assert!(validate_container_write_path("Item", path).is_err(), "{}", path);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn containment_is_compared_by_whole_segments() {
|
|
|
|
|
// The classic `starts_with` bug: `/workspace-backup` is not under
|
|
|
|
|
// `/workspace`.
|
|
|
|
|
assert!(is_under_root("/workspace", "/workspace"));
|
|
|
|
|
assert!(is_under_root("/workspace/", "/workspace"));
|
|
|
|
|
assert!(is_under_root("/workspace/app", "/workspace"));
|
|
|
|
|
assert!(!is_under_root("/workspaces", "/workspace"));
|
|
|
|
|
assert!(!is_under_root("/workspace-backup/x", "/workspace"));
|
|
|
|
|
assert!(!is_under_root("/", "/workspace"));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn an_ordinary_save_location_is_accepted() {
|
|
|
|
|
for path in ["/home/jo/Downloads/report.pdf", "/tmp/out.txt", "/media/usb/a b.md"] {
|
|
|
|
|
assert!(validate_host_path(path, HostPathUse::Write).is_ok(), "{}", path);
|
|
|
|
|
assert!(validate_host_path(path, HostPathUse::Read).is_ok(), "{}", path);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_host_path_must_be_absolute_and_traversal_free() {
|
|
|
|
|
assert!(validate_host_path("", HostPathUse::Write).is_err());
|
|
|
|
|
assert!(validate_host_path("report.pdf", HostPathUse::Write).is_err());
|
|
|
|
|
assert!(validate_host_path("/home/jo/../../etc/hosts", HostPathUse::Write).is_err());
|
|
|
|
|
assert!(validate_host_path("/home/jo/re\0port", HostPathUse::Write).is_err());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_hidden_host_directory_is_refused_in_both_directions() {
|
|
|
|
|
// The container→host write primitive worth closing: container-controlled
|
|
|
|
|
// bytes at a path of the caller's choosing.
|
|
|
|
|
assert!(validate_host_path("/home/jo/.ssh/authorized_keys", HostPathUse::Write).is_err());
|
|
|
|
|
assert!(validate_host_path("/home/jo/.config/autostart/x", HostPathUse::Write).is_err());
|
|
|
|
|
// …and the host→container read that pairs with it.
|
|
|
|
|
assert!(validate_host_path("/home/jo/.aws/credentials", HostPathUse::Read).is_err());
|
|
|
|
|
assert!(validate_host_path("/home/jo/.ssh/id_rsa", HostPathUse::Read).is_err());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_hidden_file_name_may_be_uploaded_but_not_created() {
|
|
|
|
|
// Dragging a project's own `.env` into the container is ordinary; being
|
|
|
|
|
// handed a container-controlled `~/.bashrc` is not.
|
|
|
|
|
assert!(validate_host_path("/home/jo/project/.env", HostPathUse::Read).is_ok());
|
|
|
|
|
assert!(validate_host_path("/home/jo/.bashrc", HostPathUse::Write).is_err());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn host_system_locations_are_refused_including_windows_ones() {
|
|
|
|
|
assert!(validate_host_path("/etc/cron.d/x", HostPathUse::Write).is_err());
|
|
|
|
|
assert!(validate_host_path("/usr/bin/tool", HostPathUse::Write).is_err());
|
|
|
|
|
assert!(validate_host_path("/etc/shadow", HostPathUse::Read).is_err());
|
|
|
|
|
// Case and separator are normalised before the comparison.
|
|
|
|
|
let windows = "C:\\Windows\\System32\\drivers\\etc\\hosts";
|
|
|
|
|
assert!(validate_host_path(windows, HostPathUse::Write).is_err());
|
|
|
|
|
// A user directory that merely shares a prefix is not a system one.
|
|
|
|
|
assert!(validate_host_path("/home/jo/etcetera/notes.txt", HostPathUse::Write).is_ok());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// ── Downloads ───────────────────────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_download_is_staged_beside_its_destination_and_renamed() {
|
|
|
|
|
// Why: the destination must not be touched until the transfer has
|
|
|
|
|
// succeeded, and the rename that finishes the job must not cross a
|
|
|
|
|
// filesystem.
|
|
|
|
|
let dest = Path::new("/home/jo/Downloads/report.pdf");
|
|
|
|
|
let partial = partial_download_path(dest).unwrap();
|
|
|
|
|
assert_eq!(partial.parent(), dest.parent());
|
|
|
|
|
assert_ne!(partial, dest);
|
|
|
|
|
let name = partial.file_name().unwrap().to_string_lossy().to_string();
|
|
|
|
|
assert!(name.starts_with("report.pdf."), "{}", name);
|
|
|
|
|
assert!(name.contains("triple-c-part-"), "{}", name);
|
|
|
|
|
// Visible on purpose: a crash leaves it next to the file it meant to be.
|
|
|
|
|
assert!(!name.starts_with('.'), "{}", name);
|
|
|
|
|
// Two downloads of the same file must not share a partial.
|
|
|
|
|
assert_ne!(partial_download_path(dest).unwrap(), partial);
|
|
|
|
|
assert!(partial_download_path(Path::new("/")).is_err());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[tokio::test]
|
|
|
|
|
async fn finishing_a_download_replaces_the_destination_only_once_it_is_whole() {
|
|
|
|
|
// The destination the user picked already holds something — the save
|
|
|
|
|
// dialog asked about that — and what must never happen is losing it to a
|
|
|
|
|
// download that did not arrive. Here the payload *has* arrived, so the
|
|
|
|
|
// swap goes through, on Windows (rename refuses an existing target) as
|
|
|
|
|
// well as Unix.
|
|
|
|
|
let dir = std::env::temp_dir().join(format!("tc-finish-{}", uuid::Uuid::new_v4()));
|
|
|
|
|
tokio::fs::create_dir_all(&dir).await.unwrap();
|
|
|
|
|
let dest = dir.join("thesis.docx");
|
|
|
|
|
tokio::fs::write(&dest, b"the original").await.unwrap();
|
|
|
|
|
|
|
|
|
|
let partial = partial_download_path(&dest).unwrap();
|
|
|
|
|
tokio::fs::write(&partial, b"the download").await.unwrap();
|
|
|
|
|
|
|
|
|
|
finish_download(&partial, &dest).await.unwrap();
|
|
|
|
|
assert_eq!(tokio::fs::read(&dest).await.unwrap(), b"the download");
|
|
|
|
|
assert!(!partial.exists(), "the partial file was left behind");
|
|
|
|
|
|
|
|
|
|
let _ = tokio::fs::remove_dir_all(&dir).await;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn the_download_ceiling_is_checked_against_the_declared_size() {
|
|
|
|
|
// The bug this guards: the download path passed `None` for the cap, so
|
|
|
|
|
// a 40 GB (sparse, near-free in the container) file was buffered whole
|
|
|
|
|
// in host RAM — twice.
|
|
|
|
|
assert!(check_download_size(MAX_DOWNLOAD_BYTES).is_ok());
|
|
|
|
|
let err = check_download_size(40 * 1024 * 1024 * 1024).unwrap_err();
|
|
|
|
|
assert!(err.contains("40.0 GB"), "{}", err);
|
|
|
|
|
// A ceiling with no way forward is the one thing a ceiling must not be.
|
|
|
|
|
assert!(err.contains("Backup"), "{}", err);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn every_buffering_read_has_to_name_a_ceiling() {
|
|
|
|
|
// `fetch_container_file` takes a plain `u64` now, so the `None` that
|
|
|
|
|
// made the cap inert cannot be written again. These are the two callers
|
|
|
|
|
// left, and both buffer.
|
|
|
|
|
assert!(MAX_READ_BYTES <= MAX_DRAG_STAGE_BYTES);
|
|
|
|
|
assert!(MAX_DRAG_STAGE_BYTES < MAX_DOWNLOAD_BYTES);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn an_upload_collision_is_reported_so_the_ui_can_offer_to_overwrite() {
|
|
|
|
|
// H5: Docker's extractor overwrites a file with a file silently, and
|
|
|
|
|
// dropping a `.credentials.json` onto the folder holding one was
|
|
|
|
|
// irrecoverable. The prefix is what lets the frontend tell this refusal
|
|
|
|
|
// apart from a real failure.
|
|
|
|
|
let err = upload_exists_error("/home/claude/.claude/.credentials.json");
|
|
|
|
|
// The token and the full path are a contract with
|
|
|
|
|
// `app/src/lib/uploadErrors.ts`, which turns this into the prompt.
|
|
|
|
|
assert!(err.contains(UPLOAD_EXISTS_MARKER), "{}", err);
|
|
|
|
|
assert_eq!(
|
|
|
|
|
err,
|
|
|
|
|
"FILE_EXISTS: /home/claude/.claude/.credentials.json already exists"
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2026-08-23 09:12:59 -07:00
|
|
|
// ── Drag-out staging ────────────────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn the_staging_path_is_built_under_the_supplied_temp_dir() {
|
|
|
|
|
// Never `/tmp`: on Windows the temp dir is per-user and nowhere near it,
|
|
|
|
|
// so the whole path has to be derived from what Tauri hands us.
|
|
|
|
|
let temp = Path::new("/somewhere/else");
|
|
|
|
|
let root = drag_stage_root(temp);
|
|
|
|
|
assert_eq!(root, Path::new("/somewhere/else/triple-c-drag-out"));
|
|
|
|
|
|
|
|
|
|
let session = drag_stage_session_dir(temp);
|
|
|
|
|
assert_eq!(session.parent(), Some(root.as_path()));
|
|
|
|
|
assert!(session.starts_with(root));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn every_call_in_a_process_stages_into_the_same_session_directory() {
|
|
|
|
|
// Exit cleanup deletes this directory by name rather than tracking what
|
|
|
|
|
// it wrote, which only works if the name does not move.
|
|
|
|
|
let temp = Path::new("/tmp-ish");
|
|
|
|
|
assert_eq!(drag_stage_session_dir(temp), drag_stage_session_dir(temp));
|
|
|
|
|
assert_ne!(drag_stage_session_dir(temp), drag_stage_root(temp));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn the_staged_copy_keeps_the_original_file_name() {
|
|
|
|
|
// The reason the feature stages into a per-session directory at all: a
|
|
|
|
|
// plain temp file would be dropped onto the desktop called `tmp1234`.
|
|
|
|
|
assert_eq!(stage_file_name("/workspace/notes.txt").unwrap(), "notes.txt");
|
|
|
|
|
assert_eq!(stage_file_name("/workspace/a b/.env").unwrap(), ".env");
|
|
|
|
|
assert_eq!(stage_file_name("report.pdf").unwrap(), "report.pdf");
|
|
|
|
|
assert_eq!(stage_file_name("/workspace/über.md").unwrap(), "über.md");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_name_windows_cannot_hold_is_substituted_rather_than_dropped() {
|
|
|
|
|
// These are all legal on Linux and all refused by NTFS, and the staged
|
|
|
|
|
// copy has to exist on the host we are dragging onto.
|
|
|
|
|
assert_eq!(stage_file_name("/workspace/a:b.txt").unwrap(), "a_b.txt");
|
|
|
|
|
assert_eq!(stage_file_name("/workspace/q?.log").unwrap(), "q_.log");
|
|
|
|
|
assert_eq!(stage_file_name("/workspace/a\\b").unwrap(), "a_b");
|
|
|
|
|
// A trailing dot or space is not refused, it is silently dropped — so
|
|
|
|
|
// the path we return would not be the path that exists.
|
|
|
|
|
assert_eq!(stage_file_name("/workspace/trailing. ").unwrap(), "trailing");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_path_that_does_not_name_a_file_is_refused_not_invented() {
|
|
|
|
|
assert!(stage_file_name("/").is_err());
|
|
|
|
|
assert!(stage_file_name("").is_err());
|
|
|
|
|
assert!(stage_file_name("/workspace/..").is_err());
|
|
|
|
|
assert!(stage_file_name("/workspace/.").is_err());
|
|
|
|
|
// Trims down to nothing, which is the same problem one step later.
|
|
|
|
|
assert!(stage_file_name("/workspace/...").is_err());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn two_files_with_the_same_name_stage_to_different_places() {
|
|
|
|
|
// Names are unique per directory, not per container — and the second
|
|
|
|
|
// drag would otherwise rewrite the first one's bytes under the path the
|
|
|
|
|
// first one is still cached at.
|
|
|
|
|
assert_ne!(
|
|
|
|
|
drag_stage_slot("/workspace/a/notes.txt"),
|
|
|
|
|
drag_stage_slot("/workspace/b/notes.txt")
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn re_staging_the_same_file_reuses_its_slot() {
|
|
|
|
|
// Deterministic, so a file dragged repeatedly does not grow a new
|
|
|
|
|
// directory in the host temp dir every time.
|
|
|
|
|
assert_eq!(
|
|
|
|
|
drag_stage_slot("/workspace/notes.txt"),
|
|
|
|
|
drag_stage_slot("/workspace/notes.txt")
|
|
|
|
|
);
|
|
|
|
|
// Short enough to keep the path sane, long enough not to collide.
|
|
|
|
|
assert_eq!(drag_stage_slot("/workspace/notes.txt").len(), 16);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn the_drag_size_cap_matches_the_established_ceiling_and_names_the_fallback() {
|
|
|
|
|
assert_eq!(MAX_DRAG_STAGE_BYTES, MAX_UPLOAD_BYTES);
|
|
|
|
|
assert!(check_stage_size(MAX_DRAG_STAGE_BYTES).is_ok());
|
|
|
|
|
|
|
|
|
|
let err = check_stage_size(MAX_DRAG_STAGE_BYTES + 1).unwrap_err();
|
|
|
|
|
assert!(err.contains("256 MB"), "{}", err);
|
|
|
|
|
// A size cap with no way forward is the one thing this must not be.
|
|
|
|
|
assert!(err.contains("Save to host"), "{}", err);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn the_reaper_only_takes_entries_past_the_age_threshold() {
|
|
|
|
|
let now = SystemTime::UNIX_EPOCH + Duration::from_secs(1_000_000);
|
|
|
|
|
let age = Duration::from_secs(3_600);
|
|
|
|
|
|
|
|
|
|
assert!(drag_stage_is_stale(now - Duration::from_secs(3_601), now, age));
|
|
|
|
|
assert!(drag_stage_is_stale(now - age, now, age));
|
|
|
|
|
assert!(!drag_stage_is_stale(now - Duration::from_secs(3_599), now, age));
|
|
|
|
|
assert!(!drag_stage_is_stale(now, now, age));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_future_timestamp_is_left_alone_rather_than_reaped() {
|
|
|
|
|
// A clock step must not turn housekeeping into deletion of something it
|
|
|
|
|
// cannot date.
|
|
|
|
|
let now = SystemTime::UNIX_EPOCH + Duration::from_secs(1_000_000);
|
|
|
|
|
let age = Duration::from_secs(3_600);
|
|
|
|
|
assert!(!drag_stage_is_stale(now + Duration::from_secs(60), now, age));
|
|
|
|
|
}
|
2026-08-23 13:13:35 -07:00
|
|
|
|
|
|
|
|
// ── Host path normalisation, on every platform ──────────────────────────
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn windows_system_locations_are_recognised_wherever_this_runs() {
|
|
|
|
|
// The bug this guards is a *test* bug with a real hole behind it. The
|
|
|
|
|
// old assertion was `validate_host_path("C:\\Windows\\…").is_err()`,
|
|
|
|
|
// and on Linux it passed because `Path::is_absolute` is false for a
|
|
|
|
|
// Windows path there — so the four Windows entries in
|
|
|
|
|
// `HOST_SYSTEM_ROOTS` were never once compared against anything in CI.
|
|
|
|
|
// The rule is a pure function over a string now, and this drives it.
|
|
|
|
|
assert_eq!(
|
|
|
|
|
host_system_root_for("C:\\Windows\\System32\\drivers\\etc\\hosts"),
|
|
|
|
|
Some("c:/windows")
|
|
|
|
|
);
|
|
|
|
|
assert_eq!(host_system_root_for("c:/Program Files/x"), Some("c:/program files"));
|
|
|
|
|
|
|
|
|
|
// `\\?\` turns off Win32 path parsing; it does not name a different
|
|
|
|
|
// place. `std::fs::canonicalize` returns this spelling on Windows, so
|
|
|
|
|
// the check has to understand its own output.
|
|
|
|
|
assert_eq!(
|
|
|
|
|
host_system_root_for("\\\\?\\C:\\Windows\\System32\\x"),
|
|
|
|
|
Some("c:/windows")
|
|
|
|
|
);
|
|
|
|
|
assert_eq!(
|
|
|
|
|
host_system_root_for("\\\\.\\C:\\ProgramData\\x"),
|
|
|
|
|
Some("c:/programdata")
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
// An administrative share reaches the same drive over UNC.
|
|
|
|
|
assert_eq!(host_system_root_for("\\\\localhost\\C$\\Windows\\x"), Some("c:/windows"));
|
|
|
|
|
assert_eq!(host_system_root_for("\\\\?\\UNC\\host\\C$\\Windows\\x"), Some("c:/windows"));
|
|
|
|
|
assert_eq!(host_system_root_for("\\\\host\\ADMIN$\\System32\\x"), Some("c:/windows"));
|
|
|
|
|
|
|
|
|
|
// An ordinary file share has no local equivalent, and this list does
|
|
|
|
|
// not pretend to know what is on someone else's server.
|
|
|
|
|
assert_eq!(host_system_root_for("\\\\host\\share\\report.pdf"), None);
|
|
|
|
|
// A user directory that merely shares a prefix is not a system one.
|
|
|
|
|
assert_eq!(host_system_root_for("/home/jo/etcetera/notes.txt"), None);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_windows_path_is_split_into_components_wherever_this_runs() {
|
|
|
|
|
// Same shape of bug one rule along: `Path::components` treats `\` as a
|
|
|
|
|
// separator only on Windows, so on Linux the whole of
|
|
|
|
|
// `C:\Users\jo\.ssh\id_rsa` was a single component and the
|
|
|
|
|
// hidden-directory rule had nothing to find.
|
|
|
|
|
assert_eq!(
|
|
|
|
|
host_path_names("C:\\Users\\jo\\Downloads\\a.txt"),
|
|
|
|
|
["Users", "jo", "Downloads", "a.txt"]
|
|
|
|
|
);
|
|
|
|
|
assert_eq!(host_path_names("\\\\?\\C:\\Users\\jo\\x"), ["Users", "jo", "x"]);
|
|
|
|
|
assert!(validate_host_path("C:\\Users\\jo\\.ssh\\authorized_keys", HostPathUse::Write).is_err());
|
|
|
|
|
assert!(validate_host_path("C:\\Users\\jo\\..\\admin\\x", HostPathUse::Write).is_err());
|
|
|
|
|
assert!(validate_host_path("C:\\Users\\jo\\Downloads\\report.pdf", HostPathUse::Write).is_ok());
|
|
|
|
|
assert!(is_absolute_host_path("C:\\Users\\jo\\x"));
|
|
|
|
|
assert!(!is_absolute_host_path("C:x"));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[cfg(not(windows))]
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_backslash_in_a_unix_filename_is_not_a_separator() {
|
|
|
|
|
// Unifying separators unconditionally would split a legal Linux name.
|
|
|
|
|
assert_eq!(host_path_names("/home/jo/a\\b.txt"), ["home", "jo", "a\\b.txt"]);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_login_item_directory_is_refused_for_a_write() {
|
|
|
|
|
// Defence in depth, and deliberately not called a fix: see
|
|
|
|
|
// `validate_host_path` for why a denylist of persistence directories is
|
|
|
|
|
// losing by construction.
|
|
|
|
|
assert!(validate_host_path("/Users/jo/Library/LaunchAgents/x.plist", HostPathUse::Write).is_err());
|
|
|
|
|
assert!(validate_host_path(
|
|
|
|
|
"C:\\Users\\jo\\AppData\\Roaming\\Microsoft\\Windows\\Start Menu\\Programs\\Startup\\x.lnk",
|
|
|
|
|
HostPathUse::Write
|
|
|
|
|
)
|
|
|
|
|
.is_err());
|
|
|
|
|
// A directory that merely happens to be called Library is not one.
|
|
|
|
|
assert!(validate_host_path("/Users/jo/Documents/Library/notes.md", HostPathUse::Write).is_ok());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn the_unix_system_roots_cover_the_places_a_mac_resolves_them_to() {
|
|
|
|
|
// Resolution happens before this check now, and on macOS `/etc` and
|
|
|
|
|
// `/var` resolve into `/private`.
|
|
|
|
|
assert!(validate_host_path("/private/etc/hosts", HostPathUse::Write).is_err());
|
|
|
|
|
assert!(validate_host_path("/private/var/db/x", HostPathUse::Write).is_err());
|
|
|
|
|
assert!(validate_host_path("/opt/homebrew/bin/x", HostPathUse::Write).is_err());
|
|
|
|
|
assert!(validate_host_path("/srv/www/index.html", HostPathUse::Write).is_err());
|
|
|
|
|
// …but `/tmp` resolves to `/private/tmp` there, and saving into the
|
|
|
|
|
// temp directory is entirely ordinary.
|
|
|
|
|
assert!(validate_host_path("/private/tmp/report.pdf", HostPathUse::Write).is_ok());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_home_directory_that_lives_under_a_system_root_is_still_a_home_directory() {
|
|
|
|
|
// Only a problem once the check ran on the resolved path: `/home` is a
|
|
|
|
|
// symlink to `/var/home` on rpm-ostree systems, and a Mac's per-user
|
|
|
|
|
// temp directory resolves into `/private/var/folders`.
|
|
|
|
|
assert!(validate_host_path("/var/home/jo/Downloads/report.pdf", HostPathUse::Write).is_ok());
|
|
|
|
|
assert!(validate_host_path("/private/var/folders/qx/T/report.pdf", HostPathUse::Write).is_ok());
|
|
|
|
|
// The rest of `/var` is exactly as refused as it was.
|
|
|
|
|
assert!(validate_host_path("/var/lib/docker/x", HostPathUse::Write).is_err());
|
|
|
|
|
assert!(validate_host_path("/var/log/syslog", HostPathUse::Read).is_err());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// ── H4: a symlinked component, and where the bytes actually land ────────
|
|
|
|
|
|
|
|
|
|
/// A throwaway host tree shaped like the real attack: a visible
|
|
|
|
|
/// `Downloads/pub` that is really `~/.ssh`.
|
|
|
|
|
///
|
|
|
|
|
/// This is the scenario verbatim — and the container end of it is not
|
|
|
|
|
/// hypothetical: `/proc/self/mountinfo` inside a Triple-C container spells
|
|
|
|
|
/// the host's project paths out, so code in there knows both where to plant
|
|
|
|
|
/// the link and what host path to ask the backend for.
|
|
|
|
|
#[cfg(unix)]
|
|
|
|
|
fn plant_symlinked_downloads() -> (PathBuf, PathBuf, PathBuf) {
|
|
|
|
|
let root = std::env::temp_dir()
|
|
|
|
|
.canonicalize()
|
|
|
|
|
.unwrap()
|
|
|
|
|
.join(format!("tc-h4-{}", uuid::Uuid::new_v4()));
|
|
|
|
|
let home = root.join("home");
|
|
|
|
|
let downloads = home.join("Downloads");
|
|
|
|
|
let ssh = home.join(".ssh");
|
|
|
|
|
std::fs::create_dir_all(&downloads).unwrap();
|
|
|
|
|
std::fs::create_dir_all(&ssh).unwrap();
|
|
|
|
|
let secret = ssh.join("authorized_keys");
|
|
|
|
|
std::fs::write(&secret, b"the key that was already there").unwrap();
|
|
|
|
|
std::os::unix::fs::symlink(&ssh, downloads.join("pub")).unwrap();
|
|
|
|
|
(root, downloads, secret)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[cfg(unix)]
|
|
|
|
|
#[tokio::test]
|
|
|
|
|
async fn a_symlinked_component_passes_the_lexical_check_and_is_still_refused() {
|
|
|
|
|
let (root, downloads, secret) = plant_symlinked_downloads();
|
|
|
|
|
let evil = downloads.join("pub").join("authorized_keys");
|
|
|
|
|
let evil = evil.to_string_lossy().to_string();
|
|
|
|
|
|
|
|
|
|
// The hole, stated: every rule the old code had says yes. No hidden
|
|
|
|
|
// component, no `..`, no system root — because those are properties of
|
|
|
|
|
// a string, and the string is not where the file goes.
|
|
|
|
|
assert!(validate_host_path(&evil, HostPathUse::Write).is_ok());
|
|
|
|
|
|
|
|
|
|
// Resolving first is what turns the string into a location.
|
|
|
|
|
let err = resolve_host_path(&evil, HostPathUse::Write).await.unwrap_err();
|
|
|
|
|
assert!(err.contains(".ssh"), "{}", err);
|
|
|
|
|
assert!(err.contains("resolves to"), "{}", err);
|
|
|
|
|
|
|
|
|
|
// Reading out through the same link is the same bypass backwards.
|
|
|
|
|
assert!(resolve_host_path(&evil, HostPathUse::Read).await.is_err());
|
|
|
|
|
assert_eq!(
|
|
|
|
|
std::fs::read(&secret).unwrap(),
|
|
|
|
|
b"the key that was already there"
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
let _ = std::fs::remove_dir_all(&root);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[cfg(unix)]
|
|
|
|
|
#[tokio::test]
|
|
|
|
|
async fn a_download_through_a_symlinked_component_writes_nothing_anywhere() {
|
|
|
|
|
// The whole pipeline the command runs, with the container half stubbed
|
|
|
|
|
// out: if the destination is refused, `fill` is never called, so there
|
|
|
|
|
// is no payload to land anywhere.
|
|
|
|
|
let (root, downloads, secret) = plant_symlinked_downloads();
|
|
|
|
|
let evil = downloads
|
|
|
|
|
.join("pub")
|
|
|
|
|
.join("authorized_keys")
|
|
|
|
|
.to_string_lossy()
|
|
|
|
|
.to_string();
|
|
|
|
|
|
|
|
|
|
let called = Arc::new(AtomicBool::new(false));
|
|
|
|
|
let saw = Arc::clone(&called);
|
|
|
|
|
let result = save_to_host(&evil, move |partial, created| async move {
|
|
|
|
|
saw.store(true, Ordering::SeqCst);
|
|
|
|
|
std::fs::write(&partial, b"container-controlled bytes").unwrap();
|
|
|
|
|
created.store(true, Ordering::SeqCst);
|
|
|
|
|
Ok(26)
|
|
|
|
|
})
|
|
|
|
|
.await;
|
|
|
|
|
|
|
|
|
|
assert!(result.is_err(), "the write was allowed through");
|
|
|
|
|
assert!(!called.load(Ordering::SeqCst), "the transfer started anyway");
|
|
|
|
|
assert_eq!(
|
|
|
|
|
std::fs::read(&secret).unwrap(),
|
|
|
|
|
b"the key that was already there"
|
|
|
|
|
);
|
|
|
|
|
// Nothing new in the protected directory either — no partial, no key.
|
|
|
|
|
let names: Vec<String> = std::fs::read_dir(secret.parent().unwrap())
|
|
|
|
|
.unwrap()
|
|
|
|
|
.map(|e| e.unwrap().file_name().to_string_lossy().to_string())
|
|
|
|
|
.collect();
|
|
|
|
|
assert_eq!(names, vec!["authorized_keys".to_string()]);
|
|
|
|
|
|
|
|
|
|
let _ = std::fs::remove_dir_all(&root);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[cfg(unix)]
|
|
|
|
|
#[tokio::test]
|
|
|
|
|
async fn a_download_to_an_ordinary_location_still_arrives() {
|
|
|
|
|
// The other half of the proof: the check has to refuse the escape
|
|
|
|
|
// without refusing the feature.
|
|
|
|
|
let (root, downloads, _secret) = plant_symlinked_downloads();
|
|
|
|
|
let good = downloads.join("report.txt").to_string_lossy().to_string();
|
|
|
|
|
|
|
|
|
|
let (dest, written) = save_to_host(&good, |partial, created| async move {
|
|
|
|
|
std::fs::write(&partial, b"a perfectly ordinary file").unwrap();
|
|
|
|
|
created.store(true, Ordering::SeqCst);
|
|
|
|
|
Ok(25)
|
|
|
|
|
})
|
|
|
|
|
.await
|
|
|
|
|
.unwrap();
|
|
|
|
|
|
|
|
|
|
assert_eq!(written, 25);
|
|
|
|
|
assert_eq!(dest, downloads.join("report.txt"));
|
|
|
|
|
assert_eq!(std::fs::read(&dest).unwrap(), b"a perfectly ordinary file");
|
|
|
|
|
// And the staging file is gone, not left beside it.
|
|
|
|
|
let names: Vec<String> = std::fs::read_dir(&downloads)
|
|
|
|
|
.unwrap()
|
|
|
|
|
.map(|e| e.unwrap().file_name().to_string_lossy().to_string())
|
|
|
|
|
.filter(|n| n.contains("triple-c-part"))
|
|
|
|
|
.collect();
|
|
|
|
|
assert!(names.is_empty(), "{:?}", names);
|
|
|
|
|
|
|
|
|
|
let _ = std::fs::remove_dir_all(&root);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[cfg(unix)]
|
|
|
|
|
#[tokio::test]
|
|
|
|
|
async fn a_symlinked_file_cannot_be_read_into_the_container_under_a_visible_name() {
|
|
|
|
|
// The upload direction, where the *final* component is the link:
|
|
|
|
|
// `Downloads/key.txt` is a perfectly visible name for `~/.ssh/id_rsa`.
|
|
|
|
|
let (root, downloads, secret) = plant_symlinked_downloads();
|
|
|
|
|
let alias = downloads.join("key.txt");
|
|
|
|
|
std::os::unix::fs::symlink(&secret, &alias).unwrap();
|
|
|
|
|
|
|
|
|
|
let err = resolve_host_read_path(&alias.to_string_lossy())
|
|
|
|
|
.await
|
|
|
|
|
.unwrap_err();
|
|
|
|
|
assert!(err.contains(".ssh"), "{}", err);
|
|
|
|
|
|
|
|
|
|
// An ordinary file next to it is still readable, and comes back as the
|
|
|
|
|
// path that will be opened.
|
|
|
|
|
let ordinary = downloads.join("notes.md");
|
|
|
|
|
std::fs::write(&ordinary, b"hello").unwrap();
|
|
|
|
|
assert_eq!(
|
|
|
|
|
resolve_host_read_path(&ordinary.to_string_lossy()).await.unwrap(),
|
|
|
|
|
ordinary.to_string_lossy()
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
let _ = std::fs::remove_dir_all(&root);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[cfg(target_os = "linux")]
|
|
|
|
|
#[test]
|
|
|
|
|
fn an_open_descriptor_is_checked_against_the_path_that_was_validated() {
|
|
|
|
|
// The other half of H4. Resolving answers "where does this lead *now*",
|
|
|
|
|
// and a directory can be swapped between that answer and the open — so
|
|
|
|
|
// the kernel is asked where the descriptor actually landed.
|
|
|
|
|
let dir = std::env::temp_dir()
|
|
|
|
|
.canonicalize()
|
|
|
|
|
.unwrap()
|
|
|
|
|
.join(format!("tc-fd-{}", uuid::Uuid::new_v4()));
|
|
|
|
|
std::fs::create_dir_all(&dir).unwrap();
|
|
|
|
|
let real = dir.join("report.pdf");
|
|
|
|
|
let elsewhere = dir.join("authorized_keys");
|
|
|
|
|
std::fs::write(&real, b"x").unwrap();
|
|
|
|
|
|
|
|
|
|
let file = std::fs::File::open(&real).unwrap();
|
|
|
|
|
assert!(verify_opened_path(&file, &real).is_ok());
|
|
|
|
|
let err = verify_opened_path(&file, &elsewhere).unwrap_err();
|
|
|
|
|
assert!(err.contains("while it was being opened"), "{}", err);
|
|
|
|
|
|
|
|
|
|
let _ = std::fs::remove_dir_all(&dir);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[tokio::test]
|
|
|
|
|
async fn a_failed_download_never_deletes_a_file_it_did_not_create() {
|
|
|
|
|
// The partial's name carries 32 bits of UUID, so colliding with an
|
|
|
|
|
// existing file is vanishingly unlikely — and "vanishingly unlikely" is
|
|
|
|
|
// not a reason to delete somebody's file. The cleanup runs only when
|
|
|
|
|
// the transfer actually created one.
|
|
|
|
|
let dir = std::env::temp_dir().join(format!("tc-part-{}", uuid::Uuid::new_v4()));
|
|
|
|
|
tokio::fs::create_dir_all(&dir).await.unwrap();
|
|
|
|
|
let dest = dir.join("report.pdf");
|
|
|
|
|
|
|
|
|
|
let err = save_to_host(&dest.to_string_lossy(), |partial, _created| async move {
|
|
|
|
|
// Stands in for the collision: something is already at the partial's
|
|
|
|
|
// name, so `create_new` fails and nothing here is ours.
|
|
|
|
|
std::fs::write(&partial, b"someone else's file").unwrap();
|
|
|
|
|
Err("Failed to create the partial file".to_string())
|
|
|
|
|
})
|
|
|
|
|
.await
|
|
|
|
|
.unwrap_err();
|
|
|
|
|
assert!(err.contains("Failed to create"), "{}", err);
|
|
|
|
|
|
|
|
|
|
let survivors: Vec<String> = std::fs::read_dir(&dir)
|
|
|
|
|
.unwrap()
|
|
|
|
|
.map(|e| e.unwrap().file_name().to_string_lossy().to_string())
|
|
|
|
|
.collect();
|
|
|
|
|
assert_eq!(survivors.len(), 1, "{:?}", survivors);
|
|
|
|
|
assert!(survivors[0].contains("triple-c-part"), "{:?}", survivors);
|
|
|
|
|
|
|
|
|
|
let _ = tokio::fs::remove_dir_all(&dir).await;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[tokio::test]
|
|
|
|
|
async fn a_download_into_a_directory_that_does_not_exist_says_so() {
|
|
|
|
|
// Resolution needs the parent to exist, which it always does behind a
|
|
|
|
|
// save dialog — but the refusal has to be a sentence, not an errno on
|
|
|
|
|
// its own.
|
|
|
|
|
let missing = std::env::temp_dir()
|
|
|
|
|
.join(format!("tc-missing-{}", uuid::Uuid::new_v4()))
|
|
|
|
|
.join("report.pdf");
|
|
|
|
|
let err = resolve_host_path(&missing.to_string_lossy(), HostPathUse::Write)
|
|
|
|
|
.await
|
|
|
|
|
.unwrap_err();
|
|
|
|
|
assert!(err.starts_with("Cannot save into"), "{}", err);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// ── Uploads ─────────────────────────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn the_upload_reservation_is_one_exclusive_create_not_a_check_and_then_a_write() {
|
|
|
|
|
// What the old comment claimed: `no_overwrite_dir_non_dir` "closes the
|
|
|
|
|
// race" between the `test -e` probe and the extraction. It does not —
|
|
|
|
|
// Docker refuses only a directory replaced by a non-directory and the
|
|
|
|
|
// reverse, and file-over-file extraction proceeds, which is exactly the
|
|
|
|
|
// `.credentials.json` case the guard exists for. There was no test of
|
|
|
|
|
// any of it: the only occurrence of that name in the repository was the
|
|
|
|
|
// bollard field itself. This is that test, against the thing that
|
|
|
|
|
// actually closes the window.
|
|
|
|
|
let argv = upload_reservation_argv("/workspace/notes.txt");
|
|
|
|
|
assert_eq!(argv[0], "sh");
|
|
|
|
|
assert_eq!(argv[1], "-c");
|
|
|
|
|
// noclobber: `>` becomes an O_CREAT|O_EXCL open, so the check and the
|
|
|
|
|
// creation are one syscall.
|
|
|
|
|
assert!(argv[2].contains("set -C"), "{}", argv[2]);
|
|
|
|
|
assert!(argv[2].contains('>'), "{}", argv[2]);
|
|
|
|
|
// The path is an argument read back as `$0`, never part of the script.
|
|
|
|
|
assert_eq!(argv[3], "/workspace/notes.txt");
|
|
|
|
|
assert!(!argv[2].contains("/workspace"), "{}", argv[2]);
|
|
|
|
|
|
|
|
|
|
// So a path that would be an injection anywhere else changes nothing
|
|
|
|
|
// about what the shell is asked to run.
|
|
|
|
|
let hostile = upload_reservation_argv("/workspace/$(touch pwned)`id`; rm -rf ~");
|
|
|
|
|
assert_eq!(hostile[2], argv[2]);
|
|
|
|
|
assert_eq!(hostile[3], "/workspace/$(touch pwned)`id`; rm -rf ~");
|
|
|
|
|
assert_eq!(hostile.len(), 4);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn the_collision_refusal_matches_the_shape_the_frontend_parses() {
|
|
|
|
|
// `app/src/lib/uploadErrors.ts` matches the marker as a standalone
|
|
|
|
|
// upper-case token followed by `:` — so that an unrelated failure
|
|
|
|
|
// quoting a file called `FILE_EXISTS.txt` is not read as a collision
|
|
|
|
|
// and answered with an overwrite.
|
|
|
|
|
let err = upload_exists_error("/home/claude/.claude/.credentials.json");
|
|
|
|
|
assert!(err.starts_with("FILE_EXISTS:"), "{}", err);
|
|
|
|
|
assert_eq!(UPLOAD_EXISTS_MARKER, "FILE_EXISTS");
|
|
|
|
|
assert_eq!(
|
|
|
|
|
err,
|
|
|
|
|
"FILE_EXISTS: /home/claude/.claude/.credentials.json already exists"
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// ── Listings ────────────────────────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn a_directory_too_big_to_buffer_is_described_as_one() {
|
|
|
|
|
// What the panel used to show for a directory past ~100k entries:
|
|
|
|
|
// "Command output exceeded 8388608 bytes and was abandoned" — true
|
|
|
|
|
// about a buffer, no help about a folder.
|
|
|
|
|
let refusal = format!("{}: Command output exceeded 8388608 bytes", OUTPUT_LIMIT_MARKER);
|
|
|
|
|
let described = describe_listing_failure("/workspace/big", refusal);
|
|
|
|
|
assert!(described.contains("too many entries"), "{}", described);
|
|
|
|
|
assert!(described.contains("/workspace/big"), "{}", described);
|
|
|
|
|
// Everything else is passed through as it arrived.
|
|
|
|
|
let other = describe_listing_failure("/workspace", "Exec output error: eof".to_string());
|
|
|
|
|
assert_eq!(other, "Exec output error: eof");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// ── Live Docker ─────────────────────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
/// The whole of H4 against a real daemon: plant the symlink, ask for the
|
|
|
|
|
/// download, show it is refused, then show an ordinary download still
|
|
|
|
|
/// arrives byte for byte. Also drives the container-side write-root
|
|
|
|
|
/// resolution, which cannot be tested any other way.
|
|
|
|
|
///
|
|
|
|
|
/// Ignored because it needs Docker and pulls a container up; run it with
|
|
|
|
|
///
|
|
|
|
|
/// ```text
|
|
|
|
|
/// cargo test -- --ignored --nocapture symlink_escape
|
|
|
|
|
/// ```
|
|
|
|
|
#[cfg(unix)]
|
|
|
|
|
#[tokio::test]
|
|
|
|
|
#[ignore = "needs a Docker daemon; creates and removes a throwaway container"]
|
|
|
|
|
async fn the_symlink_escape_is_closed_against_a_live_container() {
|
|
|
|
|
fn docker_cli(args: &[&str]) -> String {
|
|
|
|
|
let out = std::process::Command::new("docker")
|
|
|
|
|
.args(args)
|
|
|
|
|
.output()
|
|
|
|
|
.expect("docker CLI");
|
|
|
|
|
assert!(
|
|
|
|
|
out.status.success(),
|
|
|
|
|
"docker {:?} failed: {}",
|
|
|
|
|
args,
|
|
|
|
|
String::from_utf8_lossy(&out.stderr)
|
|
|
|
|
);
|
|
|
|
|
String::from_utf8_lossy(&out.stdout).trim().to_string()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
let name = format!("tc-h4-live-{}", &uuid::Uuid::new_v4().simple().to_string()[..8]);
|
|
|
|
|
docker_cli(&["run", "-d", "--name", &name, "ubuntu:24.04", "sleep", "300"]);
|
|
|
|
|
docker_cli(&["exec", &name, "useradd", "-m", "claude"]);
|
|
|
|
|
docker_cli(&[
|
|
|
|
|
"exec",
|
|
|
|
|
&name,
|
|
|
|
|
"sh",
|
|
|
|
|
"-c",
|
|
|
|
|
"mkdir -p /workspace && printf 'the payload' > /workspace/report.txt && ln -s /etc /workspace/escape && chown -R claude /workspace",
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
let (root, downloads, secret) = plant_symlinked_downloads();
|
|
|
|
|
let evil = downloads
|
|
|
|
|
.join("pub")
|
|
|
|
|
.join("authorized_keys")
|
|
|
|
|
.to_string_lossy()
|
|
|
|
|
.to_string();
|
|
|
|
|
let good = downloads.join("report.txt").to_string_lossy().to_string();
|
|
|
|
|
|
|
|
|
|
let cid = name.clone();
|
|
|
|
|
let refused = save_to_host(&evil, move |partial, created| async move {
|
|
|
|
|
stream_container_file_to_host(&cid, "/workspace/report.txt", &partial, created).await
|
|
|
|
|
})
|
|
|
|
|
.await;
|
|
|
|
|
println!("refused: {:?}", refused);
|
|
|
|
|
assert!(refused.is_err());
|
|
|
|
|
assert_eq!(
|
|
|
|
|
std::fs::read(&secret).unwrap(),
|
|
|
|
|
b"the key that was already there"
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
let cid = name.clone();
|
|
|
|
|
let (dest, written) = save_to_host(&good, move |partial, created| async move {
|
|
|
|
|
stream_container_file_to_host(&cid, "/workspace/report.txt", &partial, created).await
|
|
|
|
|
})
|
|
|
|
|
.await
|
|
|
|
|
.expect("an ordinary download");
|
|
|
|
|
println!("saved {} bytes to {}", written, dest.display());
|
|
|
|
|
assert_eq!(std::fs::read(&dest).unwrap(), b"the payload");
|
|
|
|
|
|
|
|
|
|
// Container side: `/workspace/escape` is under a write root as a
|
|
|
|
|
// string and is `/etc` as a location.
|
|
|
|
|
let escaped = resolve_container_dir(&name, "Folder", "/workspace/escape").await;
|
|
|
|
|
println!("container escape: {:?}", escaped);
|
|
|
|
|
assert!(escaped.is_err(), "a symlink out of /workspace was accepted");
|
|
|
|
|
resolve_container_dir(&name, "Folder", "/workspace")
|
|
|
|
|
.await
|
|
|
|
|
.expect("/workspace itself");
|
|
|
|
|
|
|
|
|
|
let _ = std::fs::remove_dir_all(&root);
|
|
|
|
|
docker_cli(&["rm", "-f", &name]);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// The claim the old comment made, checked against a real daemon: Docker's
|
|
|
|
|
/// `noOverwriteDirNonDir` does **not** stop a file replacing a file, and the
|
|
|
|
|
/// reservation does.
|
|
|
|
|
///
|
|
|
|
|
/// Ignored for the same reason as the test above; run it with
|
|
|
|
|
///
|
|
|
|
|
/// ```text
|
|
|
|
|
/// cargo test -- --ignored --nocapture overwrites_a_file
|
|
|
|
|
/// ```
|
|
|
|
|
#[tokio::test]
|
|
|
|
|
#[ignore = "needs a Docker daemon; creates and removes a throwaway container"]
|
|
|
|
|
async fn docker_overwrites_a_file_with_a_file_and_the_reservation_is_what_refuses() {
|
|
|
|
|
fn docker_cli(args: &[&str]) -> String {
|
|
|
|
|
let out = std::process::Command::new("docker")
|
|
|
|
|
.args(args)
|
|
|
|
|
.output()
|
|
|
|
|
.expect("docker CLI");
|
|
|
|
|
assert!(
|
|
|
|
|
out.status.success(),
|
|
|
|
|
"docker {:?} failed: {}",
|
|
|
|
|
args,
|
|
|
|
|
String::from_utf8_lossy(&out.stderr)
|
|
|
|
|
);
|
|
|
|
|
String::from_utf8_lossy(&out.stdout).trim().to_string()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
let name = format!("tc-h5-live-{}", &uuid::Uuid::new_v4().simple().to_string()[..8]);
|
|
|
|
|
docker_cli(&["run", "-d", "--name", &name, "ubuntu:24.04", "sleep", "300"]);
|
|
|
|
|
docker_cli(&["exec", &name, "useradd", "-m", "claude"]);
|
|
|
|
|
docker_cli(&[
|
|
|
|
|
"exec",
|
|
|
|
|
&name,
|
|
|
|
|
"sh",
|
|
|
|
|
"-c",
|
|
|
|
|
"mkdir -p /workspace && printf 'the original' > /workspace/keep.txt && chown -R claude /workspace",
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
// 1. The flag the comment leaned on, exercised exactly as the upload
|
|
|
|
|
// command sets it.
|
|
|
|
|
let tar = build_single_file_tar("keep.txt", b"replaced", 0o644, 0, 0, now_epoch_secs()).unwrap();
|
|
|
|
|
get_docker()
|
|
|
|
|
.unwrap()
|
|
|
|
|
.upload_to_container(
|
|
|
|
|
&name,
|
|
|
|
|
Some(UploadToContainerOptions {
|
|
|
|
|
path: "/workspace".to_string(),
|
|
|
|
|
no_overwrite_dir_non_dir: "true".to_string(),
|
|
|
|
|
}),
|
|
|
|
|
tar.into(),
|
|
|
|
|
)
|
|
|
|
|
.await
|
|
|
|
|
.expect("docker accepted the upload");
|
|
|
|
|
let after = docker_cli(&["exec", &name, "cat", "/workspace/keep.txt"]);
|
|
|
|
|
println!("after a file-over-file upload with noOverwriteDirNonDir: {:?}", after);
|
|
|
|
|
assert_eq!(after, "replaced", "Docker refused it after all — check the comment");
|
|
|
|
|
|
|
|
|
|
// 2. What actually refuses: one exclusive create.
|
|
|
|
|
let taken = reserve_upload_destination(&name, "/workspace/keep.txt").await;
|
|
|
|
|
println!("reservation over an existing file: {:?}", taken);
|
|
|
|
|
let err = taken.unwrap_err();
|
|
|
|
|
assert!(err.starts_with("FILE_EXISTS:"), "{}", err);
|
|
|
|
|
assert!(err.contains("/workspace/keep.txt"), "{}", err);
|
|
|
|
|
// …and the file it refused to touch is untouched.
|
|
|
|
|
assert_eq!(docker_cli(&["exec", &name, "cat", "/workspace/keep.txt"]), "replaced");
|
|
|
|
|
|
|
|
|
|
// 3. A free name is claimed, once.
|
|
|
|
|
reserve_upload_destination(&name, "/workspace/fresh.txt")
|
|
|
|
|
.await
|
|
|
|
|
.expect("a free name");
|
|
|
|
|
assert_eq!(docker_cli(&["exec", &name, "stat", "-c", "%s", "/workspace/fresh.txt"]), "0");
|
|
|
|
|
let again = reserve_upload_destination(&name, "/workspace/fresh.txt").await;
|
|
|
|
|
println!("reservation of the same name again: {:?}", again);
|
|
|
|
|
assert!(again.unwrap_err().starts_with("FILE_EXISTS:"));
|
|
|
|
|
|
|
|
|
|
// 4. A destination the container user cannot create is not reported as
|
|
|
|
|
// a collision — the frontend would offer a Replace that cannot work.
|
|
|
|
|
let denied = reserve_upload_destination(&name, "/root/nope.txt").await;
|
|
|
|
|
println!("reservation somewhere unwritable: {:?}", denied);
|
|
|
|
|
let err = denied.unwrap_err();
|
|
|
|
|
assert!(!err.starts_with("FILE_EXISTS:"), "{}", err);
|
|
|
|
|
|
|
|
|
|
docker_cli(&["rm", "-f", &name]);
|
|
|
|
|
}
|
2026-08-23 08:30:48 -07:00
|
|
|
}
|