Triple-C/app/src-tauri/src/commands/project_commands.rs

use tauri::{Emitter, State};

use crate::commands::aws_commands;
use crate::docker;
use crate::models::{container_config, AppSettings, Backend, BedrockAuthMethod, Project, ProjectPath, ProjectStatus};
use crate::storage::secure;
use crate::AppState;

pub(crate) fn emit_progress(app_handle: &tauri::AppHandle, project_id: &str, message: &str) {
    let _ = app_handle.emit(
        "container-progress",
        serde_json::json!({
            "project_id": project_id,
            "message": message,
        }),
    );
}

/// Every project secret, as the JSON pointer it arrives under and the keychain
/// key it is stored as.
///
/// The keychain keys are the ones already in users' keychains — changing one
/// orphans the secret rather than migrating it.
const PROJECT_SECRET_FIELDS: &[(&str, &str)] = &[
    ("/git_token", "git-token"),
    ("/bedrock_config/aws_access_key_id", "aws-access-key-id"),
    ("/bedrock_config/aws_secret_access_key", "aws-secret-access-key"),
    ("/bedrock_config/aws_session_token", "aws-session-token"),
    ("/bedrock_config/aws_bearer_token", "aws-bearer-token"),
    ("/openai_compatible_config/api_key", "openai-compatible-api-key"),
];

/// The keychain keys the caller sent an explicit `null` for.
///
/// **Absent and `null` are different things here, and treating them alike
/// destroys credentials.** Every secret field is `#[serde(skip_serializing)]`,
/// so the `Project` the frontend holds has no `git_token` key at all — a save
/// from the Workspace, Runtime or Model section spreads that object and sends
/// the field *absent*, while the editor that owns the field sends
/// `git_token: null` when the user blanks it (`AccessSection.tsx`:
/// `save({ git_token: gitToken || null })`). Serde maps both to `None`, which
/// is why this reads the payload rather than the deserialised struct: absent
/// means "not mine to touch", `null` means "the user emptied it".
fn explicitly_cleared_secrets(payload: &serde_json::Value) -> Vec<&'static str> {
    PROJECT_SECRET_FIELDS
        .iter()
        .filter(|(pointer, _)| matches!(payload.pointer(pointer), Some(serde_json::Value::Null)))
        .map(|(_, key)| *key)
        .collect()
}

/// Store one secret, clear it, or leave it alone — see
/// [`explicitly_cleared_secrets`] for which is which.
fn save_secret(
    project_id: &str,
    key_name: &str,
    value: Option<&str>,
    explicitly_cleared: &[&str],
) -> Result<(), String> {
    if value.is_none() && !explicitly_cleared.contains(&key_name) {
        return Ok(());
    }
    secure::store_or_clear_project_secret(project_id, key_name, value)
}

/// Extract secret fields from a project and store them in the OS keychain,
/// **deleting the ones the caller blanked**.
///
/// The `if let Some(v) = …` this replaces could only ever write: a blanked
/// token left the old value in the keychain, `load_secrets_for_project` read it
/// straight back onto the project, and the container went on getting the
/// credential the user had just revoked.
fn store_secrets_for_project(project: &Project, explicitly_cleared: &[&str]) -> Result<(), String> {
    save_secret(
        &project.id,
        "git-token",
        project.git_token.as_deref(),
        explicitly_cleared,
    )?;
    if let Some(ref bedrock) = project.bedrock_config {
        save_secret(
            &project.id,
            "aws-access-key-id",
            bedrock.aws_access_key_id.as_deref(),
            explicitly_cleared,
        )?;
        save_secret(
            &project.id,
            "aws-secret-access-key",
            bedrock.aws_secret_access_key.as_deref(),
            explicitly_cleared,
        )?;
        save_secret(
            &project.id,
            "aws-session-token",
            bedrock.aws_session_token.as_deref(),
            explicitly_cleared,
        )?;
        save_secret(
            &project.id,
            "aws-bearer-token",
            bedrock.aws_bearer_token.as_deref(),
            explicitly_cleared,
        )?;
    }
    if let Some(ref oai_config) = project.openai_compatible_config {
        save_secret(
            &project.id,
            "openai-compatible-api-key",
            oai_config.api_key.as_deref(),
            explicitly_cleared,
        )?;
    }
    Ok(())
}

/// Create the project's container, threading every global setting through.
///
/// Exists so that the two ordinary create paths below and base-image migration
/// cannot drift apart — a container created by a migration must be
/// indistinguishable from one created by a normal start, or the next
/// `container_needs_recreation` would immediately throw it away.
///
/// `create_image` is what to create *from* (the snapshot or the base);
/// `base_image_name` is the configured base, which `create_container` needs in
/// order to tell those two apart when it stamps the lineage labels.
pub(crate) async fn create_container_for_project(
    project: &Project,
    settings: &AppSettings,
    docker_socket: &str,
    aws_config_path: Option<&str>,
    create_image: &str,
    base_image_name: &str,
    extras: docker::CreateExtras<'_>,
) -> Result<String, String> {
    docker::create_container(
        project,
        docker_socket,
        create_image,
        base_image_name,
        extras,
        aws_config_path,
        &settings.global_aws,
        &settings.global_ollama,
        &settings.global_llamacpp,
        &settings.global_openai_compatible,
        settings.global_claude_instructions.as_deref(),
        &settings.global_custom_env_vars,
        settings.timezone.as_deref(),
        settings.global_claude_code_settings.as_ref(),
        settings.default_ssh_key_path.as_deref(),
        settings.ca_cert_path.as_deref(),
        settings.default_git_user_name.as_deref(),
        settings.default_git_user_email.as_deref(),
    )
    .await
}

/// Populate secret fields on a project struct from the OS keychain.
pub(crate) fn load_secrets_for_project(project: &mut Project) {
    project.git_token = secure::get_project_secret(&project.id, "git-token")
        .unwrap_or(None);
    if let Some(ref mut bedrock) = project.bedrock_config {
        bedrock.aws_access_key_id = secure::get_project_secret(&project.id, "aws-access-key-id")
            .unwrap_or(None);
        bedrock.aws_secret_access_key = secure::get_project_secret(&project.id, "aws-secret-access-key")
            .unwrap_or(None);
        bedrock.aws_session_token = secure::get_project_secret(&project.id, "aws-session-token")
            .unwrap_or(None);
        bedrock.aws_bearer_token = secure::get_project_secret(&project.id, "aws-bearer-token")
            .unwrap_or(None);
    }
    if let Some(ref mut oai_config) = project.openai_compatible_config {
        oai_config.api_key = secure::get_project_secret(&project.id, "openai-compatible-api-key")
            .unwrap_or(None);
    }
}

/// Validate the folder list a project is about to be stored with.
///
/// ## Why this is not cosmetic
///
/// `mount_name` is interpolated straight into a container mount target —
/// `docker::create_container` builds `/workspace/{mount_name}` — and the daemon
/// **normalises** what it is given. Confirmed against Engine 29.7 through the
/// same API bollard uses: a mount named `../tmp/claude-x` is created with a
/// destination of `/tmp/claude-x`, i.e. the host directory is mounted straight
/// on top of one of the paths the pre-commit scrub owns. The next recreate then
/// runs the scrub, as root, over the user's own project directory. That is the
/// C1 data-loss chain end to end, and the character check is the half of it
/// that stops the path ever being spelled.
///
/// `..` on its own passes a check for "alphanumeric, dash, underscore or dot",
/// which is why it is called out separately: it is the only single component
/// that walks *up*, and `/workspace/..` is `/`.
///
/// `host_path` is the other side of the same mount. `/` there bind-mounts the
/// entire host filesystem read-write into a container whose agent has
/// passwordless sudo. Anything short of a filesystem root is the user choosing
/// a folder — the Browse button and the free-text field lead to the same place
/// — so only the roots themselves are refused.
fn validate_project_paths(paths: &[ProjectPath]) -> Result<(), String> {
    let mut seen_names = std::collections::HashSet::new();
    for p in paths {
        // The Config tab's "+ Add folder" inserts an empty row and saves the
        // whole list on the next blur, so a wholly blank entry is the UI's
        // placeholder rather than an attempt at anything. It is stored as it
        // always was; a half-filled one is refused.
        if p.host_path.is_empty() && p.mount_name.is_empty() {
            continue;
        }
        if p.mount_name.is_empty() {
            return Err("Mount name cannot be empty.".to_string());
        }
        if !p.mount_name.chars().all(|c| c.is_alphanumeric() || c == '-' || c == '_' || c == '.') {
            return Err(format!("Mount name '{}' contains invalid characters. Use alphanumeric, dash, underscore, or dot.", p.mount_name));
        }
        if p.mount_name.chars().all(|c| c == '.') {
            return Err(format!(
                "Mount name '{}' is not a folder name — it names the directory the mount would sit in.",
                p.mount_name
            ));
        }
        if p.host_path.is_empty() {
            return Err(format!(
                "Folder mounted at '/workspace/{}' has no host path.",
                p.mount_name
            ));
        }
        if is_filesystem_root(&p.host_path) {
            return Err(format!(
                "'{}' is a filesystem root. Choose the project folder itself — mounting the whole drive gives the container everything on it.",
                p.host_path
            ));
        }
        if !seen_names.insert(p.mount_name.clone()) {
            return Err(format!("Duplicate mount name '{}'.", p.mount_name));
        }
    }
    Ok(())
}

/// Whether a host path is the root of a filesystem, in any spelling the three
/// desktop platforms produce: `/`, a Windows drive root, or a bare UNC/share
/// prefix. Trailing separators are ignored, so `C:\\` and `C:/` are the same
/// answer.
fn is_filesystem_root(host_path: &str) -> bool {
    let trimmed = host_path.trim_end_matches(['/', '\\']);
    if trimmed.is_empty() {
        // Nothing but separators: `/`, `\\`, `//`.
        return true;
    }
    // `C:` — a drive with no path on it.
    let bytes = trimmed.as_bytes();
    bytes.len() == 2 && bytes[0].is_ascii_alphabetic() && bytes[1] == b':'
}

#[tauri::command]
pub async fn list_projects(state: State<'_, AppState>) -> Result<Vec<Project>, String> {
    Ok(state.projects_store.list())
}

#[tauri::command]
pub async fn add_project(
    name: String,
    paths: Vec<ProjectPath>,
    state: State<'_, AppState>,
) -> Result<Project, String> {
    // Validate paths
    // A new project needs a folder; the blank row `validate_project_paths`
    // tolerates is the Config tab's placeholder on an *existing* one.
    if paths.is_empty()
        || paths
            .iter()
            .all(|p| p.host_path.is_empty() && p.mount_name.is_empty())
    {
        return Err("At least one folder path is required.".to_string());
    }
    validate_project_paths(&paths)?;
    let project = Project::new(name, paths);
    // Nothing can have been blanked on a project that did not exist a line ago.
    store_secrets_for_project(&project, &[])?;
    state.projects_store.add(project)
}

#[tauri::command]
pub async fn remove_project(
    project_id: String,
    state: State<'_, AppState>,
) -> Result<(), String> {
    // **H-2: the only writer of these three categories that held nothing.**
    // This purges migration artifacts, removes `triple-c-snapshot-{id}` and
    // both named volumes — and a compaction resolves that same tag when its
    // build starts and commits back over it minutes later. Compact a project,
    // then remove it from the sidebar, and `restore_image_config` commits a
    // flat image back onto `triple-c-snapshot-{id}:latest` for a project that
    // no longer exists: not dangling, not a `:pre-migration-*` tag, and not
    // reachable by the per-project scan, so no reclaim path can ever see it
    // again. Taken for the whole removal, like every other writer.
    //
    // Refusing is safe for the UI: `useProjects.remove` only drops the sidebar
    // row *after* the command resolves, and `ProjectHome` turns the rejection
    // into a toast, so the row stays and the message names what is running.
    let _guard =
        crate::project_lock::try_acquire(&project_id, crate::project_lock::ProjectOp::Destroy)?;

    // Release any host loopback ports the auth bridge holds for this project
    // before the container (and the project record) go away.
    state.auth_bridge.stop(&project_id).await;

    // A migration record outliving its project leaks a state file, a staged
    // payload tar that can run to several GB, and a `:pre-migration-<ts>` tag
    // holding an entire snapshot image that nothing will ever reference again.
    crate::commands::migration_commands::purge_migration_artifacts(&project_id).await;

    // Stop and remove container if it exists
    if let Some(ref project) = state.projects_store.get(&project_id) {
        if let Some(ref container_id) = project.container_id {
            state.exec_manager.close_sessions_for_container(container_id).await;
            let _ = docker::stop_container(container_id).await;
            let _ = docker::remove_container(container_id).await;
        }

        // Legacy MCP cleanup (pre-MCP-removal installs): drop any leftover MCP
        // containers first, then the per-project network they were attached to.
        docker::remove_legacy_mcp_containers(&project.id).await;
        docker::remove_legacy_project_network(&project.id).await;

        // Clean up the snapshot image + volumes
        if let Err(e) = docker::remove_snapshot_image(project).await {
            log::warn!("Failed to remove snapshot image for project {}: {}", project_id, e);
        }
        if let Err(e) = docker::remove_project_volumes(project).await {
            log::warn!("Failed to remove project volumes for project {}: {}", project_id, e);
        }
    }

    // Clean up keychain secrets for this project
    if let Err(e) = secure::delete_project_secrets(&project_id) {
        log::warn!("Failed to delete keychain secrets for project {}: {}", project_id, e);
    }

    state.projects_store.remove(&project_id)
}

#[tauri::command]
pub async fn update_project(
    project: serde_json::Value,
    app_handle: tauri::AppHandle,
    state: State<'_, AppState>,
) -> Result<Project, String> {
    // Taken as raw JSON, then deserialised, for one reason: a secret field that
    // arrived as `null` is a credential the user cleared, and a secret field
    // that did not arrive at all belongs to whichever editor is not saving
    // right now. `Option<String>` cannot tell those apart — see
    // [`explicitly_cleared_secrets`].
    let explicitly_cleared = explicitly_cleared_secrets(&project);
    let mut project: Project = serde_json::from_value(project)
        .map_err(|e| format!("Could not read the project being saved: {}", e))?;

    // **This takes a whole `Project` over IPC and used to store it verbatim.**
    // `add_project` validated its folder list and this did not, so every check
    // there was one edit away from being bypassed — and the Config tab's mount
    // name is a free-text field on an existing project, saved on blur, calling
    // exactly this command. See [`validate_project_paths`] for what a mount
    // name of `../tmp/claude-x` does to the user's files.
    validate_project_paths(&project.paths)?;

    // Fields this command does not get to write, whoever is calling it.
    //
    // `container_id` is the one that matters: it is the handle the whole file
    // command surface resolves against, `list_sibling_containers` hands the
    // webview the ids of every other container on the daemon, and a project
    // save is not the place a container is adopted. It is assigned by
    // `start_project_container` through `projects_store::set_container_id` and
    // read back here. `status` has its own setter (`update_status`) for the
    // same reason, and neither `id` nor `created_at` is a thing a save can
    // mean to change.
    //
    // The privileged *toggles* — `allow_docker_access`, `vpn_support_enabled`,
    // `sandbox_mode_enabled`, `permission_mode` — are deliberately not in this
    // list: they are what the Config tab's own switches write, through this
    // command, and there is nothing here that can tell that call apart from
    // any other. Their boundary is the webview, not this function.
    let stored = state
        .projects_store
        .get(&project.id)
        .ok_or_else(|| format!("Project {} not found", project.id))?;
    project.container_id = stored.container_id;
    project.status = stored.status;
    project.created_at = stored.created_at;
    project.updated_at = chrono::Utc::now().to_rfc3339();

    store_secrets_for_project(&project, &explicitly_cleared)?;
    let updated = state.projects_store.update(project)?;

    // `auth_bridge_enabled` can arrive through this generic save as well as
    // through `set_auth_bridge_enabled`, so reconcile the running bridge with
    // whatever was just persisted. `start` is idempotent and `stop` is a no-op
    // when nothing is running, so this is safe on every project save.
    if updated.auth_bridge_enabled {
        if let Some(ref container_id) = updated.container_id {
            if docker::is_container_running(container_id).await.unwrap_or(false) {
                state
                    .auth_bridge
                    .start(
                        updated.id.clone(),
                        container_id.clone(),
                        app_handle,
                        state.projects_store.clone(),
                    )
                    .await;
            }
        }
    } else {
        state.auth_bridge.stop(&updated.id).await;
    }

    Ok(updated)
}

#[tauri::command]
pub async fn start_project_container(
    project_id: String,
    app_handle: tauri::AppHandle,
    state: State<'_, AppState>,
) -> Result<Project, String> {
    // **Acquired, not polled.** A migration removes the container and creates
    // its replacement moments later. Starting in that window finds no
    // container, creates a second one under the same name, and the migration's
    // own create then fails on the name conflict — which sends it into an
    // auto-rollback that also cannot create. This used to be a one-shot
    // `is_migrating` read, which covered that case and no other: a start also
    // commits `triple-c-snapshot-{id}:latest`, so it races a *compaction*
    // committing the same tag with nothing between them. The claim is held for
    // the whole start rather than checked at its door.
    //
    // The UI already refuses (`canMigrate` gates on the container being stopped
    // and no run being in flight); this is the same gate on the side that
    // actually owns the invariant.
    let _guard =
        crate::project_lock::try_acquire(&project_id, crate::project_lock::ProjectOp::Recreate)?;
    start_project_container_locked(project_id, app_handle, state).await
}

/// The body of [`start_project_container`], with **no claim of its own**.
///
/// Split out for exactly one caller: [`rebuild_project_container`] already
/// holds the project under [`crate::project_lock::ProjectOp::Reset`] for its
/// whole run, and a Reset that then went through the public command would be
/// refused by its own guard. Every other path must go through the command.
async fn start_project_container_locked(
    project_id: String,
    app_handle: tauri::AppHandle,
    state: State<'_, AppState>,
) -> Result<Project, String> {
    let mut project = state
        .projects_store
        .get(&project_id)
        .ok_or_else(|| format!("Project {} not found", project_id))?;

    // Populate secret fields from the OS keychain so they are available
    // in memory when building environment variables for the container.
    load_secrets_for_project(&mut project);

    // Load settings for image resolution and global AWS
    let settings = state.settings_store.get();
    let image_name = container_config::resolve_image_name(&settings.image_source, &settings.custom_image_name);

    // Validate backend requirements
    if project.backend == Backend::Bedrock {
        let bedrock = project.bedrock_config.as_ref()
            .ok_or_else(|| "Bedrock backend selected but no Bedrock configuration found.".to_string())?;
        // Region can come from per-project or global
        if bedrock.aws_region.is_empty() && settings.global_aws.aws_region.is_none() {
            return Err("AWS region is required for Bedrock backend. Set it per-project or in global AWS settings.".to_string());
        }
    }

    if project.backend == Backend::Ollama {
        let ollama = project.ollama_config.as_ref()
            .ok_or_else(|| "Ollama backend selected but no Ollama configuration found.".to_string())?;
        if ollama.base_url.is_empty()
            && settings.global_ollama.base_url.as_deref().map(str::trim).unwrap_or("").is_empty()
        {
            return Err("Ollama base URL is required. Set it per-project or in global Ollama settings.".to_string());
        }
    }

    if project.backend == Backend::LlamaCpp {
        let cfg = project.llamacpp_config.as_ref()
            .ok_or_else(|| "llama.cpp backend selected but no llama.cpp configuration found.".to_string())?;
        if cfg.base_url.trim().is_empty()
            && settings.global_llamacpp.base_url.as_deref().map(str::trim).unwrap_or("").is_empty()
        {
            return Err("llama.cpp base URL is required. Set it per-project or in global llama.cpp settings.".to_string());
        }
    }

    if project.backend == Backend::OpenAiCompatible {
        let oai_config = project.openai_compatible_config.as_ref()
            .ok_or_else(|| "OpenAI Compatible backend selected but no configuration found.".to_string())?;
        if oai_config.base_url.is_empty()
            && settings.global_openai_compatible.base_url.as_deref().map(str::trim).unwrap_or("").is_empty()
        {
            return Err("OpenAI Compatible base URL is required. Set it per-project or in global settings.".to_string());
        }
    }

    // Update status to starting
    state.projects_store.update_status(&project_id, ProjectStatus::Starting)?;

    // Pre-validate AWS SSO session on the host for Bedrock Profile projects.
    // If the session is expired, trigger `aws sso login` before starting the container
    // so the entrypoint copies already-fresh credentials from the host mount.
    if project.backend == Backend::Bedrock {
        if let Some(ref bedrock) = project.bedrock_config {
            if bedrock.auth_method == BedrockAuthMethod::Profile {
                let profile = aws_commands::resolve_profile_for_project(
                    &project,
                    settings.global_aws.aws_profile.as_deref(),
                );

                emit_progress(&app_handle, &project_id, "Validating AWS session...");

                let session_valid = tokio::time::timeout(
                    std::time::Duration::from_secs(10),
                    aws_commands::check_sso_session(&profile),
                )
                .await;

                match session_valid {
                    Ok(Ok(true)) => {
                        emit_progress(&app_handle, &project_id, "AWS session valid.");
                    }
                    Ok(Ok(false)) => {
                        // Session expired — check if this is an SSO profile
                        if aws_commands::is_sso_profile(&profile).await.unwrap_or(false) {
                            emit_progress(
                                &app_handle,
                                &project_id,
                                "AWS session expired. Starting SSO login (check your browser)...",
                            );
                            match aws_commands::run_sso_login(&profile).await {
                                Ok(()) => {
                                    emit_progress(
                                        &app_handle,
                                        &project_id,
                                        "SSO login successful.",
                                    );
                                }
                                Err(e) => {
                                    log::warn!(
                                        "SSO login failed for profile '{}': {} — continuing anyway",
                                        profile,
                                        e
                                    );
                                    emit_progress(
                                        &app_handle,
                                        &project_id,
                                        "SSO login failed or cancelled. Continuing...",
                                    );
                                }
                            }
                        } else {
                            log::warn!(
                                "AWS session invalid for profile '{}' (not SSO). Continuing...",
                                profile
                            );
                        }
                    }
                    Ok(Err(e)) => {
                        log::warn!("Failed to check AWS session: {} — continuing anyway", e);
                    }
                    Err(_) => {
                        log::warn!("AWS session check timed out — continuing anyway");
                    }
                }
            }
        }
    }

    // Wrap container operations so that any failure resets status to Stopped.
    let result: Result<String, String> = async {
        // Ensure image exists
        emit_progress(&app_handle, &project_id, "Checking image...");
        if !docker::image_exists(&image_name).await? {
            return Err(format!("Docker image '{}' not found. Please pull or build the image first.", image_name));
        }

        // Determine docker socket path
        let docker_socket = settings.docker_socket_path
            .as_deref()
            .map(|s| s.to_string())
            .unwrap_or_else(|| default_docker_socket());

        // AWS config path from global settings
        let aws_config_path = settings.global_aws.aws_config_path.clone();

        // What we would create this container from *right now*: the project's
        // snapshot when one exists, else the configured base. This is the value
        // `container_needs_recreation` compares against the container's
        // `triple-c.create-image` label — the check that replaced the old
        // tautological one. It is resolved *before* the commit below, so it
        // describes the pre-commit world the existing container was born into.
        let snapshot_image = docker::get_snapshot_image_name(&project);
        let expected_create_image =
            if docker::image_exists(&snapshot_image).await.unwrap_or(false) {
                snapshot_image.clone()
            } else {
                image_name.clone()
            };

        let container_id = if let Some(existing_id) = docker::find_existing_container(&project).await? {
            // Check if config changed — if so, snapshot + recreate
            let needs_recreate = docker::container_needs_recreation(
                &existing_id,
                &project,
                &expected_create_image,
                &settings.global_aws,
                &settings.global_ollama,
                &settings.global_llamacpp,
                &settings.global_openai_compatible,
                settings.global_claude_instructions.as_deref(),
                &settings.global_custom_env_vars,
                settings.timezone.as_deref(),
                settings.global_claude_code_settings.as_ref(),
                settings.default_ssh_key_path.as_deref(),
                settings.ca_cert_path.as_deref(),
                settings.default_git_user_name.as_deref(),
                settings.default_git_user_email.as_deref(),
            ).await.unwrap_or(false);

            if needs_recreate {
                log::info!("Container config changed for project {} — committing snapshot and recreating", project.id);
                // Snapshot the filesystem before destroying
                emit_progress(&app_handle, &project_id, "Saving container state...");
                if let Err(e) = docker::commit_container_snapshot(&existing_id, &project).await {
                    log::warn!("Failed to snapshot container before recreation: {}", e);
                }
                emit_progress(&app_handle, &project_id, "Recreating container...");
                let _ = docker::stop_container(&existing_id).await;
                docker::remove_container(&existing_id).await?;

                // Legacy MCP cleanup: the old container may have been attached to
                // `triple-c-net-<projectId>`. Tear down leftover MCP containers and
                // that network now, before the replacement is created without it.
                docker::remove_legacy_mcp_containers(&project.id).await;
                docker::remove_legacy_project_network(&project.id).await;

                // Create from snapshot image (preserves system-level changes).
                // Re-resolved after the commit above: when no snapshot existed
                // before, one does now, and creating from the base instead
                // would throw away the state that was just saved.
                let create_image = if docker::image_exists(&snapshot_image).await.unwrap_or(false) {
                    snapshot_image.clone()
                } else {
                    image_name.clone()
                };

                let new_id = create_container_for_project(
                    &project,
                    &settings,
                    &docker_socket,
                    aws_config_path.as_deref(),
                    &create_image,
                    &image_name,
                    docker::CreateExtras::default(),
                ).await?;
                emit_progress(&app_handle, &project_id, "Starting container...");
                docker::start_container(&new_id).await?;

                // The commit above moved `:latest` and orphaned the image it
                // used to point at; the container holding that image open was
                // removed a few lines up, so now is when Docker will actually
                // let it go. Detached because this is housekeeping and the
                // project is already running — and it sweeps every orphan, not
                // just this one, so recreations that happened before the sweep
                // existed are cleaned up too.
                tauri::async_runtime::spawn(async {
                    docker::sweep_orphaned_snapshots_logged("after recreation").await;
                });

                new_id
            } else {
                emit_progress(&app_handle, &project_id, "Starting container...");
                docker::start_container(&existing_id).await?;
                existing_id
            }
        } else {
            // Container doesn't exist (first start, or Docker pruned it).
            // Check for a snapshot image first — it preserves system-level
            // changes (apt/pip/npm installs) from the previous session.
            if expected_create_image == snapshot_image {
                log::info!("Creating container from snapshot image for project {}", project.id);
            }
            let create_image = expected_create_image.clone();

            emit_progress(&app_handle, &project_id, "Creating container...");
            let new_id = create_container_for_project(
                &project,
                &settings,
                &docker_socket,
                aws_config_path.as_deref(),
                &create_image,
                &image_name,
                docker::CreateExtras::default(),
            ).await?;
            emit_progress(&app_handle, &project_id, "Starting container...");
            docker::start_container(&new_id).await?;
            new_id
        };

        // Sync Bedrock credentials on every start: refresh static/session creds
        // so rotated keys are picked up without a full container recreation, and
        // clear stale creds when the project no longer uses static-cred Bedrock.
        if let Err(e) = docker::sync_bedrock_credentials(&container_id, &project).await {
            log::warn!("Failed to sync AWS credentials for project {}: {}", project.id, e);
        }

        Ok(container_id)
    }.await;

    // On failure, reset status to Stopped so the project doesn't get stuck.
    if let Err(ref e) = result {
        log::error!("Failed to start container for project {}: {}", project_id, e);
        let _ = state.projects_store.update_status(&project_id, ProjectStatus::Stopped);
    }

    let container_id = result?;

    // Update project with container info using granular methods (Issue 14: TOCTOU)
    state.projects_store.set_container_id(&project_id, Some(container_id.clone()))?;
    state.projects_store.update_status(&project_id, ProjectStatus::Running)?;

    // Arm the auth bridge if this project opted in. Purely host-side, so it
    // happens after the container is up and never affects the start itself.
    if project.auth_bridge_enabled {
        state
            .auth_bridge
            .start(
                project_id.clone(),
                container_id.clone(),
                app_handle.clone(),
                state.projects_store.clone(),
            )
            .await;
    }

    project.container_id = Some(container_id);
    project.status = ProjectStatus::Running;
    Ok(project)
}

#[tauri::command]
pub async fn stop_project_container(
    project_id: String,
    app_handle: tauri::AppHandle,
    state: State<'_, AppState>,
) -> Result<(), String> {
    // Stop had **no** exclusion at all, which is the one gap CLAUDE.md's "every
    // command that stops, removes or recreates the container consults
    // `is_migrating`" rule already named and this function did not honour. A
    // stop lands on the container a migration is mid-swap on, and it closes the
    // exec sessions a compaction's config replay is not expecting to lose.
    let _guard =
        crate::project_lock::try_acquire(&project_id, crate::project_lock::ProjectOp::Recreate)?;

    let project = state
        .projects_store
        .get(&project_id)
        .ok_or_else(|| format!("Project {} not found", project_id))?;

    state.projects_store.update_status(&project_id, ProjectStatus::Stopping)?;

    // Drop host listeners first: they only make sense while the container runs.
    state.auth_bridge.stop(&project_id).await;

    if let Some(ref container_id) = project.container_id {
        // Close exec sessions for this project
        emit_progress(&app_handle, &project_id, "Stopping container...");
        state.exec_manager.close_sessions_for_container(container_id).await;

        if let Err(e) = docker::stop_container(container_id).await {
            log::warn!("Docker stop failed for container {} (project {}): {} — resetting to Stopped anyway", container_id, project_id, e);
        }
    }

    state.projects_store.update_status(&project_id, ProjectStatus::Stopped)?;
    Ok(())
}

#[tauri::command]
pub async fn rebuild_project_container(
    project_id: String,
    app_handle: tauri::AppHandle,
    state: State<'_, AppState>,
) -> Result<Project, String> {
    // Reset deletes both volumes and the snapshot image. Doing that while a
    // migration is mid-flight pulls the ground out from under it and leaves an
    // orphan migration record pointing at images that no longer exist — and
    // doing it while a *compaction* is mid-flight is worse, because the
    // compaction then commits `flat(old)` back over the `:latest` this just
    // destroyed and resurrects the system layer the user asked to be rid of.
    // Held for the whole Reset, including the start at the end of it.
    let _guard =
        crate::project_lock::try_acquire(&project_id, crate::project_lock::ProjectOp::Reset)?;

    let project = state
        .projects_store
        .get(&project_id)
        .ok_or_else(|| format!("Project {} not found", project_id))?;

    // Reset supersedes any migration decision that was still pending: the
    // snapshot image and both volumes are about to go, so a surviving record
    // could only describe things that no longer exist — while its
    // `:pre-migration-<ts>` tag held a whole snapshot image (multiple GB) alive
    // with nothing left that could ever use it.
    crate::commands::migration_commands::purge_migration_artifacts(&project_id).await;

    // The bridge is bound to the container that is about to be destroyed;
    // `start_project_container` below re-arms it against the new one.
    state.auth_bridge.stop(&project_id).await;

    // Remove existing container
    if let Some(ref container_id) = project.container_id {
        state.exec_manager.close_sessions_for_container(container_id).await;
        let _ = docker::stop_container(container_id).await;
        docker::remove_container(container_id).await?;
        state.projects_store.set_container_id(&project_id, None)?;
    }

    // Remove snapshot image + volumes so Reset creates from the clean base image
    if let Err(e) = docker::remove_snapshot_image(&project).await {
        log::warn!("Failed to remove snapshot image for project {}: {}", project_id, e);
    }
    if let Err(e) = docker::remove_project_volumes(&project).await {
        log::warn!("Failed to remove project volumes for project {}: {}", project_id, e);
    }

    // Start fresh. The locked variant, because `_guard` above is this project's
    // claim and the public command would be refused by it.
    start_project_container_locked(project_id, app_handle, state).await
}

/// Reconcile project statuses against actual Docker container state.
/// Called by the frontend after Docker is confirmed available. Projects
/// marked as Running whose containers are no longer running get reset
/// to Stopped.
///
/// This is also where an interrupted **base-image migration** is picked up.
/// It runs at startup, which is exactly when a migration that died with the app
/// needs to be noticed — see
/// [`crate::commands::migration_commands::reconcile_migration`]. The migration
/// pass runs over *every* project, not just the Running ones, because a project
/// whose container was removed mid-migration reports Stopped.
#[tauri::command]
pub async fn reconcile_project_statuses(
    app_handle: tauri::AppHandle,
    state: State<'_, AppState>,
) -> Result<Vec<Project>, String> {
    let projects = state.projects_store.list();

    for project in &projects {
        crate::commands::migration_commands::reconcile_migration(project, &app_handle).await;
    }

    for project in &projects {
        // `Starting` and `Stopping` are in here as a backstop, not because
        // anything is expected to leave a project in one. They are transitional
        // states owned by an in-flight command, so a project still wearing one
        // is a project whose command died — a crash mid-start, or a migration
        // that bailed out between the stop and the swap. Skipping them, as this
        // loop used to, meant nothing in the app ever put such a project right:
        // it sat at "Stopping" with the Start button disabled, permanently.
        // Docker is the authority either way, so the check below is correct for
        // all four.
        if !matches!(
            project.status,
            ProjectStatus::Running
                | ProjectStatus::Error
                | ProjectStatus::Starting
                | ProjectStatus::Stopping
        ) {
            continue;
        }
        // ...but never for a project this process is actively working on. A
        // migration's container is legitimately absent between the
        // `remove_container` and the create that follows, and so is a Reset's,
        // and so is a start's before its create returns. Reconciling into any
        // of those windows writes `Stopped` over a project that is mid-run.
        // Broadened from `is_migrating` to the whole lock for exactly that
        // reason — the migration was never the only operation with a gap.
        if crate::project_lock::held(&project.id).is_some() {
            continue;
        }

        let is_running = if let Some(ref container_id) = project.container_id {
            docker::is_container_running(container_id).await.unwrap_or(false)
        } else {
            false
        };

        if is_running {
            log::info!(
                "Project '{}' ({}) container is still running — keeping Running status",
                project.name,
                project.id
            );
            // The app may have restarted while the container kept running; the
            // bridge lives in this process, so re-arm it here. `start` is
            // idempotent, so a bridge that is already polling is untouched.
            if project.auth_bridge_enabled {
                if let Some(ref container_id) = project.container_id {
                    state
                        .auth_bridge
                        .start(
                            project.id.clone(),
                            container_id.clone(),
                            app_handle.clone(),
                            state.projects_store.clone(),
                        )
                        .await;
                }
            }
        } else {
            log::info!(
                "Project '{}' ({}) container is not running — setting to Stopped",
                project.name,
                project.id
            );
            let _ = state.projects_store.update_status(&project.id, ProjectStatus::Stopped);
        }
    }

    Ok(state.projects_store.list())
}

fn default_docker_socket() -> String {
    if cfg!(target_os = "windows") {
        "//./pipe/docker_engine".to_string()
    } else {
        "/var/run/docker.sock".to_string()
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    fn path(host: &str, mount: &str) -> ProjectPath {
        ProjectPath {
            host_path: host.to_string(),
            mount_name: mount.to_string(),
        }
    }

    /// The mount name that reaches the scrub. `docker::create_container` builds
    /// `/workspace/{mount_name}`, and the daemon normalises `..` out of it —
    /// verified against Engine 29.7, where a mount created with a target of
    /// `/workspace/../tmp/claude-x` is reported by `inspect` as `/tmp/claude-x`.
    #[test]
    fn a_mount_name_cannot_walk_out_of_workspace() {
        for escape in ["..", "../tmp/claude-x", "../../etc", "/tmp/claude-x", "a/../.."] {
            assert!(
                validate_project_paths(&[path("/home/u/project", escape)]).is_err(),
                "mount name '{}' was accepted, which puts the host folder somewhere \
                 /workspace/{{name}} does not reach",
                escape
            );
        }
        // The dotted names that are *not* a traversal stay usable.
        for ok in ["my.project", ".hidden", "a.b-c_d", "workspace2"] {
            assert!(
                validate_project_paths(&[path("/home/u/project", ok)]).is_ok(),
                "mount name '{}' should be usable",
                ok
            );
        }
    }

    #[test]
    fn the_whole_host_filesystem_cannot_be_mounted() {
        // A read-write bind of `/` into a container whose agent has
        // passwordless sudo.
        for root in ["/", "//", "\\", "C:\\", "c:/", "D:"] {
            assert!(
                validate_project_paths(&[path(root, "everything")]).is_err(),
                "host path '{}' was accepted as a project folder",
                root
            );
        }
        assert!(validate_project_paths(&[path("/home/u/project", "project")]).is_ok());
        assert!(validate_project_paths(&[path("C:\\Users\\u\\project", "project")]).is_ok());
    }

    #[test]
    fn duplicate_and_half_filled_rows_are_refused_but_the_blank_row_is_not() {
        assert!(validate_project_paths(&[
            path("/home/u/a", "same"),
            path("/home/u/b", "same"),
        ])
        .is_err());
        assert!(validate_project_paths(&[path("/home/u/a", "")]).is_err());
        assert!(validate_project_paths(&[path("", "a")]).is_err());
        // "+ Add folder" inserts this and the next blur saves the whole list;
        // refusing it would turn an empty row into an error toast.
        assert!(validate_project_paths(&[path("/home/u/a", "a"), path("", "")]).is_ok());
    }

    /// The distinction the whole secret-clearing path rests on.
    ///
    /// Every secret field is `#[serde(skip_serializing)]`, so the project
    /// object the frontend holds has no `git_token` key — a save from the
    /// Workspace or Runtime section sends it *absent*, and clearing on absent
    /// would delete the token every time an unrelated setting was changed. The
    /// editor that owns the field sends an explicit `null`.
    #[test]
    fn a_blanked_secret_is_cleared_and_an_absent_one_is_left_alone() {
        let blanked = serde_json::json!({
            "id": "p1",
            "git_token": null,
            "bedrock_config": { "aws_bearer_token": null },
        });
        let cleared = explicitly_cleared_secrets(&blanked);
        assert!(cleared.contains(&"git-token"));
        assert!(cleared.contains(&"aws-bearer-token"));
        // Present in the same payload, absent from the clear list.
        assert!(!cleared.contains(&"aws-access-key-id"));

        // What a Workspace-section save looks like: no secret keys at all.
        let unrelated = serde_json::json!({ "id": "p1", "name": "renamed" });
        assert!(explicitly_cleared_secrets(&unrelated).is_empty());

        // And a value is neither.
        let written = serde_json::json!({ "id": "p1", "git_token": "ghp_xxx" });
        assert!(explicitly_cleared_secrets(&written).is_empty());
    }

    #[test]
    fn every_secret_field_can_be_cleared() {
        // A field the frontend can blank but this list does not name is a
        // credential that cannot be revoked through the UI, which is the bug
        // this exists to close. The keychain keys must match the ones
        // `load_secrets_for_project` reads back, or a save writes one name and
        // the container is handed another.
        for (pointer, key) in PROJECT_SECRET_FIELDS {
            let field = pointer.rsplit('/').next().unwrap();
            let payload = match pointer.matches('/').count() {
                1 => serde_json::json!({ field: null }),
                _ => {
                    let parent = pointer.trim_start_matches('/').split('/').next().unwrap();
                    serde_json::json!({ parent: { field: null } })
                }
            };
            assert!(
                explicitly_cleared_secrets(&payload).contains(key),
                "{} does not reach the keychain key {}",
                pointer,
                key
            );
        }
    }

    #[test]
    fn add_and_update_cannot_disagree_about_what_a_folder_list_may_contain() {
        // `update_project` used to validate nothing at all, so every rule in
        // `add_project` was one save-on-blur away from being bypassed. Both go
        // through the same function now; this fails if either grows its own
        // copy.
        let bad = [path("/home/u/project", "../tmp/claude-x")];
        assert!(validate_project_paths(&bad).is_err());
    }
}