Close the blockers from the fifth audit
Build App (Preview) / compute-version (pull_request) Successful in 3s
Build Container / build-container (pull_request) Successful in 10m5s
Build App (Preview) / create-release (pull_request) Successful in 1s
Build App (Preview) / build-macos (pull_request) Successful in 4m31s
Build App (Preview) / build-linux (pull_request) Successful in 5m21s
Build App (Preview) / build-windows (pull_request) Successful in 19m1s
Build App (Preview) / prune-previews (pull_request) Successful in 1s

Docs and disclosure. HOW-TO-USE.md's settings table still described the
pre-fix behaviour — and help_commands.rs fetches that file from GitHub
main at runtime, ahead of the embedded copy, so it would have reached
every user's Help dialog the moment this merged. The Config tab named
three settings that need a base-image update; there are four, and the
omitted one (Session recap) is the one that fails *without* the "won't
switch off" symptom the warning teaches. Both now also state the cost
nobody had written down: changing any of these recreates the container,
which commits a layer.

Two stale comments that told a reviewer the code was safe when it was
not. compute_claude_code_settings_fingerprint still claimed the
historical fingerprint is preserved so an upgrade cannot churn every
container — carried over from before the widening, false since the
format string changed. And capabilities/default.json, which is the
reviewed threat model of record, described a "Save to host…" action this
branch deletes.

Security and correctness. update_settings validated env vars and nothing
else, so the *global* default_ssh_key_path — the fallback for every
project without an override — took `/` and read-only bind-mounted the
host, which entrypoint.sh then copies into the home volume. classify_
mount_source ran canonicalize on the raw string, which resolves a
relative path against Triple-C's own cwd, so `.` and `..` were accepted
or refused depending on where the app was launched; the daemon then
refuses the mount and the project can never start. Its test passed only
because its examples did not exist under app/src-tauri.

bind_mount_exclusions still derived a path from every row while
project_path_mounts had learned to skip unmountable ones, so a legacy
row made /workspace/<name> ordinary container content that a migration
would then exclude from staging and destroy. The skip is also logged now
rather than silently dropping a folder.

The terminal's file-in path checked is_dir() but not file type, so a
dropped FIFO blocked forever with no timeout — and it is the only route
in now. The web terminal labelled sessions from a global set at request
time, so two quick opens swapped them; harmless until Shift+Enter became
type-dependent, at which point a mislabelled Claude session submitted a
half-written prompt. Opened now carries the type.

Every ~/.claude.json write goes through one atomic helper. The
awsAuthRefresh branches still truncated in place — the same corruption
the Shift+Enter block was fixed for twenty lines later, and its own
comment said so. Demonstrated: a failed write now leaves the original
byte-identical.

And the registration test I added yesterday could pass while the
property was false: an audit got five real unregistered commands past its
exact-string attribute match, and "exactly once" was in its name but not
its body. Mutation-checked against all six shapes.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GBq2rGum6GX7xXgsas1fDc
This commit is contained in:
2026-08-23 18:45:11 -07:00
co-authored by Claude Opus 5
parent 4d1a5a2417
commit 016de8f641
16 changed files with 339 additions and 77 deletions
+72 -10
View File
@@ -713,8 +713,22 @@ mod tests {
let mut defined: BTreeSet<String> = BTreeSet::new();
// Walk the source tree for `#[tauri::command]` and take the `fn` name
// on the following non-attribute line.
// Walk the source tree for the command attribute and take the `fn` name
// that follows.
//
// The first version of this matched `line.trim() == "#[tauri::command]"`
// exactly and broke on the first non-`#` line. An audit got five real,
// compiling, unregistered commands past it — `#[tauri::command(async)]`,
// `#[tauri::command(rename_all = "snake_case")]`, a trailing comment,
// spaces in the path, and a bare `#[command]` after `use tauri::command`
// — plus `pub(crate) fn` and a `///` line between attribute and `fn`.
// Every one of those is a command the frontend could not call, which is
// the bug this test exists for, and the test stayed green.
//
// The asymmetry matters: confusion on the *definition* side is a silent
// pass, while on the *registration* side it fails loudly against
// legitimate code — and rustc already covers that direction. So this
// errs toward over-matching definitions.
fn collect(dir: &std::path::Path, out: &mut BTreeSet<String>) {
let Ok(entries) = std::fs::read_dir(dir) else { return };
for entry in entries.flatten() {
@@ -725,20 +739,39 @@ mod tests {
let Ok(text) = std::fs::read_to_string(&path) else { continue };
let lines: Vec<&str> = text.lines().collect();
for (i, line) in lines.iter().enumerate() {
if line.trim() != "#[tauri::command]" {
let t = line.trim();
// `#[tauri::command]`, `#[tauri::command(async)]`,
// `#[tauri :: command]`, a bare `#[command]` under
// `use tauri::command`, and any of those with a
// trailing comment.
let attr = t.strip_prefix("#[").map(|a| {
a.split(']').next().unwrap_or("").replace(' ', "")
});
let is_command_attr = attr.is_some_and(|a| {
a == "command" || a == "tauri::command"
|| a.starts_with("command(")
|| a.starts_with("tauri::command(")
});
if !is_command_attr {
continue;
}
// Skip further attributes and doc comments rather than
// giving up at the first line that is not an attribute.
for next in lines.iter().skip(i + 1) {
let t = next.trim();
if t.starts_with('#') {
if t.starts_with('#') || t.starts_with("//") || t.is_empty() {
continue;
}
if let Some(rest) = t
.strip_prefix("pub async fn ")
.or_else(|| t.strip_prefix("pub fn "))
.or_else(|| t.strip_prefix("async fn "))
.or_else(|| t.strip_prefix("fn "))
{
// Any visibility, then `fn` or `async fn`.
let after_vis = t
.strip_prefix("pub(crate) ")
.or_else(|| t.strip_prefix("pub(super) "))
.or_else(|| t.strip_prefix("pub(in crate) "))
.or_else(|| t.strip_prefix("pub "))
.unwrap_or(t);
let after_async =
after_vis.strip_prefix("async ").unwrap_or(after_vis);
if let Some(rest) = after_async.strip_prefix("fn ") {
if let Some(name) = rest.split(['(', '<']).next() {
out.insert(name.trim().to_string());
}
@@ -799,6 +832,35 @@ mod tests {
"these are registered but no `#[tauri::command]` defines them: {:?}",
undefined
);
// "exactly once" was in this test's name and not in its body: both
// sides were sets, so registering the same command twice in a
// hand-maintained 118-line list compiled, warned about nothing, and
// passed here.
let mut seen: Vec<&str> = Vec::new();
let mut duplicated: Vec<&str> = Vec::new();
for line in handler
.lines()
.map(str::trim)
.filter(|l| !l.is_empty() && !l.starts_with("//"))
{
if let Some(name) = line.trim_end_matches(',').rsplit("::").next() {
let name = name.trim();
if name.is_empty() {
continue;
}
if seen.contains(&name) {
duplicated.push(name);
} else {
seen.push(name);
}
}
}
assert!(
duplicated.is_empty(),
"these are registered more than once: {:?}",
duplicated
);
}
#[test]