Build App (Preview) / compute-version (pull_request) Successful in 8s
Secret Scan / scan (push) Successful in 12s
Secret Scan / scan (pull_request) Successful in 9s
Build App (Preview) / create-release (pull_request) Successful in 1s
Build App (Preview) / test (pull_request) Successful in 4m18s
Build App (Preview) / build-macos (pull_request) Successful in 3m15s
Build App (Preview) / build-windows (pull_request) Successful in 6m51s
Build App (Preview) / build-linux (pull_request) Successful in 9m31s
Build App (Preview) / prune-previews (pull_request) Successful in 3s
Second-review follow-ups, replacing the label + probe approach: - Local builds are tagged `triple-c-gateway:<pin>` instead of `latest`, so a build for an older pin simply doesn't match. Drops the version label, the probe container, its cache and version normalisation — and with them the case where a failed probe made a current build look stale. - The pinned image is pulled before taking the gateway lock, so a long pull no longer blocks Stop, shutdown or settings saves; skipped when the start would fail on configuration anyway. - If no pinned image is available, the old container is removed and the error keeps the pull failure, reporting a removal failure alongside it. - Status gains `image_outdated` (container image id != pinned image id). Settings uses it for the label, keeps Stop for any running gateway, and always offers Start, since Start pulls the image. - Reuse `migration::image_id` and one container-removal helper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
129 lines
4.8 KiB
TypeScript
129 lines
4.8 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from "vitest";
|
|
import { render, screen, fireEvent, waitFor } from "@testing-library/react";
|
|
import GatewaySettings from "./GatewaySettings";
|
|
import type { AppSettings, GatewayStatus } from "../../lib/types";
|
|
|
|
const getGatewayStatus = vi.fn();
|
|
const stopGateway = vi.fn();
|
|
const startGateway = vi.fn();
|
|
const checkGatewayHealth = vi.fn();
|
|
const saveSettings = vi.fn();
|
|
|
|
vi.mock("../../lib/tauri-commands", () => ({
|
|
getGatewayStatus: () => getGatewayStatus(),
|
|
startGateway: () => startGateway(),
|
|
stopGateway: () => stopGateway(),
|
|
checkGatewayHealth: () => checkGatewayHealth(),
|
|
pullGatewayImage: vi.fn(),
|
|
buildGatewayImage: vi.fn(),
|
|
setGatewayApiKey: vi.fn(),
|
|
clearGatewayApiKey: vi.fn(),
|
|
getGatewayAuthToken: vi.fn(),
|
|
regenerateGatewayAuthToken: vi.fn(),
|
|
}));
|
|
|
|
vi.mock("@tauri-apps/api/event", () => ({ listen: vi.fn(async () => vi.fn()) }));
|
|
|
|
let appSettings: AppSettings | null = null;
|
|
vi.mock("../../hooks/useSettings", () => ({
|
|
useSettings: () => ({ appSettings, saveSettings }),
|
|
}));
|
|
|
|
const settingsWithGateway = (enabled: boolean): AppSettings =>
|
|
({
|
|
gateway: { enabled, port: 4000, provider: "openai", api_base: null, models: [] },
|
|
}) as unknown as AppSettings;
|
|
|
|
const status = (over: Partial<GatewayStatus> = {}): GatewayStatus => ({
|
|
container_exists: true,
|
|
running: true,
|
|
port: 4000,
|
|
image_exists: true,
|
|
image_outdated: false,
|
|
model_count: 0,
|
|
has_api_key: false,
|
|
base_url: "http://host.docker.internal:4000",
|
|
...over,
|
|
});
|
|
|
|
describe("GatewaySettings", () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
appSettings = settingsWithGateway(false);
|
|
getGatewayStatus.mockResolvedValue(status());
|
|
checkGatewayHealth.mockResolvedValue(true);
|
|
saveSettings.mockImplementation(async (s: AppSettings) => s);
|
|
stopGateway.mockResolvedValue(undefined);
|
|
});
|
|
|
|
it("keeps a working Stop button when the gateway is disabled but its container exists", async () => {
|
|
render(<GatewaySettings />);
|
|
|
|
const stop = await screen.findByRole("button", { name: "Stop" });
|
|
// The configuration UI stays hidden — only the container row survives.
|
|
expect(screen.queryByLabelText("Provider")).not.toBeInTheDocument();
|
|
expect(screen.getByTestId("gateway-leftover-container")).toHaveTextContent(
|
|
/gateway container is still present/i,
|
|
);
|
|
// Status is a word, not just a colour.
|
|
expect(screen.getByTestId("gateway-leftover-container")).toHaveTextContent(
|
|
/Running on port 4000/,
|
|
);
|
|
|
|
fireEvent.click(stop);
|
|
await waitFor(() => expect(stopGateway).toHaveBeenCalledTimes(1));
|
|
// Stopping re-reads status: once on mount, once after the action.
|
|
await waitFor(() => expect(getGatewayStatus).toHaveBeenCalledTimes(2));
|
|
});
|
|
|
|
it("shows nothing extra when the gateway is disabled and no container exists", async () => {
|
|
getGatewayStatus.mockResolvedValue(status({ container_exists: false, running: false }));
|
|
render(<GatewaySettings />);
|
|
|
|
await waitFor(() => expect(getGatewayStatus).toHaveBeenCalled());
|
|
expect(screen.queryByTestId("gateway-leftover-container")).not.toBeInTheDocument();
|
|
expect(screen.queryByRole("button", { name: "Stop" })).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("re-reads container status after toggling the gateway off", async () => {
|
|
appSettings = settingsWithGateway(true);
|
|
render(<GatewaySettings />);
|
|
|
|
await waitFor(() => expect(getGatewayStatus).toHaveBeenCalledTimes(1));
|
|
|
|
// The backend stops the container as part of update_settings, so the UI has
|
|
// to re-read rather than trust the status it already has.
|
|
getGatewayStatus.mockResolvedValue(status({ running: false }));
|
|
fireEvent.click(screen.getByRole("switch", { name: "Model gateway" }));
|
|
|
|
await waitFor(() =>
|
|
expect(saveSettings).toHaveBeenCalledWith(
|
|
expect.objectContaining({ gateway: expect.objectContaining({ enabled: false }) }),
|
|
),
|
|
);
|
|
await waitFor(() => expect(getGatewayStatus).toHaveBeenCalledTimes(2));
|
|
});
|
|
it("can stop a gateway running an outdated image, and says so", async () => {
|
|
appSettings = settingsWithGateway(true);
|
|
getGatewayStatus.mockResolvedValue(status({ image_outdated: true }));
|
|
render(<GatewaySettings />);
|
|
|
|
const stop = await screen.findByRole("button", { name: "Stop" });
|
|
expect(screen.getByText(/outdated LiteLLM/i)).toBeInTheDocument();
|
|
|
|
fireEvent.click(stop);
|
|
await waitFor(() => expect(stopGateway).toHaveBeenCalledTimes(1));
|
|
});
|
|
|
|
it("offers Start without an image, since Start pulls it", async () => {
|
|
appSettings = settingsWithGateway(true);
|
|
getGatewayStatus.mockResolvedValue(
|
|
status({ running: false, container_exists: false, image_exists: false }),
|
|
);
|
|
render(<GatewaySettings />);
|
|
|
|
expect(await screen.findByRole("button", { name: "Start" })).toBeInTheDocument();
|
|
expect(screen.getByText(/Start will pull it/i)).toBeInTheDocument();
|
|
});
|
|
});
|