Files
Triple-C/app/src/components/projects/home/config/WorkspaceSection.tsx
T
shadow-testandClaude Opus 5 6a8972980d Stop an untouched secret field from deleting the stored credential
Making `null` actually clear a secret — which it had to, since a blanked
token was previously never revoked — turned the config editors into a
credential shredder. Secrets are `#[serde(skip_serializing)]`, so the
inputs always render empty whether or not one is stored, and the blur
handlers sent `value || null` unconditionally. Focusing the Git token
field and tabbing away deleted it, with nothing shown and no undo.

`useSecretField` encodes the rule: only a field the user typed in may
speak about a secret. Untouched, `patch()` contributes no key at all, and
Rust already distinguishes an absent key from an explicit null.

`withoutUntouchedSecrets` covers the structural half. `saveBedrock`
spreads `{ ...bedrock, ...patch }`, and when that falls back to
DEFAULT_BEDROCK_CONFIG the literal spells every secret out as `null` — so
editing the AWS region would have wiped the credentials as a side effect.

Also here: `WorkspaceSection` no longer saves a half-filled folder row,
which `update_project`'s new validation would refuse on every keystroke
between the two inputs; `snapshots_skipped` is declared on the wire type
rather than widened locally; and `#[must_use]` on `ProjectGuard` and
`ScrubOutcome` — which immediately caught the migration path discarding
its scrub outcome, the one scrub whose silence is expensive because the
layer it declined to clean is about to be committed.

The capability test reads the real file and is mutation-verified: adding
`core:default` back makes it fail. That grant pulls in an unscoped
`std::fs::read` of any host path and went unnoticed for months, because
nothing in the suite read the file at all.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GBq2rGum6GX7xXgsas1fDc
2026-08-23 13:23:00 -07:00

162 lines
5.7 KiB
TypeScript

import { useEffect, useState } from "react";
import { open } from "@tauri-apps/plugin-dialog";
import type { Project, ProjectPath } from "../../../../lib/types";
import Button from "../../../ui/Button";
import Field, { ConfigGroup, inputClass, monoInputClass } from "../../../ui/Field";
interface Props {
project: Project;
save: (patch: Partial<Project>) => Promise<boolean>;
disabled: boolean;
}
export default function WorkspaceSection({ project, save, disabled }: Props) {
const [name, setName] = useState(project.name);
const [paths, setPaths] = useState<ProjectPath[]>(project.paths ?? []);
useEffect(() => {
setName(project.name);
setPaths(project.paths ?? []);
}, [project]);
/**
* Save only when every row is fully filled in.
*
* Both inputs save on blur, so tabbing from the host path to the mount name
* fires a save with the name still empty. `update_project` now validates —
* a half-filled row is refused — so the unconditional save turned an ordinary
* keystroke into an error toast. A blank row is *not* incomplete: the
* "+ Add folder" button adds one deliberately, and it is dropped on save.
*/
const saveIfComplete = () => {
const filled = paths.filter((p) => p.host_path.trim() || p.mount_name.trim());
const halfFilled = filled.some((p) => !p.host_path.trim() || !p.mount_name.trim());
if (halfFilled) return;
return save({ paths });
};
return (
<ConfigGroup
title="Workspace"
description="What this sandbox is called and which host folders it can see."
>
<Field
label="Project name"
hint="Shown in the sidebar and on terminal tabs."
>
{(id) => (
<input
id={id}
value={name}
onChange={(e) => setName(e.target.value)}
onBlur={() => {
const trimmed = name.trim();
if (!trimmed) {
setName(project.name);
return;
}
if (trimmed !== project.name) save({ name: trimmed });
}}
onKeyDown={(e) => {
if (e.key === "Enter") (e.target as HTMLInputElement).blur();
if (e.key === "Escape") setName(project.name);
}}
className={inputClass}
/>
)}
</Field>
<div>
<span className="block text-[13px] font-medium text-[var(--text-primary)]">
Folders
</span>
<p className="mt-0.5 mb-2 text-xs text-[var(--text-secondary)] leading-snug">
Each host folder is mounted at <span className="font-mono">/workspace/&lt;name&gt;</span>{" "}
inside the container.
</p>
<div className="space-y-3">
{paths.map((pp, i) => (
<div key={i} className="flex flex-col gap-1.5 sm:flex-row sm:items-center">
<input
value={pp.host_path}
aria-label={`Folder ${i + 1} host path`}
onChange={(e) => {
const updated = [...paths];
updated[i] = { ...updated[i], host_path: e.target.value };
setPaths(updated);
}}
onBlur={() => saveIfComplete()}
placeholder="/path/to/folder"
disabled={disabled}
className={`flex-1 min-w-0 ${inputClass}`}
/>
<div className="flex items-center gap-1.5">
<Button
size="md"
disabled={disabled}
onClick={async () => {
const selected = await open({ directory: true, multiple: false });
if (typeof selected === "string") {
const updated = [...paths];
const basename =
selected.replace(/[/\\]$/, "").split(/[/\\]/).pop() || "";
updated[i] = {
host_path: selected,
mount_name: updated[i].mount_name || basename,
};
setPaths(updated);
save({ paths: updated });
}
}}
>
Browse
</Button>
<span className="text-xs text-[var(--text-secondary)] font-mono flex-shrink-0">
/workspace/
</span>
<input
value={pp.mount_name}
aria-label={`Folder ${i + 1} mount name`}
onChange={(e) => {
const updated = [...paths];
updated[i] = { ...updated[i], mount_name: e.target.value };
setPaths(updated);
}}
onBlur={() => saveIfComplete()}
placeholder="name"
disabled={disabled}
className={`w-40 ${monoInputClass}`}
/>
{paths.length > 1 && (
<Button
size="md"
variant="danger"
disabled={disabled}
aria-label={`Remove folder ${i + 1}`}
onClick={() => {
const updated = paths.filter((_, j) => j !== i);
setPaths(updated);
save({ paths: updated });
}}
>
Remove
</Button>
)}
</div>
</div>
))}
</div>
<Button
className="mt-2"
disabled={disabled}
onClick={() => setPaths([...paths, { host_path: "", mount_name: "" }])}
>
+ Add folder
</Button>
</div>
</ConfigGroup>
);
}