Secret Scan / scan (push) Successful in 5s
Build App (Preview) / compute-version (pull_request) Successful in 3s
Secret Scan / scan (pull_request) Successful in 3s
Build App (Preview) / create-release (pull_request) Successful in 1s
Build App (Preview) / build-macos (pull_request) Successful in 2m44s
Build App (Preview) / build-windows (pull_request) Successful in 4m55s
Build App (Preview) / build-linux (pull_request) Successful in 5m29s
Build App (Preview) / prune-previews (pull_request) Successful in 1s
The dock was showing `NotesPanel`, which is a master/detail layout: a column of titles beside an editor. The previous commit made that survive dock width; it did not make it right. At 352px the layout still spends roughly 356px of height on chrome — dock header, panel header, title strip, a button row that wraps, and a paragraph of help — before the body gets a pixel. So the dock now shows one note. The title field names what is open and the chevron beside it switches; New and Delete move into the overflow menu; the help text goes. Chrome drops to about 112px and the body takes the rest. The two surfaces are now different components, which contradicts a docstring I wrote — "shared so the two cannot drift into different behaviour". That claim was about behaviour, and behaviour was never in the layout: it is in `useNotes` for the cache and its write ordering, and now in `useNoteDraft`, extracted here so when a keystroke becomes a save is defined in exactly one place. Only the layout diverges. `NotesPanel.shared.test.tsx` gets stronger for it — it now mounts the dock panel and the tab panel together, which is what the app actually does, instead of the same component twice. `NoteSwitcher` is not `OverflowMenu` despite the shape being close: that keys items by label, and notes are addressed by id, so two untitled notes — the ordinary case — would collapse into one row. It is also not a `combobox`; an input plus a listbox button is two honest controls, where the role would owe active-descendant tracking and filtering that nothing here needs. `SendToAgentButton` picks up `useUnavailable` from #49, which is what its `disabled` plus explanatory `title` was already asking for. Four tests moved from `toBeDisabled()` to the new contract, and one of them — "does nothing for an empty note" — turned out never to have asserted that it does nothing. It does now, for click and for Enter, which is the guard the swap needs. It also gains `dropUp`, and that is load-bearing rather than cosmetic: the dock clips its own overflow, so a session menu opening downward from a button on the bottom edge is drawn outside the panel and never seen. 744 tests pass, 62 files. As before, jsdom has no layout engine: that the dock now reads as compact is not something the suite can tell you. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011YPqHpjV4EL6RNEwrRKqQm
116 lines
4.2 KiB
TypeScript
116 lines
4.2 KiB
TypeScript
import { useMemo, useState } from "react";
|
|
import { useNotes } from "../../hooks/useNotes";
|
|
import { useNoteDraft } from "./useNoteDraft";
|
|
import NoteEditor from "./NoteEditor";
|
|
import Button from "../ui/Button";
|
|
import SaveIndicator from "../ui/SaveIndicator";
|
|
|
|
interface Props {
|
|
projectId: string;
|
|
}
|
|
|
|
const UNTITLED = "Untitled note";
|
|
|
|
/**
|
|
* The notes surface itself, shared by the Project Home tab and the dock so the
|
|
* two cannot drift into different behaviour.
|
|
*
|
|
* Master/detail: titles beside the editor when there is room, stacked above it
|
|
* when there is not. That is a **container** query, not a viewport one, because
|
|
* the two surfaces differ in width while sharing a viewport — the dock opens at
|
|
* 352px and the tab is the width of the main area. A `md:` breakpoint would
|
|
* read the window and give both the same answer, which is the wrong answer for
|
|
* one of them.
|
|
*
|
|
* The threshold is arithmetic, not taste: side by side needs the 192px list,
|
|
* plus an editor wide enough for its own action row (~280px), plus the divider.
|
|
* Below ~473px the editor is narrower than its buttons, so `@lg` (512px) is the
|
|
* first stop that clears it.
|
|
*
|
|
* The editor holds draft text locally and commits on blur, which is how every
|
|
* other editable field in the app behaves (`ClaudeInstructionsEditor`, the
|
|
* Config tab).
|
|
*/
|
|
export default function NotesPanel({ projectId }: Props) {
|
|
const { notes, loading, saveState, createNote, saveNote, deleteNote } =
|
|
useNotes(projectId);
|
|
const [selectedId, setSelectedId] = useState<string | null>(null);
|
|
|
|
const selected = useMemo(
|
|
() => notes.find((n) => n.id === selectedId) ?? notes[0] ?? null,
|
|
[notes, selectedId],
|
|
);
|
|
|
|
const { title, body, setTitle, setBody, commit } = useNoteDraft(
|
|
selected,
|
|
saveNote,
|
|
);
|
|
|
|
const onCreate = async () => {
|
|
const note = await createNote();
|
|
if (note) setSelectedId(note.id);
|
|
};
|
|
|
|
if (loading) {
|
|
return (
|
|
<p className="p-4 text-xs text-[var(--text-secondary)]">Loading notes…</p>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<div className="@container flex flex-col h-full min-h-0">
|
|
<div className="flex items-center justify-between gap-2 px-3 py-2 border-b border-[var(--border-color)]">
|
|
<Button variant="primary" onClick={onCreate}>
|
|
New note
|
|
</Button>
|
|
<SaveIndicator state={saveState} />
|
|
</div>
|
|
|
|
{notes.length === 0 ? (
|
|
<div className="flex-1 flex items-center justify-center p-4">
|
|
<p className="text-[13px] text-[var(--text-secondary)] text-center">
|
|
No notes yet. Keep reminders here, and send any of them straight to a
|
|
running Claude session.
|
|
</p>
|
|
</div>
|
|
) : (
|
|
<div className="flex-1 min-h-0 flex flex-col @lg:flex-row">
|
|
{/* Stacked: a capped strip of titles above the editor, so the note
|
|
being written keeps most of the height. Side by side: a full-height
|
|
column of the fixed width the editor's arithmetic assumes. */}
|
|
<ul className="flex-shrink-0 overflow-y-auto py-1 max-h-32 border-b @lg:max-h-none @lg:w-48 @lg:border-b-0 @lg:border-r border-[var(--border-color)]">
|
|
{notes.map((n) => (
|
|
<li key={n.id}>
|
|
<button
|
|
type="button"
|
|
onClick={() => setSelectedId(n.id)}
|
|
className={`w-full text-left px-3 py-1.5 text-xs truncate transition-colors ${
|
|
selected?.id === n.id
|
|
? "bg-[var(--bg-tertiary)] text-[var(--text-primary)]"
|
|
: "text-[var(--text-secondary)] hover:text-[var(--text-primary)]"
|
|
}`}
|
|
>
|
|
{n.title.trim() || UNTITLED}
|
|
</button>
|
|
</li>
|
|
))}
|
|
</ul>
|
|
<div className="flex-1 min-w-0">
|
|
{selected && (
|
|
<NoteEditor
|
|
projectId={projectId}
|
|
title={title}
|
|
body={body}
|
|
onTitleChange={setTitle}
|
|
onBodyChange={setBody}
|
|
onCommit={commit}
|
|
onDelete={() => void deleteNote(selected.id)}
|
|
/>
|
|
)}
|
|
</div>
|
|
</div>
|
|
)}
|
|
</div>
|
|
);
|
|
}
|