shadowdaoandClaude Opus 5
436b6dd470
`toClaudePayload` matched `/\r?\n/`, so a bare CR that is not part of a CRLF went through verbatim — and a bare CR *submits* in a Claude prompt and *runs* the line in a shell, which is the terminator the function's own contract says it never appends. A `<textarea>` cannot produce one, but `load_in` returns whatever a hand-edited or externally written notes file holds, so the guarantee has to cover that rather than only what the editor can type. `Note.pinned` is persisted and sorted on, but nothing in the app sets it: there is no pin control and no indicator. The spec stated the ordering rule as though pinning existed and §8 did not list it, so the spec is amended to say `pinned` is reserved and inert in v1, and pinning is added to the out-of-scope list. No UI is added — a user-facing affordance does not belong in a fix wave. Also renamed NotesPanel.test.tsx's "deletes the selected note and falls back to another": `useNotes` is mocked in that file and the mocked list never changes, so the fallback was never exercised. A name that claims coverage which is absent is worse than an absent test, because it makes the gap invisible. The real assertion now lives against the real hook in NotesPanel.shared.test.tsx. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HjL1E2JFNctUqCYotUwqqb
37 lines
1.7 KiB
TypeScript
37 lines
1.7 KiB
TypeScript
/**
|
|
* The bytes that insert a newline in Claude Code's prompt without submitting
|
|
* it: ESC then CR.
|
|
*
|
|
* These are the in-band bytes, not a guess — they are exactly what Claude
|
|
* Code's own `/terminal-setup` writes into the VS Code, Cursor, Alacritty and
|
|
* Zed keymaps, and `TerminalView`'s Shift+Enter handler has sent them since
|
|
* that feature landed. **This must not be "simplified" to `\n`:** Claude Code
|
|
* accepts `\n` too, but a shell would *run* the line, so the two session types
|
|
* would quietly diverge.
|
|
*
|
|
* That last sentence is also why anything sending this must first check the
|
|
* session is a Claude one. `bash -l`'s readline has no binding for `\e\r` and
|
|
* answers with a bell.
|
|
*/
|
|
export const CLAUDE_SOFT_NEWLINE = "\x1b\r";
|
|
|
|
/**
|
|
* Turn multi-line text into something that arrives in a Claude prompt as one
|
|
* message.
|
|
*
|
|
* Sent as raw keystrokes, every `\n` submits, so an N-line note would arrive
|
|
* as N truncated prompts. Deliberately appends no terminator: the text lands
|
|
* in the prompt and the user presses Enter, which is what speech-to-text does
|
|
* for the same reason — an unsent prompt is recoverable and a sent one is not.
|
|
*
|
|
* A **lone** `\r` is matched too, not only the one in a CRLF. It is a carriage
|
|
* return: it submits in a Claude prompt and runs the line in a shell, which is
|
|
* exactly the terminator this function promises never to append. A `<textarea>`
|
|
* cannot produce one, but a note body is read back from a JSON file that can be
|
|
* hand-edited or written by something else, so the guarantee has to hold for
|
|
* whatever `load_in` returns rather than for whatever the editor can type.
|
|
*/
|
|
export function toClaudePayload(text: string): string {
|
|
return text.replace(/\r\n|\r|\n/g, CLAUDE_SOFT_NEWLINE);
|
|
}
|