Files pane
- F16: a drag-out released back inside the app no longer re-imports its own
staged copy over the container original. An in-flight flag (cleared from the
drag plugin's `onEvent` channel, with a watchdog) suppresses the drop and the
"Drop files into …" hint, and an exact staged-path filter is the second line
of defence — the `path|size|modified` cache could otherwise write a
minutes-old snapshot over a file an agent had since rewritten.
- F17: a slow upload/rename no longer yanks the user back to the directory the
operation started in. Every operation captures its target path and re-lists
only if the user is still there; failures go to the toast host either way.
- The grid keeps keyboard focus. Roving tabindex (one tab stop, not one per
row) plus focus restore after navigation, rename commit/cancel and Escape.
- Transient failures now surface in `ToastHost` (z-[60], persistent aria-live)
instead of a `role="alert"` 300 rows down a scroller or behind a modal
overlay. The inline error is kept only for the listing failure.
- `navigate` is sequenced by generation; "Save to host…" sets `busy`.
- Grid a11y: column headers, a text affordance for folder vs file, a live
region that is mounted empty and announces completion, Label-in-Name fixed.
- FileViewerModal: the blob URL is released only once its replacement exists;
the preview is a focusable, named, scrollable region.
Native drop routing
- New `lib/dropTarget.ts`: the hit test now refuses a drop while any
`[aria-modal="true"]` dialog or `[data-blocks-drop]` overlay is up, and
checks z-order where the environment can answer it. Shared by FilesTab and
TerminalView; App's shutdown overlay opts in.
Disk
- A partially failed reclaim says so in words ("… — 2 of 5 failed"), not by hue
alone.
- The scan/reclaim race is closed: every mutation retires an in-flight scan, so
a scan can no longer repaint a pre-reclaim report plus a clickable plan of
objects that are gone. Scan is disabled while working; the status is a live
region; a failed destructive action keeps its dialog open and reports there.
- The "unknown" layer count gets a screen-reader fallback; `--text-disabled`
no longer carries live information.
Terminal / OAuth
- After the toast is dismissed, a truncated heuristic guess can no longer fill
the slot that an exact OSC 8 or relay URL occupied — the detector remembers
every exact URL and drops any candidate that is a strict prefix of one.
- The prompt is reachable by keyboard: Ctrl+Shift+O jumps to the default
action, Escape dismisses, focus returns to the terminal, and auto-dismiss
holds off while focus is inside. It deliberately does not steal focus.
- UrlToast renders through `ui/Button` and `--shadow-overlay`.
Elsewhere
- AuthBridgeRow: a pushed `auth-bridge-changed` status always outranks an older
awaited toggle result.
- The last two ad-hoc byte formatters route through `lib/formatBytes`.
Contract for the backend agent: `upload_file_to_container` refusing to
overwrite must satisfy `isFileExistsError` in `src/lib/uploadErrors.ts` (marker
`FILE_EXISTS`) and accept an `overwrite` argument; the frontend turns that into
an `ui/Modal` Replace/Skip prompt rather than a raw error string.
Tests: 536 -> 627 passing. `npm run build` and `npx tsc --noEmit` green.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GBq2rGum6GX7xXgsas1fDc
182 lines
6.7 KiB
TypeScript
182 lines
6.7 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from "vitest";
|
|
import { render, screen, fireEvent, waitFor } from "@testing-library/react";
|
|
import RuntimeSection from "./RuntimeSection";
|
|
import type { AuthBridgeStatus, Project } from "../../../../lib/types";
|
|
|
|
// The auth-bridge row owns its own IPC — see `AuthBridgeRow.tsx` for why it
|
|
// does not go through `save`.
|
|
const OFF_BRIDGE: AuthBridgeStatus = { enabled: false, active_ports: [], conflicts: [] };
|
|
const setAuthBridgeEnabled = vi.fn(async () => ({ ...OFF_BRIDGE, enabled: true }));
|
|
|
|
vi.mock("../../../../lib/tauri-commands", () => ({
|
|
getAuthBridgeStatus: vi.fn(async () => OFF_BRIDGE),
|
|
setAuthBridgeEnabled: (id: string, on: boolean) => setAuthBridgeEnabled(id, on),
|
|
}));
|
|
|
|
vi.mock("@tauri-apps/api/event", () => ({
|
|
listen: vi.fn(async () => () => {}),
|
|
}));
|
|
|
|
const baseProject: Project = {
|
|
id: "p1",
|
|
name: "api-server",
|
|
paths: [{ host_path: "/src/api", mount_name: "api" }],
|
|
container_id: null,
|
|
status: "stopped",
|
|
backend: "anthropic",
|
|
bedrock_config: null,
|
|
ollama_config: null,
|
|
llamacpp_config: null,
|
|
openai_compatible_config: null,
|
|
allow_docker_access: false,
|
|
sandbox_mode_enabled: true,
|
|
mission_control_enabled: false,
|
|
auth_bridge_enabled: false,
|
|
browser_view_enabled: false,
|
|
vpn_support_enabled: false,
|
|
use_shared_auth_token: true,
|
|
full_permissions: false,
|
|
permission_mode: null,
|
|
ssh_key_path: null,
|
|
ca_cert_path: null,
|
|
git_token: null,
|
|
git_user_name: null,
|
|
git_user_email: null,
|
|
custom_env_vars: [],
|
|
port_mappings: [],
|
|
claude_instructions: null,
|
|
claude_code_settings: null,
|
|
renamed_session_names: {},
|
|
created_at: "2026-01-01T00:00:00Z",
|
|
updated_at: "2026-01-01T00:00:00Z",
|
|
};
|
|
|
|
const VPN = "VPN support";
|
|
|
|
const save = vi.fn().mockResolvedValue(true);
|
|
|
|
function renderSection(over: Partial<Project> = {}, disabled = false) {
|
|
return render(
|
|
<RuntimeSection
|
|
project={{ ...baseProject, ...over }}
|
|
save={save}
|
|
disabled={disabled}
|
|
disabledReason="Container must be stopped to change this setting."
|
|
/>,
|
|
);
|
|
}
|
|
|
|
describe("RuntimeSection — VPN support toggle", () => {
|
|
beforeEach(() => vi.clearAllMocks());
|
|
|
|
it("saves only the VPN flag when switched on", () => {
|
|
renderSection();
|
|
fireEvent.click(screen.getByRole("switch", { name: VPN }));
|
|
expect(save).toHaveBeenCalledWith({ vpn_support_enabled: true });
|
|
});
|
|
|
|
it("saves the flag off again, rather than dropping the key", () => {
|
|
// Off has to be written explicitly: the container carries a
|
|
// `triple-c.vpn-support` label either way, and an absent value would leave
|
|
// the capability granted.
|
|
renderSection({ vpn_support_enabled: true });
|
|
fireEvent.click(screen.getByRole("switch", { name: VPN }));
|
|
expect(save).toHaveBeenCalledWith({ vpn_support_enabled: false });
|
|
});
|
|
|
|
it("reflects the project's current state", () => {
|
|
renderSection({ vpn_support_enabled: true });
|
|
expect(screen.getByRole("switch", { name: VPN })).toBeChecked();
|
|
});
|
|
|
|
it("cannot be changed while the container is running", () => {
|
|
// Capabilities and devices are fixed at creation, so this setting is gated
|
|
// on the container being stopped along with the rest of the tab.
|
|
renderSection({}, true);
|
|
const toggle = screen.getByRole("switch", { name: VPN });
|
|
expect(toggle).toBeDisabled();
|
|
fireEvent.click(toggle);
|
|
expect(save).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("warns that the change recreates the container", () => {
|
|
renderSection();
|
|
expect(
|
|
screen.getByText(/recreates the container on its next start/i),
|
|
).toBeInTheDocument();
|
|
});
|
|
});
|
|
|
|
/**
|
|
* `scope="project"` on the settings editor is one prop with no visible owner,
|
|
* and deleting it fails silently in the worst possible direction: the editor
|
|
* falls back to `"global"`, every three-state control collapses to an on/off
|
|
* switch, and a field the project is *inheriting* as on renders flat Off. The
|
|
* user then reads a lie and, worse, flipping that switch writes a deliberate
|
|
* `false` that overrides the global On they thought they were looking at.
|
|
*
|
|
* Nothing asserted the prop was passed, so these go through what is rendered
|
|
* rather than through props — a switch where a select belongs is exactly the
|
|
* regression, and it is visible from the outside.
|
|
*/
|
|
describe("RuntimeSection — Claude Code settings are edited at project scope", () => {
|
|
beforeEach(() => vi.clearAllMocks());
|
|
|
|
it("gives every setting the third Global state a project can inherit through", () => {
|
|
renderSection();
|
|
const focus = screen.getByLabelText("Focus mode") as HTMLSelectElement;
|
|
expect(
|
|
Array.from(focus.querySelectorAll("option")).map((o) => o.getAttribute("value")),
|
|
).toEqual(["global", "off", "on"]);
|
|
});
|
|
|
|
it("renders an untouched setting as inheriting, not as Off", () => {
|
|
// `claude_code_settings: null` means "this project has no opinion", which
|
|
// is not the same instruction as off. At global scope the same field is a
|
|
// plain unchecked switch — indistinguishable from a user who turned it
|
|
// off, and the reason the missing prop would never be noticed.
|
|
renderSection({ claude_code_settings: null });
|
|
expect((screen.getByLabelText("Focus mode") as HTMLSelectElement).value).toBe(
|
|
"global",
|
|
);
|
|
expect(screen.queryByRole("switch", { name: "Focus mode" })).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("keeps a stored project override visible over the inherited value", () => {
|
|
renderSection({
|
|
claude_code_settings: {
|
|
tui_mode: null,
|
|
effort: null,
|
|
auto_scroll_disabled: null,
|
|
focus_mode: true,
|
|
show_thinking_summaries: null,
|
|
session_recap_disabled: null,
|
|
env_scrub: null,
|
|
prompt_caching_1h: null,
|
|
},
|
|
});
|
|
expect((screen.getByLabelText("Focus mode") as HTMLSelectElement).value).toBe("on");
|
|
});
|
|
});
|
|
|
|
describe("RuntimeSection — auth bridge toggle", () => {
|
|
beforeEach(() => vi.clearAllMocks());
|
|
|
|
it("is reachable while the container is running", async () => {
|
|
// The rest of the tab is gated on a stopped container because those
|
|
// settings are baked in at creation. This one is host-side and has its own
|
|
// command, and the moment a user needs it is the moment a login is hanging
|
|
// in a *running* container — so the tab's `disabled` must not reach it.
|
|
renderSection({ status: "running" }, true);
|
|
|
|
const toggle = screen.getByRole("switch", { name: "Auth bridge" });
|
|
await waitFor(() => expect(toggle).not.toBeDisabled());
|
|
|
|
fireEvent.click(toggle);
|
|
await waitFor(() => expect(setAuthBridgeEnabled).toHaveBeenCalledWith("p1", true));
|
|
// And never through the generic project save, which would drop it on the
|
|
// floor while the container runs.
|
|
expect(save).not.toHaveBeenCalled();
|
|
});
|
|
});
|