shadowdaoandClaude Sonnet 5
6b12859887
test_core.cpp used bare assert(). CI builds Release, Release defines NDEBUG, and NDEBUG compiles assert() out entirely -- so that suite had been passing unconditionally, checking nothing. It now uses the same always-live ST_ASSERT harness as the other suites and reports a count (10 checks), and additionally asserts that core_version() really is the version CMake injected rather than a stale literal. macOS SDK, third iteration. The previous fix assumed OBS only wanted a version-carrying SDK filename. Reading OBS 30.0.2's cmake/macos/compilerconfig.cmake shows the actual pattern is stricter: ".+/MacOSX.platform/Developer/SDKs/MacOSX([0-9]+\.[0-9])+\.sdk$" which only ever matches a full-Xcode SDK path. A Command-Line-Tools-only install keeps its SDK at /Library/Developer/CommandLineTools/SDKs/MacOSX<ver>.sdk, with no MacOSX.platform/Developer/SDKs segment at all, so it can never match however it is named -- which is why the second attempt got past the "REGEX needs at least 5 arguments" error and still landed on "Your macOS SDK version () is too low", with the version still empty. _resolve_versioned_macos_sdk now builds a symlink tree under .deps/ whose shape matches that pattern and which points at exactly the same SDK, and uses the toolchain's own path untouched when it already matches (i.e. when real Xcode is installed). Nothing about the compilation changes -- only the spelling of the path, which is all OBS's check reads. Also refreshes the scaffold-era comments in core.h and core_c.h, which still described this library as a placeholder that would one day talk to livekit-ffi. Linux CI is green on the previous commit: real libobs adapter linked (ldd shows libobs.so.0 plus liblivekit/liblivekit_ffi resolving from the staged package directory), obs_module_load exported, ctest 6/6, artifact uploaded. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RL8abRmgFXkVASHkkqiJbE
49 lines
1.8 KiB
C++
49 lines
1.8 KiB
C++
/*
|
|
streamer-tools OBS Camera Plugin - core library
|
|
Copyright (C) 2026 CyberCoveLLC <jknapp85@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License along
|
|
with this program. If not, see <https://www.gnu.org/licenses/>
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <string>
|
|
|
|
// The small shared pieces of the core library: its version string, and the
|
|
// streamer-tools connection settings that both the API client and the OBS
|
|
// adapter pass around. Everything substantial lives in its own header --
|
|
// api_client.h, session.h, http.h, json.h -- and none of it depends on OBS,
|
|
// so the whole library builds and tests headlessly on all three platforms.
|
|
|
|
namespace stplugin {
|
|
|
|
// The core library's version string, injected by CMake from the top-level
|
|
// project() version, so what OBS logs on load is the actual build.
|
|
const char *core_version();
|
|
|
|
// What an operator types into the source's properties, and what ApiClient
|
|
// needs to reach the two read-key-scoped endpoints in
|
|
// apps/server/src/obs/plugin.routes.ts (streamer-tools repo). The read key is
|
|
// a credential: it is masked in the properties UI and never logged (see
|
|
// ApiClient::redactedUrl).
|
|
struct ConnectionConfig {
|
|
std::string server_url;
|
|
std::string room_slug;
|
|
std::string read_key;
|
|
|
|
bool is_valid() const;
|
|
};
|
|
|
|
} // namespace stplugin
|