From 4cc769fcdd45a4d90ea8df2c78ca72c72ca9b1c5 Mon Sep 17 00:00:00 2001 From: Chandrasekhar Gadde <106585855+ChandraSGadde@users.noreply.github.com> Date: Thu, 14 May 2026 23:22:02 +0530 Subject: [PATCH] fix accidental nested loop (#801) Co-authored-by: Chandrasekhar Gadde --- internal/provider/resource_role.go | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/internal/provider/resource_role.go b/internal/provider/resource_role.go index 73511f20..a3abc5b8 100644 --- a/internal/provider/resource_role.go +++ b/internal/provider/resource_role.go @@ -151,18 +151,15 @@ func resourceRoleCreate(ctx context.Context, d *schema.ResourceData, meta interf if grantStringsVal, ok := d.GetOk(roleGrantStringsKey); ok { list := grantStringsVal.(*schema.Set).List() grantStrings = make([]string, 0, len(list)) - for _, i := range list { - for _, grant := range list { - deprecationNotice, err := checkGrantForDeprecation(grant.(string)) - if err != nil { - return diag.FromErr(err) - } - if deprecationNotice != "" { - diags = append(diags, diag.Diagnostic{Severity: diag.Warning, Summary: "deprecated field found in grant", Detail: deprecationNotice}) - } - grantStrings = append(grantStrings, grant.(string)) + for _, grant := range list { + deprecationNotice, err := checkGrantForDeprecation(grant.(string)) + if err != nil { + return diag.FromErr(err) } - grantStrings = append(grantStrings, i.(string)) + if deprecationNotice != "" { + diags = append(diags, diag.Diagnostic{Severity: diag.Warning, Summary: "deprecated field found in grant", Detail: deprecationNotice}) + } + grantStrings = append(grantStrings, grant.(string)) } } @@ -175,6 +172,9 @@ func resourceRoleCreate(ctx context.Context, d *schema.ResourceData, meta interf if tcr == nil { return diag.Errorf("nil role after create") } + if tcr.Item == nil { + return diag.Errorf("nil role item after create") + } apiResponse := tcr.GetResponse().Map defer func() { if err := setFromRoleResponseMap(d, apiResponse); err != nil {