Worker storage bucket credential state (#46)

* feat: parse generic aws api errors

* feat: parse s3 api errors

* feat: return credential state for all status errors

* fix status codes on certain http error codes and re-enable two tests

* switch code to FailedPrecondition

* update certain error codes

* update go.mod for new sdk version

---------

Co-authored-by: Damian Debkowski <damian.debkowski@hashicorp.com>
This commit is contained in:
daniandDamian Debkowski authored and GitHub committed 2024-07-17 15:37:27 -04:00
1 parent 88798fb76b
commit 5add0a1b53
16 files changed
+2090 -394

No files matched your search

+5 -5
View File
@@ -132,7 +132,7 @@ func TestPluginOnCreateCatalogErr(t *testing.T) {
),
}),
},
expectedErrContains: fmt.Sprintf("error during credential rotation: error rotating credentials: error calling CreateAccessKey: error calling iam.GetUser: %s", testGetUserErr),
expectedErrContains: "aws service unknown: unknown error: error rotating credentials",
expectedErrCode: codes.InvalidArgument,
},
{
@@ -163,7 +163,7 @@ func TestPluginOnCreateCatalogErr(t *testing.T) {
),
}),
},
expectedErrContains: fmt.Sprintf("error during credential validation: error validating credentials: %s", testGetCallerIdentityErr),
expectedErrContains: "aws service unknown: unknown error: validating credentials",
expectedErrCode: codes.InvalidArgument,
},
}
@@ -342,7 +342,7 @@ func TestPluginOnUpdateCatalogErr(t *testing.T) {
),
}),
},
expectedErrContains: fmt.Sprintf("error attempting to replace credentials: error deleting old access key: %s", testDeleteAccessKeyErr),
expectedErrContains: "aws service unknown: unknown error: failed to delete access key",
expectedErrCode: codes.InvalidArgument,
},
{
@@ -375,7 +375,7 @@ func TestPluginOnUpdateCatalogErr(t *testing.T) {
),
}),
},
expectedErrContains: fmt.Sprintf("error during credential rotation: error rotating credentials: error calling CreateAccessKey: error calling iam.GetUser: %s", testGetUserErr),
expectedErrContains: "aws service unknown: unknown error: error rotating credentials",
expectedErrCode: codes.InvalidArgument,
},
}
@@ -466,7 +466,7 @@ func TestPluginOnDeleteCatalogErr(t *testing.T) {
),
}),
},
expectedErrContains: fmt.Sprintf("error removing rotated credentials during catalog deletion: error deleting old access key: %s", testDeleteAccessKeyErr),
expectedErrContains: "aws service unknown: unknown error: failed to delete access key",
expectedErrCode: codes.Aborted,
},
}