From 38bcd34baf0a8ae4a1b439eb2953e55716a3eb9b Mon Sep 17 00:00:00 2001 From: Chris Marchesi Date: Mon, 15 Nov 2021 15:26:15 -0800 Subject: [PATCH] plugin: Remove TODO from E2E test covering rotated -> not rotated ...when no new credentials are supplied. This was initially not covered when the E2E tests were written but was added later once we the mocks necessary to do unit testing to get error coverage. --- plugin/e2e_test.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/plugin/e2e_test.go b/plugin/e2e_test.go index c3b571b..1f43e20 100644 --- a/plugin/e2e_test.go +++ b/plugin/e2e_test.go @@ -358,11 +358,9 @@ func testPluginOnUpdateCatalog( case newAccessKeyId == "" && rotated && !rotate: // No new credentials have been provided, and we have previously - // rotated the credentials. This is actually an error. - // - // TODO: validate this scenario through unit testing. For now if - // we for some reason try to test this with this function, return - // an error. + // rotated the credentials. This is actually an error, but we + // don't test it here; it's covered in unit testing (see + // plugin_test.go). require.FailNow("testing rotated-to-not-rotated scenario not implemented by this helper") case newAccessKeyId == "" && !rotated && rotate: