Compare commits

...
3 Commits
Author SHA1 Message Date
Delaine Rogers 57acf5f697 move the nil check 2026-09-16 11:05:15 -07:00
Delaine Rogers b807cf2107 Allow nil setAttributes 2026-08-19 14:00:50 -07:00
Susmitha Girumala 163ec69771 Update github test workflow permissions to read-only (#76)
Set GITHUB_TOKEN to read-only permission by default
2026-07-14 15:31:58 -04:00
3 changed files with 21 additions and 0 deletions

No files matched your search

+2
View File
@@ -4,6 +4,8 @@ on:
- workflow_dispatch - workflow_dispatch
- push - push
permissions: read-all
jobs: jobs:
test: test:
runs-on: ubuntu-latest runs-on: ubuntu-latest
+4
View File
@@ -634,6 +634,10 @@ func buildFilters(attrs *SetAttributes) ([]types.Filter, error) {
} }
func buildDescribeInstancesInput(attrs *SetAttributes, dryRun bool) (*ec2.DescribeInstancesInput, error) { func buildDescribeInstancesInput(attrs *SetAttributes, dryRun bool) (*ec2.DescribeInstancesInput, error) {
if attrs == nil {
attrs = &SetAttributes{}
}
filters, err := buildFilters(attrs) filters, err := buildFilters(attrs)
if err != nil { if err != nil {
return nil, fmt.Errorf("error building filters: %w", err) return nil, fmt.Errorf("error building filters: %w", err)
+15
View File
@@ -2383,6 +2383,21 @@ func TestBuildDescribeInstancesInput(t *testing.T) {
require.Equal(tc.expected, actual) require.Equal(tc.expected, actual)
}) })
} }
t.Run("nil attrs, dry run", func(t *testing.T) {
require := require.New(t)
actual, err := buildDescribeInstancesInput(nil, true)
require.NoError(err)
require.Equal(&ec2.DescribeInstancesInput{
DryRun: aws.Bool(true),
Filters: []types.Filter{
{
Name: aws.String("instance-state-name"),
Values: []string{string(types.InstanceStateNameRunning)},
},
},
}, actual)
})
} }
func TestAwsInstanceToHost(t *testing.T) { func TestAwsInstanceToHost(t *testing.T) {