feat: package structure (#2)
Update structure to match other Boundary plugins which groups packages by service
This commit is contained in:
1 parent
cd73a74e1e
commit
6588e10934
8 files changed
+309
-280
No files matched your search
@@ -0,0 +1,701 @@
|
||||
// Copyright (c) HashiCorp, Inc.
|
||||
// SPDX-License-Identifier: MPL-2.0
|
||||
|
||||
package host
|
||||
|
||||
import (
|
||||
"context"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
|
||||
cred "github.com/hashicorp/boundary-plugin-gcp/internal/credential"
|
||||
"github.com/hashicorp/boundary/sdk/pbs/controller/api/resources/hostcatalogs"
|
||||
"github.com/hashicorp/boundary/sdk/pbs/controller/api/resources/hostsets"
|
||||
pb "github.com/hashicorp/boundary/sdk/pbs/plugin"
|
||||
"github.com/hashicorp/go-secure-stdlib/parseutil"
|
||||
"github.com/stretchr/testify/require"
|
||||
"google.golang.org/protobuf/types/known/structpb"
|
||||
)
|
||||
|
||||
func wrapMap(t *testing.T, in map[string]interface{}) *structpb.Struct {
|
||||
t.Helper()
|
||||
out, err := structpb.NewStruct(in)
|
||||
require.NoError(t, err)
|
||||
return out
|
||||
}
|
||||
|
||||
func TestListHosts(t *testing.T) {
|
||||
t.Skip("TODO: this needs a secrets file to run - maybe only manually?")
|
||||
ctx := context.Background()
|
||||
p := &HostPlugin{}
|
||||
|
||||
wd, err := os.Getwd()
|
||||
require.NoError(t, err)
|
||||
require.NotEmpty(t, wd)
|
||||
project, err := parseutil.ParsePath("file://" + filepath.Join(wd, "secrets", "project"))
|
||||
require.NoError(t, err)
|
||||
zone, err := parseutil.ParsePath("file://" + filepath.Join(wd, "secrets", "zone"))
|
||||
require.NoError(t, err)
|
||||
|
||||
hostCatalogAttributes := &hostcatalogs.HostCatalog_Attributes{
|
||||
Attributes: wrapMap(t, map[string]interface{}{
|
||||
cred.ConstProject: project,
|
||||
cred.ConstZone: zone,
|
||||
}),
|
||||
}
|
||||
|
||||
cases := []struct {
|
||||
name string
|
||||
req *pb.ListHostsRequest
|
||||
expected []*pb.ListHostsResponseHost
|
||||
expectedErr string
|
||||
}{
|
||||
{
|
||||
name: "nil catalog",
|
||||
req: &pb.ListHostsRequest{},
|
||||
expectedErr: "catalog is nil",
|
||||
},
|
||||
{
|
||||
name: "project not defined",
|
||||
req: &pb.ListHostsRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{
|
||||
Attrs: &hostcatalogs.HostCatalog_Attributes{
|
||||
Attributes: wrapMap(t, map[string]interface{}{
|
||||
cred.ConstZone: zone,
|
||||
}),
|
||||
},
|
||||
},
|
||||
},
|
||||
expectedErr: "attributes.project: missing required value \"project\"",
|
||||
},
|
||||
{
|
||||
name: "get all three instances",
|
||||
req: &pb.ListHostsRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{
|
||||
Attrs: hostCatalogAttributes,
|
||||
},
|
||||
Sets: []*hostsets.HostSet{
|
||||
{
|
||||
Id: "get-all-instances",
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: wrapMap(t, map[string]interface{}{}),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expected: []*pb.ListHostsResponseHost{
|
||||
{
|
||||
Name: "boundary-0",
|
||||
},
|
||||
{
|
||||
Name: "boundary-1",
|
||||
},
|
||||
{
|
||||
Name: "boundary-2",
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "get one instance by name",
|
||||
req: &pb.ListHostsRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{
|
||||
Attrs: hostCatalogAttributes,
|
||||
},
|
||||
Sets: []*hostsets.HostSet{
|
||||
{
|
||||
Id: "get-one-instance-by-name",
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: wrapMap(t, map[string]interface{}{
|
||||
ConstListInstancesFilter: "name = boundary-1",
|
||||
}),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expected: []*pb.ListHostsResponseHost{
|
||||
{
|
||||
Name: "boundary-1",
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "get instance group",
|
||||
req: &pb.ListHostsRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{
|
||||
Attrs: hostCatalogAttributes,
|
||||
},
|
||||
Sets: []*hostsets.HostSet{
|
||||
{
|
||||
Id: "get-instance-group",
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: wrapMap(t, map[string]interface{}{
|
||||
ConstInstanceGroup: "boundary-servers",
|
||||
}),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expected: []*pb.ListHostsResponseHost{
|
||||
{
|
||||
Name: "boundary-0",
|
||||
},
|
||||
{
|
||||
Name: "boundary-1",
|
||||
},
|
||||
{
|
||||
Name: "boundary-2",
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "get two specific instances with two host sets",
|
||||
req: &pb.ListHostsRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{
|
||||
Attrs: hostCatalogAttributes,
|
||||
},
|
||||
Sets: []*hostsets.HostSet{
|
||||
{
|
||||
Id: "get-one-instance-by-name-0",
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: wrapMap(t, map[string]interface{}{
|
||||
ConstListInstancesFilter: "name = boundary-0",
|
||||
}),
|
||||
},
|
||||
},
|
||||
{
|
||||
Id: "get-one-instance-by-name-2",
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: wrapMap(t, map[string]interface{}{
|
||||
ConstListInstancesFilter: "name = boundary-2",
|
||||
}),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expected: []*pb.ListHostsResponseHost{
|
||||
{
|
||||
Name: "boundary-0",
|
||||
},
|
||||
{
|
||||
Name: "boundary-2",
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "get one instance and an instance group in two host sets",
|
||||
req: &pb.ListHostsRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{
|
||||
Attrs: hostCatalogAttributes,
|
||||
},
|
||||
Sets: []*hostsets.HostSet{
|
||||
{
|
||||
Id: "get-one-instance-by-name",
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: wrapMap(t, map[string]interface{}{
|
||||
ConstListInstancesFilter: "name = boundary-1",
|
||||
}),
|
||||
},
|
||||
},
|
||||
{
|
||||
Id: "get-instance-group",
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: wrapMap(t, map[string]interface{}{
|
||||
ConstInstanceGroup: "boundary-servers",
|
||||
}),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expected: []*pb.ListHostsResponseHost{
|
||||
{
|
||||
Name: "boundary-0",
|
||||
},
|
||||
{
|
||||
Name: "boundary-1",
|
||||
},
|
||||
{
|
||||
Name: "boundary-2",
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "get an instance group and one instance in two host sets",
|
||||
req: &pb.ListHostsRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{
|
||||
Attrs: hostCatalogAttributes,
|
||||
},
|
||||
Sets: []*hostsets.HostSet{
|
||||
{
|
||||
Id: "get-instance-group",
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: wrapMap(t, map[string]interface{}{
|
||||
ConstInstanceGroup: "boundary-servers",
|
||||
}),
|
||||
},
|
||||
},
|
||||
{
|
||||
Id: "get-one-instance-by-name",
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: wrapMap(t, map[string]interface{}{
|
||||
ConstListInstancesFilter: "name = boundary-2",
|
||||
}),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expected: []*pb.ListHostsResponseHost{
|
||||
{
|
||||
Name: "boundary-0",
|
||||
},
|
||||
{
|
||||
Name: "boundary-1",
|
||||
},
|
||||
{
|
||||
Name: "boundary-2",
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "invalid filter",
|
||||
req: &pb.ListHostsRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{
|
||||
Attrs: hostCatalogAttributes,
|
||||
},
|
||||
Sets: []*hostsets.HostSet{
|
||||
{
|
||||
Id: "invalid-filter",
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: wrapMap(t, map[string]interface{}{
|
||||
ConstListInstancesFilter: "not-a-filter",
|
||||
}),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expectedErr: "Invalid list filter expression",
|
||||
},
|
||||
}
|
||||
|
||||
for _, tc := range cases {
|
||||
tc := tc
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
require := require.New(t)
|
||||
|
||||
actual, err := p.ListHosts(ctx, tc.req)
|
||||
if tc.expectedErr != "" {
|
||||
require.Contains(err.Error(), tc.expectedErr)
|
||||
return
|
||||
}
|
||||
|
||||
require.NoError(err)
|
||||
require.Equal(len(tc.expected), len(actual.GetHosts()))
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestCreateCatalog(t *testing.T) {
|
||||
t.Skip("TODO: this needs a secrets file to run - maybe only manually?")
|
||||
ctx := context.Background()
|
||||
p := &HostPlugin{}
|
||||
|
||||
wd, err := os.Getwd()
|
||||
require.NoError(t, err)
|
||||
require.NotEmpty(t, wd)
|
||||
project, err := parseutil.ParsePath("file://" + filepath.Join(wd, "secrets", "project"))
|
||||
require.NoError(t, err)
|
||||
zone, err := parseutil.ParsePath("file://" + filepath.Join(wd, "secrets", "zone"))
|
||||
require.NoError(t, err)
|
||||
|
||||
hostCatalogAttributes := &hostcatalogs.HostCatalog_Attributes{
|
||||
Attributes: wrapMap(t, map[string]interface{}{
|
||||
cred.ConstProject: project,
|
||||
cred.ConstZone: zone,
|
||||
}),
|
||||
}
|
||||
|
||||
require.NoError(t, err)
|
||||
|
||||
cases := []struct {
|
||||
name string
|
||||
req *pb.OnCreateCatalogRequest
|
||||
expected *pb.HostCatalogPersisted
|
||||
expectedErr string
|
||||
}{
|
||||
{
|
||||
name: "nil catalog",
|
||||
req: &pb.OnCreateCatalogRequest{},
|
||||
expectedErr: "catalog is nil",
|
||||
},
|
||||
{
|
||||
name: "nil attributes",
|
||||
req: &pb.OnCreateCatalogRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{},
|
||||
},
|
||||
expectedErr: "attributes are required",
|
||||
},
|
||||
{
|
||||
name: "error reading attributes",
|
||||
req: &pb.OnCreateCatalogRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{
|
||||
Attrs: &hostcatalogs.HostCatalog_Attributes{
|
||||
Attributes: new(structpb.Struct),
|
||||
},
|
||||
},
|
||||
},
|
||||
expectedErr: "attributes.project: missing required value \"project\"",
|
||||
},
|
||||
{
|
||||
name: "do not persist secrets, use gcloud application default creds",
|
||||
req: &pb.OnCreateCatalogRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{
|
||||
Attrs: hostCatalogAttributes,
|
||||
},
|
||||
},
|
||||
expected: &pb.HostCatalogPersisted{
|
||||
Secrets: nil,
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
for _, tc := range cases {
|
||||
tc := tc
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
require := require.New(t)
|
||||
|
||||
actual, err := p.OnCreateCatalog(ctx, tc.req)
|
||||
if tc.expectedErr != "" {
|
||||
require.Contains(err.Error(), tc.expectedErr)
|
||||
return
|
||||
}
|
||||
|
||||
require.NoError(err)
|
||||
require.Nil(actual.GetPersisted().Secrets)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestUpdateCatalog(t *testing.T) {
|
||||
t.Skip("TODO: this needs a secrets file to run - maybe only manually?")
|
||||
ctx := context.Background()
|
||||
p := &HostPlugin{}
|
||||
|
||||
wd, err := os.Getwd()
|
||||
require.NoError(t, err)
|
||||
require.NotEmpty(t, wd)
|
||||
project, err := parseutil.ParsePath("file://" + filepath.Join(wd, "secrets", "project"))
|
||||
require.NoError(t, err)
|
||||
zone, err := parseutil.ParsePath("file://" + filepath.Join(wd, "secrets", "zone"))
|
||||
require.NoError(t, err)
|
||||
|
||||
hostCatalogAttributes := &hostcatalogs.HostCatalog_Attributes{
|
||||
Attributes: wrapMap(t, map[string]interface{}{
|
||||
cred.ConstProject: project,
|
||||
cred.ConstZone: zone,
|
||||
}),
|
||||
}
|
||||
|
||||
require.NoError(t, err)
|
||||
|
||||
cases := []struct {
|
||||
name string
|
||||
req *pb.OnCreateCatalogRequest
|
||||
expected *pb.HostCatalogPersisted
|
||||
expectedErr string
|
||||
}{
|
||||
{
|
||||
name: "nil catalog",
|
||||
req: &pb.OnCreateCatalogRequest{},
|
||||
expectedErr: "catalog is nil",
|
||||
},
|
||||
{
|
||||
name: "nil attributes",
|
||||
req: &pb.OnCreateCatalogRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{},
|
||||
},
|
||||
expectedErr: "attributes are required",
|
||||
},
|
||||
{
|
||||
name: "error reading attributes",
|
||||
req: &pb.OnCreateCatalogRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{
|
||||
Attrs: &hostcatalogs.HostCatalog_Attributes{
|
||||
Attributes: new(structpb.Struct),
|
||||
},
|
||||
},
|
||||
},
|
||||
expectedErr: "attributes.project: missing required value \"project\"",
|
||||
},
|
||||
{
|
||||
name: "do not persist secrets, use gcloud ADC",
|
||||
req: &pb.OnCreateCatalogRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{
|
||||
Attrs: hostCatalogAttributes,
|
||||
},
|
||||
},
|
||||
expected: &pb.HostCatalogPersisted{
|
||||
Secrets: nil,
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
for _, tc := range cases {
|
||||
tc := tc
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
require := require.New(t)
|
||||
|
||||
actual, err := p.OnCreateCatalog(ctx, tc.req)
|
||||
if tc.expectedErr != "" {
|
||||
require.Contains(err.Error(), tc.expectedErr)
|
||||
return
|
||||
}
|
||||
|
||||
require.NoError(err)
|
||||
require.Equal(actual.GetPersisted().Secrets, tc.expected.GetSecrets())
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestCreateSet(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
p := &HostPlugin{}
|
||||
|
||||
cases := []struct {
|
||||
name string
|
||||
req *pb.OnCreateSetRequest
|
||||
expectedErr string
|
||||
}{
|
||||
{
|
||||
name: "nil set",
|
||||
req: &pb.OnCreateSetRequest{},
|
||||
expectedErr: "set is nil",
|
||||
},
|
||||
{
|
||||
name: "nil set",
|
||||
req: &pb.OnCreateSetRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{
|
||||
Attrs: &hostcatalogs.HostCatalog_Attributes{
|
||||
Attributes: &structpb.Struct{
|
||||
Fields: map[string]*structpb.Value{
|
||||
cred.ConstProject: structpb.NewStringValue("test-project"),
|
||||
cred.ConstZone: structpb.NewStringValue("us-central1-a"),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expectedErr: "set is nil",
|
||||
},
|
||||
{
|
||||
name: "only allow instance group or filter, not both",
|
||||
req: &pb.OnCreateSetRequest{
|
||||
Set: &hostsets.HostSet{
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: &structpb.Struct{
|
||||
Fields: map[string]*structpb.Value{
|
||||
ConstListInstancesFilter: structpb.NewStringValue("status=RUNNING"),
|
||||
ConstInstanceGroup: structpb.NewStringValue("test"),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expectedErr: "attributes: must set instance group or filter",
|
||||
},
|
||||
{
|
||||
name: "empty filter",
|
||||
req: &pb.OnCreateSetRequest{
|
||||
Set: &hostsets.HostSet{
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: &structpb.Struct{
|
||||
Fields: map[string]*structpb.Value{
|
||||
ConstListInstancesFilter: structpb.NewStringValue(""),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expectedErr: "attributes.filter: must not be empty",
|
||||
},
|
||||
{
|
||||
name: "empty instance group",
|
||||
req: &pb.OnCreateSetRequest{
|
||||
Set: &hostsets.HostSet{
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: &structpb.Struct{
|
||||
Fields: map[string]*structpb.Value{
|
||||
ConstInstanceGroup: structpb.NewStringValue(""),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expectedErr: "attributes.instance_group: must not be empty",
|
||||
},
|
||||
{
|
||||
name: "good filter",
|
||||
req: &pb.OnCreateSetRequest{
|
||||
Set: &hostsets.HostSet{
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: &structpb.Struct{
|
||||
Fields: map[string]*structpb.Value{
|
||||
ConstInstanceGroup: structpb.NewStringValue("status=RUNNING"),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "good instance group",
|
||||
req: &pb.OnCreateSetRequest{
|
||||
Set: &hostsets.HostSet{
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: &structpb.Struct{
|
||||
Fields: map[string]*structpb.Value{
|
||||
ConstInstanceGroup: structpb.NewStringValue("test"),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
for _, tc := range cases {
|
||||
tc := tc
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
require := require.New(t)
|
||||
|
||||
_, err := p.OnCreateSet(ctx, tc.req)
|
||||
if tc.expectedErr != "" {
|
||||
require.Contains(err.Error(), tc.expectedErr)
|
||||
return
|
||||
}
|
||||
|
||||
require.NoError(err)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestUpdateSet(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
p := &HostPlugin{}
|
||||
|
||||
cases := []struct {
|
||||
name string
|
||||
req *pb.OnUpdateSetRequest
|
||||
expectedErr string
|
||||
}{
|
||||
{
|
||||
name: "nil set",
|
||||
req: &pb.OnUpdateSetRequest{},
|
||||
expectedErr: "set is nil",
|
||||
},
|
||||
{
|
||||
name: "nil set",
|
||||
req: &pb.OnUpdateSetRequest{
|
||||
Catalog: &hostcatalogs.HostCatalog{
|
||||
Attrs: &hostcatalogs.HostCatalog_Attributes{
|
||||
Attributes: &structpb.Struct{
|
||||
Fields: map[string]*structpb.Value{
|
||||
cred.ConstProject: structpb.NewStringValue("test-project"),
|
||||
cred.ConstZone: structpb.NewStringValue("us-central1-a"),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expectedErr: "set is nil",
|
||||
},
|
||||
{
|
||||
name: "only allow instance group or filter, not both",
|
||||
req: &pb.OnUpdateSetRequest{
|
||||
NewSet: &hostsets.HostSet{
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: &structpb.Struct{
|
||||
Fields: map[string]*structpb.Value{
|
||||
ConstListInstancesFilter: structpb.NewStringValue("status=RUNNING"),
|
||||
ConstInstanceGroup: structpb.NewStringValue("test"),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expectedErr: "attributes: must set instance group or filter",
|
||||
},
|
||||
{
|
||||
name: "empty filter",
|
||||
req: &pb.OnUpdateSetRequest{
|
||||
NewSet: &hostsets.HostSet{
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: &structpb.Struct{
|
||||
Fields: map[string]*structpb.Value{
|
||||
ConstListInstancesFilter: structpb.NewStringValue(""),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expectedErr: "attributes.filter: must not be empty",
|
||||
},
|
||||
{
|
||||
name: "empty instance group",
|
||||
req: &pb.OnUpdateSetRequest{
|
||||
NewSet: &hostsets.HostSet{
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: &structpb.Struct{
|
||||
Fields: map[string]*structpb.Value{
|
||||
ConstInstanceGroup: structpb.NewStringValue(""),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
expectedErr: "attributes.instance_group: must not be empty",
|
||||
},
|
||||
{
|
||||
name: "good filter",
|
||||
req: &pb.OnUpdateSetRequest{
|
||||
NewSet: &hostsets.HostSet{
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: &structpb.Struct{
|
||||
Fields: map[string]*structpb.Value{
|
||||
ConstInstanceGroup: structpb.NewStringValue("status=RUNNING"),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "good instance group",
|
||||
req: &pb.OnUpdateSetRequest{
|
||||
NewSet: &hostsets.HostSet{
|
||||
Attrs: &hostsets.HostSet_Attributes{
|
||||
Attributes: &structpb.Struct{
|
||||
Fields: map[string]*structpb.Value{
|
||||
ConstInstanceGroup: structpb.NewStringValue("test"),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
for _, tc := range cases {
|
||||
tc := tc
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
require := require.New(t)
|
||||
|
||||
_, err := p.OnUpdateSet(ctx, tc.req)
|
||||
if tc.expectedErr != "" {
|
||||
require.Contains(err.Error(), tc.expectedErr)
|
||||
return
|
||||
}
|
||||
|
||||
require.NoError(err)
|
||||
})
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user