feat: OnDeleteCatalog (#10)

* feat: OnDeleteCatalog

Delete managed creds (creds we rotated previously) when a host catalog is deleted
This commit is contained in:
Elim Tsiagbey authored and GitHub committed 2024-10-28 11:00:14 -04:00
1 parent 08fd6e5b01
commit ba53ae16b2
4 files changed
+135 -3

No files matched your search

+1 -1
View File
@@ -143,7 +143,7 @@ func (c *Config) DeletePrivateKey(ctx context.Context, opts ...option.ClientOpti
Name: fmt.Sprintf("projects/-/serviceAccounts/%s/keys/%s", c.ClientEmail, c.PrivateKeyId),
})
if err != nil {
return status.Errorf(codes.Internal, "error deleting service account key: %v", err)
return status.Errorf(codes.Unknown, "error deleting service account key: %v", err)
}
return nil
+1 -1
View File
@@ -317,7 +317,7 @@ func TestDeletePrivateKey(t *testing.T) {
setup: func() {
testIAMAdminServer.testDeleteServiceAccountKeyError = errors.New("delete key error")
},
expectedError: status.Errorf(codes.Internal, "error deleting service account key"),
expectedError: status.Errorf(codes.Unknown, "error deleting service account key"),
},
{
name: "Successful deletion",