From 03b603be54946d2e79cda4505b842216a7d06c19 Mon Sep 17 00:00:00 2001
From: Devon Anderson <dvonanderson@gmail.com>
Date: Tue, 30 Aug 2022 12:11:19 -0400
Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20Disable=20read-only?=
 =?UTF-8?q?=20fields=20when=20editing=20worker=20(#1287)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Refactor detailed worker to not hide read-only fields when editing, but
leave them disabled

✅ Closes: ICU-5902
---
 .../addon/helpers/relative-datetime-live.js   |  1 -
 ui/admin/app/components/form/worker/index.hbs | 59 +++++++++----------
 2 files changed, 29 insertions(+), 31 deletions(-)

diff --git a/addons/core/addon/helpers/relative-datetime-live.js b/addons/core/addon/helpers/relative-datetime-live.js
index de7ab46aa..746f89643 100644
--- a/addons/core/addon/helpers/relative-datetime-live.js
+++ b/addons/core/addon/helpers/relative-datetime-live.js
@@ -46,7 +46,6 @@ export default class extends Helper {
 
   compute([date]) {
     const delta = date.valueOf() - this.clockTick.now;
-    console.log(delta);
     const greatestMeaningfulUnit = unitMappings.reduce(
       (currentValue, previousValue) => {
         return Math.abs(delta) >= previousValue.value
diff --git a/ui/admin/app/components/form/worker/index.hbs b/ui/admin/app/components/form/worker/index.hbs
index 159b39bee..80e5b9cee 100644
--- a/ui/admin/app/components/form/worker/index.hbs
+++ b/ui/admin/app/components/form/worker/index.hbs
@@ -6,15 +6,14 @@
   as |form|
 >
 
-  {{#unless form.isEditable}}
-    <form.input
-      @name='type'
-      @value={{@model.type}}
-      @label={{t 'form.type.label'}}
-      @helperText={{t 'form.worker_type.help'}}
-      readonly={{true}}
-    />
-  {{/unless}}
+  <form.input
+    @name='type'
+    @value={{@model.type}}
+    @label={{t 'form.type.label'}}
+    @helperText={{t 'form.worker_type.help'}}
+    @disabled={{true}}
+    readonly={{true}}
+  />
 
   <form.input
     @name='name'
@@ -54,30 +53,30 @@
     {{/if}}
   </form.textarea>
 
-  {{#unless form.isEditable}}
+  <form.input
+    @name='address'
+    @type='url'
+    @value={{@model.address}}
+    @label={{t 'form.address.label'}}
+    @helperText={{t 'form.worker_address.help'}}
+    @disabled={{true}}
+    readonly={{true}}
+  />
+  {{#let
+    (relative-datetime-live @model.last_status_time)
+    (format-date @model.last_status_time format='yymmddt')
+    as |relativeDate customFormat|
+  }}
     <form.input
-      @name='address'
-      @type='url'
-      @value={{@model.address}}
-      @label={{t 'form.address.label'}}
-      @helperText={{t 'form.worker_address.help'}}
+      @name='last seen'
+      @type='datetime'
+      @value={{concat relativeDate ', ' customFormat}}
+      @label={{t 'form.worker_last_seen.label'}}
+      @helperText={{t 'form.worker_last_seen.help'}}
+      @disabled={{true}}
       readonly={{true}}
     />
-    {{#let
-      (relative-datetime-live @model.last_status_time)
-      (format-date @model.last_status_time format='yymmddt')
-      as |relativeDate customFormat|
-    }}
-      <form.input
-        @name='last seen'
-        @type='datetime'
-        @value={{concat relativeDate ', ' customFormat}}
-        @label={{t 'form.worker_last_seen.label'}}
-        @helperText={{t 'form.worker_last_seen.help'}}
-        readonly={{true}}
-      />
-    {{/let}}
-  {{/unless}}
+  {{/let}}
 
   {{#if (can 'save worker' @model)}}
     <form.actions