From 0691b57e403c25c443e109dde88ced41c46dbb93 Mon Sep 17 00:00:00 2001 From: Cameron Perera Date: Fri, 10 May 2024 13:03:43 -0500 Subject: [PATCH] Icu 11936 support node 20 stop support node 16 (#2282) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * chore: 🤖 remove .mdx format script in rose addon ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-11936 * chore: 🤖 deprecate use of node v16 and include node v20 ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-11936 * chore: 🤖 update github workflows to use node v18 ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-11936 * chore: 🤖 update workflows to use node v20 ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-11936 --- .github/workflows/build-admin-ui.yaml | 8 ++++---- .github/workflows/monorepo-validate.yaml | 8 ++++---- addons/api/package.json | 2 +- addons/auth/package.json | 2 +- addons/core/package.json | 2 +- addons/rose/package.json | 3 +-- package.json | 2 +- ui/admin/package.json | 2 +- ui/desktop/package.json | 2 +- 9 files changed, 15 insertions(+), 16 deletions(-) diff --git a/.github/workflows/build-admin-ui.yaml b/.github/workflows/build-admin-ui.yaml index f75a2cea7..1b0184cd4 100644 --- a/.github/workflows/build-admin-ui.yaml +++ b/.github/workflows/build-admin-ui.yaml @@ -21,7 +21,7 @@ jobs: node-modules- - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: - node-version: 16 + node-version: 20 - run: yarn install build-admin-ui-oss: name: Build Admin UI OSS @@ -39,7 +39,7 @@ jobs: - name: Build uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: - node-version: 16 + node-version: 20 - run: yarn run build:ui:admin:oss - name: Upload artifact admin-ui uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 @@ -67,7 +67,7 @@ jobs: - name: Build uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: - node-version: 16 + node-version: 20 - run: yarn run build:ui:admin:enterprise - name: Upload artifact enterprise admin UI uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 @@ -90,7 +90,7 @@ jobs: - name: Build uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: - node-version: 16 + node-version: 20 - run: yarn run build:ui:admin:hcp - name: Upload artifact HCP admin UI uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 diff --git a/.github/workflows/monorepo-validate.yaml b/.github/workflows/monorepo-validate.yaml index eb9c9ec53..c1ab43e2d 100644 --- a/.github/workflows/monorepo-validate.yaml +++ b/.github/workflows/monorepo-validate.yaml @@ -16,7 +16,7 @@ jobs: node-modules- - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: - node-version: 16 + node-version: 20 - run: yarn install compliance: @@ -34,7 +34,7 @@ jobs: node-modules- - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: - node-version: 16 + node-version: 20 - run: yarn run compliance:licenses lint: @@ -53,7 +53,7 @@ jobs: node-modules- - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: - node-version: 16 + node-version: 20 - run: yarn lint test: @@ -70,5 +70,5 @@ jobs: key: node-modules-${{ hashFiles('**/yarn.lock') }} - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: - node-version: 16 + node-version: 20 - run: yarn test diff --git a/addons/api/package.json b/addons/api/package.json index c335ade94..c0b7ec256 100644 --- a/addons/api/package.json +++ b/addons/api/package.json @@ -76,7 +76,7 @@ "ember-source": ">4.0.0" }, "engines": { - "node": "16.* || 18.*" + "node": "18.* || 20.*" }, "ember": { "edition": "octane" diff --git a/addons/auth/package.json b/addons/auth/package.json index f47e3404b..6ef810633 100644 --- a/addons/auth/package.json +++ b/addons/auth/package.json @@ -67,7 +67,7 @@ "webpack": "^5.78.0" }, "engines": { - "node": "16.* || 18.*" + "node": "18.* || 20.*" }, "ember": { "edition": "octane" diff --git a/addons/core/package.json b/addons/core/package.json index 981aae0bb..391382ab9 100644 --- a/addons/core/package.json +++ b/addons/core/package.json @@ -92,7 +92,7 @@ "lodash": "^4.17.21" }, "engines": { - "node": "16.* || 18.*" + "node": "18.* || 20.*" }, "ember": { "edition": "octane" diff --git a/addons/rose/package.json b/addons/rose/package.json index 0a14dd6a1..23a9a4285 100644 --- a/addons/rose/package.json +++ b/addons/rose/package.json @@ -21,7 +21,6 @@ "format": "concurrently \"npm:format:*\" --names \"format:\"", "format:hbs": "prettier --write '{addon,tests}/**/*.hbs'", "format:js": "prettier --write '{addon,app,config,stories,tests}/**/*.js' *.js", - "format:mdx": "prettier --write 'addon/**/*.mdx'", "format:sass": "prettier --write '{addon,app}/**/*.scss'", "start": "ember serve", "test": "ember exam --test-port 0 --split=4 --parallel=1 --random", @@ -103,7 +102,7 @@ "ember-source": "^4.0.0" }, "engines": { - "node": "16.* || 18.*" + "node": "18.* || 20.*" }, "ember": { "edition": "octane" diff --git a/package.json b/package.json index c40e89842..9fd9e2ffc 100755 --- a/package.json +++ b/package.json @@ -79,6 +79,6 @@ } }, "engines": { - "node": "16.* || 18.*" + "node": "18.* || 20.*" } } diff --git a/ui/admin/package.json b/ui/admin/package.json index 7717ab10a..179662b68 100644 --- a/ui/admin/package.json +++ b/ui/admin/package.json @@ -110,7 +110,7 @@ "webpack": "^5.78.0" }, "engines": { - "node": "16.* || 18.*" + "node": "18.* || 20.*" }, "ember": { "edition": "octane" diff --git a/ui/desktop/package.json b/ui/desktop/package.json index e01514639..603397061 100644 --- a/ui/desktop/package.json +++ b/ui/desktop/package.json @@ -120,7 +120,7 @@ "webpack": "^5.78.0" }, "engines": { - "node": "16.* || 18.*" + "node": "18.* || 20.*" }, "ember": { "edition": "octane"