From 0a674480b89f31a74113c9724c716666e7090bad Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Fri, 16 Oct 2020 10:21:30 -0400 Subject: [PATCH] =?UTF-8?q?chore:=20=F0=9F=A4=96=20dialog=20must=20have=20?= =?UTF-8?q?aria-describedby=20for=20header?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- addons/rose/addon/components/rose/dialog/index.hbs | 7 ++++++- addons/rose/addon/components/rose/dialog/index.js | 8 ++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/addons/rose/addon/components/rose/dialog/index.hbs b/addons/rose/addon/components/rose/dialog/index.hbs index e5ab02b7b..aa03d38de 100644 --- a/addons/rose/addon/components/rose/dialog/index.hbs +++ b/addons/rose/addon/components/rose/dialog/index.hbs @@ -5,10 +5,15 @@ ...attributes role="dialog" class="rose-dialog {{if @style (concat "rose-dialog-" @style)}} {{if @modal 'modal'}}" + id={{this.id}} + aria-describedby={{concat "dialog-header-" this.id}} {{focus-trap}} > -
+
{{#if @icon}} diff --git a/addons/rose/addon/components/rose/dialog/index.js b/addons/rose/addon/components/rose/dialog/index.js index 241ed5ba7..e152fcaf0 100644 --- a/addons/rose/addon/components/rose/dialog/index.js +++ b/addons/rose/addon/components/rose/dialog/index.js @@ -1,8 +1,16 @@ import Component from '@glimmer/component'; +import { generateComponentID } from '../../../utilities/component-auto-id'; import { action } from '@ember/object'; export default class RoseDialogComponent extends Component { + // =attributes + + /** + * @type {string} + */ + id = generateComponentID(); + // =methods /**