From 0adca934147cc9e389c708070616013536ee077b Mon Sep 17 00:00:00 2001 From: NatashaKab <133793701+NatashaKab@users.noreply.github.com> Date: Wed, 28 Jun 2023 18:05:36 -0400 Subject: [PATCH] Icu 9881 remove use of rose form textarea from admin UI (#1744) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * refactor: 💡 Changing rose textarea to hds --- .../components/form/account/oidc/index.hbs | 25 ++-- .../form/account/password/index.hbs | 25 ++-- .../form/auth-method/oidc/index.hbs | 51 ++++---- .../form/auth-method/password/index.hbs | 26 ++-- .../form/credential-store/static/index.hbs | 25 ++-- .../form/credential-store/vault/index.hbs | 113 +++++++++--------- .../components/form/credential/json/index.hbs | 22 ++-- .../form/credential/ssh_private_key/index.hbs | 46 +++---- .../credential/username_password/index.hbs | 23 ++-- ui/admin/app/components/form/group/index.hbs | 25 ++-- .../form/host-catalog/aws/index.hbs | 24 ++-- .../form/host-catalog/azure/index.hbs | 24 ++-- .../form/host-catalog/static/index.hbs | 25 ++-- .../components/form/host-set/aws/index.hbs | 25 ++-- .../components/form/host-set/azure/index.hbs | 54 ++++----- .../components/form/host-set/static/index.hbs | 25 ++-- .../app/components/form/host/static/index.hbs | 25 ++-- .../components/form/managed-group/index.hbs | 25 ++-- ui/admin/app/components/form/user/index.hbs | 25 ++-- ui/admin/app/components/form/worker/index.hbs | 24 ++-- .../credentials/create-test.js | 2 +- 21 files changed, 336 insertions(+), 323 deletions(-) diff --git a/ui/admin/app/components/form/account/oidc/index.hbs b/ui/admin/app/components/form/account/oidc/index.hbs index 108272215..706858b92 100644 --- a/ui/admin/app/components/form/account/oidc/index.hbs +++ b/ui/admin/app/components/form/account/oidc/index.hbs @@ -63,25 +63,24 @@ {{/if}} - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#if @model.isNew}} - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + - - {{t 'form.certificate.label'}} - - + {{#if @model.errors.idp_ca_certs}} + + {{#each @model.errors.idp_ca_certs as |error|}} + {{error.message}} + {{/each}} + + {{/if}} + - diff --git a/ui/admin/app/components/form/auth-method/password/index.hbs b/ui/admin/app/components/form/auth-method/password/index.hbs index 62f0ec96c..8970d3541 100644 --- a/ui/admin/app/components/form/auth-method/password/index.hbs +++ b/ui/admin/app/components/form/auth-method/password/index.hbs @@ -36,25 +36,25 @@ {{/if}} - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + + {{#if (can 'save model' @model)}} - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#if (feature-flag 'static-credentials')}} {{#if @model.isNew}} diff --git a/ui/admin/app/components/form/credential-store/vault/index.hbs b/ui/admin/app/components/form/credential-store/vault/index.hbs index a71880c6b..c1493a946 100644 --- a/ui/admin/app/components/form/credential-store/vault/index.hbs +++ b/ui/admin/app/components/form/credential-store/vault/index.hbs @@ -30,25 +30,24 @@ {{/if}} - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#if (feature-flag 'static-credentials')}} {{#if @model.isNew}} @@ -220,47 +219,51 @@ {{/if}} - + {{t + 'resources.credential-store.form.client_certificate.label' + }} + {{t + 'resources.credential-store.form.client_certificate.help' + }} {{#if @model.errors.client_certificate}} - + {{#each @model.errors.client_certificate as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + - + {{t + 'resources.credential-store.form.client_certificate_key.label' + }} + {{t + 'resources.credential-store.form.client_certificate_key.help' + }} {{#if @model.errors.client_certificate_key}} - + {{#each @model.errors.client_certificate_key as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#unless @model.isNew}} {{/unless}} - + {{t 'resources.credential-store.form.ca_cert.label'}} + {{t + 'resources.credential-store.form.ca_cert.help' + }} {{#if @model.errors.ca_cert}} - + {{#each @model.errors.ca_cert as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + + {{#if (can 'save model' @model)}} - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#if @model.isNew}} diff --git a/ui/admin/app/components/form/credential/ssh_private_key/index.hbs b/ui/admin/app/components/form/credential/ssh_private_key/index.hbs index dd12f33bd..6f06ef732 100644 --- a/ui/admin/app/components/form/credential/ssh_private_key/index.hbs +++ b/ui/admin/app/components/form/credential/ssh_private_key/index.hbs @@ -28,22 +28,24 @@ {{/if}} - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#if @model.isNew}} {{t 'form.type.label'}} @@ -95,22 +97,26 @@ {{#if (or @model.isNew form.isEditable)}} - + {{t 'resources.credential.form.private_key.label'}} + {{t + 'resources.credential.form.private_key.help' + }} {{#if @model.errors.private_key}} - + {{#each @model.errors.private_key as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{/if}} - - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#if @model.isNew}} {{t 'form.type.label'}} diff --git a/ui/admin/app/components/form/group/index.hbs b/ui/admin/app/components/form/group/index.hbs index bc328317d..9dda5c39d 100644 --- a/ui/admin/app/components/form/group/index.hbs +++ b/ui/admin/app/components/form/group/index.hbs @@ -30,25 +30,24 @@ {{/if}} - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#if (can 'save model' @model)}} - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#if @model.isNew}} diff --git a/ui/admin/app/components/form/host-catalog/azure/index.hbs b/ui/admin/app/components/form/host-catalog/azure/index.hbs index 238a3e334..697a7b385 100644 --- a/ui/admin/app/components/form/host-catalog/azure/index.hbs +++ b/ui/admin/app/components/form/host-catalog/azure/index.hbs @@ -29,24 +29,24 @@ {{/if}} - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#if @model.isNew}} diff --git a/ui/admin/app/components/form/host-catalog/static/index.hbs b/ui/admin/app/components/form/host-catalog/static/index.hbs index 23bed2624..e0a1dc1a8 100644 --- a/ui/admin/app/components/form/host-catalog/static/index.hbs +++ b/ui/admin/app/components/form/host-catalog/static/index.hbs @@ -30,25 +30,24 @@ {{/if}} - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#if @model.isNew}} diff --git a/ui/admin/app/components/form/host-set/aws/index.hbs b/ui/admin/app/components/form/host-set/aws/index.hbs index 28e99317b..52616e421 100644 --- a/ui/admin/app/components/form/host-set/aws/index.hbs +++ b/ui/admin/app/components/form/host-set/aws/index.hbs @@ -31,25 +31,24 @@ {{/if}} - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + - + {{t 'resources.host-set.form.filter.label'}} + {{t + 'resources.host-set.form.filter.azure.help' + }} {{#if @model.errors.filter_string}} - + {{#each @model.errors.filter_string as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + + - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#if (can 'save model' @model)}} - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + {{#if (can 'save model' @model)}} - + {{t 'form.description.label'}} + {{t 'form.description.help'}} {{#if @model.errors.description}} - + {{#each @model.errors.description as |error|}} - {{error.message}} + {{error.message}} {{/each}} - + {{/if}} - + <:title>{{t 'resources.worker.form.worker_tags.label'}} <:description>{{t 'resources.worker.form.worker_tags.help'}} diff --git a/ui/admin/tests/acceptance/credential-store/credentials/create-test.js b/ui/admin/tests/acceptance/credential-store/credentials/create-test.js index 67133fb92..ff4529c69 100644 --- a/ui/admin/tests/acceptance/credential-store/credentials/create-test.js +++ b/ui/admin/tests/acceptance/credential-store/credentials/create-test.js @@ -280,7 +280,7 @@ module( .dom('.rose-notification-body') .hasText('Error in provided request.'); assert - .dom('.rose-form-error-message') + .dom('.hds-form-error__message') .hasText('Field required for creating a username-key-pair credential.'); });