fix: 🐛 modal bubbling up when user has not updated model (#2227)
✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13106
This commit is contained in:
1 parent
c8839d6db1
commit
0b4fd6765e
2 files changed
+6
-6
No files matched your search
@@ -4,7 +4,11 @@
|
|||||||
}}
|
}}
|
||||||
|
|
||||||
<Rose::Dropdown
|
<Rose::Dropdown
|
||||||
@text={{this.scope.org.displayName}}
|
@text={{if
|
||||||
|
this.scope.org.isGlobal
|
||||||
|
(t 'titles.global')
|
||||||
|
this.scope.org.displayName
|
||||||
|
}}
|
||||||
@icon={{if
|
@icon={{if
|
||||||
this.scope.org.isGlobal
|
this.scope.org.isGlobal
|
||||||
'flight-icons/svg/globe-16'
|
'flight-icons/svg/globe-16'
|
||||||
|
|||||||
@@ -33,17 +33,13 @@ export default class ScopesScopeRoute extends Route {
|
|||||||
* @param {string} params.scope_id
|
* @param {string} params.scope_id
|
||||||
* @return {Promise{ScopeModel}}
|
* @return {Promise{ScopeModel}}
|
||||||
*/
|
*/
|
||||||
model({ scope_id: id }) {
|
async model({ scope_id: id }) {
|
||||||
// Since only global and org scopes are authenticatable, we can infer type
|
// Since only global and org scopes are authenticatable, we can infer type
|
||||||
// from ID because global has a fixed ID.
|
// from ID because global has a fixed ID.
|
||||||
const type = id === 'global' ? 'global' : 'org';
|
const type = id === 'global' ? 'global' : 'org';
|
||||||
return this.store.findRecord('scope', id).catch(() => {
|
return this.store.findRecord('scope', id).catch(() => {
|
||||||
const maybeExistingScope = this.store.peekRecord('scope', id);
|
const maybeExistingScope = this.store.peekRecord('scope', id);
|
||||||
const scopeOptions = { id, type };
|
const scopeOptions = { id, type };
|
||||||
/* istanbul ignore else */
|
|
||||||
if (type === 'global') {
|
|
||||||
scopeOptions.name = this.intl.t('titles.global');
|
|
||||||
}
|
|
||||||
return (
|
return (
|
||||||
maybeExistingScope || this.store.createRecord('scope', scopeOptions)
|
maybeExistingScope || this.store.createRecord('scope', scopeOptions)
|
||||||
);
|
);
|
||||||
|
|||||||
Reference in new issue
Block a user