Upgrade api to ember 4.12 (#1833) (#1839)

* chore: 🤖 Upgrade API layer to ember 4.12

* chore: 🤖 Upgrade ember-data to 4.12

* fix: 🐛 Fix breaking change from usage of internal method

* chore: 🤖 Remove stylelint in API addon

* test: 💍 Fix broken API tests

* chore: 🤖 get rid of toArray

* test: 💍 Fix tests broken by ember data changes

---------

Co-authored-by: dharini <dharini@hashicorp.com>
This commit is contained in:
Zhihe Lianddharini authored and GitHub committed 2023-08-14 17:03:59 -04:00
1 parent 77b47e2cb3
commit 0e9042f588
21 files changed
+1338 -284

No files matched your search

@@ -3,7 +3,7 @@
"packages": [
{
"name": "ember-cli",
"version": "4.4.1",
"version": "4.12.1",
"blueprints": [
{
"name": "addon",
@@ -0,0 +1,66 @@
/**
* Copyright (c) HashiCorp, Inc.
* SPDX-License-Identifier: MPL-2.0
*/
'use strict';
const getChannelURL = require('ember-source-channel-url');
const { embroiderSafe, embroiderOptimized } = require('@embroider/test-setup');
module.exports = async function () {
return {
scenarios: [
{
name: 'ember-lts-4.4',
npm: {
devDependencies: {
'ember-source': '~4.4.0',
},
},
},
{
name: 'ember-lts-4.8',
npm: {
devDependencies: {
'ember-source': '~4.8.0',
},
},
},
{
name: 'ember-lts-4.4',
npm: {
devDependencies: {
'ember-source': '~4.4.0',
},
},
},
{
name: 'ember-release',
npm: {
devDependencies: {
'ember-source': await getChannelURL('release'),
},
},
},
{
name: 'ember-beta',
npm: {
devDependencies: {
'ember-source': await getChannelURL('beta'),
},
},
},
{
name: 'ember-canary',
npm: {
devDependencies: {
'ember-source': await getChannelURL('canary'),
},
},
},
embroiderSafe(),
embroiderOptimized(),
],
};
};
+2 -5
View File
@@ -6,20 +6,17 @@
'use strict';
module.exports = function (environment) {
let ENV = {
const ENV = {
modulePrefix: 'dummy',
environment,
rootURL: '/',
locationType: 'history',
EmberENV: {
EXTEND_PROTOTYPES: false,
FEATURES: {
// Here you can enable experimental features on an ember canary build
// e.g. EMBER_NATIVE_DECORATOR_SUPPORT: true
},
EXTEND_PROTOTYPES: {
// Prevent Ember Data from overriding Date.parse.
Date: false,
},
},
APP: {
+8 -10
View File
@@ -85,7 +85,7 @@ module('Unit | Model | base', function (hooks) {
});
this.server.patch('/v1/users/1', () => {
assert.ok(true, 'Correctly scoped update record URL was requested.');
return {};
return { id: 1 };
});
const model = store.peekRecord('user', '1');
assert.false(model.canSave);
@@ -117,19 +117,18 @@ module('Unit | Model | base', function (hooks) {
const model = store.createRecord('user', { scopeID: 'o_123' });
this.server.post('/v1/users', () => {
assert.ok(true, 'Correctly scoped create record URL was requested.');
return {};
return { id: 'u_123' };
});
await model.save();
this.server.patch('/v1/users', () => {
this.server.patch('/v1/users/u_123', () => {
assert.ok(true, 'Correctly scoped update record URL was requested.');
return {};
return { id: 'u_123' };
});
await model.save();
this.server.delete('/v1/users/u_123', () => {
assert.ok(true, 'Correctly scoped delete record URL was requested.');
return {};
});
model.id = 'u_123';
await model.destroyRecord();
});
@@ -141,19 +140,18 @@ module('Unit | Model | base', function (hooks) {
const model = store.createRecord('user', { scope });
this.server.post('/v1/users', () => {
assert.ok(true, 'Correctly scoped create record URL was requested.');
return {};
return { id: 'u_123' };
});
await model.save({ adapterOptions: { scopeID: customScopeID } });
this.server.patch('/v1/users', () => {
this.server.patch('/v1/users/u_123', () => {
assert.ok(true, 'Correctly scoped update record URL was requested.');
return {};
return { id: 'u_123' };
});
await model.save({ adapterOptions: { scopeID: customScopeID } });
this.server.delete('/v1/users/u_123', () => {
assert.ok(true, 'Correctly scoped delete record URL was requested.');
return {};
});
model.id = 'u_123';
await model.destroyRecord({ adapterOptions: { scopeID: customScopeID } });
});
@@ -165,7 +163,7 @@ module('Unit | Model | base', function (hooks) {
const model = store.createRecord('user', { scope });
this.server.post(`/v1/users:${method}`, () => {
assert.ok(true, 'Correctly scoped create record URL was requested.');
return {};
return { id: 'u_123' };
});
await model.save({ adapterOptions: { method } });
});