From 10c128ee3baf695e350679f82122ef0cfb8cdd8a Mon Sep 17 00:00:00 2001 From: Zhihe Li Date: Fri, 19 Jul 2024 16:53:50 -0400 Subject: [PATCH] =?UTF-8?q?feat:=20=F0=9F=8E=B8=20Add=20debug=20logging=20?= =?UTF-8?q?for=20search=20times=20(#2406)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- ui/desktop/electron-app/src/index.js | 1 + .../src/services/cache-daemon-manager.js | 20 ++++++++++++++++--- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/ui/desktop/electron-app/src/index.js b/ui/desktop/electron-app/src/index.js index dbcaf1a98..5ad542280 100644 --- a/ui/desktop/electron-app/src/index.js +++ b/ui/desktop/electron-app/src/index.js @@ -61,6 +61,7 @@ fixPath(); // Setup logger log.initialize(); log.transports.console.level = false; +log.transports.file.level = process.env.BOUNDARY_DESKTOP_LOG_LEVEL ?? 'info'; log.transports.file.format = '[{y}-{m}-{d}T{h}:{i}:{s}.{ms}{z}] [{level}] {text}'; log.transports.file.fileName = 'desktop-client.log'; diff --git a/ui/desktop/electron-app/src/services/cache-daemon-manager.js b/ui/desktop/electron-app/src/services/cache-daemon-manager.js index 108ac84fd..e30b54bcf 100644 --- a/ui/desktop/electron-app/src/services/cache-daemon-manager.js +++ b/ui/desktop/electron-app/src/services/cache-daemon-manager.js @@ -117,9 +117,18 @@ class CacheDaemonManager { return generateErrorPromise(stderr); } - search(requestData) { + async search(requestData) { + const start = Date.now(); + // Log request data, but clean up token from log + const { auth_token_id, token, ...logRequestData } = requestData; + if (isWindows()) { - return searchCliCommand(requestData); + const result = await searchCliCommand(requestData); + + const end = Date.now(); + log.debug(`Search request took ${end - start} ms`, logRequestData); + + return result; } delete requestData.token; @@ -130,7 +139,12 @@ class CacheDaemonManager { path: `http://internal.boundary.local/v1/search?${queryString.toString()}`, socketPath: this.#socketPath, }; - return unixSocketRequest(request); + + const result = await unixSocketRequest(request); + const end = Date.now(); + log.debug(`Search request took ${end - start} ms`, logRequestData); + + return result; } }