From 80d6eda2283ec3b305464bdbeaf269aa46dbff89 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Wed, 24 Feb 2021 10:49:19 -0500 Subject: [PATCH 1/4] =?UTF-8?q?style:=20=F0=9F=92=84=20scroll=20only=20wit?= =?UTF-8?q?hin=20columns=20so=20header=20remains=20visible?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- ui/desktop/app/styles/app.scss | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/ui/desktop/app/styles/app.scss b/ui/desktop/app/styles/app.scss index d361d91f6..be3610b51 100644 --- a/ui/desktop/app/styles/app.scss +++ b/ui/desktop/app/styles/app.scss @@ -19,6 +19,25 @@ } } +/** + * This section enables scrolling within the sidebar columns separately, + * rather than the whole viewport. This ensures the sidebar and application + * header remain visible when scrolling. + */ +.rose-layout-global { + max-height: 100vh; + + .rose-layout-global-body { + max-height: 100vh; + overflow: hidden; + } + + .rose-layout-sidebar-sidebar, + .rose-layout-sidebar-body { + overflow-y: scroll; + } +} + .rose-nav-sidebar { margin-top: sizing.rems(xxl); @@ -167,7 +186,7 @@ 0% { background-color: var(--action-subtler-1); } - + 100% { background-color: transparent; } From d61faa93383f2312831544e40225613f97b09585 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Wed, 24 Feb 2021 10:50:32 -0500 Subject: [PATCH 2/4] docs: add scrolling changelog entry --- ui/desktop/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/desktop/CHANGELOG.md b/ui/desktop/CHANGELOG.md index cee2b0afe..c4a85ba0a 100644 --- a/ui/desktop/CHANGELOG.md +++ b/ui/desktop/CHANGELOG.md @@ -7,6 +7,7 @@ Canonical reference for changes, improvements, and bugfixes for Boundary Desktop ### Changes/Deprecations +- Scrolling now occurs within columns individually so that sidebar and header remain visible when scrolling the application body. - Boundary origin validation now occurs via Electron's built-in net request module, ensuring the validation request is made via chromium's networking library rather than Node's. ([PR](https://github.com/hashicorp/boundary-ui/pull/480)) ## v1.0.0-alpha (2021.02.16) From 32b64106185b85404f3bc1fdb26ad6ab5290f226 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Wed, 24 Feb 2021 10:52:08 -0500 Subject: [PATCH 3/4] docs: add changelog PR link --- ui/desktop/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/desktop/CHANGELOG.md b/ui/desktop/CHANGELOG.md index c4a85ba0a..a781b57db 100644 --- a/ui/desktop/CHANGELOG.md +++ b/ui/desktop/CHANGELOG.md @@ -7,7 +7,7 @@ Canonical reference for changes, improvements, and bugfixes for Boundary Desktop ### Changes/Deprecations -- Scrolling now occurs within columns individually so that sidebar and header remain visible when scrolling the application body. +- Scrolling now occurs within columns individually so that sidebar and header remain visible when scrolling the application body. ([PR](https://github.com/hashicorp/boundary-ui/pull/482)) - Boundary origin validation now occurs via Electron's built-in net request module, ensuring the validation request is made via chromium's networking library rather than Node's. ([PR](https://github.com/hashicorp/boundary-ui/pull/480)) ## v1.0.0-alpha (2021.02.16) From 9dfb07e1cd5b73d094456dee2bfb350311d6e74b Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Wed, 24 Feb 2021 10:53:17 -0500 Subject: [PATCH 4/4] docs: move scrolling changelog entry to new and improved section --- ui/desktop/CHANGELOG.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/desktop/CHANGELOG.md b/ui/desktop/CHANGELOG.md index a781b57db..6491ca19a 100644 --- a/ui/desktop/CHANGELOG.md +++ b/ui/desktop/CHANGELOG.md @@ -5,9 +5,12 @@ Canonical reference for changes, improvements, and bugfixes for Boundary Desktop ## Next -### Changes/Deprecations +### New & Improved - Scrolling now occurs within columns individually so that sidebar and header remain visible when scrolling the application body. ([PR](https://github.com/hashicorp/boundary-ui/pull/482)) + +### Changes/Deprecations + - Boundary origin validation now occurs via Electron's built-in net request module, ensuring the validation request is made via chromium's networking library rather than Node's. ([PR](https://github.com/hashicorp/boundary-ui/pull/480)) ## v1.0.0-alpha (2021.02.16)