From 12b18510b9159e9a69cdfae38285668b2dc1011b Mon Sep 17 00:00:00 2001 From: Cameron Perera Date: Mon, 16 May 2022 17:28:45 -0500 Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20Update=20language=20?= =?UTF-8?q?to=20use=20Sign=20In=20and=20Sign=20Out=20(#1109)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * refactor: 💡 Update language to use Sign In and Sign Out Update authenticate/deauthenticate language to sign in and sign out respectively ✅ Closes: ICU-3941 * refactor: 💡 Change translation keys back to (de)authenticate Co-authored-by: Dharini Jeeva --- .../core/tests/integration/components/error/message-test.js | 2 +- addons/core/translations/actions/en-us.yaml | 4 ++-- addons/core/translations/errors/en-us.yaml | 2 +- ui/desktop/tests/acceptance/authentication-test.js | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/addons/core/tests/integration/components/error/message-test.js b/addons/core/tests/integration/components/error/message-test.js index a28f3c618..45194503b 100644 --- a/addons/core/tests/integration/components/error/message-test.js +++ b/addons/core/tests/integration/components/error/message-test.js @@ -18,7 +18,7 @@ module('Integration | Component | error/message', function (hooks) { ); assert.equal( find('.rose-message-description').textContent.trim(), - 'You are not authenticated. Please authenticate and try again later.' + 'You are not signed in. Please sign in and try again later.' ); await render(hbs``); assert.equal( diff --git a/addons/core/translations/actions/en-us.yaml b/addons/core/translations/actions/en-us.yaml index 2bdd086cd..cce2d9ea4 100644 --- a/addons/core/translations/actions/en-us.yaml +++ b/addons/core/translations/actions/en-us.yaml @@ -17,8 +17,8 @@ retry: Retry get-topic-help: Get help for this topic copy-to-clipboard: Copy to Clipboard copy-error-detail-to-clipboard: Copy error detail to clipboard -authenticate: Authenticate -deauthenticate: Deauthenticate +authenticate: Sign In +deauthenticate: Sign Out choose-org: Choose Scope choose-different-org: Choose a different scope add-host-set: Create Host Set diff --git a/addons/core/translations/errors/en-us.yaml b/addons/core/translations/errors/en-us.yaml index 0f05b94a7..eaaac2f20 100644 --- a/addons/core/translations/errors/en-us.yaml +++ b/addons/core/translations/errors/en-us.yaml @@ -1,6 +1,6 @@ 401: title: You are not signed in - description: You are not authenticated. Please authenticate and try again later. + description: You are not signed in. Please sign in and try again later. 403: title: You are not authorized description: You must be granted permissions to view this data. Ask your administrator if you think you should have access. diff --git a/ui/desktop/tests/acceptance/authentication-test.js b/ui/desktop/tests/acceptance/authentication-test.js index 1869e1de3..bc48a1f33 100644 --- a/ui/desktop/tests/acceptance/authentication-test.js +++ b/ui/desktop/tests/acceptance/authentication-test.js @@ -179,7 +179,7 @@ module('Acceptance | authentication', function (hooks) { assert.equal(currentURL(), urls.origin); }); - test('deauthentication redirects to first global authenticate method', async function (assert) { + test('signing out redirects to first global authenticate method', async function (assert) { assert.expect(3); await visit(urls.authenticate.methods.global); await fillIn('[name="identification"]', 'test'); @@ -191,7 +191,7 @@ module('Acceptance | authentication', function (hooks) { find( '.rose-header-utilities .rose-dropdown-content button' ).textContent.trim(), - 'Deauthenticate' + 'Sign Out' ); await click('.rose-header-utilities .rose-dropdown-content button'); assert.notOk(currentSession().isAuthenticated);