From 4328b4c6dadf6609a1b32ccb8154b90fdbc43622 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Wed, 27 Oct 2021 17:23:18 -0400 Subject: [PATCH 1/4] tweak filter i18n label --- addons/core/translations/actions/en-us.yaml | 2 -- ui/admin/app/templates/scopes/scope/sessions/index.hbs | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/addons/core/translations/actions/en-us.yaml b/addons/core/translations/actions/en-us.yaml index 49cd11a23..144ced636 100644 --- a/addons/core/translations/actions/en-us.yaml +++ b/addons/core/translations/actions/en-us.yaml @@ -35,5 +35,3 @@ close: Close toggle-secret: Toggle secret visibility minimize: Minimize fullscreen: Fullscreen -filter: - status: status diff --git a/ui/admin/app/templates/scopes/scope/sessions/index.hbs b/ui/admin/app/templates/scopes/scope/sessions/index.hbs index c3653a062..e3fa0e32b 100644 --- a/ui/admin/app/templates/scopes/scope/sessions/index.hbs +++ b/ui/admin/app/templates/scopes/scope/sessions/index.hbs @@ -19,7 +19,7 @@ @@ -125,4 +125,4 @@ - \ No newline at end of file + From ca03aca886201ad0c6c5b2eedc96d48c29f3463f Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Wed, 27 Oct 2021 17:35:00 -0400 Subject: [PATCH 2/4] =?UTF-8?q?chore:=20=F0=9F=A4=96=20tweak=20tests=20and?= =?UTF-8?q?=20remove=20unused=20class=20file?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- addons/rose/addon/components/rose/toolbar/index.js | 8 -------- .../tests/integration/components/rose/toolbar-test.js | 3 ++- ui/admin/app/templates/scopes/scope/sessions/index.hbs | 2 +- 3 files changed, 3 insertions(+), 10 deletions(-) delete mode 100644 addons/rose/addon/components/rose/toolbar/index.js diff --git a/addons/rose/addon/components/rose/toolbar/index.js b/addons/rose/addon/components/rose/toolbar/index.js deleted file mode 100644 index 1ae2378ca..000000000 --- a/addons/rose/addon/components/rose/toolbar/index.js +++ /dev/null @@ -1,8 +0,0 @@ -import Component from '@glimmer/component'; -import { generateComponentID } from '../../../utilities/component-auto-id'; - -export default class RoseToolbarComponent extends Component { - // =attributes - - id = generateComponentID(); -} diff --git a/addons/rose/tests/integration/components/rose/toolbar-test.js b/addons/rose/tests/integration/components/rose/toolbar-test.js index 3a9166ef7..9c91e6c7a 100644 --- a/addons/rose/tests/integration/components/rose/toolbar-test.js +++ b/addons/rose/tests/integration/components/rose/toolbar-test.js @@ -7,12 +7,13 @@ module('Integration | Component | rose/toolbar', function (hooks) { setupRenderingTest(hooks); test('it renders', async function (assert) { + assert.expect(1); await render(hbs``); - assert.ok(find('div')); assert.ok(find('.rose-toolbar')); }); test('it renders with attributes', async function (assert) { + assert.expect(1); await render(hbs``); assert.ok(find('#toolbar')); }); diff --git a/ui/admin/app/templates/scopes/scope/sessions/index.hbs b/ui/admin/app/templates/scopes/scope/sessions/index.hbs index e3fa0e32b..31f079f2e 100644 --- a/ui/admin/app/templates/scopes/scope/sessions/index.hbs +++ b/ui/admin/app/templates/scopes/scope/sessions/index.hbs @@ -125,4 +125,4 @@ - + \ No newline at end of file From 324c5dd98cde9183ffaa9c2ed4659ae02b8a2844 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Thu, 28 Oct 2021 11:53:31 -0400 Subject: [PATCH 3/4] chore: fix formatting and update yarn lock --- .../app/templates/scopes/scope/sessions/index.hbs | 2 +- yarn.lock | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ui/admin/app/templates/scopes/scope/sessions/index.hbs b/ui/admin/app/templates/scopes/scope/sessions/index.hbs index e6714ecef..31f079f2e 100644 --- a/ui/admin/app/templates/scopes/scope/sessions/index.hbs +++ b/ui/admin/app/templates/scopes/scope/sessions/index.hbs @@ -17,7 +17,7 @@ {{#if @model}} {{#if (feature-flag 'filter')}} - + Date: Thu, 28 Oct 2021 12:46:56 -0400 Subject: [PATCH 4/4] chore: linting --- ui/admin/app/templates/scopes/scope/sessions/index.hbs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/admin/app/templates/scopes/scope/sessions/index.hbs b/ui/admin/app/templates/scopes/scope/sessions/index.hbs index e3fa0e32b..31f079f2e 100644 --- a/ui/admin/app/templates/scopes/scope/sessions/index.hbs +++ b/ui/admin/app/templates/scopes/scope/sessions/index.hbs @@ -125,4 +125,4 @@ - + \ No newline at end of file