From 1c774aa7836a26fe43a029e4bbaea2c38496bed2 Mon Sep 17 00:00:00 2001 From: Lauren Date: Thu, 15 May 2025 13:01:58 -0400 Subject: [PATCH] [Retire] Rose::Form::Label (#2815) * remove rose::form::label integration test * update label on fieldset element to ref .hds-form-label * remove file _label.scss * remove import * delete components/rose/form/label/index.hbs * remove styling from app.scss --- .../components/rose/form/label/index.hbs | 8 ------ addons/rose/app/components/rose/form/label.js | 6 ----- .../styles/rose/components/form/_index.scss | 1 - .../styles/rose/components/form/_label.scss | 18 ------------- .../components/rose/form/label-test.js | 26 ------------------- ui/desktop/app/styles/app.scss | 4 --- 6 files changed, 63 deletions(-) delete mode 100644 addons/rose/addon/components/rose/form/label/index.hbs delete mode 100644 addons/rose/app/components/rose/form/label.js delete mode 100644 addons/rose/app/styles/rose/components/form/_label.scss delete mode 100644 addons/rose/tests/integration/components/rose/form/label-test.js diff --git a/addons/rose/addon/components/rose/form/label/index.hbs b/addons/rose/addon/components/rose/form/label/index.hbs deleted file mode 100644 index a218960a9..000000000 --- a/addons/rose/addon/components/rose/form/label/index.hbs +++ /dev/null @@ -1,8 +0,0 @@ -{{! - Copyright (c) HashiCorp, Inc. - SPDX-License-Identifier: BUSL-1.1 -}} - - \ No newline at end of file diff --git a/addons/rose/app/components/rose/form/label.js b/addons/rose/app/components/rose/form/label.js deleted file mode 100644 index 432dcfebb..000000000 --- a/addons/rose/app/components/rose/form/label.js +++ /dev/null @@ -1,6 +0,0 @@ -/** - * Copyright (c) HashiCorp, Inc. - * SPDX-License-Identifier: BUSL-1.1 - */ - -export { default } from 'rose/components/rose/form/label'; diff --git a/addons/rose/app/styles/rose/components/form/_index.scss b/addons/rose/app/styles/rose/components/form/_index.scss index 3d337b426..1af7ea57c 100644 --- a/addons/rose/app/styles/rose/components/form/_index.scss +++ b/addons/rose/app/styles/rose/components/form/_index.scss @@ -3,7 +3,6 @@ * SPDX-License-Identifier: BUSL-1.1 */ -@use 'label'; @use 'errors'; @use 'helper-text'; @use 'checkbox'; diff --git a/addons/rose/app/styles/rose/components/form/_label.scss b/addons/rose/app/styles/rose/components/form/_label.scss deleted file mode 100644 index bd3105c7e..000000000 --- a/addons/rose/app/styles/rose/components/form/_label.scss +++ /dev/null @@ -1,18 +0,0 @@ -/** - * Copyright (c) HashiCorp, Inc. - * SPDX-License-Identifier: BUSL-1.1 - */ - -@use '../../variables/sizing'; -@use '../../utilities/type'; - -.rose-form-label { - @include type.type(s, semibold); - - display: block; - margin-bottom: sizing.rems(xxs); - - &.error { - color: var(--failure); - } -} diff --git a/addons/rose/tests/integration/components/rose/form/label-test.js b/addons/rose/tests/integration/components/rose/form/label-test.js deleted file mode 100644 index a16c0a4a2..000000000 --- a/addons/rose/tests/integration/components/rose/form/label-test.js +++ /dev/null @@ -1,26 +0,0 @@ -/** - * Copyright (c) HashiCorp, Inc. - * SPDX-License-Identifier: BUSL-1.1 - */ - -import { module, test } from 'qunit'; -import { setupRenderingTest } from 'ember-qunit'; -import { render, find } from '@ember/test-helpers'; -import { hbs } from 'ember-cli-htmlbars'; - -module('Integration | Component | rose/form/label', function (hooks) { - setupRenderingTest(hooks); - - test('it renders', async function (assert) { - await render(hbs` - - Form Label - - `); - assert.ok(find('.rose-form-label')); - assert.strictEqual( - find('.rose-form-label').textContent.trim(), - 'Form Label', - ); - }); -}); diff --git a/ui/desktop/app/styles/app.scss b/ui/desktop/app/styles/app.scss index f61de4b54..63766f819 100644 --- a/ui/desktop/app/styles/app.scss +++ b/ui/desktop/app/styles/app.scss @@ -94,10 +94,6 @@ fieldset { margin-bottom: sizing.rems(m); - - legend { - @extend .rose-form-label; - } } }