From 1dcfc67e0a4cf04ee59387f506cef544489d3558 Mon Sep 17 00:00:00 2001 From: dharini Date: Wed, 16 Feb 2022 13:47:02 -0800 Subject: [PATCH] remove attr from input --- addons/rose/addon/components/rose/form/input/index.hbs | 2 -- .../rose/addon/components/rose/form/input/index.stories.mdx | 4 ---- addons/rose/addon/components/rose/form/input/input/index.hbs | 1 - ui/admin/app/components/form/host-set/aws/index.hbs | 4 ++-- ui/admin/app/components/form/host-set/azure/index.hbs | 4 ++-- 5 files changed, 4 insertions(+), 11 deletions(-) diff --git a/addons/rose/addon/components/rose/form/input/index.hbs b/addons/rose/addon/components/rose/form/input/index.hbs index 96bf0330d..524523bbb 100644 --- a/addons/rose/addon/components/rose/form/input/index.hbs +++ b/addons/rose/addon/components/rose/form/input/index.hbs @@ -15,7 +15,6 @@ type=@type disabled=@disabled error=@error - placeholder=@placeholder aria-describedby=(concat (if @helperText (concat 'helper-text-' this.id)) (if @error (concat ' errors-' this.id))) ) errors=(component 'rose/form/errors' @@ -49,7 +48,6 @@ @type={{@type}} @disabled={{@disabled}} @error={{@error}} - @placeholder={{@placeholder}} @aria-describedby="{{if @helperText (concat 'helper-text-' this.id)}} {{if @error (concat 'errors-' this.id)}}" /> {{yield (hash diff --git a/addons/rose/addon/components/rose/form/input/index.stories.mdx b/addons/rose/addon/components/rose/form/input/index.stories.mdx index e84eab87b..4dbe35b58 100644 --- a/addons/rose/addon/components/rose/form/input/index.stories.mdx +++ b/addons/rose/addon/components/rose/form/input/index.stories.mdx @@ -22,7 +22,6 @@ Renders a simple form input. @disabled={{false}} @icon='flight-icons/svg/search-16' readonly={{false}} - placeholder='this is a placeholder' /> ``` @@ -41,7 +40,6 @@ Or a fully contextual component without a wrapper, for maximum flexibility. @error={{false}} @disabled={{false}} readonly={{false}} - placeholder='la la la' > @@ -62,7 +60,6 @@ Or a fully contextual component without a wrapper, for maximum flexibility. @disabled={{disabled}} readonly={{read-only}} @icon={{icon}} - placeholder={{placeholder}} /> `, context: { @@ -78,7 +75,6 @@ Or a fully contextual component without a wrapper, for maximum flexibility. ), value: text('value', 'Value'), label: text('label', 'Label'), - placeholder: text('placeholder', 'this is a placeholder'), helperText: text('helperText', 'Helper text'), link: text('link', 'link goes here'), linkText: text('linkText', 'link text'), diff --git a/addons/rose/addon/components/rose/form/input/input/index.hbs b/addons/rose/addon/components/rose/form/input/input/index.hbs index 802feeea7..95e81a114 100644 --- a/addons/rose/addon/components/rose/form/input/input/index.hbs +++ b/addons/rose/addon/components/rose/form/input/input/index.hbs @@ -6,5 +6,4 @@ name={{@name}} @type={{@type}} @value={{@value}} - placeholder={{@placeholder}} aria-describedby={{@aria-describedby}} /> diff --git a/ui/admin/app/components/form/host-set/aws/index.hbs b/ui/admin/app/components/form/host-set/aws/index.hbs index 79782093e..3d7b974ab 100644 --- a/ui/admin/app/components/form/host-set/aws/index.hbs +++ b/ui/admin/app/components/form/host-set/aws/index.hbs @@ -103,7 +103,7 @@ @value={{endpoint.value}} @error={{@model.errors.preferred_endpoints}} @contextual={{true}} - @placeholder='cidr:2001:4860:4860::8888/32' + placeholder='cidr:2001:4860:4860::8888/32' as |field| > @@ -132,7 +132,7 @@ diff --git a/ui/admin/app/components/form/host-set/azure/index.hbs b/ui/admin/app/components/form/host-set/azure/index.hbs index b31f8e7df..866577b7d 100644 --- a/ui/admin/app/components/form/host-set/azure/index.hbs +++ b/ui/admin/app/components/form/host-set/azure/index.hbs @@ -103,7 +103,7 @@ @value={{endpoint.value}} @error={{@model.errors.preferred_endpoints}} @contextual={{true}} - @placeholder='cidr:2001:4860:4860::8888/32' + placeholder='cidr:2001:4860:4860::8888/32' as |field| > @@ -132,7 +132,7 @@