From 1f4076d8d495bca1f925977e57401f1aaf1760a2 Mon Sep 17 00:00:00 2001
From: hashicc <191911133+hashicc@users.noreply.github.com>
Date: Wed, 6 Aug 2025 10:55:26 -0700
Subject: [PATCH] (HACK WEEK 2025) Upload a11y reports in ci (#2949)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* ci: 🎡 consolidate ember a11y reports and upload as gh artifact

* ci: 🎡 Bump test timeout for a11y tests

* chore: 🤖 run a11y tests in parallel

* chore: 🤖 only run a11y audit against acceptance tests

* chore: 🤖 restore ember test in place of ember exam

testing whether or not ember test hangs with three tests timing out like
ember exam does

* ci: 🎡 output a11y reports filtered down in ci

* ci: 🎡 attempt to fix shell exit code for a11y test failures

* ci: 🎡 add step names for outputting a11y test report summary
---
 .github/workflows/a11y-tests.yaml | 31 +++++++++++++++++++++++++++++--
 ui/admin/package.json             |  4 ++--
 ui/desktop/package.json           |  4 ++--
 3 files changed, 33 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/a11y-tests.yaml b/.github/workflows/a11y-tests.yaml
index ec20c764c..370859ddd 100644
--- a/.github/workflows/a11y-tests.yaml
+++ b/.github/workflows/a11y-tests.yaml
@@ -11,7 +11,7 @@ jobs:
     name: Run A11y Tests
     if: contains(github.event.pull_request.labels.*.name, 'a11y-tests')
     runs-on: ${{ fromJSON(vars.RUNNER) }}
-    timeout-minutes: 35
+    timeout-minutes: 40
     steps:
       - uses: browser-actions/setup-chrome@c785b87e244131f27c9f19c1a33e2ead956ab7ce # v1.7.3
         with:
@@ -26,4 +26,31 @@ jobs:
           cache: 'pnpm'
           cache-dependency-path: '**/pnpm-lock.yaml'
       - run: pnpm install
-      - run: pnpm test-a11y
+      - name: Run a11y tests
+        env:
+          # this will generate the test reports but causes tests to pass even when there a11y failures
+          ENABLE_A11Y_MIDDLEWARE_REPORTER: true
+        run: pnpm test-a11y
+      - name: Consolidate ember a11y reports
+        run: |
+          mkdir ember-a11y-reports
+          jq -s 'map(.[])' ./ui/admin/ember-a11y-report/*.json > ember-a11y-reports/admin.json
+          jq -s 'map(.[])' ./ui/desktop/ember-a11y-report/*.json > ember-a11y-reports/desktop.json
+      - name: Output ember a11y test report summary (admin)
+        run: 'cat ember-a11y-reports/admin.json | jq "map({moduleName,testName,routes,urls,violations: .violations | map({id, nodes: .nodes | map({failureSummary, targets: .[].[]?.relatedNodes?.[]?.target? })}) })"'
+      - name: Output ember a11y test report summary (desktop)
+        run: 'cat ember-a11y-reports/desktop.json | jq "map({moduleName,testName,routes,urls,violations: .violations | map({id, nodes: .nodes | map({failureSummary, targets: .[].[]?.relatedNodes?.[]?.target? })}) })"'
+      - name: Upload ember a11y reports
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+        with:
+          name: ember-a11y-reports
+          path: ./ember-a11y-reports
+      - name: Report a11y test results status
+        if: always()
+        # fail CI when the combined array length of admin and desktop a11y reports is not 0
+        run: |
+          EMBER_A11Y_FAILURE_COUNT=$(jq -s 'map(.[]) | length' ember-a11y-reports/admin.json ember-a11y-reports/desktop.json)
+          echo "$EMBER_A11Y_FAILURE_COUNT ember-a11y test failures"
+          if [ "$EMBER_A11Y_FAILURE_COUNT" != '0' ]; then
+            exit 1
+          fi
diff --git a/ui/admin/package.json b/ui/admin/package.json
index 59473b60a..5210546e1 100644
--- a/ui/admin/package.json
+++ b/ui/admin/package.json
@@ -32,8 +32,8 @@
     "clean:coverage": "rm -rf coverage_* || true",
     "test": "pnpm clean:coverage && pnpm test:ember && pnpm test:finalize",
     "test-a11y": "concurrently \"pnpm:test-a11y:*\" --names \"test-a11y:\"",
-    "test-a11y:light": "ENABLE_A11Y_AUDIT=true ember test",
-    "test-a11y:dark": "COLOR_THEME=dark pnpm test-a11y:light --test-port=7358",
+    "test-a11y:light": "ENABLE_A11Y_AUDIT=true ember test --test-port 0 --filter='acceptance'",
+    "test-a11y:dark": "COLOR_THEME=dark pnpm test-a11y:light",
     "test:ember": "COVERAGE=true ember exam --test-port 0 --split=4 --parallel=1 --random",
     "test:finalize": "ember coverage-merge && pnpm clean:coverage"
   },
diff --git a/ui/desktop/package.json b/ui/desktop/package.json
index 1394400a9..36d12f2b9 100644
--- a/ui/desktop/package.json
+++ b/ui/desktop/package.json
@@ -35,8 +35,8 @@
     "test": "pnpm clean:coverage && pnpm test:ember && pnpm test:finalize",
     "test:ember": "cross-env COVERAGE=true ember exam --test-port 0 --split=4 --parallel=1 --random",
     "test-a11y": "concurrently \"pnpm:test-a11y:*\" --names \"test-a11y:\"",
-    "test-a11y:light": "ENABLE_A11Y_AUDIT=true ember test --test-port=7359",
-    "test-a11y:dark": "COLOR_THEME=dark pnpm test-a11y:light --test-port=7360",
+    "test-a11y:light": "ENABLE_A11Y_AUDIT=true ember test --test-port 0 --filter='acceptance'",
+    "test-a11y:dark": "COLOR_THEME=dark pnpm test-a11y:light",
     "postinstall": "pnpm --dir electron-app install",
     "test:finalize": "ember coverage-merge && pnpm clean:coverage"
   },