From 210296f298dcd285c059bf79f68dffcc3498a006 Mon Sep 17 00:00:00 2001
From: lisbet-alvarez <107949262+lisbet-alvarez@users.noreply.github.com>
Date: Mon, 1 Aug 2022 10:47:36 -0700
Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20Remove=20helper=20te?=
 =?UTF-8?q?xt=20for=20Username=20&=20Password=20(#1231)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Remove helper text for username and password fields in Credential form
as requested in a previous conversation.

✅ Closes: ICU-5459
---
 addons/core/translations/resources/en-us.yaml |  2 --
 .../app/components/form/credential/index.hbs  | 25 +------------------
 2 files changed, 1 insertion(+), 26 deletions(-)

diff --git a/addons/core/translations/resources/en-us.yaml b/addons/core/translations/resources/en-us.yaml
index 289959e6c..ac4dbc6a6 100644
--- a/addons/core/translations/resources/en-us.yaml
+++ b/addons/core/translations/resources/en-us.yaml
@@ -390,8 +390,6 @@ credential:
     username_password: Username & Password
   help:
     username_password: This host requires a username and password to connect.
-    username: The username to use when signing in with this credential store.
-    password: The password to use when signing in with this credential store.
 scope:
   title: Scope
   title_plural: Scopes
diff --git a/ui/admin/app/components/form/credential/index.hbs b/ui/admin/app/components/form/credential/index.hbs
index 3f6f07d51..6600f7ac2 100644
--- a/ui/admin/app/components/form/credential/index.hbs
+++ b/ui/admin/app/components/form/credential/index.hbs
@@ -71,7 +71,6 @@
     @value={{@model.username}}
     @label={{t 'form.username.label'}}
     @error={{@model.errors.username}}
-    @helperText={{t 'resources.credential.help.username'}}
     disabled={{@model.isSaving}}
     readonly={{false}}
     as |field|
@@ -84,36 +83,14 @@
       </field.errors>
     {{/if}}
   </form.input>
-  {{#if @model.isNew}}
-    <form.input
-      @name='password'
-      @type='password'
-      @value={{@model.password}}
-      @label={{t 'form.password.label'}}
-      @error={{@model.errors.password}}
-      @helperText={{t 'resources.credential.help.password'}}
-      disabled={{@model.isSaving}}
-      readonly={{false}}
-      as |field|
-    >
-      {{#if @model.errors.password}}
-        <field.errors as |errors|>
-          {{#each @model.errors.password as |error|}}
-            <errors.message>{{error.message}}</errors.message>
-          {{/each}}
-        </field.errors>
-      {{/if}}
-    </form.input>
-  {{/if}}
 
-  {{#if form.isEditable}}
+  {{#if (or @model.isNew form.isEditable)}}
     <form.input
       @name='password'
       @type='password'
       @value={{@model.password}}
       @label={{t 'form.password.label'}}
       @error={{@model.errors.password}}
-      @helperText={{t 'resources.credential.help.password'}}
       disabled={{@model.isSaving}}
       readonly={{false}}
       as |field|