Llb/worker filter improvements (#2614)
* test: 💍 clean up worker filter component tests (#2559) * Icu 15741 add show filter generator toggle to worker filter component (#2562) * feat: 🎸 add filter generator to worker filter component ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15741 * feat: 🎸 show add worker filter when none set for targets (#2564) ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15760 * Icu 15743 tag workflow (#2565) * feat: 🎸 add tag generator workflow ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15743 * test: 💍 add test cases ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15743 * refactor: 💡 update selected type name to selectedGeneratorType ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15743 * Apply suggestions from code review minor translation change Co-authored-by: Lisbet Alvarez <107949262+lisbet-alvarez@users.noreply.github.com> * refactor: 💡 update id for generated-value ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15743 --------- Co-authored-by: Lisbet Alvarez <lisbet.alvarez@hashicorp.com> Co-authored-by: Lisbet Alvarez <107949262+lisbet-alvarez@users.noreply.github.com> * Icu 15744 name workflow (#2566) * feat: 🎸 add name workflow ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15744 * test: 💍 add "name" workflow tests for filter generator ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15744 * refactor: 💡 use const test selectors for filter generator ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15744 * refactor: 💡 add default option ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15744 * docs: ✏️ fix comment ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15744 --------- Co-authored-by: cameronperera <cameron.perera@hashicorp.com> * refactor: 💡 move worker filter generator outside of rose::form (#2574) * refactor: 💡 move worker filter generator outside of rose::form * [ICU-15718] Add worker filter route, template for empty state (#2576) * feat: 🎸 Vault Credential Store Worker Filter The Worker Filters tab will display the associated worker filter and have an empty state for when there is no worker filter assigned. * add template * Add missing copyright headers * update styling, remove Rose component * color primary is already default, remove * add rose component, remove custom css * fix test * singularize lang --------- Co-authored-by: laurenolivia <laurenolivia@users.noreply.github.com> * feat: 🎸 update worker filter field to use code editor (#2578) * feat: 🎸 update worker filter field to use code editor ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15737 * test: 💍 fix failing storage bucket tests ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15737 * test: 💍 update tests for new worker filter field (#2580) * test: 💍 update tests for new worker filter field ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15739 * Update ui/admin/tests/acceptance/storage-buckets/update-test.js Co-authored-by: Lisbet Alvarez <107949262+lisbet-alvarez@users.noreply.github.com> --------- Co-authored-by: Lisbet Alvarez <107949262+lisbet-alvarez@users.noreply.github.com> * [ICU-15719] Create edit worker filter route and template (#2582) * add codeblock to template * add cancel btn fn * add controller test * add save fn * display formatted worker filter text inside codeblock * move codeblock component outside rose::layout::centered * remove console.log * remove router.refresh() and refactor translations yaml * refactor translations, add breadcrumb::item * replace html elements with hds * move component, delete file * [ICU-15720] Add edit worker filter action to manage dropdown (#2593) * add acceptance test file * delete test file * add edit option to manage dropdown * update route in dropdown * add check for model isVault * add acceptance test file * delete test file * remove data test selectors, fix syntax * [ICU-15721] Remove worker filter input field (#2596) * remove worker filter input field from vault credential store form * revert yaml * [ICU-15838] Add vault credential store worker filter tests (#2595) * add data test elements * add subtests to update-test.js * add subtext to check for .hasText() * add subtest when worker filter exists * update subtest name * remove console.log * clean up * add new selectors * refactor: 💡 worker filter clean-up (#2592) * refactor: 💡 worker filter clean-up ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15816 * refactor: 💡 add aria labels & missing can save check ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15816 * refactor: 💡 pr feedback of using uuid ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15816 * Add missing copyright headers * refactor: 💡 use unique-id helper for aria labels (pr feedback) ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15816 --------- Co-authored-by: lisbet-alvarez <lisbet-alvarez@users.noreply.github.com> * refactor: 💡 update icon logic for egress worker filter (#2612) * refactor: 💡 update worker_filter help translation * refactor: 💡 add maxHeight to worker filter code blocks * refactor: 💡 use existing default option for dropdowns * refactor: 💡 hide copy button when no result to copy and remove unused styles --------- Co-authored-by: Lisbet Alvarez <107949262+lisbet-alvarez@users.noreply.github.com> Co-authored-by: Lisbet Alvarez <lisbet.alvarez@hashicorp.com> Co-authored-by: Lauren <lauren.burwell@hashicorp.com> Co-authored-by: laurenolivia <laurenolivia@users.noreply.github.com> Co-authored-by: lisbet-alvarez <lisbet-alvarez@users.noreply.github.com>
This commit is contained in:
40 files changed
+1045
-212
No files matched your search
@@ -0,0 +1,13 @@
|
||||
/**
|
||||
* Copyright (c) HashiCorp, Inc.
|
||||
* SPDX-License-Identifier: BUSL-1.1
|
||||
*/
|
||||
|
||||
// Manage actions dropdown selectors
|
||||
export const MANAGE_DROPDOWN =
|
||||
'[data-test-manage-credential-stores-dropdown] button:first-child';
|
||||
export const EDIT_ACTION =
|
||||
'[data-test-manage-credential-stores-dropdown] ul li:nth-child(2) a';
|
||||
|
||||
export const CODE_EDITOR_BODY = '[data-test-code-editor-field-editor] textarea';
|
||||
export const CODE_BLOCK_BODY = '.hds-code-block__code';
|
||||
@@ -10,6 +10,8 @@ import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
|
||||
import { setupIndexedDb } from 'api/test-support/helpers/indexed-db';
|
||||
import { authenticateSession } from 'ember-simple-auth/test-support';
|
||||
import { Response } from 'miragejs';
|
||||
import * as selectors from './selectors';
|
||||
import * as commonSelectors from 'admin/tests/helpers/selectors';
|
||||
|
||||
module('Acceptance | credential-stores | update', function (hooks) {
|
||||
setupApplicationTest(hooks);
|
||||
@@ -59,7 +61,13 @@ module('Acceptance | credential-stores | update', function (hooks) {
|
||||
urls.credentialStores = `${urls.projectScope}/credential-stores`;
|
||||
urls.vaultCredentialStore = `${urls.credentialStores}/${instances.vaultCredentialStore.id}`;
|
||||
urls.staticCredentialStore = `${urls.credentialStores}/${instances.staticCredentialStore.id}`;
|
||||
urls.workerFilter = `${urls.credentialStores}/${instances.vaultCredentialStore.id}/worker-filter`;
|
||||
urls.editWorkerFilter = `${urls.credentialStores}/${instances.vaultCredentialStore.id}/edit-worker-filter`;
|
||||
await authenticateSession({});
|
||||
|
||||
// Enable feature flag
|
||||
const featuresService = this.owner.lookup('service:features');
|
||||
featuresService.enable('vault-worker-filter');
|
||||
});
|
||||
|
||||
test('can save changes to existing static credential store', async function (assert) {
|
||||
@@ -295,4 +303,63 @@ module('Acceptance | credential-stores | update', function (hooks) {
|
||||
);
|
||||
}
|
||||
});
|
||||
|
||||
test('visiting static credential store does not show worker filter tab', async function (assert) {
|
||||
await visit(urls.staticCredentialStore);
|
||||
|
||||
assert.dom(commonSelectors.HREF(urls.workerFilter)).doesNotExist();
|
||||
});
|
||||
|
||||
test('user can click vault credential store worker filter tab and be rerouted to correct url', async function (assert) {
|
||||
await visit(urls.vaultCredentialStore);
|
||||
|
||||
assert.dom(commonSelectors.HREF(urls.workerFilter)).exists();
|
||||
|
||||
await click(commonSelectors.HREF(urls.workerFilter));
|
||||
|
||||
assert.strictEqual(currentURL(), urls.workerFilter);
|
||||
});
|
||||
|
||||
test('manage actions dropdown displays edit option and routes to correct url', async function (assert) {
|
||||
await visit(urls.vaultCredentialStore);
|
||||
|
||||
await click(commonSelectors.HREF(urls.workerFilter));
|
||||
await click(selectors.MANAGE_DROPDOWN);
|
||||
await click(selectors.EDIT_ACTION);
|
||||
|
||||
assert.strictEqual(currentURL(), urls.editWorkerFilter);
|
||||
});
|
||||
|
||||
test('when work filters code editor is empty, save btn reroutes to empty state template', async function (assert) {
|
||||
instances.vaultCredentialStore.update({
|
||||
attributes: { worker_filter: null },
|
||||
});
|
||||
await visit(urls.vaultCredentialStore);
|
||||
|
||||
await click(commonSelectors.HREF(urls.workerFilter));
|
||||
|
||||
assert.dom('.hds-application-state').exists();
|
||||
assert
|
||||
.dom('.hds-application-state')
|
||||
.hasText(
|
||||
`No worker filter added You haven't added a worker filter yet. Add Worker Filter`,
|
||||
);
|
||||
});
|
||||
|
||||
test('when worker filter exists, readonly code block displays the filter text', async function (assert) {
|
||||
instances.vaultCredentialStore.update({
|
||||
attributes: { worker_filter: null },
|
||||
});
|
||||
|
||||
await visit(urls.vaultCredentialStore);
|
||||
|
||||
await click(commonSelectors.HREF(urls.workerFilter));
|
||||
await click(selectors.MANAGE_DROPDOWN);
|
||||
await click(selectors.EDIT_ACTION);
|
||||
await fillIn(selectors.CODE_EDITOR_BODY, '"bar" in "/tags/foo"');
|
||||
await click(commonSelectors.SAVE_BTN);
|
||||
|
||||
assert.dom(selectors.CODE_BLOCK_BODY).exists();
|
||||
assert.dom(selectors.CODE_BLOCK_BODY).includesText('"bar" in "/tags/foo"');
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user