From 28e2b67aa8e167dc1fa226ceb841d53f7baff1d2 Mon Sep 17 00:00:00 2001 From: dharini Date: Thu, 12 Aug 2021 11:04:47 -0700 Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=90=9B=20remove=20redudant=20test?= =?UTF-8?q?=20cases?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- ui/admin/tests/acceptance/roles-test.js | 56 ------------------------- 1 file changed, 56 deletions(-) diff --git a/ui/admin/tests/acceptance/roles-test.js b/ui/admin/tests/acceptance/roles-test.js index 648d6de31..77b971f46 100644 --- a/ui/admin/tests/acceptance/roles-test.js +++ b/ui/admin/tests/acceptance/roles-test.js @@ -56,25 +56,6 @@ module('Acceptance | roles', function (hooks) { urls.newRole = `${urls.roles}/new`; }); - test('can save changes to an existing role', async function (assert) { - assert.expect(2); - await visit(urls.role); - await click('form [type="button"]', 'Activate edit mode'); - await fillIn('[name="name"]', 'Updated admin role'); - await click('.rose-form-actions [type="submit"]'); - assert.equal(currentURL(), urls.role); - assert.equal(this.server.db.roles[0].name, 'Updated admin role'); - }); - - test('can cancel changes to an existing role', async function (assert) { - assert.expect(1); - await visit(urls.role); - await click('form [type="button"]', 'Activate edit mode'); - await fillIn('[name="name"]', 'Updated admin role'); - await click('.rose-form-actions [type="button"]'); - assert.notEqual(find('[name="name"]').value, 'Updated admin role'); - }); - test('can create new role', async function (assert) { assert.expect(1); const rolesCount = this.server.db.roles.length; @@ -122,41 +103,4 @@ module('Acceptance | roles', function (hooks) { assert.ok(find('[role="alert"]')); assert.ok(find('.rose-form-error-message')); }); - - test('saving an existing role with invalid fields displays error messages', async function (assert) { - assert.expect(2); - this.server.patch('/roles/:id', () => { - return new Response( - 400, - {}, - { - status: 400, - code: 'invalid_argument', - message: 'The request was invalid.', - details: { - request_fields: [ - { - name: 'name', - description: 'Name is required.', - }, - ], - }, - } - ); - }); - await visit(urls.role); - await click('form [type="button"]', 'Activate edit mode'); - await fillIn('[name="name"]', 'random string'); - await click('[type="submit"]'); - assert.ok( - find('[role="alert"]').textContent.trim(), - 'The request was invalid.', - 'Displays primary error message.' - ); - assert.ok( - find('.rose-form-error-message').textContent.trim(), - 'Name is required.', - 'Displays field-level errors.' - ); - }); });