From 2c93c378c4dd2d7d5a6f164beea51e4bb4fd003f Mon Sep 17 00:00:00 2001
From: Dharini Jeeva <dharini@hashicorp.com>
Date: Tue, 4 Apr 2023 12:20:45 -0700
Subject: [PATCH] Fix feature flag session recording target (#187)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* chore: 🤖 wrap target session recording with feature flag

* fix: 🐛 test

* fix: 🐛 test

* fix: 🐛 use ember truth helper
---
 .../templates/scopes/scope/targets/target/index.hbs   |  8 ++++++--
 ui/admin/tests/acceptance/targets/read-test.js        | 11 +++++++++++
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/ui/admin/app/templates/scopes/scope/targets/target/index.hbs b/ui/admin/app/templates/scopes/scope/targets/target/index.hbs
index 212d49bbc..d76840a99 100644
--- a/ui/admin/app/templates/scopes/scope/targets/target/index.hbs
+++ b/ui/admin/app/templates/scopes/scope/targets/target/index.hbs
@@ -30,8 +30,12 @@
           @cancel={{route-action 'cancel' @model}}
         />
       </sb.Body>
-
-      {{#if (can 'setStorageBucket target' @model)}}
+      {{#if
+        (and
+          (can 'setStorageBucket target' @model)
+          (feature-flag 'session-recording')
+        )
+      }}
         <sb.Sidebar>
           <div class='target-sidebar'>
             <div class='title-wrapper'>
diff --git a/ui/admin/tests/acceptance/targets/read-test.js b/ui/admin/tests/acceptance/targets/read-test.js
index 7a9fdf1e4..a4367202c 100644
--- a/ui/admin/tests/acceptance/targets/read-test.js
+++ b/ui/admin/tests/acceptance/targets/read-test.js
@@ -195,7 +195,17 @@ module('Acceptance | targets | read', function (hooks) {
       .exists();
   });
 
+  test('cannot enable session recording for a target without proper authorization', async function (assert) {
+    assert.expect(2);
+    assert.false(featuresService.isEnabled('session-recording'));
+
+    await visit(urls.sshTarget);
+
+    assert.dom('.target-sidebar a').doesNotExist();
+  });
+
   test('users can click on enable-recording button in target session-recording sidebar and it takes them to enable session recording', async function (assert) {
+    featuresService.enable('session-recording');
     assert.expect(1);
 
     await visit(urls.sshTarget);
@@ -205,6 +215,7 @@ module('Acceptance | targets | read', function (hooks) {
   });
 
   test('users can click on settings icon in target session-recording sidebar and it takes them to enable session recording', async function (assert) {
+    featuresService.enable('session-recording');
     assert.expect(1);
 
     await visit(urls.sshTarget);