chore: 🤖 Enable stylistic linting rules (#1298)

This commit is contained in:
Zhihe Li authored and GitHub committed 2022-09-07 16:21:27 -04:00
1 parent d930c3da3a
commit 34da192ef9
53 files changed
+301 -123

No files matched your search

+4 -3
View File
@@ -1,8 +1,7 @@
'use strict';
module.exports = {
extends: ['recommended'],
extends: ['recommended', 'stylistic'],
rules: {
'no-passed-in-event-handlers': false,
'no-bare-strings': true,
@@ -19,6 +18,8 @@ module.exports = {
],
},
quotes: 'single',
'eol-last': 'editorconfig',
'self-closing-void-elements': false,
'block-indentation': false,
'no-route-action': false,
},
};
@@ -1,6 +1,6 @@
{{#if (can 'delete model' @model)}}
<Rose::Dropdown
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
@dropdownRight={{true}}
as |dropdown|
>
@@ -36,7 +36,7 @@
{{/if}}
<Rose::Dropdown
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
@dropdownRight={{true}}
as |dropdown|
>
@@ -75,9 +75,11 @@
<form.fieldset>
<:title>{{t 'resources.credential-library.form.http_method.label'}}</:title>
<:description>{{t
<:description>
{{t
'resources.credential-library.form.http_method.help'
}}</:description>
}}
</:description>
<:body>
<form.radioGroup
@name='http_method'
@@ -1,3 +1,4 @@
{{!-- template-lint-disable no-whitespace-for-layout --}}
{{#if this.availableUsers}}
<Rose::Form
class='full-width'
+2 -2
View File
@@ -6,8 +6,8 @@
cancel=@cancel
}}
{{else}}
{{! create-and-add-host cancel route doesn't
have a model and this else part is required to prevent
{{! create-and-add-host cancel route doesn't
have a model and this else part is required to prevent
erroring out here. This has been noted in the tech debt doc to further investigate }}
{{component
(concat 'form/host/' 'static')
@@ -1,3 +1,4 @@
{{!-- template-lint-disable no-whitespace-for-layout --}}
{{#if this.hasAvailablePrincipals}}
<Rose::Form
class='full-width'
+4 -2
View File
@@ -51,9 +51,11 @@
aria-labelledby='legend-text-grant-scope'
aria-describedby='helper-text-grant-scope'
>
<legend id='legend-text-grant-scope'>{{t
<legend id='legend-text-grant-scope'>
{{t
'form.grant_scope.label'
}}</legend>
}}
</legend>
<Rose::Form::HelperText
@id='helper-text-grant-scope'
@error={{@model.errors.grant_scope_id}}
@@ -1,5 +1,5 @@
<Rose::Dropdown
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
@dropdownRight={{true}}
as |dropdown|
>
@@ -1,5 +1,5 @@
<Rose::Dropdown
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
@dropdownRight={{true}}
as |dropdown|
>
@@ -4,4 +4,6 @@
'flight-icons/svg/grid-16'
(if @scope.isOrg 'flight-icons/svg/org-16' 'flight-icons/svg/globe-16')
}}
>{{@scope.displayName}}</Rose::Badge>
>
{{@scope.displayName}}
</Rose::Badge>
@@ -1,5 +1,5 @@
<Rose::Dropdown
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
@dropdownRight={{true}}
as |dropdown|
>
@@ -18,5 +18,3 @@
</nav.link>
{{/if}}
</Rose::Nav::Tabs>
@@ -1,5 +1,5 @@
<Rose::Dropdown
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
@dropdownRight={{true}}
as |dropdown|
>
+1 -1
View File
@@ -3,7 +3,7 @@
<Rose::Layout::Global as |layout|>
<layout.header>
<Rose::Header class='{{if (is-loading) ' loading'}}' as |header|>
<Rose::Header class={{if (is-loading) ' loading'}} as |header|>
<header.brand @logo='logo-app' @text={{(app-name)}} />
{{#if this.session.isAuthenticated}}
+1 -1
View File
@@ -1,2 +1,2 @@
{{page-title 'Onboarding'}}
{{page-title (t 'onboarding.title')}}
{{outlet}}
@@ -44,7 +44,7 @@
}}
<Rose::Toolbar>
<Rose::Form as |form|>
{{#with
{{#let
(resource-filter 'scopes.scope.auth-methods' 'type')
as |filter|
}}
@@ -71,7 +71,7 @@
</dropdown.item>
</form.checkboxGroup>
</Rose::Dropdown>
{{/with}}
{{/let}}
{{#if
(has-resource-filter-selections 'scopes.scope.auth-methods' 'type')
+1 -1
View File
@@ -41,7 +41,7 @@
{{#if (can 'delete model' @model)}}
<page.actions>
<Rose::Dropdown
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
@dropdownRight={{true}}
as |dropdown|
>
@@ -16,7 +16,7 @@
<page.body>
{{#with
{{#let
(resource-filter 'scopes.scope.groups.group.add-members' 'scope')
as |filter|
}}
@@ -38,11 +38,11 @@
as |group|
>
<li
class='{{if
class={{if
group.item.isOrg
'indent-label-1'
(if group.item.isProject 'indent-label-2')
}}'
}}
>
<dropdown.item>
<group.checkbox
@@ -70,7 +70,7 @@
</Rose::Form>
</toolbar.primary>
</Rose::Toolbar>
{{/with}}
{{/let}}
<br />
@@ -58,7 +58,7 @@
@iconOnly={{true}}
@showCaret={{false}}
@dropdownRight={{true}}
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
as |dropdown|
>
<dropdown.button
@@ -1,5 +1,5 @@
<Rose::Dropdown
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
@dropdownRight={{true}}
as |dropdown|
>
@@ -1,5 +1,5 @@
<Rose::Dropdown
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
@dropdownRight={{true}}
as |dropdown|
>
@@ -52,7 +52,7 @@
@iconOnly={{true}}
@showCaret={{false}}
@dropdownRight={{true}}
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
as |dropdown|
>
<dropdown.button
@@ -1,6 +1,6 @@
{{#if (can 'delete model' @model)}}
<Rose::Dropdown
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
@dropdownRight={{true}}
as |dropdown|
>
@@ -16,7 +16,7 @@
<page.body>
{{#with
{{#let
(resource-filter 'scopes.scope.roles.role.add-principals' 'scope')
as |filter|
}}
@@ -38,11 +38,11 @@
as |group|
>
<li
class='{{if
class={{if
group.item.isOrg
'indent-label-1'
(if group.item.isProject 'indent-label-2')
}}'
}}
>
<dropdown.item>
<group.checkbox
@@ -70,7 +70,7 @@
</Rose::Form>
</toolbar.primary>
</Rose::Toolbar>
{{/with}}
{{/let}}
<br />
@@ -86,7 +86,7 @@
@iconOnly={{true}}
@showCaret={{false}}
@dropdownRight={{true}}
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
as |dropdown|
>
<dropdown.button
@@ -16,7 +16,7 @@
<Rose::Toolbar as |toolbar|>
<toolbar.primary>
<Rose::Form as |form|>
{{#with
{{#let
(resource-filter 'scopes.scope.sessions' 'status')
as |filter|
}}
@@ -41,7 +41,7 @@
</dropdown.item>
</form.checkboxGroup>
</Rose::Dropdown>
{{/with}}
{{/let}}
{{#if
(has-resource-filter-selections 'scopes.scope.sessions' 'status')
@@ -56,7 +56,7 @@
@iconOnly={{true}}
@showCaret={{false}}
@dropdownRight={{true}}
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
as |dropdown|
>
<dropdown.button
@@ -58,7 +58,7 @@
@iconOnly={{true}}
@showCaret={{false}}
@dropdownRight={{true}}
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
as |dropdown|
>
<dropdown.button
@@ -26,7 +26,7 @@
<Rose::Toolbar as |toolbar|>
<toolbar.primary>
<Rose::Form as |form|>
{{#with
{{#let
(resource-filter 'scopes.scope.workers.index' 'tags')
as |filter|
}}
@@ -53,7 +53,7 @@
</form.checkboxGroup>
</Rose::Dropdown>
{{/if}}
{{/with}}
{{/let}}
{{#if
(has-resource-filter-selections
'scopes.scope.workers.index' 'tags'
@@ -29,7 +29,7 @@
<page.actions>
<Rose::Dropdown
@text='{{t 'actions.manage'}}'
@text={{t 'actions.manage'}}
@dropdownRight={{true}}
as |dropdown|
>
+1 -1
View File
@@ -78,7 +78,7 @@
"ember-qunit": "^5.1.4",
"ember-resolver": "^8.0.3",
"ember-source": "~3.28.4",
"ember-template-lint": "^3.16.0",
"ember-template-lint": "^4.14.0",
"eslint": "^8.18.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-ember": "^10.6.1",