refactor: 💡 update Rose::Frame to use Hds::Card::Container (#2795)

This commit is contained in:
Priya Patel authored and GitHub committed 2025-04-29 09:15:17 -07:00
1 parent 24d86a230a
commit 3bafb708ea
3 files changed
+27 -44

No files matched your search

@@ -3,8 +3,7 @@
SPDX-License-Identifier: BUSL-1.1
}}
<section ...attributes class='rose-frame'>
<Hds::Card::Container @level='high' @hasBorder='true' ...attributes>
<header class='rose-frame-header'>
{{yield to='header'}}
</header>
@@ -12,5 +11,4 @@
<div class='rose-frame-body'>
{{yield to='body'}}
</div>
</section>
</Hds::Card::Container>
@@ -15,43 +15,28 @@ $xxs: sizing.rems(xxs); // 4
$xxxs: sizing.rems(xxxs); // 2
$xxxxs: sizing.rems(xxxxs); // 1
.rose-frame {
--header-color: var(--ui-gray-starker-3);
--header-icon-color: var(--header-color);
--header-background-color: var(--ui-gray-subtler-5);
--header-border-color: var(--ui-gray-subtler-3);
.rose-frame-header {
padding: ($xs + $xxxs) $l;
color: var(--token-color-palette-neutral-600);
background-color: var(--token-color-palette-neutral-50);
border-bottom: $xxxxs solid var(--token-color-border-primary);
border-top-left-radius: var(--token-border-radius-medium);
border-top-right-radius: var(--token-border-radius-medium);
display: flex;
align-items: center;
column-gap: $xs;
@include type.type(s);
border: $xxxxs solid var(--ui-gray-subtler-3);
border-radius: $xxxs;
box-shadow: 0 $xxs $xxs rgba(var(--stark-components), var(--opacity-4));
background-color: var(--background-color);
.rose-frame-header {
padding: ($xs + $xxxs) $l;
min-height: $l;
color: var(--header-color);
background-color: var(--header-background-color);
border-bottom: $xxxxs solid var(--header-border-color);
border-top-left-radius: $xxxs;
border-top-right-radius: $xxxs;
display: flex;
align-items: center;
column-gap: $xs;
h2 {
margin: $m 0;
}
}
.rose-frame-body {
$body-padding: $l;
padding: $body-padding;
p {
margin-bottom: $m;
}
h2 {
margin: $m 0;
}
}
.rose-frame-body {
$body-padding: $l;
padding: $body-padding;
p {
margin-bottom: $m;
}
}
@@ -5,7 +5,7 @@
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { render, find } from '@ember/test-helpers';
import { render } from '@ember/test-helpers';
import { hbs } from 'ember-cli-htmlbars';
module('Integration | Component | rose/frame', function (hooks) {
@@ -19,7 +19,7 @@ module('Integration | Component | rose/frame', function (hooks) {
</Rose::Frame>
`);
assert.ok(find('section > header'));
assert.ok(find('section > div'));
assert.dom('.hds-card__container > header').isVisible();
assert.dom('.hds-card__container > div').isVisible();
});
});