From 3f238140b43a07d4dfb3c046e06b872ab1cdb8f6 Mon Sep 17 00:00:00 2001
From: Zhihe Li <zhihe.li@hashicorp.com>
Date: Thu, 30 May 2024 14:11:48 -0400
Subject: [PATCH] =?UTF-8?q?feat:=20=F0=9F=8E=B8=20Change=20the=20default?=
 =?UTF-8?q?=20notification=20on=20mac=20to=20be=20alert=20(#2311)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13931
---
 ui/desktop/electron-app/config/forge.config.js | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/ui/desktop/electron-app/config/forge.config.js b/ui/desktop/electron-app/config/forge.config.js
index 6d9c906f0..38c7ca75f 100644
--- a/ui/desktop/electron-app/config/forge.config.js
+++ b/ui/desktop/electron-app/config/forge.config.js
@@ -20,6 +20,11 @@ module.exports = {
       'entitlements-inherit': './assets/macos/entitlements.plist',
       'signature-flags': 'library',
     },
+    // Add extra keys to our Info.plist
+    extendInfo: {
+      // Set the default notification style to be alert instead of banner
+      NSUserNotificationAlertStyle: 'alert',
+    },
     asar: {
       // We need to unpack node-pty helpers so we have them available
       // outside of the ASAR when they are called
@@ -78,13 +83,13 @@ module.exports = {
         !process.env.BUILD_DEBIAN
       )
         console.warn(
-          '[package] WARNING: Could not find signing identity. Proceeding without signing.'
+          '[package] WARNING: Could not find signing identity. Proceeding without signing.',
         );
     },
     postPackage: async (forgeConfig, options) => {
       if (options.spinner) {
         options.spinner.info(
-          `Packaged for ${options.platform}-${options.arch} at ${options.outputPaths[0]}`
+          `Packaged for ${options.platform}-${options.arch} at ${options.outputPaths[0]}`,
         );
       }
     },
@@ -99,14 +104,14 @@ module.exports = {
         // Copy artifacts
         artifacts.forEach(async (artifact) => {
           const name = `boundary-desktop_${version}_${platform}_${arch}${path.extname(
-            artifact
+            artifact,
           )}`;
           const artifactDestination = path.join(destination, name);
           console.log(`[release] Found artifact: ${artifact}`);
           try {
             await fs.promises.copyFile(artifact, artifactDestination);
             console.log(
-              `[release] Copied artifact: ${path.resolve(artifactDestination)}`
+              `[release] Copied artifact: ${path.resolve(artifactDestination)}`,
             );
           } catch (e) {
             console.warn(`[release] Could not copy ${artifact}`, e);
@@ -126,7 +131,7 @@ module.exports = {
         'node_modules',
         'node-pty',
         'build',
-        'node_gyp_bins'
+        'node_gyp_bins',
       );
       await fs.promises.rm(gypPath, { recursive: true, force: true });
     },