From 4170c7aa248f09d1e62a1c72cb28a1b2875a9291 Mon Sep 17 00:00:00 2001 From: Tony <52470376+wongtonyb@users.noreply.github.com> Date: Tue, 23 Dec 2025 12:32:16 -0500 Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=90=9B=20e2e=20-=20update=20save?= =?UTF-8?q?=20button=20selector=20(#3116)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- e2e-tests/admin/pages/aliases.js | 2 +- e2e-tests/admin/pages/auth-methods.js | 8 ++++---- e2e-tests/admin/pages/credential-stores.js | 16 ++++++++-------- e2e-tests/admin/pages/groups.js | 2 +- e2e-tests/admin/pages/host-catalogs.js | 6 +++--- e2e-tests/admin/pages/orgs.js | 4 ++-- e2e-tests/admin/pages/projects.js | 2 +- e2e-tests/admin/pages/roles.js | 2 +- e2e-tests/admin/pages/storage-buckets.js | 4 ++-- e2e-tests/admin/pages/storage-policies.js | 2 +- e2e-tests/admin/pages/targets.js | 10 +++++----- e2e-tests/admin/pages/users.js | 2 +- e2e-tests/admin/pages/workers.js | 4 ++-- 13 files changed, 32 insertions(+), 32 deletions(-) diff --git a/e2e-tests/admin/pages/aliases.js b/e2e-tests/admin/pages/aliases.js index 3a6d740e8..c9660f5c3 100644 --- a/e2e-tests/admin/pages/aliases.js +++ b/e2e-tests/admin/pages/aliases.js @@ -36,7 +36,7 @@ export class AliasesPage extends BaseResourcePage { await this.page.getByLabel('Alias Value').fill(alias); await this.page.getByLabel('Target ID').fill(targetId); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page diff --git a/e2e-tests/admin/pages/auth-methods.js b/e2e-tests/admin/pages/auth-methods.js index 7371af69b..47582b7b3 100644 --- a/e2e-tests/admin/pages/auth-methods.js +++ b/e2e-tests/admin/pages/auth-methods.js @@ -22,7 +22,7 @@ export class AuthMethodsPage extends BaseResourcePage { await this.page.getByRole('button', { name: 'New' }).click(); await this.page.getByText('Password', { exact: true }).click(); await this.page.getByLabel('Name').fill(authMethodName); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page @@ -113,7 +113,7 @@ export class AuthMethodsPage extends BaseResourcePage { await this.page.getByLabel('Maximum Age').fill('20'); await this.page.getByLabel('API URL Prefix').fill(boundaryAddr); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page @@ -166,7 +166,7 @@ export class AuthMethodsPage extends BaseResourcePage { await this.page.getByLabel('Name (Optional)').fill(accountName); await this.page.getByLabel('Login Name').fill(login); await this.page.getByLabel('Password', { exact: true }).fill(password); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page @@ -184,7 +184,7 @@ export class AuthMethodsPage extends BaseResourcePage { async setPasswordToAccount(password) { await this.page.getByRole('link', { name: 'Set Password' }).click(); await this.page.getByLabel(new RegExp('Password*')).fill(password); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); } } diff --git a/e2e-tests/admin/pages/credential-stores.js b/e2e-tests/admin/pages/credential-stores.js index 716021ceb..f6b3c1f2f 100644 --- a/e2e-tests/admin/pages/credential-stores.js +++ b/e2e-tests/admin/pages/credential-stores.js @@ -27,7 +27,7 @@ export class CredentialStoresPage extends BaseResourcePage { .getByRole('group', { name: 'Type' }) .getByLabel('Static') .click(); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page @@ -59,7 +59,7 @@ export class CredentialStoresPage extends BaseResourcePage { .click(); await this.page.getByLabel('Address').fill(vaultAddr); await this.page.getByLabel('Token').fill(clientToken); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page @@ -100,7 +100,7 @@ export class CredentialStoresPage extends BaseResourcePage { .getByRole('textbox') .fill(workerFilter); await this.page.getByLabel('Token').fill(clientToken); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page @@ -160,7 +160,7 @@ export class CredentialStoresPage extends BaseResourcePage { encoding: 'utf-8', }); await this.page.getByLabel('SSH Private Key').fill(keyData); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page @@ -219,7 +219,7 @@ export class CredentialStoresPage extends BaseResourcePage { await this.page .getByLabel('Password Required', { exact: true }) .fill(password); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page @@ -284,7 +284,7 @@ export class CredentialStoresPage extends BaseResourcePage { .getByLabel('Password Required', { exact: true }) .fill(password); await this.page.getByLabel('Domain Required', { exact: true }).fill(domain); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page @@ -323,7 +323,7 @@ export class CredentialStoresPage extends BaseResourcePage { .selectOption(credentialType); } - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); return credentialLibraryName; @@ -364,7 +364,7 @@ export class CredentialStoresPage extends BaseResourcePage { .getByRole('button', { name: 'Add' }) .click(); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); return credentialLibraryName; diff --git a/e2e-tests/admin/pages/groups.js b/e2e-tests/admin/pages/groups.js index b15133a61..8054f099a 100644 --- a/e2e-tests/admin/pages/groups.js +++ b/e2e-tests/admin/pages/groups.js @@ -21,7 +21,7 @@ export class GroupsPage extends BaseResourcePage { .click(); await this.page.getByRole('link', { name: 'New', exact: true }).click(); await this.page.getByLabel('Name').fill(groupName); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page diff --git a/e2e-tests/admin/pages/host-catalogs.js b/e2e-tests/admin/pages/host-catalogs.js index 805b984c8..f37570e88 100644 --- a/e2e-tests/admin/pages/host-catalogs.js +++ b/e2e-tests/admin/pages/host-catalogs.js @@ -40,7 +40,7 @@ export class HostCatalogsPage extends BaseResourcePage { .getByRole('group', { name: 'Type', exact: 'true' }) .getByLabel('Static') .click(); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page @@ -76,7 +76,7 @@ export class HostCatalogsPage extends BaseResourcePage { await this.page.getByLabel('Name').fill(hostSetName); await this.page.getByLabel('Description').fill('This is an automated test'); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page @@ -99,7 +99,7 @@ export class HostCatalogsPage extends BaseResourcePage { await this.page.getByLabel('Name').fill(hostName); await this.page.getByLabel('Description').fill('This is an automated test'); await this.page.getByLabel('Address').fill(address); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect(this.page.getByRole('link', { name: hostName })).toBeVisible(); diff --git a/e2e-tests/admin/pages/orgs.js b/e2e-tests/admin/pages/orgs.js index dd2660d1a..0b9186928 100644 --- a/e2e-tests/admin/pages/orgs.js +++ b/e2e-tests/admin/pages/orgs.js @@ -22,7 +22,7 @@ export class OrgsPage extends BaseResourcePage { await this.page.getByRole('link', { name: 'New Org' }).click(); await this.page.getByLabel('Name').fill(orgName); await this.page.getByLabel('Description').fill('This is an automated test'); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page @@ -45,7 +45,7 @@ export class OrgsPage extends BaseResourcePage { await this.page .getByLabel('Storage Policy') .selectOption({ label: policyName }); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page.getByRole('listitem').getByText(policyName), diff --git a/e2e-tests/admin/pages/projects.js b/e2e-tests/admin/pages/projects.js index d689678c0..c907e11a9 100644 --- a/e2e-tests/admin/pages/projects.js +++ b/e2e-tests/admin/pages/projects.js @@ -22,7 +22,7 @@ export class ProjectsPage extends BaseResourcePage { await this.page.getByRole('link', { name: 'New', exact: true }).click(); await this.page.getByLabel('Name').fill(projectName); await this.page.getByLabel('Description').fill('This is an automated test'); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page diff --git a/e2e-tests/admin/pages/roles.js b/e2e-tests/admin/pages/roles.js index 407f536e9..3265112bd 100644 --- a/e2e-tests/admin/pages/roles.js +++ b/e2e-tests/admin/pages/roles.js @@ -26,7 +26,7 @@ export class RolesPage extends BaseResourcePage { .click(); await this.page.getByRole('link', { name: 'New Role' }).click(); await this.page.getByLabel('Name').fill(roleName); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page diff --git a/e2e-tests/admin/pages/storage-buckets.js b/e2e-tests/admin/pages/storage-buckets.js index 01a2f6798..3892a364d 100644 --- a/e2e-tests/admin/pages/storage-buckets.js +++ b/e2e-tests/admin/pages/storage-buckets.js @@ -49,7 +49,7 @@ export class StorageBucketsPage extends BaseResourcePage { .getByRole('textbox') .fill(workerFilter); await this.page.getByLabel('Disable credential rotation').click(); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page @@ -103,7 +103,7 @@ export class StorageBucketsPage extends BaseResourcePage { .getByRole('textbox') .fill(workerFilter); await this.page.getByLabel('Disable credential rotation').click(); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page diff --git a/e2e-tests/admin/pages/storage-policies.js b/e2e-tests/admin/pages/storage-policies.js index 64f46bc9d..acb1cc52d 100644 --- a/e2e-tests/admin/pages/storage-policies.js +++ b/e2e-tests/admin/pages/storage-policies.js @@ -41,7 +41,7 @@ export class StoragePoliciesPage extends BaseResourcePage { await this.page .getByLabel('Retention Policy') .selectOption({ label: 'Forever' }); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page diff --git a/e2e-tests/admin/pages/targets.js b/e2e-tests/admin/pages/targets.js index 99ebd6b9f..a77df276b 100644 --- a/e2e-tests/admin/pages/targets.js +++ b/e2e-tests/admin/pages/targets.js @@ -64,7 +64,7 @@ export class TargetsPage extends BaseResourcePage { await this.page.getByRole('button', { name: 'Add' }).click(); } - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page @@ -147,7 +147,7 @@ export class TargetsPage extends BaseResourcePage { await this.page.locator('.CodeMirror').getByRole('textbox').fill(filter); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); } @@ -176,7 +176,7 @@ export class TargetsPage extends BaseResourcePage { await this.page.locator('.CodeMirror').getByRole('textbox').fill(filter); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); } @@ -298,7 +298,7 @@ export class TargetsPage extends BaseResourcePage { await this.page .getByLabel('Storage buckets') .selectOption({ label: storageBucketName }); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page.getByRole('listitem').getByText(storageBucketName), @@ -313,7 +313,7 @@ export class TargetsPage extends BaseResourcePage { .getByRole('link', { name: 'Session Recording settings' }) .click(); await this.page.getByLabel('Record sessions for this target').uncheck(); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); } } diff --git a/e2e-tests/admin/pages/users.js b/e2e-tests/admin/pages/users.js index 6665201b5..f285f772b 100644 --- a/e2e-tests/admin/pages/users.js +++ b/e2e-tests/admin/pages/users.js @@ -21,7 +21,7 @@ export class UsersPage extends BaseResourcePage { .click(); await this.page.getByRole('link', { name: 'New', exact: true }).click(); await this.page.getByLabel('Name').fill(userName); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); await expect( this.page diff --git a/e2e-tests/admin/pages/workers.js b/e2e-tests/admin/pages/workers.js index b2f6061b3..10d2ecf57 100644 --- a/e2e-tests/admin/pages/workers.js +++ b/e2e-tests/admin/pages/workers.js @@ -25,7 +25,7 @@ export class WorkersPage extends BaseResourcePage { await this.page.getByLabel('Key').fill(key); await this.page.getByLabel('Value').fill(value); await this.page.getByRole('button', { name: 'Add' }).click(); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); } @@ -46,7 +46,7 @@ export class WorkersPage extends BaseResourcePage { await this.page.getByLabel('Key').fill(newKey); await this.page.getByLabel('Value').fill(newValue); - await this.page.getByRole('button', { name: 'Save' }).click(); + await this.page.getByRole('button', { name: 'Save', exact: true }).click(); await this.dismissSuccessAlert(); }