From 42013a919f5481d69b60274a1e2f869770d8b0fc Mon Sep 17 00:00:00 2001 From: Cameron Perera Date: Tue, 22 Jul 2025 13:25:07 -0500 Subject: [PATCH] =?UTF-8?q?(HACK=20WEEK=202025)=20refactor:=20=F0=9F=92=A1?= =?UTF-8?q?=20remove=20explicit=20a11yAudit=20usage=20(#2936)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * refactor: 💡 remove explicit usage of a11yAudit * Delete a11yAudit method from readme --------- Co-authored-by: calcaide --- ui/admin/README.md | 2 -- .../accounts/change-password-test.js | 5 ---- .../tests/acceptance/accounts/create-test.js | 4 +--- .../tests/acceptance/accounts/delete-test.js | 2 -- .../tests/acceptance/accounts/read-test.js | 2 -- .../acceptance/accounts/set-password-test.js | 4 ---- .../tests/acceptance/accounts/update-test.js | 3 --- .../tests/acceptance/aliases/create-test.js | 2 -- .../tests/acceptance/aliases/read-test.js | 5 ---- .../acceptance/auth-methods/delete-test.js | 3 --- .../acceptance/auth-methods/oidc-test.js | 2 -- .../acceptance/auth-methods/read-test.js | 5 ---- .../acceptance/auth-methods/update-test.js | 3 --- .../tests/acceptance/authentication-test.js | 4 ---- .../credential-library/create-test.js | 3 --- .../credential-library/read-test.js | 4 +--- .../credential-store/credentials/read-test.js | 8 ------- .../acceptance/credential-store/read-test.js | 5 ---- .../tests/acceptance/groups/members-test.js | 4 +--- ui/admin/tests/acceptance/groups/read-test.js | 2 -- .../host-catalogs/host-sets/hosts-test.js | 4 ---- .../host-catalogs/host-sets/read-test.js | 4 ---- .../host-catalogs/hosts/read-test.js | 5 +--- .../acceptance/host-catalogs/read-test.js | 4 ---- .../acceptance/managed-groups/create-test.js | 3 --- .../acceptance/managed-groups/delete-test.js | 3 --- .../acceptance/managed-groups/members-test.js | 2 -- .../acceptance/managed-groups/read-test.js | 3 --- .../tests/acceptance/policy/create-test.js | 2 -- ui/admin/tests/acceptance/policy/read-test.js | 5 ---- .../tests/acceptance/roles/create-test.js | 2 -- .../acceptance/roles/global-scope-test.js | 11 --------- .../tests/acceptance/roles/grants-test.js | 2 -- .../tests/acceptance/roles/org-scope-test.js | 5 ---- .../tests/acceptance/roles/principals-test.js | 2 -- .../acceptance/roles/project-scope-test.js | 2 -- ui/admin/tests/acceptance/roles/read-test.js | 4 ---- ui/admin/tests/acceptance/scopes-test.js | 5 ---- .../scopes/add-storage-policy-test.js | 2 -- ui/admin/tests/acceptance/scopes/read-test.js | 11 --------- .../session-recordings/read-test.js | 9 -------- .../channels-by-connection/channel-test.js | 2 -- .../tests/acceptance/sessions/list-test.js | 4 ---- .../acceptance/storage-buckets/read-test.js | 3 --- .../brokered-credential-sources-test.js | 5 ---- .../acceptance/targets/create-alias-test.js | 2 -- .../targets/enable-session-recording-test.js | 2 -- .../enable-session-recording/index-test.js | 2 -- .../acceptance/targets/host-sources-test.js | 3 --- ...ted-application-credential-sources-test.js | 5 ---- .../acceptance/targets/manage-alias-test.js | 2 -- .../tests/acceptance/targets/read-test.js | 5 ---- .../tests/acceptance/targets/workers-test.js | 8 ------- .../tests/acceptance/users/accounts-test.js | 3 --- ui/admin/tests/acceptance/users/read-test.js | 4 ---- .../acceptance/workers/create-tags-test.js | 2 -- .../tests/acceptance/workers/read-test.js | 8 ------- .../tests/acceptance/workers/tags-test.js | 2 -- ui/desktop/README.md | 2 -- .../tests/acceptance/authentication-test.js | 7 +++--- .../tests/acceptance/cluster-url-test.js | 5 ++-- ui/desktop/tests/acceptance/projects-test.js | 5 ++-- .../projects/sessions/index-test.js | 10 -------- .../projects/sessions/session-test.js | 2 -- .../acceptance/projects/targets/index-test.js | 9 -------- ui/desktop/tests/acceptance/scopes-test.js | 23 ------------------- 66 files changed, 11 insertions(+), 276 deletions(-) diff --git a/ui/admin/README.md b/ui/admin/README.md index c2626cff0..827a3bd48 100644 --- a/ui/admin/README.md +++ b/ui/admin/README.md @@ -96,8 +96,6 @@ of testing". Use test coverage as a guide to help you identify untested high-value code. We rely on `ember-a11y-testing` to validate accessibility in acceptance tests. -If you write acceptance tests, please ensure at least one validation per -route using `await a11yAudit();`. ### Deploying diff --git a/ui/admin/tests/acceptance/accounts/change-password-test.js b/ui/admin/tests/acceptance/accounts/change-password-test.js index 17f7006e1..6c1d3765b 100644 --- a/ui/admin/tests/acceptance/accounts/change-password-test.js +++ b/ui/admin/tests/acceptance/accounts/change-password-test.js @@ -8,7 +8,6 @@ import { visit, currentURL, click, fillIn } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession, @@ -60,7 +59,6 @@ module('Acceptance | accounts | change password', function (hooks) { await click(commonSelectors.SIDEBAR_USER_DROPDOWN); await click(commonSelectors.HREF(urls.changePassword)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.changePassword); }); @@ -102,8 +100,6 @@ module('Acceptance | accounts | change password', function (hooks) { selectors.FIELD_NEW_PASSWORD_VALUE, ); await click(commonSelectors.SAVE_BTN); - - await a11yAudit(); }); test('can cancel password change', async function (assert) { @@ -147,7 +143,6 @@ module('Acceptance | accounts | change password', function (hooks) { selectors.FIELD_NEW_PASSWORD_VALUE, ); await click(commonSelectors.SAVE_BTN); - await a11yAudit(); assert.dom(commonSelectors.ALERT_TOAST).isVisible(); }); diff --git a/ui/admin/tests/acceptance/accounts/create-test.js b/ui/admin/tests/acceptance/accounts/create-test.js index 814e07652..142c957a9 100644 --- a/ui/admin/tests/acceptance/accounts/create-test.js +++ b/ui/admin/tests/acceptance/accounts/create-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click, find, fillIn } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as selectors from './selectors'; @@ -67,7 +66,7 @@ module('Acceptance | accounts | create', function (hooks) { test('visiting accounts', async function (assert) { await visit(urls.accounts); - await a11yAudit(); + assert.strictEqual(currentURL(), urls.accounts); }); @@ -205,7 +204,6 @@ module('Acceptance | accounts | create', function (hooks) { await fillIn(commonSelectors.FIELD_NAME, commonSelectors.FIELD_NAME_VALUE); await click(commonSelectors.SAVE_BTN); - await a11yAudit(); assert .dom(commonSelectors.ALERT_TOAST_BODY) .hasText('The request was invalid.'); diff --git a/ui/admin/tests/acceptance/accounts/delete-test.js b/ui/admin/tests/acceptance/accounts/delete-test.js index c0cc9e950..5ff76a8d8 100644 --- a/ui/admin/tests/acceptance/accounts/delete-test.js +++ b/ui/admin/tests/acceptance/accounts/delete-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, click, find } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as selectors from './selectors'; @@ -101,7 +100,6 @@ module('Acceptance | accounts | delete', function (hooks) { await click(selectors.MANAGE_DROPDOWN_ACCOUNT); await click(selectors.MANAGE_DROPDOWN_DELETE_ACCOUNT); - await a11yAudit(); assert.dom(commonSelectors.ALERT_TOAST_BODY).hasText('Oops.'); }); }); diff --git a/ui/admin/tests/acceptance/accounts/read-test.js b/ui/admin/tests/acceptance/accounts/read-test.js index e640f312f..0f2d277f9 100644 --- a/ui/admin/tests/acceptance/accounts/read-test.js +++ b/ui/admin/tests/acceptance/accounts/read-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -55,7 +54,6 @@ module('Acceptance | accounts | read', function (hooks) { await visit(urls.accounts); await click(commonSelectors.TABLE_RESOURCE_LINK(urls.account)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.account); }); diff --git a/ui/admin/tests/acceptance/accounts/set-password-test.js b/ui/admin/tests/acceptance/accounts/set-password-test.js index 279b133b9..aa09d7b00 100644 --- a/ui/admin/tests/acceptance/accounts/set-password-test.js +++ b/ui/admin/tests/acceptance/accounts/set-password-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click, fillIn } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -55,7 +54,6 @@ module('Acceptance | accounts | set password', function (hooks) { test('visiting account set password', async function (assert) { await visit(urls.setPassword); - await a11yAudit(); assert.strictEqual(currentURL(), urls.setPassword); }); @@ -96,7 +94,6 @@ module('Acceptance | accounts | set password', function (hooks) { await fillIn(commonSelectors.FIELD_PASSWORD, 'update password'); await click(commonSelectors.SAVE_BTN); - await a11yAudit(); }); test('can cancel setting new password by navigating away', async function (assert) { @@ -132,6 +129,5 @@ module('Acceptance | accounts | set password', function (hooks) { await click(commonSelectors.SAVE_BTN); assert.dom(commonSelectors.ALERT_TOAST).isVisible(); - await a11yAudit(); }); }); diff --git a/ui/admin/tests/acceptance/accounts/update-test.js b/ui/admin/tests/acceptance/accounts/update-test.js index 3dbf66d7f..43446aff0 100644 --- a/ui/admin/tests/acceptance/accounts/update-test.js +++ b/ui/admin/tests/acceptance/accounts/update-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, click, fillIn } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -125,7 +124,6 @@ module('Acceptance | accounts | update', function (hooks) { await fillIn(commonSelectors.FIELD_NAME, commonSelectors.FIELD_NAME_VALUE); await click(commonSelectors.SAVE_BTN); - await a11yAudit(); assert.dom(commonSelectors.ALERT_TOAST_BODY).hasText('Oops.'); }); @@ -155,7 +153,6 @@ module('Acceptance | accounts | update', function (hooks) { await fillIn(commonSelectors.FIELD_NAME, commonSelectors.FIELD_NAME_VALUE); await click(commonSelectors.SAVE_BTN); - await a11yAudit(); assert .dom(commonSelectors.ALERT_TOAST_BODY) .hasText('The request was invalid.'); diff --git a/ui/admin/tests/acceptance/aliases/create-test.js b/ui/admin/tests/acceptance/aliases/create-test.js index f2dc72b6d..2a8daaefd 100644 --- a/ui/admin/tests/acceptance/aliases/create-test.js +++ b/ui/admin/tests/acceptance/aliases/create-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click, fillIn } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; @@ -107,7 +106,6 @@ module('Acceptance | aliases | create', function (hooks) { }); await visit(urls.newAlias); await click(commonSelectors.SAVE_BTN); - await a11yAudit(); assert .dom(commonSelectors.ALERT_TOAST_BODY) diff --git a/ui/admin/tests/acceptance/aliases/read-test.js b/ui/admin/tests/acceptance/aliases/read-test.js index 481d35d73..0b80c8fa7 100644 --- a/ui/admin/tests/acceptance/aliases/read-test.js +++ b/ui/admin/tests/acceptance/aliases/read-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -51,12 +50,9 @@ module('Acceptance | aliases | read', function (hooks) { test('visiting an alias', async function (assert) { await visit(urls.globalScope); - await a11yAudit(); await click(commonSelectors.HREF(urls.aliases)); - await a11yAudit(); await click(commonSelectors.HREF(urls.alias)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.alias); }); @@ -73,7 +69,6 @@ module('Acceptance | aliases | read', function (hooks) { test('visiting an unknown alias displays 404 message', async function (assert) { await visit(urls.unknownAlias); - await a11yAudit(); assert .dom(commonSelectors.RESOURCE_NOT_FOUND_SUBTITLE) diff --git a/ui/admin/tests/acceptance/auth-methods/delete-test.js b/ui/admin/tests/acceptance/auth-methods/delete-test.js index c99538c61..09af6ed43 100644 --- a/ui/admin/tests/acceptance/auth-methods/delete-test.js +++ b/ui/admin/tests/acceptance/auth-methods/delete-test.js @@ -8,7 +8,6 @@ import { visit, click, currentURL } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { TYPE_AUTH_METHOD_LDAP } from 'api/models/auth-method'; @@ -104,7 +103,6 @@ module('Acceptance | auth-methods | delete', function (hooks) { await click(commonSelectors.HREF(urls.authMethod)); await click(selectors.MANAGE_DROPDOWN); await click(selectors.MANAGE_DROPDOWN_DELETE); - await a11yAudit(); assert.dom(commonSelectors.ALERT_TOAST_BODY).hasText('Oops.'); }); @@ -127,7 +125,6 @@ module('Acceptance | auth-methods | delete', function (hooks) { await click(commonSelectors.HREF(urls.ldapAuthMethod)); await click(selectors.MANAGE_DROPDOWN); await click(selectors.MANAGE_DROPDOWN_DELETE); - await a11yAudit(); assert.dom(commonSelectors.ALERT_TOAST_BODY).hasText('Oops.'); }); diff --git a/ui/admin/tests/acceptance/auth-methods/oidc-test.js b/ui/admin/tests/acceptance/auth-methods/oidc-test.js index 454ecac68..fe3edbb14 100644 --- a/ui/admin/tests/acceptance/auth-methods/oidc-test.js +++ b/ui/admin/tests/acceptance/auth-methods/oidc-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { TYPE_AUTH_METHOD_OIDC } from 'api/models/auth-method'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -49,7 +48,6 @@ module('Acceptance | auth-methods | oidc', function (hooks) { test('visiting oidc auth method', async function (assert) { await visit(urls.authMethod); - await a11yAudit(); assert.strictEqual(currentURL(), urls.authMethod); }); diff --git a/ui/admin/tests/acceptance/auth-methods/read-test.js b/ui/admin/tests/acceptance/auth-methods/read-test.js index 04d2c35f6..521b2c548 100644 --- a/ui/admin/tests/acceptance/auth-methods/read-test.js +++ b/ui/admin/tests/acceptance/auth-methods/read-test.js @@ -8,7 +8,6 @@ import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { TYPE_AUTH_METHOD_LDAP, @@ -71,7 +70,6 @@ module('Acceptance | auth-methods | read', function (hooks) { await visit(urls.orgScope); await click(commonSelectors.HREF(urls.orgAuthMethods)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.orgAuthMethods); }); @@ -80,7 +78,6 @@ module('Acceptance | auth-methods | read', function (hooks) { await visit(urls.globalScope); await click(commonSelectors.HREF(urls.globalAuthMethods)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.globalAuthMethods); }); @@ -100,7 +97,6 @@ module('Acceptance | auth-methods | read', function (hooks) { await click( selectors.TABLE_ROW_NAME_LINK(instances.passwordAuthMethodOrg.id), ); - await a11yAudit(); assert.strictEqual(currentURL(), urls.passwordAuthMethodOrg); }); @@ -120,7 +116,6 @@ module('Acceptance | auth-methods | read', function (hooks) { await click( selectors.TABLE_ROW_NAME_LINK(instances.oidcAuthMethodGlobal.id), ); - await a11yAudit(); assert.strictEqual(currentURL(), urls.oidcAuthMethodGlobal); }); diff --git a/ui/admin/tests/acceptance/auth-methods/update-test.js b/ui/admin/tests/acceptance/auth-methods/update-test.js index ff8744f9d..722bc7eb5 100644 --- a/ui/admin/tests/acceptance/auth-methods/update-test.js +++ b/ui/admin/tests/acceptance/auth-methods/update-test.js @@ -8,7 +8,6 @@ import { visit, click, fillIn, select, findAll } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { @@ -445,7 +444,6 @@ module('Acceptance | auth-methods | update', function (hooks) { await click(commonSelectors.EDIT_BTN); await fillIn(commonSelectors.FIELD_NAME, commonSelectors.FIELD_NAME_VALUE); await click(commonSelectors.SAVE_BTN); - await a11yAudit(); assert.dom(commonSelectors.ALERT_TOAST_BODY).hasText(errorMessage); assert.dom(commonSelectors.FIELD_NAME_ERROR).hasText(errorDescription); @@ -480,7 +478,6 @@ module('Acceptance | auth-methods | update', function (hooks) { await click(commonSelectors.EDIT_BTN); await fillIn(selectors.FIELD_URLS, ''); await click(commonSelectors.SAVE_BTN); - await a11yAudit(); assert.dom(commonSelectors.ALERT_TOAST_BODY).hasText(errorMessage); assert.dom(commonSelectors.FIELD_ERROR).hasText(errorDescription); diff --git a/ui/admin/tests/acceptance/authentication-test.js b/ui/admin/tests/acceptance/authentication-test.js index 9045ffd8f..856e52393 100644 --- a/ui/admin/tests/acceptance/authentication-test.js +++ b/ui/admin/tests/acceptance/authentication-test.js @@ -16,7 +16,6 @@ import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; import { setupIntl } from 'ember-intl/test-support'; import { Response } from 'miragejs'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { currentSession, authenticateSession, @@ -136,7 +135,6 @@ module('Acceptance | authentication', function (hooks) { test('visiting auth methods authenticate route redirects to first auth method', async function (assert) { await visit(authenticateURL); - await a11yAudit(); assert.strictEqual(currentURL(), authMethodAuthenticateURL); }); @@ -146,7 +144,6 @@ module('Acceptance | authentication', function (hooks) { return new Response(404); }); await visit(authMethodAuthenticateURL); - await a11yAudit(); assert.strictEqual(currentURL(), authMethodAuthenticateURL); }); @@ -249,7 +246,6 @@ module('Acceptance | authentication', function (hooks) { test('visiting auth method authenticate route', async function (assert) { await visit(authMethodAuthenticateURL); - await a11yAudit(); assert.strictEqual(currentURL(), authMethodAuthenticateURL); }); diff --git a/ui/admin/tests/acceptance/credential-library/create-test.js b/ui/admin/tests/acceptance/credential-library/create-test.js index 208143da1..08c2d3580 100644 --- a/ui/admin/tests/acceptance/credential-library/create-test.js +++ b/ui/admin/tests/acceptance/credential-library/create-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, click, fillIn, currentURL, select } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { Response } from 'miragejs'; import { TYPE_CREDENTIAL_LIBRARY_VAULT_SSH_CERTIFICATE } from 'api/models/credential-library'; @@ -77,12 +76,10 @@ module('Acceptance | credential-libraries | create', function (hooks) { test('visiting credential libraries', async function (assert) { await visit(urls.credentialLibraries); - await a11yAudit(); assert.strictEqual(currentURL(), urls.credentialLibraries); await visit(urls.credentialLibrary); - await a11yAudit(); assert.strictEqual(currentURL(), urls.credentialLibrary); }); diff --git a/ui/admin/tests/acceptance/credential-library/read-test.js b/ui/admin/tests/acceptance/credential-library/read-test.js index 87fd41190..95ac057cd 100644 --- a/ui/admin/tests/acceptance/credential-library/read-test.js +++ b/ui/admin/tests/acceptance/credential-library/read-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, click, currentURL } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { TYPE_CREDENTIAL_LIBRARY_VAULT_SSH_CERTIFICATE } from 'api/models/credential-library'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -72,7 +71,6 @@ module('Acceptance | credential-libraries | read', function (hooks) { await visit(urls.credentialLibraries); await click(commonSelectors.TABLE_RESOURCE_LINK(urls.credentialLibrary)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.credentialLibrary); }); @@ -110,7 +108,7 @@ module('Acceptance | credential-libraries | read', function (hooks) { test('visiting an unknown credential library displays 404 message', async function (assert) { await visit(urls.unknownCredentialLibrary); - await a11yAudit(); + assert .dom(commonSelectors.RESOURCE_NOT_FOUND_SUBTITLE) .hasText(commonSelectors.RESOURCE_NOT_FOUND_VALUE); diff --git a/ui/admin/tests/acceptance/credential-store/credentials/read-test.js b/ui/admin/tests/acceptance/credential-store/credentials/read-test.js index 0bd63679a..79a8f70fb 100644 --- a/ui/admin/tests/acceptance/credential-store/credentials/read-test.js +++ b/ui/admin/tests/acceptance/credential-store/credentials/read-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, find, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -84,12 +83,10 @@ module('Acceptance | credential-stores | credentials | read', function (hooks) { test('visiting username & password credential', async function (assert) { await visit(urls.staticCredentialStore); await click(commonSelectors.HREF(urls.credentials)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.credentials); await click(commonSelectors.HREF(urls.usernamePasswordCredential)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.usernamePasswordCredential); }); @@ -97,12 +94,10 @@ module('Acceptance | credential-stores | credentials | read', function (hooks) { test('visiting username & key pair credential', async function (assert) { await visit(urls.staticCredentialStore); await click(commonSelectors.HREF(urls.credentials)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.credentials); await click(commonSelectors.HREF(urls.usernameKeyPairCredential)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.usernameKeyPairCredential); }); @@ -111,12 +106,10 @@ module('Acceptance | credential-stores | credentials | read', function (hooks) { featuresService.enable('json-credentials'); await visit(urls.staticCredentialStore); await click(commonSelectors.HREF(urls.credentials)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.credentials); await click(commonSelectors.HREF(urls.jsonCredential)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.jsonCredential); }); @@ -180,7 +173,6 @@ module('Acceptance | credential-stores | credentials | read', function (hooks) { test('visiting an unknown credential displays 404 message', async function (assert) { await visit(urls.unknownCredential); - await a11yAudit(); assert .dom(commonSelectors.RESOURCE_NOT_FOUND_SUBTITLE) diff --git a/ui/admin/tests/acceptance/credential-store/read-test.js b/ui/admin/tests/acceptance/credential-store/read-test.js index a1239b0ec..d94e9b737 100644 --- a/ui/admin/tests/acceptance/credential-store/read-test.js +++ b/ui/admin/tests/acceptance/credential-store/read-test.js @@ -8,7 +8,6 @@ import { visit, click, currentURL } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -71,12 +70,10 @@ module('Acceptance | credential-stores | read', function (hooks) { featuresService.enable('static-credentials'); await visit(urls.credentialStores); - await a11yAudit(); assert.strictEqual(currentURL(), urls.credentialStores); await click(commonSelectors.HREF(urls.staticCredentialStore)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.staticCredentialStore); }); @@ -87,7 +84,6 @@ module('Acceptance | credential-stores | read', function (hooks) { await click(commonSelectors.HREF(urls.vaultCredentialStore)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.vaultCredentialStore); }); @@ -129,7 +125,6 @@ module('Acceptance | credential-stores | read', function (hooks) { test('visiting an unknown credential store displays 404 message', async function (assert) { await visit(urls.unknownCredentialStore); - await a11yAudit(); assert .dom(commonSelectors.RESOURCE_NOT_FOUND_SUBTITLE) .hasText(commonSelectors.RESOURCE_NOT_FOUND_VALUE); diff --git a/ui/admin/tests/acceptance/groups/members-test.js b/ui/admin/tests/acceptance/groups/members-test.js index 94c70eccb..c89b0f602 100644 --- a/ui/admin/tests/acceptance/groups/members-test.js +++ b/ui/admin/tests/acceptance/groups/members-test.js @@ -8,7 +8,6 @@ import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -58,7 +57,6 @@ module('Acceptance | groups | members', function (hooks) { test('visiting group members', async function (assert) { await visit(urls.members); - await a11yAudit(); assert.strictEqual(currentURL(), urls.members); assert.dom(commonSelectors.TABLE_ROWS).exists({ count: membersCount }); @@ -112,7 +110,7 @@ module('Acceptance | groups | members', function (hooks) { test('visiting member selection', async function (assert) { await visit(urls.addMembers); - await a11yAudit(); + assert.strictEqual(currentURL(), urls.addMembers); }); diff --git a/ui/admin/tests/acceptance/groups/read-test.js b/ui/admin/tests/acceptance/groups/read-test.js index e74ee7468..90d33cad7 100644 --- a/ui/admin/tests/acceptance/groups/read-test.js +++ b/ui/admin/tests/acceptance/groups/read-test.js @@ -8,7 +8,6 @@ import { visit, currentURL } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -49,7 +48,6 @@ module('Acceptance | groups | read', function (hooks) { test('visiting a group', async function (assert) { await visit(urls.newGroup); - await a11yAudit(); assert.strictEqual(currentURL(), urls.newGroup); }); diff --git a/ui/admin/tests/acceptance/host-catalogs/host-sets/hosts-test.js b/ui/admin/tests/acceptance/host-catalogs/host-sets/hosts-test.js index c39b12afa..a0138fd40 100644 --- a/ui/admin/tests/acceptance/host-catalogs/host-sets/hosts-test.js +++ b/ui/admin/tests/acceptance/host-catalogs/host-sets/hosts-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click, fillIn } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -80,7 +79,6 @@ module('Acceptance | host-catalogs | host-sets | hosts', function (hooks) { test('visiting host set hosts', async function (assert) { const count = getHostSetHostCount(); await visit(urls.hostSetHosts); - await a11yAudit(); assert.strictEqual(currentURL(), urls.hostSetHosts); assert.dom(commonSelectors.TABLE_ROWS).exists({ count }); @@ -136,7 +134,6 @@ module('Acceptance | host-catalogs | host-sets | hosts', function (hooks) { test('visiting add hosts', async function (assert) { await visit(urls.addHosts); - await a11yAudit(); assert.strictEqual(currentURL(), urls.addHosts); }); @@ -228,7 +225,6 @@ module('Acceptance | host-catalogs | host-sets | hosts', function (hooks) { test('visiting host creation from a host set', async function (assert) { await visit(urls.createAndAddHost); - await a11yAudit(); assert.strictEqual(currentURL(), urls.createAndAddHost); }); diff --git a/ui/admin/tests/acceptance/host-catalogs/host-sets/read-test.js b/ui/admin/tests/acceptance/host-catalogs/host-sets/read-test.js index 0f16ec815..d5df51755 100644 --- a/ui/admin/tests/acceptance/host-catalogs/host-sets/read-test.js +++ b/ui/admin/tests/acceptance/host-catalogs/host-sets/read-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -69,12 +68,10 @@ module('Acceptance | host-catalogs | host-sets | read', function (hooks) { test('visiting host sets', async function (assert) { await visit(urls.hostSets); - await a11yAudit(); assert.strictEqual(currentURL(), urls.hostSets); await click(commonSelectors.HREF(urls.hostSet)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.hostSet); }); @@ -93,7 +90,6 @@ module('Acceptance | host-catalogs | host-sets | read', function (hooks) { test('visiting an unknown host set displays 404 message', async function (assert) { await visit(urls.unknownHostSet); - await a11yAudit(); assert .dom(commonSelectors.RESOURCE_NOT_FOUND_SUBTITLE) diff --git a/ui/admin/tests/acceptance/host-catalogs/hosts/read-test.js b/ui/admin/tests/acceptance/host-catalogs/hosts/read-test.js index 9351fcb8e..30d3f281f 100644 --- a/ui/admin/tests/acceptance/host-catalogs/hosts/read-test.js +++ b/ui/admin/tests/acceptance/host-catalogs/hosts/read-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -69,11 +68,10 @@ module('Acceptance | host-catalogs | hosts | read', function (hooks) { test('visiting hosts', async function (assert) { await visit(urls.hosts); - await a11yAudit(); + assert.strictEqual(currentURL(), urls.hosts); await click(commonSelectors.HREF(urls.host)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.host); }); @@ -90,7 +88,6 @@ module('Acceptance | host-catalogs | hosts | read', function (hooks) { test('visiting an unknown host displays 404 message', async function (assert) { await visit(urls.unknownHost); - await a11yAudit(); assert .dom(commonSelectors.RESOURCE_NOT_FOUND_SUBTITLE) diff --git a/ui/admin/tests/acceptance/host-catalogs/read-test.js b/ui/admin/tests/acceptance/host-catalogs/read-test.js index b4baafc82..7ee513aa6 100644 --- a/ui/admin/tests/acceptance/host-catalogs/read-test.js +++ b/ui/admin/tests/acceptance/host-catalogs/read-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -61,12 +60,10 @@ module('Acceptance | host-catalogs | read', function (hooks) { test('visiting host catalogs', async function (assert) { await visit(urls.hostCatalogs); - await a11yAudit(); assert.strictEqual(currentURL(), urls.hostCatalogs); await click(commonSelectors.HREF(urls.hostCatalog)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.hostCatalog); }); @@ -87,7 +84,6 @@ module('Acceptance | host-catalogs | read', function (hooks) { test('visiting an unknown host catalog displays 404 message', async function (assert) { await visit(urls.unknownHostCatalog); - await a11yAudit(); assert .dom(commonSelectors.RESOURCE_NOT_FOUND_SUBTITLE) diff --git a/ui/admin/tests/acceptance/managed-groups/create-test.js b/ui/admin/tests/acceptance/managed-groups/create-test.js index 3830123b8..686955e26 100644 --- a/ui/admin/tests/acceptance/managed-groups/create-test.js +++ b/ui/admin/tests/acceptance/managed-groups/create-test.js @@ -9,7 +9,6 @@ import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; import { authenticateSession } from 'ember-simple-auth/test-support'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { TYPE_AUTH_METHOD_OIDC, @@ -216,7 +215,6 @@ module('Acceptance | managed-groups | create', function (hooks) { await click(commonSelectors.HREF(urls.newManagedGroup)); await click(commonSelectors.SAVE_BTN); - await a11yAudit(); assert .dom(commonSelectors.ALERT_TOAST_BODY) @@ -249,7 +247,6 @@ module('Acceptance | managed-groups | create', function (hooks) { await click(commonSelectors.HREF(urls.newLdapManagedGroup)); await click(commonSelectors.SAVE_BTN); - await a11yAudit(); assert .dom(commonSelectors.ALERT_TOAST_BODY) diff --git a/ui/admin/tests/acceptance/managed-groups/delete-test.js b/ui/admin/tests/acceptance/managed-groups/delete-test.js index cabe3245c..715688f6c 100644 --- a/ui/admin/tests/acceptance/managed-groups/delete-test.js +++ b/ui/admin/tests/acceptance/managed-groups/delete-test.js @@ -8,7 +8,6 @@ import { visit, click, currentURL } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { authenticateSession } from 'ember-simple-auth/test-support'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { TYPE_AUTH_METHOD_OIDC, @@ -145,7 +144,6 @@ module('Acceptance | managed-groups | delete', function (hooks) { await click(commonSelectors.HREF(urls.managedGroup)); await click(selectors.MANAGE_DROPDOWN_MANAGED_GROUPS); await click(selectors.MANAGE_DROPDOWN_MANAGED_GROUP_DELETE); - await a11yAudit(); assert.dom(commonSelectors.ALERT_TOAST_BODY).hasText('Oops.'); assert.strictEqual(currentURL(), urls.managedGroup); @@ -168,7 +166,6 @@ module('Acceptance | managed-groups | delete', function (hooks) { await click(commonSelectors.HREF(urls.ldapManagedGroup)); await click(selectors.MANAGE_DROPDOWN_MANAGED_GROUPS); await click(selectors.MANAGE_DROPDOWN_MANAGED_GROUP_DELETE); - await a11yAudit(); assert.dom(commonSelectors.ALERT_TOAST_BODY).hasText('Oops.'); assert.strictEqual(currentURL(), urls.ldapManagedGroup); diff --git a/ui/admin/tests/acceptance/managed-groups/members-test.js b/ui/admin/tests/acceptance/managed-groups/members-test.js index 96a14f7a8..3a0345c9b 100644 --- a/ui/admin/tests/acceptance/managed-groups/members-test.js +++ b/ui/admin/tests/acceptance/managed-groups/members-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { TYPE_AUTH_METHOD_OIDC } from 'api/models/auth-method'; @@ -61,7 +60,6 @@ module('Acceptance | managed-groups | members', function (hooks) { const membersCount = instances.managedGroup.memberIds.length; await visit(urls.managedGroupMembers); - await a11yAudit(); assert.strictEqual(currentURL(), urls.managedGroupMembers); assert.ok(membersCount); assert.dom('tbody tr').exists({ count: membersCount }); diff --git a/ui/admin/tests/acceptance/managed-groups/read-test.js b/ui/admin/tests/acceptance/managed-groups/read-test.js index fb73e42e7..3fe458a11 100644 --- a/ui/admin/tests/acceptance/managed-groups/read-test.js +++ b/ui/admin/tests/acceptance/managed-groups/read-test.js @@ -8,7 +8,6 @@ import { visit, click, currentURL } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { authenticateSession } from 'ember-simple-auth/test-support'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { TYPE_AUTH_METHOD_OIDC, TYPE_AUTH_METHOD_LDAP, @@ -78,7 +77,6 @@ module('Acceptance | managed-groups | read', function (hooks) { await visit(urls.managedGroups); await click(commonSelectors.HREF(urls.managedGroup)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.managedGroup); }); @@ -87,7 +85,6 @@ module('Acceptance | managed-groups | read', function (hooks) { await visit(urls.ldapManagedGroups); await click(commonSelectors.HREF(urls.ldapManagedGroup)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.ldapManagedGroup); }); diff --git a/ui/admin/tests/acceptance/policy/create-test.js b/ui/admin/tests/acceptance/policy/create-test.js index 66b3a12cb..f42f53a89 100644 --- a/ui/admin/tests/acceptance/policy/create-test.js +++ b/ui/admin/tests/acceptance/policy/create-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click, fillIn, select } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -161,7 +160,6 @@ module('Acceptance | policies | create', function (hooks) { await click(commonSelectors.HREF(urls.newPolicy)); await click(commonSelectors.SAVE_BTN); - await a11yAudit(); assert.dom(commonSelectors.ALERT_TOAST_BODY).hasText(errorMessage); }); diff --git a/ui/admin/tests/acceptance/policy/read-test.js b/ui/admin/tests/acceptance/policy/read-test.js index 84428f36f..b6ec1c170 100644 --- a/ui/admin/tests/acceptance/policy/read-test.js +++ b/ui/admin/tests/acceptance/policy/read-test.js @@ -8,7 +8,6 @@ import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -55,12 +54,9 @@ module('Acceptance | policies | read', function (hooks) { test('visiting a policy', async function (assert) { await visit(urls.globalScope); - await a11yAudit(); await click(commonSelectors.HREF(urls.policies)); - await a11yAudit(); await click(commonSelectors.HREF(urls.policy)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.policy); }); @@ -77,7 +73,6 @@ module('Acceptance | policies | read', function (hooks) { test('visiting an unknown policy displays 404 message', async function (assert) { await visit(urls.unknownPolicy); - await a11yAudit(); assert .dom(commonSelectors.RESOURCE_NOT_FOUND_SUBTITLE) diff --git a/ui/admin/tests/acceptance/roles/create-test.js b/ui/admin/tests/acceptance/roles/create-test.js index b3a5cc97f..3a8f391c0 100644 --- a/ui/admin/tests/acceptance/roles/create-test.js +++ b/ui/admin/tests/acceptance/roles/create-test.js @@ -8,7 +8,6 @@ import { visit, currentURL, click, fillIn } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as selectors from './selectors'; @@ -140,7 +139,6 @@ module('Acceptance | roles | create', function (hooks) { await fillIn(commonSelectors.FIELD_NAME, commonSelectors.FIELD_NAME_VALUE); await click(commonSelectors.SAVE_BTN); - await a11yAudit(); assert.dom(commonSelectors.ALERT_TOAST_BODY).hasText(errorMsg); }); diff --git a/ui/admin/tests/acceptance/roles/global-scope-test.js b/ui/admin/tests/acceptance/roles/global-scope-test.js index 9bda46181..625e5261a 100644 --- a/ui/admin/tests/acceptance/roles/global-scope-test.js +++ b/ui/admin/tests/acceptance/roles/global-scope-test.js @@ -16,7 +16,6 @@ import { import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { GRANT_SCOPE_THIS, @@ -81,16 +80,9 @@ module('Acceptance | roles | global-scope', function (hooks) { }); test('visiting role scopes', async function (assert) { - // TODO: address issue with ICU-15021 - // Failing due to a11y violation while in dark mode. - // Investigating issue with styles not properly - // being applied during test. - const session = this.owner.lookup('service:session'); - session.set('data.theme', 'light'); await visit(urls.role); await click(commonSelectors.HREF(urls.roleScopes)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.roleScopes); assert @@ -295,7 +287,6 @@ module('Acceptance | roles | global-scope', function (hooks) { await click(selectors.MANAGE_DROPDOWN_ROLES); await click(selectors.MANAGE_DROPDOWN_ROLES_SCOPES); - await a11yAudit(); assert.strictEqual(currentURL(), urls.manageScopes); @@ -410,7 +401,6 @@ module('Acceptance | roles | global-scope', function (hooks) { assert.strictEqual(currentURL(), urls.manageScopes); await click(commonSelectors.HREF(urls.manageCustomScopes)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.manageCustomScopes); @@ -839,7 +829,6 @@ module('Acceptance | roles | global-scope', function (hooks) { await click(selectors.MANAGE_DROPDOWN_ROLES_SCOPES); await click(commonSelectors.HREF(urls.manageCustomScopes)); await click(commonSelectors.TABLE_RESOURCE_LINK(urls.manageScopesOrg)); - await a11yAudit(); // Click three times to select, unselect, then reselect (for coverage) await click( diff --git a/ui/admin/tests/acceptance/roles/grants-test.js b/ui/admin/tests/acceptance/roles/grants-test.js index 4e49607ba..66dee9096 100644 --- a/ui/admin/tests/acceptance/roles/grants-test.js +++ b/ui/admin/tests/acceptance/roles/grants-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click, fillIn } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as selectors from './selectors'; @@ -54,7 +53,6 @@ module('Acceptance | roles | grants', function (hooks) { test('visiting role grants', async function (assert) { await visit(urls.grants); - await a11yAudit(); assert.strictEqual(currentURL(), urls.grants); assert.dom(selectors.FIELD_GRANT).exists({ count: grantsCount() }); diff --git a/ui/admin/tests/acceptance/roles/org-scope-test.js b/ui/admin/tests/acceptance/roles/org-scope-test.js index 91212d296..a9e9a80b9 100644 --- a/ui/admin/tests/acceptance/roles/org-scope-test.js +++ b/ui/admin/tests/acceptance/roles/org-scope-test.js @@ -15,7 +15,6 @@ import { import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as selectors from './selectors'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -87,7 +86,6 @@ module('Acceptance | roles | org-scope', function (hooks) { await visit(urls.role); await click(commonSelectors.HREF(urls.roleScopes)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.roleScopes); assert @@ -248,7 +246,6 @@ module('Acceptance | roles | org-scope', function (hooks) { await click(selectors.MANAGE_DROPDOWN_ROLES); await click(selectors.MANAGE_DROPDOWN_ROLES_SCOPES); - await a11yAudit(); assert.strictEqual(currentURL(), urls.manageScopes); @@ -354,7 +351,6 @@ module('Acceptance | roles | org-scope', function (hooks) { await click(selectors.MANAGE_DROPDOWN_ROLES); await click(selectors.MANAGE_DROPDOWN_ROLES_SCOPES); await click(commonSelectors.HREF(urls.manageOrgProjects)); - await a11yAudit(); // Click three times to select, unselect, then reselect (for coverage) await click( @@ -388,7 +384,6 @@ module('Acceptance | roles | org-scope', function (hooks) { await click(selectors.MANAGE_DROPDOWN_ROLES); await click(selectors.MANAGE_DROPDOWN_ROLES_SCOPES); await click(commonSelectors.HREF(urls.manageOrgProjects)); - await a11yAudit(); // Click three times to select, unselect, then reselect (for coverage) await click( diff --git a/ui/admin/tests/acceptance/roles/principals-test.js b/ui/admin/tests/acceptance/roles/principals-test.js index 695afea97..c87adf085 100644 --- a/ui/admin/tests/acceptance/roles/principals-test.js +++ b/ui/admin/tests/acceptance/roles/principals-test.js @@ -8,7 +8,6 @@ import { visit, currentURL, click, findAll } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as selectors from './selectors'; @@ -61,7 +60,6 @@ module('Acceptance | roles | principals', function (hooks) { test('visiting role principals', async function (assert) { await visit(urls.rolePrincipals); - await a11yAudit(); assert.strictEqual(currentURL(), urls.rolePrincipals); assert.strictEqual(findAll('tbody tr').length, principalsCount); diff --git a/ui/admin/tests/acceptance/roles/project-scope-test.js b/ui/admin/tests/acceptance/roles/project-scope-test.js index 8758a8aa4..93409a52e 100644 --- a/ui/admin/tests/acceptance/roles/project-scope-test.js +++ b/ui/admin/tests/acceptance/roles/project-scope-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { GRANT_SCOPE_THIS } from 'api/models/role'; import * as selectors from './selectors'; @@ -56,7 +55,6 @@ module('Acceptance | roles | project-scope', function (hooks) { await visit(urls.role); await click(commonSelectors.HREF(urls.roleScopes)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.roleScopes); assert.dom(selectors.GRANT_SCOPE_ROW(GRANT_SCOPE_THIS)).isVisible(); diff --git a/ui/admin/tests/acceptance/roles/read-test.js b/ui/admin/tests/acceptance/roles/read-test.js index 34db697c7..9f2b71a39 100644 --- a/ui/admin/tests/acceptance/roles/read-test.js +++ b/ui/admin/tests/acceptance/roles/read-test.js @@ -8,7 +8,6 @@ import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -61,7 +60,6 @@ module('Acceptance | roles | read', function (hooks) { test('visiting roles', async function (assert) { await visit(urls.roles); - await a11yAudit(); assert.strictEqual(currentURL(), urls.roles); }); @@ -71,7 +69,6 @@ module('Acceptance | roles | read', function (hooks) { await click(commonSelectors.HREF(urls.roles)); await click(commonSelectors.TABLE_RESOURCE_LINK(urls.role)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.role); }); @@ -94,7 +91,6 @@ module('Acceptance | roles | read', function (hooks) { await visit(urls.roles); await click(commonSelectors.TABLE_RESOURCE_LINK(urls.role)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.role); }); diff --git a/ui/admin/tests/acceptance/scopes-test.js b/ui/admin/tests/acceptance/scopes-test.js index 43e556c23..a53aff262 100644 --- a/ui/admin/tests/acceptance/scopes-test.js +++ b/ui/admin/tests/acceptance/scopes-test.js @@ -8,7 +8,6 @@ import { visit, currentURL, click, fillIn } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -85,7 +84,6 @@ module('Acceptance | scopes', function (hooks) { test('visiting global scope', async function (assert) { await visit(urls.globalScope); - await a11yAudit(); assert.strictEqual(currentURL(), urls.globalScope); }); @@ -107,14 +105,12 @@ module('Acceptance | scopes', function (hooks) { test('visiting org scope', async function (assert) { await visit(urls.orgScopes); - await a11yAudit(); assert.strictEqual(currentURL(), urls.orgScopes); }); test('can navigate among org scopes via side-nav', async function (assert) { await visit(urls.globalScope); - await a11yAudit(); assert.strictEqual(currentURL(), urls.globalScope); @@ -130,7 +126,6 @@ module('Acceptance | scopes', function (hooks) { test('can navigate among project scopes via side-nav', async function (assert) { await visit(urls.projectScope); - await a11yAudit(); assert.strictEqual(currentURL(), urls.projectTargets); diff --git a/ui/admin/tests/acceptance/scopes/add-storage-policy-test.js b/ui/admin/tests/acceptance/scopes/add-storage-policy-test.js index 1798229d7..eb9114448 100644 --- a/ui/admin/tests/acceptance/scopes/add-storage-policy-test.js +++ b/ui/admin/tests/acceptance/scopes/add-storage-policy-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, click, currentURL } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import select from '@ember/test-helpers/dom/select'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -72,7 +71,6 @@ module('Acceptance | scope | add storage policy', function (hooks) { assert.false(featuresService.isEnabled('ssh-session-recording')); await visit(urls.orgScopeEdit); - await a11yAudit(); assert.dom(selectors.STORAGE_POLICY_SIDEBAR).doesNotExist(); }); diff --git a/ui/admin/tests/acceptance/scopes/read-test.js b/ui/admin/tests/acceptance/scopes/read-test.js index 6d43d42bd..f517f8a83 100644 --- a/ui/admin/tests/acceptance/scopes/read-test.js +++ b/ui/admin/tests/acceptance/scopes/read-test.js @@ -8,7 +8,6 @@ import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; import * as selectors from './selectors'; @@ -53,10 +52,8 @@ module('Acceptance | scopes | read', function (hooks) { test('visiting org scope edit', async function (assert) { await visit(urls.orgScope); - await a11yAudit(); await click(commonSelectors.HREF(urls.orgScopeEdit)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.orgScopeEdit); assert.dom(commonSelectors.FORM).isVisible(); @@ -64,18 +61,10 @@ module('Acceptance | scopes | read', function (hooks) { }); test('visiting global scope settings when feature flag is enabled', async function (assert) { - // TODO: address issue with ICU-15021 - // Failing due to a11y violation while in dark mode. - // Investigating issue with styles not properly - // being applied during test. - const session = this.owner.lookup('service:session'); - session.set('data.theme', 'light'); features.enable('ssh-session-recording'); await visit(urls.globalScope); - await a11yAudit(); await click(commonSelectors.HREF(urls.globalScopeEdit)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.globalScopeEdit); assert.dom(commonSelectors.FORM).isVisible(); diff --git a/ui/admin/tests/acceptance/session-recordings/read-test.js b/ui/admin/tests/acceptance/session-recordings/read-test.js index 94f51a749..825c892a3 100644 --- a/ui/admin/tests/acceptance/session-recordings/read-test.js +++ b/ui/admin/tests/acceptance/session-recordings/read-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; import { setupIntl } from 'ember-intl/test-support'; @@ -72,21 +71,13 @@ module('Acceptance | session-recordings | read', function (hooks) { }); test('visiting a session recording', async function (assert) { - // TODO: address issue with ICU-15021 - // Failing due to a11y violation while in dark mode. - // Investigating issue with styles not properly - // being applied during test. - const session = this.owner.lookup('service:session'); - session.set('data.theme', 'light'); featuresService.enable('ssh-session-recording'); await visit(urls.globalScope); // Visit session recordings await click(commonSelectors.HREF(urls.sessionRecordings)); - await a11yAudit(); // Click a session recording and check it navigates properly await click(selectors.TABLE_FIRST_ROW_ACTION_LINK); - await a11yAudit(); assert.strictEqual(currentURL(), urls.sessionRecording); }); diff --git a/ui/admin/tests/acceptance/session-recordings/session-recording/channels-by-connection/channel-test.js b/ui/admin/tests/acceptance/session-recordings/session-recording/channels-by-connection/channel-test.js index 243ed3388..8be857ea8 100644 --- a/ui/admin/tests/acceptance/session-recordings/session-recording/channels-by-connection/channel-test.js +++ b/ui/admin/tests/acceptance/session-recordings/session-recording/channels-by-connection/channel-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { Response } from 'miragejs'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; @@ -89,7 +88,6 @@ module( // Visit channel await click(commonSelectors.HREF(urls.channelRecording)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.channelRecording); }); diff --git a/ui/admin/tests/acceptance/sessions/list-test.js b/ui/admin/tests/acceptance/sessions/list-test.js index acf3bd61d..bb1b57d3d 100644 --- a/ui/admin/tests/acceptance/sessions/list-test.js +++ b/ui/admin/tests/acceptance/sessions/list-test.js @@ -8,7 +8,6 @@ import { visit, currentURL, click, fillIn, waitFor } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { faker } from '@faker-js/faker'; @@ -114,10 +113,8 @@ module('Acceptance | sessions | list', function (hooks) { test('visiting sessions', async function (assert) { await visit(urls.projectScope); - await a11yAudit(); await click(commonSelectors.HREF(urls.sessions)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.sessions); assert @@ -127,7 +124,6 @@ module('Acceptance | sessions | list', function (hooks) { test('users cannot navigate to sessions tab without proper authorization', async function (assert) { await visit(urls.orgScope); - await a11yAudit(); instances.scopes.project.authorized_collection_actions.sessions = instances.scopes.project.authorized_collection_actions.sessions.filter( (item) => item !== 'list', diff --git a/ui/admin/tests/acceptance/storage-buckets/read-test.js b/ui/admin/tests/acceptance/storage-buckets/read-test.js index 1a9cfc9c4..b82dc2438 100644 --- a/ui/admin/tests/acceptance/storage-buckets/read-test.js +++ b/ui/admin/tests/acceptance/storage-buckets/read-test.js @@ -8,7 +8,6 @@ import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -57,7 +56,6 @@ module('Acceptance | storage-buckets | read', function (hooks) { await visit(urls.storageBuckets); await click(commonSelectors.HREF(urls.storageBucket)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.storageBucket); }); @@ -78,7 +76,6 @@ module('Acceptance | storage-buckets | read', function (hooks) { test('visiting an unknown storage bucket displays 404 message', async function (assert) { await visit(urls.unknownStorageBucket); - await a11yAudit(); assert .dom(commonSelectors.RESOURCE_NOT_FOUND_SUBTITLE) diff --git a/ui/admin/tests/acceptance/targets/brokered-credential-sources-test.js b/ui/admin/tests/acceptance/targets/brokered-credential-sources-test.js index 75a40747c..14763e07e 100644 --- a/ui/admin/tests/acceptance/targets/brokered-credential-sources-test.js +++ b/ui/admin/tests/acceptance/targets/brokered-credential-sources-test.js @@ -8,7 +8,6 @@ import { visit, click, currentURL } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { Response } from 'miragejs'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; import * as selectors from './selectors'; @@ -126,7 +125,6 @@ module('Acceptance | targets | brokered credential sources', function (hooks) { test('visiting target brokered credential sources', async function (assert) { await visit(urls.brokeredCredentialSources); - await a11yAudit(); assert.strictEqual(currentURL(), urls.brokeredCredentialSources); assert @@ -138,7 +136,6 @@ module('Acceptance | targets | brokered credential sources', function (hooks) { await visit(urls.brokeredCredentialSources); await click(commonSelectors.TABLE_RESOURCE_LINK(urls.credentialLibrary)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.credentialLibrary); }); @@ -150,7 +147,6 @@ module('Acceptance | targets | brokered credential sources', function (hooks) { await visit(urls.brokeredCredentialSources); await click(commonSelectors.TABLE_RESOURCE_LINK(urls.credential)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.credential); }); @@ -169,7 +165,6 @@ module('Acceptance | targets | brokered credential sources', function (hooks) { test('visiting add brokered credential sources', async function (assert) { await visit(urls.addBrokeredCredentialSources); - await a11yAudit(); assert.strictEqual(currentURL(), urls.addBrokeredCredentialSources); }); diff --git a/ui/admin/tests/acceptance/targets/create-alias-test.js b/ui/admin/tests/acceptance/targets/create-alias-test.js index 9f165bc1d..238ec1a15 100644 --- a/ui/admin/tests/acceptance/targets/create-alias-test.js +++ b/ui/admin/tests/acceptance/targets/create-alias-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, click, fillIn, getContext } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; @@ -181,7 +180,6 @@ module('Acceptance | targets | create-alias', function (hooks) { await click(commonSelectors.HREF(urls.target)); await click(selectors.ALIASES_ADD_BTN); await click(commonSelectors.SAVE_BTN); - await a11yAudit(); assert .dom(commonSelectors.ALERT_TOAST_BODY) diff --git a/ui/admin/tests/acceptance/targets/enable-session-recording-test.js b/ui/admin/tests/acceptance/targets/enable-session-recording-test.js index 72f4fe7fb..0c340cc38 100644 --- a/ui/admin/tests/acceptance/targets/enable-session-recording-test.js +++ b/ui/admin/tests/acceptance/targets/enable-session-recording-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, find, click, currentURL, select } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; import * as selectors from './selectors'; @@ -84,7 +83,6 @@ module('Acceptance | targets | enable session recording', function (hooks) { test('cannot enable session recording for a target without proper authorization', async function (assert) { await visit(urls.target); - await a11yAudit(); assert.false(featuresService.isEnabled('ssh-session-recording')); assert.dom(selectors.ENABLE_RECORDING_BTN).doesNotExist(); diff --git a/ui/admin/tests/acceptance/targets/enable-session-recording/index-test.js b/ui/admin/tests/acceptance/targets/enable-session-recording/index-test.js index aef7ed499..7cd758133 100644 --- a/ui/admin/tests/acceptance/targets/enable-session-recording/index-test.js +++ b/ui/admin/tests/acceptance/targets/enable-session-recording/index-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, find, click, currentURL } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { TYPE_TARGET_SSH } from 'api/models/target'; import select from '@ember/test-helpers/dom/select'; @@ -93,7 +92,6 @@ module( assert.false(featuresService.isEnabled('ssh-session-recording')); await visit(urls.target); - await a11yAudit(); assert.dom(SESSION_RECORDING_ENABLE_BTN).doesNotExist(); }); diff --git a/ui/admin/tests/acceptance/targets/host-sources-test.js b/ui/admin/tests/acceptance/targets/host-sources-test.js index 27c45478a..d3d251d53 100644 --- a/ui/admin/tests/acceptance/targets/host-sources-test.js +++ b/ui/admin/tests/acceptance/targets/host-sources-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -88,7 +87,6 @@ module('Acceptance | targets | host-sources', function (hooks) { await visit(urls.target); await click(commonSelectors.HREF(urls.targetHostSources)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.targetHostSources); assert @@ -100,7 +98,6 @@ module('Acceptance | targets | host-sources', function (hooks) { await visit(urls.targetHostSources); await click(commonSelectors.HREF(urls.hostSet)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.hostSet); }); diff --git a/ui/admin/tests/acceptance/targets/injected-application-credential-sources-test.js b/ui/admin/tests/acceptance/targets/injected-application-credential-sources-test.js index 35e18f43d..bf83c266d 100644 --- a/ui/admin/tests/acceptance/targets/injected-application-credential-sources-test.js +++ b/ui/admin/tests/acceptance/targets/injected-application-credential-sources-test.js @@ -8,7 +8,6 @@ import { visit, click, currentURL } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { Response } from 'miragejs'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { TYPE_TARGET_SSH } from 'api/models/target'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -125,7 +124,6 @@ module( test('visiting target injected application credential sources', async function (assert) { await visit(urls.injectedApplicationCredentialSources); - await a11yAudit(); assert.strictEqual( currentURL(), @@ -140,7 +138,6 @@ module( await visit(urls.injectedApplicationCredentialSources); await click(commonSelectors.TABLE_RESOURCE_LINK(urls.credentialLibrary)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.credentialLibrary); }); @@ -154,14 +151,12 @@ module( await visit(urls.injectedApplicationCredentialSources); await click(commonSelectors.TABLE_RESOURCE_LINK(urls.credential)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.credential); }); test('visiting add injected application credential sources', async function (assert) { await visit(urls.addInjectedApplicationCredentialSources); - await a11yAudit(); assert.strictEqual( currentURL(), diff --git a/ui/admin/tests/acceptance/targets/manage-alias-test.js b/ui/admin/tests/acceptance/targets/manage-alias-test.js index a8d3212f1..04f11d264 100644 --- a/ui/admin/tests/acceptance/targets/manage-alias-test.js +++ b/ui/admin/tests/acceptance/targets/manage-alias-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { TYPE_TARGET_TCP, TYPE_TARGET_SSH } from 'api/models/target'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -93,7 +92,6 @@ module('Acceptance | targets | manage-alias', function (hooks) { await click(selectors.LINK_LIST_ITEM); assert.strictEqual(currentURL(), urls.tcpAlias); - await a11yAudit(); }); test('clicking on `clear alias` from the dropdown should remove the destination ID and alias should disapper from the target sidebar', async function (assert) { diff --git a/ui/admin/tests/acceptance/targets/read-test.js b/ui/admin/tests/acceptance/targets/read-test.js index 4b0386b90..0bb1a580d 100644 --- a/ui/admin/tests/acceptance/targets/read-test.js +++ b/ui/admin/tests/acceptance/targets/read-test.js @@ -9,7 +9,6 @@ import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; import { setupIntl } from 'ember-intl/test-support'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { TYPE_TARGET_TCP, TYPE_TARGET_SSH } from 'api/models/target'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -92,12 +91,10 @@ module('Acceptance | targets | read', function (hooks) { await visit(urls.projectScope); await click(commonSelectors.HREF(urls.targets)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.targets); await click(commonSelectors.HREF(urls.sshTarget)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.sshTarget); }); @@ -109,7 +106,6 @@ module('Acceptance | targets | read', function (hooks) { assert.strictEqual(currentURL(), urls.targets); await click(commonSelectors.HREF(urls.tcpTarget)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.tcpTarget); }); @@ -142,7 +138,6 @@ module('Acceptance | targets | read', function (hooks) { test('visiting an unknown target displays 404 message', async function (assert) { await visit(urls.unknownTarget); - await a11yAudit(); assert .dom(commonSelectors.RESOURCE_NOT_FOUND_SUBTITLE) diff --git a/ui/admin/tests/acceptance/targets/workers-test.js b/ui/admin/tests/acceptance/targets/workers-test.js index 827edc243..b10a6f35c 100644 --- a/ui/admin/tests/acceptance/targets/workers-test.js +++ b/ui/admin/tests/acceptance/targets/workers-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click, fillIn } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; import * as selectors from './selectors'; @@ -72,16 +71,9 @@ module('Acceptance | targets | workers', function (hooks) { }); test('visiting target workers', async function (assert) { - // TODO: address issue with ICU-15021 - // Failing due to a11y violation while in dark mode. - // Investigating issue with styles not properly - // being applied during test. - const session = this.owner.lookup('service:session'); - session.set('data.theme', 'light'); await visit(urls.target); await click(commonSelectors.HREF(urls.targetWorkers)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.targetWorkers); }); diff --git a/ui/admin/tests/acceptance/users/accounts-test.js b/ui/admin/tests/acceptance/users/accounts-test.js index 5a3588a0d..c0dfa86bc 100644 --- a/ui/admin/tests/acceptance/users/accounts-test.js +++ b/ui/admin/tests/acceptance/users/accounts-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { Response } from 'miragejs'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { @@ -69,7 +68,6 @@ module('Acceptance | users | accounts', function (hooks) { await visit(urls.user); await click(commonSelectors.HREF(urls.accounts)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.accounts); assert.dom(commonSelectors.TABLE_ROWS).exists({ count: accountsCount }); @@ -171,7 +169,6 @@ module('Acceptance | users | accounts', function (hooks) { await click(selectors.MANAGE_DROPDOWN_USER); await click(selectors.MANAGE_DROPDOWN_USER_ADD_ACCOUNTS); - await a11yAudit(); assert.strictEqual(currentURL(), urls.addAccounts); }); diff --git a/ui/admin/tests/acceptance/users/read-test.js b/ui/admin/tests/acceptance/users/read-test.js index 08705f19d..ec60a5a00 100644 --- a/ui/admin/tests/acceptance/users/read-test.js +++ b/ui/admin/tests/acceptance/users/read-test.js @@ -8,7 +8,6 @@ import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -48,10 +47,8 @@ module('Acceptance | users | read', function (hooks) { test('visiting users', async function (assert) { await visit(urls.orgScope); - await a11yAudit(); await click(commonSelectors.HREF(urls.users)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.users); }); @@ -60,7 +57,6 @@ module('Acceptance | users | read', function (hooks) { await visit(urls.users); await click(commonSelectors.HREF(urls.user)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.user); }); diff --git a/ui/admin/tests/acceptance/workers/create-tags-test.js b/ui/admin/tests/acceptance/workers/create-tags-test.js index 12ab0747a..3806f4946 100644 --- a/ui/admin/tests/acceptance/workers/create-tags-test.js +++ b/ui/admin/tests/acceptance/workers/create-tags-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, click, fillIn } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; import * as selectors from './selectors'; @@ -51,7 +50,6 @@ module('Acceptance | workers | worker | create-tags', function (hooks) { await click(selectors.MANAGE_DROPDOWN_WORKER); await click(selectors.MANAGE_DROPDOWN_WORKER_CREATE_TAGS); - await a11yAudit(); assert.strictEqual(currentURL(), urls.createTags); }); diff --git a/ui/admin/tests/acceptance/workers/read-test.js b/ui/admin/tests/acceptance/workers/read-test.js index 94eace54a..d43c4fda4 100644 --- a/ui/admin/tests/acceptance/workers/read-test.js +++ b/ui/admin/tests/acceptance/workers/read-test.js @@ -8,7 +8,6 @@ import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { setupIndexedDb } from 'api/test-support/helpers/indexed-db'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -54,14 +53,7 @@ module('Acceptance | workers | read', function (hooks) { }); test('visiting worker', async function (assert) { - // TODO: address issue with ICU-15021 - // Failing due to a11y violation while in dark mode. - // Investigating issue with styles not properly - // being applied during test. - const session = this.owner.lookup('service:session'); - session.set('data.theme', 'light'); await visit(urls.workers); - await a11yAudit(); await click(commonSelectors.HREF(urls.worker)); diff --git a/ui/admin/tests/acceptance/workers/tags-test.js b/ui/admin/tests/acceptance/workers/tags-test.js index 0912f4a3a..5d1ddc0a5 100644 --- a/ui/admin/tests/acceptance/workers/tags-test.js +++ b/ui/admin/tests/acceptance/workers/tags-test.js @@ -14,7 +14,6 @@ import { } from '@ember/test-helpers'; import { setupApplicationTest } from 'admin/tests/helpers'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import { HCP_MANAGED_KEY } from 'api/models/worker'; import * as commonSelectors from 'admin/tests/helpers/selectors'; @@ -53,7 +52,6 @@ module('Acceptance | workers | worker | tags', function (hooks) { await visit(urls.worker); await click(commonSelectors.HREF(urls.tags)); - await a11yAudit(); assert.strictEqual(currentURL(), urls.tags); assert.dom(commonSelectors.TABLE_ROWS).exists({ count: 11 }); diff --git a/ui/desktop/README.md b/ui/desktop/README.md index bf45ca755..89cb8c174 100644 --- a/ui/desktop/README.md +++ b/ui/desktop/README.md @@ -148,8 +148,6 @@ of testing". Use test coverage as a guide to help you identify untested high-value code. We rely on `ember-a11y-testing` to validate accessibility in acceptance tests. -If you write acceptance tests, please ensure at least one validation per -route using `await a11yAudit();`. ### Running end to end Tests diff --git a/ui/desktop/tests/acceptance/authentication-test.js b/ui/desktop/tests/acceptance/authentication-test.js index afd2bb75f..34af52648 100644 --- a/ui/desktop/tests/acceptance/authentication-test.js +++ b/ui/desktop/tests/acceptance/authentication-test.js @@ -14,7 +14,6 @@ import { import { setupApplicationTest } from 'ember-qunit'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { Response } from 'miragejs'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { currentSession, authenticateSession, @@ -153,7 +152,7 @@ module('Acceptance | authentication', function (hooks) { test('visiting index while unauthenticated redirects to global authenticate method', async function (assert) { assert.expect(2); await visit(urls.index); - await a11yAudit(); + assert.notOk(currentSession().isAuthenticated); assert.strictEqual(currentURL(), urls.authenticate.methods.global); }); @@ -162,7 +161,7 @@ module('Acceptance | authentication', function (hooks) { assert.expect(1); this.owner.lookup('service:clusterUrl').rendererClusterUrl = null; await visit(urls.authenticate.global); - await a11yAudit(); + assert.strictEqual(currentURL(), urls.clusterUrl); }); @@ -172,7 +171,7 @@ module('Acceptance | authentication', function (hooks) { return new Response(404); }); await visit(urls.authenticate.global); - await a11yAudit(); + assert.strictEqual(currentURL(), urls.authenticate.methods.global); }); diff --git a/ui/desktop/tests/acceptance/cluster-url-test.js b/ui/desktop/tests/acceptance/cluster-url-test.js index 14d7db380..2071a1eac 100644 --- a/ui/desktop/tests/acceptance/cluster-url-test.js +++ b/ui/desktop/tests/acceptance/cluster-url-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL, fillIn, click, find } from '@ember/test-helpers'; import { setupApplicationTest } from 'ember-qunit'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import sinon from 'sinon'; import { invalidateSession } from 'ember-simple-auth/test-support'; import { setupBrowserFakes } from 'ember-browser-services/test-support'; @@ -109,7 +108,7 @@ module('Acceptance | clusterUrl', function (hooks) { test('visiting index', async function (assert) { assert.expect(1); await visit(urls.clusterUrl); - await a11yAudit(); + assert.strictEqual(currentURL(), urls.clusterUrl); }); @@ -117,7 +116,7 @@ module('Acceptance | clusterUrl', function (hooks) { assert.expect(2); setupMockIpc(this); await visit(urls.index); - await a11yAudit(); + assert.notOk(mockIPC.clusterUrl); assert.strictEqual(currentURL(), urls.clusterUrl); }); diff --git a/ui/desktop/tests/acceptance/projects-test.js b/ui/desktop/tests/acceptance/projects-test.js index 3574276c5..4c8be1da7 100644 --- a/ui/desktop/tests/acceptance/projects-test.js +++ b/ui/desktop/tests/acceptance/projects-test.js @@ -7,7 +7,6 @@ import { module, test } from 'qunit'; import { visit, currentURL } from '@ember/test-helpers'; import { setupApplicationTest } from 'ember-qunit'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { currentSession, authenticateSession, @@ -105,7 +104,7 @@ module('Acceptance | projects', function (hooks) { await invalidateSession(); assert.expect(2); await visit(urls.projects); - await a11yAudit(); + assert.notOk(currentSession().isAuthenticated); assert.strictEqual(currentURL(), urls.authenticate.methods.global); }); @@ -113,7 +112,7 @@ module('Acceptance | projects', function (hooks) { test('visiting index', async function (assert) { assert.expect(1); await visit(urls.projects); - await a11yAudit(); + assert.strictEqual(currentURL(), urls.projects); }); }); diff --git a/ui/desktop/tests/acceptance/projects/sessions/index-test.js b/ui/desktop/tests/acceptance/projects/sessions/index-test.js index e1dd3090e..768708add 100644 --- a/ui/desktop/tests/acceptance/projects/sessions/index-test.js +++ b/ui/desktop/tests/acceptance/projects/sessions/index-test.js @@ -8,7 +8,6 @@ import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'ember-qunit'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { Response } from 'miragejs'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import WindowMockIPC from '../../../helpers/window-mock-ipc'; import { currentSession, @@ -170,7 +169,6 @@ module('Acceptance | projects | sessions | index', function (hooks) { this.stubCacheDaemonSearch(); await visit(urls.sessions); - await a11yAudit(); assert.notOk(currentSession().isAuthenticated); assert.strictEqual(currentURL(), urls.authenticate.methods.global); @@ -193,24 +191,16 @@ module('Acceptance | projects | sessions | index', function (hooks) { await visit(urls.projects); await click(`[href="${urls.sessions}"]`); - await a11yAudit(); assert.dom(APP_STATE_TITLE).hasText('No Sessions Available'); }); test('visiting sessions without targets is OK', async function (assert) { - // TODO: address issue with ICU-15021 - // Failing due to a11y violation while in dark mode. - // Investigating issue with styles not properly - // being applied during test. - const session = this.owner.lookup('service:session'); - session.set('data.theme', 'light'); instances.session.update({ targetId: undefined }); const sessionsCount = this.server.schema.sessions.all().models.length; await visit(urls.projects); await click(`[href="${urls.sessions}"]`); - await a11yAudit(); assert.strictEqual(currentURL(), urls.sessions); assert.dom('tbody tr').exists({ count: sessionsCount }); diff --git a/ui/desktop/tests/acceptance/projects/sessions/session-test.js b/ui/desktop/tests/acceptance/projects/sessions/session-test.js index 0325fecfd..50ea1a5fc 100644 --- a/ui/desktop/tests/acceptance/projects/sessions/session-test.js +++ b/ui/desktop/tests/acceptance/projects/sessions/session-test.js @@ -10,7 +10,6 @@ import { visit, currentURL, click } from '@ember/test-helpers'; import { setupApplicationTest } from 'ember-qunit'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { Response } from 'miragejs'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { authenticateSession } from 'ember-simple-auth/test-support'; import WindowMockIPC from '../../../helpers/window-mock-ipc'; import { STATUS_SESSION_ACTIVE } from 'api/models/session'; @@ -129,7 +128,6 @@ module('Acceptance | projects | sessions | session', function (hooks) { assert.expect(1); await visit(urls.session); - await a11yAudit(); assert.strictEqual(currentURL(), urls.session); }); diff --git a/ui/desktop/tests/acceptance/projects/targets/index-test.js b/ui/desktop/tests/acceptance/projects/targets/index-test.js index 19c5df779..fa3d8378b 100644 --- a/ui/desktop/tests/acceptance/projects/targets/index-test.js +++ b/ui/desktop/tests/acceptance/projects/targets/index-test.js @@ -12,7 +12,6 @@ import { } from '@ember/test-helpers'; import { setupApplicationTest } from 'ember-qunit'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import WindowMockIPC from '../../../helpers/window-mock-ipc'; import { authenticateSession, @@ -168,24 +167,16 @@ module('Acceptance | projects | targets | index', function (hooks) { await invalidateSession(); this.stubCacheDaemonSearch(); await visit(urls.targets); - await a11yAudit(); assert.notOk(currentSession().isAuthenticated); assert.strictEqual(currentURL(), urls.authenticate.methods.global); }); test('visiting targets index', async function (assert) { - // TODO: address issue with ICU-15021 - // Failing due to a11y violation while in dark mode. - // Investigating issue with styles not properly - // being applied during test. - const session = this.owner.lookup('service:session'); - session.set('data.theme', 'light'); const targetsCount = getTargetCount(); await visit(urls.projects); await click(`[href="${urls.targets}"]`); - await a11yAudit(); assert.dom('.hds-segmented-group').exists(); assert.strictEqual(currentURL(), urls.targets); diff --git a/ui/desktop/tests/acceptance/scopes-test.js b/ui/desktop/tests/acceptance/scopes-test.js index 40be6405c..84f13e9db 100644 --- a/ui/desktop/tests/acceptance/scopes-test.js +++ b/ui/desktop/tests/acceptance/scopes-test.js @@ -15,7 +15,6 @@ import { import { setupApplicationTest } from 'ember-qunit'; import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; import { Response } from 'miragejs'; -import a11yAudit from 'ember-a11y-testing/test-support/audit'; import { currentSession, authenticateSession, @@ -157,16 +156,9 @@ module('Acceptance | scopes', function (hooks) { }); test('visiting global scope', async function (assert) { - // TODO: address issue with ICU-15021 - // Failing due to a11y violation while in dark mode. - // Investigating issue with styles not properly - // being applied during test. - const session = this.owner.lookup('service:session'); - session.set('data.theme', 'light'); assert.expect(1); await visit(urls.scopes.global); - await a11yAudit(); assert.strictEqual(currentURL(), urls.globalTargets); }); @@ -176,12 +168,6 @@ module('Acceptance | scopes', function (hooks) { // In order to resolve this, we might hoist authentication routes up from // under scopes. test('visiting global scope is not successful when the global scope cannot be fetched', async function (assert) { - // TODO: address issue with ICU-15021 - // Failing due to a11y violation while in dark mode. - // Investigating issue with styles not properly - // being applied during test. - const session = this.owner.lookup('service:session'); - session.set('data.theme', 'light'); assert.expect(1); this.server.get('/scopes/:id', ({ scopes }, { params: { id } }) => { const scope = scopes.find(id); @@ -190,22 +176,14 @@ module('Acceptance | scopes', function (hooks) { }); await visit(urls.scopes.global); - await a11yAudit(); assert.strictEqual(currentURL(), urls.globalTargets); }); test('visiting org scope', async function (assert) { - // TODO: address issue with ICU-15021 - // Failing due to a11y violation while in dark mode. - // Investigating issue with styles not properly - // being applied during test. - const session = this.owner.lookup('service:session'); - session.set('data.theme', 'light'); assert.expect(1); await visit(urls.scopes.org); - await a11yAudit(); assert.strictEqual(currentURL(), urls.targets); }); @@ -249,7 +227,6 @@ module('Acceptance | scopes', function (hooks) { this.stubCacheDaemonSearch(); await visit(urls.targets); - await a11yAudit(); assert.notOk(currentSession().isAuthenticated); assert.strictEqual(currentURL(), urls.authenticate.methods.global);