From 4659b54e9e33905dbdb9d3e6c988767585e534c6 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Thu, 19 Aug 2021 17:52:27 -0400 Subject: [PATCH] =?UTF-8?q?feat:=20=F0=9F=8E=B8=20add=20ui-level=20navigat?= =?UTF-8?q?ion=20ability?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- ui/admin/app/abilities/collection.js | 30 +++++++++++++++++++ .../tests/unit/abilities/collection-test.js | 29 ++++++++++++++++++ ui/desktop/app/abilities/collection.js | 30 +++++++++++++++++++ .../tests/unit/abilities/collection-test.js | 29 ++++++++++++++++++ 4 files changed, 118 insertions(+) create mode 100644 ui/admin/app/abilities/collection.js create mode 100644 ui/admin/tests/unit/abilities/collection-test.js create mode 100644 ui/desktop/app/abilities/collection.js create mode 100644 ui/desktop/tests/unit/abilities/collection-test.js diff --git a/ui/admin/app/abilities/collection.js b/ui/admin/app/abilities/collection.js new file mode 100644 index 000000000..c40786021 --- /dev/null +++ b/ui/admin/app/abilities/collection.js @@ -0,0 +1,30 @@ +import CollectionAbility from 'api/abilities/collection'; +import { inject as service } from '@ember/service'; + +export default class OverrideModelAbility extends CollectionAbility { + // =services + + @service features; + + // =permissions + + /** + * Navigating to a resource is allowed if either list or create grants + * are present. + * @type {boolean} + */ + get canNavigate() { + return this.canList || this.canCreate; + } + + // =methods + + /** + * If the capabilities feature flag is disabled, actions are always + * authorized. This mimics pre-capabilities behavior. + */ + hasAuthorizedCollectionAction() { + if (!this.features.isEnabled('capabilities')) return true; + return super.hasAuthorizedCollectionAction(...arguments); + } +} diff --git a/ui/admin/tests/unit/abilities/collection-test.js b/ui/admin/tests/unit/abilities/collection-test.js new file mode 100644 index 000000000..586eb52b4 --- /dev/null +++ b/ui/admin/tests/unit/abilities/collection-test.js @@ -0,0 +1,29 @@ +import { module, test } from 'qunit'; +import { setupTest } from 'ember-qunit'; + +module('Unit | Abilities | Collection', function (hooks) { + setupTest(hooks); + + test('it reflects when a resource may be navigated to based on list and create actions', function (assert) { + assert.expect(4); + const service = this.owner.lookup('service:can'); + const model = { + authorized_collection_actions: { foobars: [] }, + }; + assert.notOk( + service.can('navigate collection', model, { collection: 'foobars' }) + ); + model.authorized_collection_actions.foobars = ['list']; + assert.ok( + service.can('navigate collection', model, { collection: 'foobars' }) + ); + model.authorized_collection_actions.foobars = ['create']; + assert.ok( + service.can('navigate collection', model, { collection: 'foobars' }) + ); + model.authorized_collection_actions.foobars = ['list', 'create']; + assert.ok( + service.can('navigate collection', model, { collection: 'foobars' }) + ); + }); +}); diff --git a/ui/desktop/app/abilities/collection.js b/ui/desktop/app/abilities/collection.js new file mode 100644 index 000000000..c40786021 --- /dev/null +++ b/ui/desktop/app/abilities/collection.js @@ -0,0 +1,30 @@ +import CollectionAbility from 'api/abilities/collection'; +import { inject as service } from '@ember/service'; + +export default class OverrideModelAbility extends CollectionAbility { + // =services + + @service features; + + // =permissions + + /** + * Navigating to a resource is allowed if either list or create grants + * are present. + * @type {boolean} + */ + get canNavigate() { + return this.canList || this.canCreate; + } + + // =methods + + /** + * If the capabilities feature flag is disabled, actions are always + * authorized. This mimics pre-capabilities behavior. + */ + hasAuthorizedCollectionAction() { + if (!this.features.isEnabled('capabilities')) return true; + return super.hasAuthorizedCollectionAction(...arguments); + } +} diff --git a/ui/desktop/tests/unit/abilities/collection-test.js b/ui/desktop/tests/unit/abilities/collection-test.js new file mode 100644 index 000000000..586eb52b4 --- /dev/null +++ b/ui/desktop/tests/unit/abilities/collection-test.js @@ -0,0 +1,29 @@ +import { module, test } from 'qunit'; +import { setupTest } from 'ember-qunit'; + +module('Unit | Abilities | Collection', function (hooks) { + setupTest(hooks); + + test('it reflects when a resource may be navigated to based on list and create actions', function (assert) { + assert.expect(4); + const service = this.owner.lookup('service:can'); + const model = { + authorized_collection_actions: { foobars: [] }, + }; + assert.notOk( + service.can('navigate collection', model, { collection: 'foobars' }) + ); + model.authorized_collection_actions.foobars = ['list']; + assert.ok( + service.can('navigate collection', model, { collection: 'foobars' }) + ); + model.authorized_collection_actions.foobars = ['create']; + assert.ok( + service.can('navigate collection', model, { collection: 'foobars' }) + ); + model.authorized_collection_actions.foobars = ['list', 'create']; + assert.ok( + service.can('navigate collection', model, { collection: 'foobars' }) + ); + }); +});