From 48cc8596dcb5cd8710269fab795b6c563ab7febc Mon Sep 17 00:00:00 2001
From: Carlos Alcaide <me@calcaide.com>
Date: Wed, 23 Jun 2021 13:48:51 -0700
Subject: [PATCH] =?UTF-8?q?chore:=20=F0=9F=A4=96=20Finish=20up=20some=20st?=
 =?UTF-8?q?yles?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Finish up some styles. Deleted old commented code and add a temporary
lint ignore comment for no-bare-strings in targets.hbs
---
 ui/desktop/app/styles/app.scss                | 10 +++-
 .../scopes/scope/projects/targets.hbs         | 57 ++-----------------
 2 files changed, 13 insertions(+), 54 deletions(-)

diff --git a/ui/desktop/app/styles/app.scss b/ui/desktop/app/styles/app.scss
index 7e2357988..4abf9c368 100644
--- a/ui/desktop/app/styles/app.scss
+++ b/ui/desktop/app/styles/app.scss
@@ -395,14 +395,20 @@ $chevron-down: url("data:image/svg+xml;utf-8,<svg viewBox='0 0 24 24' fill='%231
   }
 
   &:not([open]) {
+    .reveal-trigger-text-close {
+      background: $chevron-down no-repeat right center;
+      padding-right: sizing.rems(l);
+    }
+
     .reveal-trigger-text-open {
       display: none;
     }
   }
 
   &[open] {
-    .reveal-trigger {
-      background: url($chevron-up) no-repeat right center;
+    .reveal-trigger-text-open {
+      background: $chevron-up no-repeat right center;
+      padding-right: sizing.rems(l);
     }
 
     .reveal-trigger-text-close {
diff --git a/ui/desktop/app/templates/scopes/scope/projects/targets.hbs b/ui/desktop/app/templates/scopes/scope/projects/targets.hbs
index 54ee518d8..cf3eddfc4 100644
--- a/ui/desktop/app/templates/scopes/scope/projects/targets.hbs
+++ b/ui/desktop/app/templates/scopes/scope/projects/targets.hbs
@@ -1,3 +1,5 @@
+{{! template-lint-disable no-bare-strings  }}
+
 {{page-title (t 'resources.target.title_plural')}}
 
 {{#each @model as |target|}}
@@ -85,41 +87,6 @@
                   </table.body>
                 </Rose::Table>
               </:body>
-            </Card>
-            {{!--  <Rose::Separator />
-
-            <h3>Credentials</h3>
-
-            <Card @heading="Credentials" @icon='app-icons/credentials'>
-              <:header>
-                <Rose::Dropdown
-                  @style="condensed"
-                  @text="Credential library details"
-                  @showCaret={{true}}
-                  as |dropdown|
-                >
-                </Rose::Dropdown>
-              </:header>
-              <:body>
-                <Rose::Table @style='condensed' as |table|>
-                  <table.header as |header|>
-                    <header.row as |row|>
-                      <row.headerCell>Key</row.headerCell>
-                      <row.headerCell colspan='2'>Value</row.headerCell>
-                    </header.row>
-                  </table.header>
-                  <table.body as |body|>
-                    <body.row as |row|>
-                      <row.headerCell>foo</row.headerCell>
-                      <row.cell>Value</row.cell>
-                    </body.row>
-                    <body.row as |row|>
-                      <row.headerCell>ttl</row.headerCell>
-                      <row.cell>Test</row.cell>
-                    </body.row>
-                  </table.body>
-                </Rose::Table>
-              </:body>
               <:footer>
                 <Reveal
                   @textWhenOpen='Hide content'
@@ -127,18 +94,13 @@
                 >
                   <pre>
                     <code>
-  {
-    "auth": null,
-    "lease_duration": 3600,
-    "lease_id": "",
-    "renewable": false
-  }
+                      { "auth": null, "lease_duration": 3600, "lease_id": "",
+                      "renewable": false }
                     </code>
                   </pre>
                 </Reveal>
               </:footer>
-            </Card> --}}
-
+            </Card>
           </:body>
           <:footer>
             <div>
@@ -149,15 +111,6 @@
                 {{t 'actions.close'}}
               </Rose::Button>
             </div>
-            <div>
-              {{! <Rose::LinkButton
-              @route='scopes.scope.projects.sessions'
-              @style='inline-link-action'
-              @iconRight='chevron-right'
-            >
-              View sessions
-            </Rose::LinkButton> }}
-            </div>
           </:footer>
         </DialogDetail>
       {{/unless}}