From 6f5e2ce2e930b21d48ec8b905eec79d49e5d35e7 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Tue, 23 Feb 2021 16:55:49 -0500 Subject: [PATCH 1/5] =?UTF-8?q?chore:=20=F0=9F=A4=96=20change=20macos=20us?= =?UTF-8?q?er-facing=20app=20name=20to=20"Boundary"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit also update asset filenames to "Boundary" --- ui/desktop/electron-app/config/cli.js | 2 +- ui/desktop/electron-app/config/forge.config.js | 4 ++-- ui/desktop/electron-app/package.json | 2 +- ui/desktop/electron-app/src/menu.js | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ui/desktop/electron-app/config/cli.js b/ui/desktop/electron-app/config/cli.js index 2e6858008..b3a24e434 100644 --- a/ui/desktop/electron-app/config/cli.js +++ b/ui/desktop/electron-app/config/cli.js @@ -10,7 +10,7 @@ const artifactDestination = path.resolve(__dirname, '..', 'cli'); const downloadArtifact = version => { const url = `https://releases.hashicorp.com/boundary/${version}/boundary_${version}_darwin_amd64.zip`; return new Promise((resolve, reject) => { - const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'boundary-desktop-artifact-')) + const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'boundary-artifact-')) console.log('Create tmp artifact directory: ', tmpDir); const artifactFileName = url.split('/').pop(); diff --git a/ui/desktop/electron-app/config/forge.config.js b/ui/desktop/electron-app/config/forge.config.js index 5eb335012..092522ce1 100644 --- a/ui/desktop/electron-app/config/forge.config.js +++ b/ui/desktop/electron-app/config/forge.config.js @@ -25,7 +25,7 @@ module.exports = { "/ember-test(/|$)", "/tests(/|$)" ], - name: "Boundary Desktop", + name: "Boundary", appBundleId: "com.electron.boundary", // TODO: where should the client version number come from? appVersion: `${formattedAppVersion}${formattedCLIVersion}\n`, @@ -44,7 +44,7 @@ module.exports = { name: "@electron-forge/maker-dmg", config: { title: "Boundary", - name: "boundary-desktop", + name: "boundary", icon: "./config/macos/disk.icns", background: "./config/macos/background.png" } diff --git a/ui/desktop/electron-app/package.json b/ui/desktop/electron-app/package.json index 69caf84b0..774beacec 100644 --- a/ui/desktop/electron-app/package.json +++ b/ui/desktop/electron-app/package.json @@ -1,6 +1,6 @@ { "name": "desktop", - "productName": "Boundary Desktop", + "productName": "Boundary", "version": "0.0.0", "private": true, "description": "Electron UI for client for Boundary.", diff --git a/ui/desktop/electron-app/src/menu.js b/ui/desktop/electron-app/src/menu.js index 8e37595bc..1047bb8a6 100644 --- a/ui/desktop/electron-app/src/menu.js +++ b/ui/desktop/electron-app/src/menu.js @@ -4,7 +4,7 @@ const generateMenuTemplate = () => { return [ // { role: 'appMenu' } { - label: 'Boundary Desktop', + label: 'Boundary', submenu: [ { role: 'about' }, { type: 'separator' }, @@ -86,4 +86,4 @@ const generateMenuTemplate = () => { module.exports = { generateMenuTemplate: generateMenuTemplate -}; \ No newline at end of file +}; From 2b77c25238bc9ad2bb8f970d31d493f9cb3285ea Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Tue, 23 Feb 2021 16:56:10 -0500 Subject: [PATCH 2/5] chore: update readme regarding name change --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index af9ca0b99..b645d2c1a 100644 --- a/README.md +++ b/README.md @@ -120,7 +120,7 @@ To provide a signing identify for macOS build, use `BOUNDARY_DESKTOP_SIGNING_IDE environment variable to set signing certificate name (e.g Developer ID Application: * (*)). Assets are saved to `ui/desktop/electron-app/out/make/`. -DMG packaged desktop UI is available at asset location as `Boundary Desktop.dmg`. +DMG packaged desktop UI is available at asset location as `Boundary.dmg`. ### Committing From a0f8e0d2ae662ec699d7d1f349bd9c6a29411fc2 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Tue, 23 Feb 2021 17:01:11 -0500 Subject: [PATCH 3/5] docs: tweak readme filename casing --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b645d2c1a..71733826a 100644 --- a/README.md +++ b/README.md @@ -120,7 +120,7 @@ To provide a signing identify for macOS build, use `BOUNDARY_DESKTOP_SIGNING_IDE environment variable to set signing certificate name (e.g Developer ID Application: * (*)). Assets are saved to `ui/desktop/electron-app/out/make/`. -DMG packaged desktop UI is available at asset location as `Boundary.dmg`. +DMG packaged desktop UI is available at asset location as `boundary.dmg`. ### Committing From b861352389eadb1b12f5fa31d9644e2b99953dfd Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Tue, 23 Feb 2021 17:13:30 -0500 Subject: [PATCH 4/5] docs: add changelog entry for app name change --- ui/desktop/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/desktop/CHANGELOG.md b/ui/desktop/CHANGELOG.md index cee2b0afe..1b30e6a2d 100644 --- a/ui/desktop/CHANGELOG.md +++ b/ui/desktop/CHANGELOG.md @@ -7,6 +7,7 @@ Canonical reference for changes, improvements, and bugfixes for Boundary Desktop ### Changes/Deprecations +- Boundary Desktop is now simply "Boundary". This change affects macOS asset filenames, as well as the title used within the application. Documentation will continue to use the name "Boundary Desktop" to avoid confusion with the core binary. ([PR](https://github.com/hashicorp/boundary-ui/pull/481)) - Boundary origin validation now occurs via Electron's built-in net request module, ensuring the validation request is made via chromium's networking library rather than Node's. ([PR](https://github.com/hashicorp/boundary-ui/pull/480)) ## v1.0.0-alpha (2021.02.16) From c6fd966372f6e3ce3d64d736a0df910b048022bf Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Tue, 23 Feb 2021 17:19:26 -0500 Subject: [PATCH 5/5] docs: language tweak --- ui/desktop/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/desktop/CHANGELOG.md b/ui/desktop/CHANGELOG.md index 1b30e6a2d..9ec58424c 100644 --- a/ui/desktop/CHANGELOG.md +++ b/ui/desktop/CHANGELOG.md @@ -7,7 +7,7 @@ Canonical reference for changes, improvements, and bugfixes for Boundary Desktop ### Changes/Deprecations -- Boundary Desktop is now simply "Boundary". This change affects macOS asset filenames, as well as the title used within the application. Documentation will continue to use the name "Boundary Desktop" to avoid confusion with the core binary. ([PR](https://github.com/hashicorp/boundary-ui/pull/481)) +- Boundary Desktop is now simply "Boundary". This change affects macOS asset filenames, as well as the title used within the application. Documentation will continue to refer to "Boundary Desktop" to avoid confusion with the core binary. ([PR](https://github.com/hashicorp/boundary-ui/pull/481)) - Boundary origin validation now occurs via Electron's built-in net request module, ensuring the validation request is made via chromium's networking library rather than Node's. ([PR](https://github.com/hashicorp/boundary-ui/pull/480)) ## v1.0.0-alpha (2021.02.16)