From 378fcc53c2892d9b9cb1fff65a0f6d5fa6c9add4 Mon Sep 17 00:00:00 2001
From: Carlos Alcaide <me@calcaide.com>
Date: Fri, 25 Jun 2021 09:19:39 -0700
Subject: [PATCH] =?UTF-8?q?feat:=20=F0=9F=8E=B8=20Add=20Hidden=20secret=20?=
 =?UTF-8?q?component=20within=20the=20view?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Add hidden secret component within the view and delete duplicate code
(perhaps from a rebase)
---
 .../addon/styles/rose/components/table/_table.scss    |  2 +-
 ui/desktop/app/styles/app.scss                        | 11 -----------
 .../app/templates/scopes/scope/projects/targets.hbs   |  8 +-------
 3 files changed, 2 insertions(+), 19 deletions(-)

diff --git a/addons/rose/addon/styles/rose/components/table/_table.scss b/addons/rose/addon/styles/rose/components/table/_table.scss
index 279deda1a..641b86a59 100644
--- a/addons/rose/addon/styles/rose/components/table/_table.scss
+++ b/addons/rose/addon/styles/rose/components/table/_table.scss
@@ -86,11 +86,11 @@
       }
     }
     .rose-table-header {
+      border-bottom: sizing.rems(xxxxs) solid var(--ui-gray-subtler-3);
       .rose-table-header-cell {
         $lineHeight: math.div(16, 14);
         line-height: $lineHeight;
         padding: sizing.rems(xs) sizing.rems(s);
-
         &:first-child {
           padding-left: 0;
         }
diff --git a/ui/desktop/app/styles/app.scss b/ui/desktop/app/styles/app.scss
index 5e1042934..bb493d9e8 100644
--- a/ui/desktop/app/styles/app.scss
+++ b/ui/desktop/app/styles/app.scss
@@ -464,17 +464,6 @@ $chevron-down: url("data:image/svg+xml;utf-8,<svg viewBox='0 0 24 24' fill='%231
   }
 }
 
-.hidden-secret {
-  display: flex;
-  align-items: center;
-  justify-content: space-between;
-  color: var(--ui-gray-subtler-2);
-
-  .rose-button-ghost {
-    color: var(--ui-gray-subtler-1);
-  }
-}
-
 // Hidden secret component (app/components/hidden-secret)
 .hidden-secret {
   display: flex;
diff --git a/ui/desktop/app/templates/scopes/scope/projects/targets.hbs b/ui/desktop/app/templates/scopes/scope/projects/targets.hbs
index e26742ea1..07c9655b5 100644
--- a/ui/desktop/app/templates/scopes/scope/projects/targets.hbs
+++ b/ui/desktop/app/templates/scopes/scope/projects/targets.hbs
@@ -105,13 +105,7 @@
                             <body.row as |row|>
                               <row.headerCell>{{secret.key}}</row.headerCell>
                               <row.cell colspan='2'>
-                                <Copyable
-                                  @text={{secret.value}}
-                                  @buttonText={{t 'actions.copy-to-clipboard'}}
-                                  @acknowledgeText={{t 'states.copied'}}
-                                >
-                                  {{secret.value}}
-                                </Copyable>
+                                <HiddenSecret @secret={{secret.value}} />
                               </row.cell>
                             </body.row>
                           {{/each}}