From 5844768f573b7a5bbf461b8de46a62e601846b78 Mon Sep 17 00:00:00 2001 From: Dharini Jeeva Date: Tue, 9 May 2023 14:06:05 -0700 Subject: [PATCH] =?UTF-8?q?chore:=20=F0=9F=A4=96=20add=20disable=20cred=20?= =?UTF-8?q?rotation=20field=20to=20storage=20bucket=20creation=20form=20(#?= =?UTF-8?q?246)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * chore: 🤖 add disable cred rotation field --- addons/api/addon/generated/models/storage-bucket.js | 6 ++++++ addons/api/mirage/factories/storage-bucket.js | 1 + addons/api/tests/unit/serializers/storage-bucket-test.js | 4 ++++ ui/admin/app/components/form/storage-bucket/index.hbs | 9 +++++++++ ui/admin/app/components/form/storage-bucket/index.js | 6 ++++++ 5 files changed, 26 insertions(+) diff --git a/addons/api/addon/generated/models/storage-bucket.js b/addons/api/addon/generated/models/storage-bucket.js index d81c1ade7..a1973abc6 100644 --- a/addons/api/addon/generated/models/storage-bucket.js +++ b/addons/api/addon/generated/models/storage-bucket.js @@ -85,4 +85,10 @@ export default class GeneratedStorageBucketModel extends BaseModel { description: 'The secret access key to use.', }) secret_access_key; + + @attr('boolean', { + isNestedAttribute: true, + description: '', + }) + disable_credential_rotation; } diff --git a/addons/api/mirage/factories/storage-bucket.js b/addons/api/mirage/factories/storage-bucket.js index 0946e5dae..3482d45d1 100644 --- a/addons/api/mirage/factories/storage-bucket.js +++ b/addons/api/mirage/factories/storage-bucket.js @@ -50,6 +50,7 @@ export default factory.extend({ max: 9, } )}`, + disable_credential_rotation: faker.datatype.boolean(), }; } }, diff --git a/addons/api/tests/unit/serializers/storage-bucket-test.js b/addons/api/tests/unit/serializers/storage-bucket-test.js index d3fa6dab6..b2a6aeac0 100644 --- a/addons/api/tests/unit/serializers/storage-bucket-test.js +++ b/addons/api/tests/unit/serializers/storage-bucket-test.js @@ -31,6 +31,7 @@ module('Unit | Serializer | storage bucket', function (hooks) { access_key_id: 'foobars', secret_access_key: 'testing', secrets_hmac: 'hmac', + disable_credential_rotation: true, }); const expectedResult = { name: 'AWS', @@ -41,6 +42,7 @@ module('Unit | Serializer | storage bucket', function (hooks) { worker_filter: 'workerfilter', attributes: { region: 'eu-west-1', + disable_credential_rotation: true, }, secrets: { access_key_id: 'foobars', @@ -66,6 +68,7 @@ module('Unit | Serializer | storage bucket', function (hooks) { worker_filter: 'workerfilter', attributes: { region: 'eu-west-1', + disable_credential_rotation: true, }, secrets_hmac: 'this is secret', }; @@ -90,6 +93,7 @@ module('Unit | Serializer | storage bucket', function (hooks) { worker_filter: 'workerfilter', secrets_hmac: 'this is secret', region: 'eu-west-1', + disable_credential_rotation: true, }, type: 'storage-bucket', relationships: {}, diff --git a/ui/admin/app/components/form/storage-bucket/index.hbs b/ui/admin/app/components/form/storage-bucket/index.hbs index 9acfd0855..3bd26790c 100644 --- a/ui/admin/app/components/form/storage-bucket/index.hbs +++ b/ui/admin/app/components/form/storage-bucket/index.hbs @@ -301,6 +301,15 @@ {{/if}} + + {{t 'form.disable_credential_rotation.label'}} + + {{#if (can 'save model' @model)}}