From 5947c6e08a8566307ea397ce5f36e0875c552d64 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Fri, 4 Nov 2022 19:09:07 -0700 Subject: [PATCH] chore: improve titling for new groups - icu-6715 (#1411) --- addons/core/translations/resources/en-us.yaml | 2 ++ ui/admin/app/controllers/scopes/scope/groups/new.js | 2 +- ui/admin/app/templates/scopes/scope/groups/index.hbs | 2 +- ui/admin/app/templates/scopes/scope/groups/new.hbs | 6 +++++- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/addons/core/translations/resources/en-us.yaml b/addons/core/translations/resources/en-us.yaml index 4ae6ec0c3..4e1633cee 100644 --- a/addons/core/translations/resources/en-us.yaml +++ b/addons/core/translations/resources/en-us.yaml @@ -71,6 +71,8 @@ group: no-members: title: No Members Available description: There are no members available to add to this group. + titles: + new: New Group actions: add-members: Add Members delete: Delete Group diff --git a/ui/admin/app/controllers/scopes/scope/groups/new.js b/ui/admin/app/controllers/scopes/scope/groups/new.js index 0de96d821..375c4e571 100644 --- a/ui/admin/app/controllers/scopes/scope/groups/new.js +++ b/ui/admin/app/controllers/scopes/scope/groups/new.js @@ -13,6 +13,6 @@ export default class ScopesScopeGroupsNewController extends Controller { * @type {string} */ get breadCrumb() { - return this.intl.t('titles.new'); + return this.intl.t('resources.group.titles.new'); } } diff --git a/ui/admin/app/templates/scopes/scope/groups/index.hbs b/ui/admin/app/templates/scopes/scope/groups/index.hbs index bbab758dc..9a96da07e 100644 --- a/ui/admin/app/templates/scopes/scope/groups/index.hbs +++ b/ui/admin/app/templates/scopes/scope/groups/index.hbs @@ -16,7 +16,7 @@ {{#if (can 'create model' this.scope collection='groups')}} {{#if @model}} {{t - 'titles.new' + 'resources.group.titles.new' }} {{/if}} {{/if}} diff --git a/ui/admin/app/templates/scopes/scope/groups/new.hbs b/ui/admin/app/templates/scopes/scope/groups/new.hbs index 75f491203..40191bb5f 100644 --- a/ui/admin/app/templates/scopes/scope/groups/new.hbs +++ b/ui/admin/app/templates/scopes/scope/groups/new.hbs @@ -7,7 +7,11 @@ -

{{t 'titles.new'}}

+

+ {{t 'resources.group.titles.new'}} + +

+

{{t 'resources.group.description'}}