From 644a4db908228cb96262619b9bd64dc6f5758e30 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Thu, 24 Sep 2020 12:56:45 -0400 Subject: [PATCH] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20convert=20message=20?= =?UTF-8?q?component=20to=20nested=20structure?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- addons/rose/addon/components/rose/message.js | 7 ------- .../rose/message/index.hbs} | 0 addons/rose/addon/components/rose/message/index.js | 3 +++ .../index.stories.mdx} | 0 ui/core/app/components/error/message.hbs | 2 +- ui/core/app/components/error/message.js | 12 ++++++------ 6 files changed, 10 insertions(+), 14 deletions(-) delete mode 100644 addons/rose/addon/components/rose/message.js rename addons/rose/addon/{templates/components/rose/message.hbs => components/rose/message/index.hbs} (100%) create mode 100644 addons/rose/addon/components/rose/message/index.js rename addons/rose/addon/components/rose/{message.stories.mdx => message/index.stories.mdx} (100%) diff --git a/addons/rose/addon/components/rose/message.js b/addons/rose/addon/components/rose/message.js deleted file mode 100644 index 89ac42ee5..000000000 --- a/addons/rose/addon/components/rose/message.js +++ /dev/null @@ -1,7 +0,0 @@ -import Component from '@ember/component'; -import layout from '../../templates/components/rose/message'; - -export default Component.extend({ - layout, - tagName: '', -}); diff --git a/addons/rose/addon/templates/components/rose/message.hbs b/addons/rose/addon/components/rose/message/index.hbs similarity index 100% rename from addons/rose/addon/templates/components/rose/message.hbs rename to addons/rose/addon/components/rose/message/index.hbs diff --git a/addons/rose/addon/components/rose/message/index.js b/addons/rose/addon/components/rose/message/index.js new file mode 100644 index 000000000..00b2c7c53 --- /dev/null +++ b/addons/rose/addon/components/rose/message/index.js @@ -0,0 +1,3 @@ +import Component from '@glimmer/component'; + +export default class RoseMessageComponent extends Component {} diff --git a/addons/rose/addon/components/rose/message.stories.mdx b/addons/rose/addon/components/rose/message/index.stories.mdx similarity index 100% rename from addons/rose/addon/components/rose/message.stories.mdx rename to addons/rose/addon/components/rose/message/index.stories.mdx diff --git a/ui/core/app/components/error/message.hbs b/ui/core/app/components/error/message.hbs index afcf013d9..a602536c5 100644 --- a/ui/core/app/components/error/message.hbs +++ b/ui/core/app/components/error/message.hbs @@ -1,6 +1,6 @@ {{t (concat "errors." this.messageCode ".description")}} diff --git a/ui/core/app/components/error/message.js b/ui/core/app/components/error/message.js index 21b362c5f..7dc91ca27 100644 --- a/ui/core/app/components/error/message.js +++ b/ui/core/app/components/error/message.js @@ -1,4 +1,4 @@ -import Message from 'rose/components/rose/message'; +import MessageComponent from 'rose/components/rose/message'; import { computed } from '@ember/object'; /* @@ -17,16 +17,16 @@ import { computed } from '@ember/object'; const statuses = ['401', '403', '404', '500']; -export default class ErrorMessageComponent extends Message { +export default class ErrorMessageComponent extends MessageComponent { // =methods /** * Returns an icon for error status. * @return {string} */ - @computed('status') + @computed('args.status') get icon() { - switch (this.status) { + switch (this.args.status) { case '401': case '403': return 'disabled'; @@ -51,9 +51,9 @@ export default class ErrorMessageComponent extends Message { * isn't part of predefined statuses. * @return {string} */ - @computed('status') + @computed('args.status') get messageCode() { - let messageCode = this.status; + let messageCode = this.args.status; if(!statuses.includes(messageCode)) messageCode = 'unknown'; return messageCode; }