From d3738f58589b179845351ae20a9bc5a8ed451b14 Mon Sep 17 00:00:00 2001
From: Randall Morey <randall@randallmorey.com>
Date: Wed, 7 Oct 2020 09:58:12 -0400
Subject: [PATCH 1/4] =?UTF-8?q?chore:=20=F0=9F=A4=96=20add=20missing=20pag?=
 =?UTF-8?q?e=20titles?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 ui/core/app/templates/scopes/scope/auth-methods.hbs           | 2 ++
 .../scope/auth-methods/auth-method/accounts/account.hbs       | 4 +++-
 .../auth-method/accounts/account/set-password.hbs             | 2 ++
 .../project/host-catalogs/host-catalog/host-sets/host-set.hbs | 4 +++-
 .../project/host-catalogs/host-catalog/hosts/host.hbs         | 4 +++-
 .../templates/scopes/scope/roles/role/principals/-header.hbs  | 4 ++--
 6 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/ui/core/app/templates/scopes/scope/auth-methods.hbs b/ui/core/app/templates/scopes/scope/auth-methods.hbs
index c24cd6895..fb4d78b4a 100644
--- a/ui/core/app/templates/scopes/scope/auth-methods.hbs
+++ b/ui/core/app/templates/scopes/scope/auth-methods.hbs
@@ -1 +1,3 @@
+{{title (t "resources.auth-method.title_plural")}}
+
 {{outlet}}
diff --git a/ui/core/app/templates/scopes/scope/auth-methods/auth-method/accounts/account.hbs b/ui/core/app/templates/scopes/scope/auth-methods/auth-method/accounts/account.hbs
index e2147cab0..d66e83390 100644
--- a/ui/core/app/templates/scopes/scope/auth-methods/auth-method/accounts/account.hbs
+++ b/ui/core/app/templates/scopes/scope/auth-methods/auth-method/accounts/account.hbs
@@ -1 +1,3 @@
-{{outlet}}
\ No newline at end of file
+{{title @model.displayName}}
+
+{{outlet}}
diff --git a/ui/core/app/templates/scopes/scope/auth-methods/auth-method/accounts/account/set-password.hbs b/ui/core/app/templates/scopes/scope/auth-methods/auth-method/accounts/account/set-password.hbs
index eba48df37..315877a6f 100644
--- a/ui/core/app/templates/scopes/scope/auth-methods/auth-method/accounts/account/set-password.hbs
+++ b/ui/core/app/templates/scopes/scope/auth-methods/auth-method/accounts/account/set-password.hbs
@@ -1,3 +1,5 @@
+{{title (t 'actions.set-password')}}
+
 <Form::Account::Password::SetPassword
   @model={{@model}}
   @submit={{route-action "setPassword" @model}}
diff --git a/ui/core/app/templates/scopes/scope/projects/project/host-catalogs/host-catalog/host-sets/host-set.hbs b/ui/core/app/templates/scopes/scope/projects/project/host-catalogs/host-catalog/host-sets/host-set.hbs
index e2147cab0..d66e83390 100644
--- a/ui/core/app/templates/scopes/scope/projects/project/host-catalogs/host-catalog/host-sets/host-set.hbs
+++ b/ui/core/app/templates/scopes/scope/projects/project/host-catalogs/host-catalog/host-sets/host-set.hbs
@@ -1 +1,3 @@
-{{outlet}}
\ No newline at end of file
+{{title @model.displayName}}
+
+{{outlet}}
diff --git a/ui/core/app/templates/scopes/scope/projects/project/host-catalogs/host-catalog/hosts/host.hbs b/ui/core/app/templates/scopes/scope/projects/project/host-catalogs/host-catalog/hosts/host.hbs
index e2147cab0..d66e83390 100644
--- a/ui/core/app/templates/scopes/scope/projects/project/host-catalogs/host-catalog/hosts/host.hbs
+++ b/ui/core/app/templates/scopes/scope/projects/project/host-catalogs/host-catalog/hosts/host.hbs
@@ -1 +1,3 @@
-{{outlet}}
\ No newline at end of file
+{{title @model.displayName}}
+
+{{outlet}}
diff --git a/ui/core/app/templates/scopes/scope/roles/role/principals/-header.hbs b/ui/core/app/templates/scopes/scope/roles/role/principals/-header.hbs
index 63c44f53c..8854ae095 100644
--- a/ui/core/app/templates/scopes/scope/roles/role/principals/-header.hbs
+++ b/ui/core/app/templates/scopes/scope/roles/role/principals/-header.hbs
@@ -4,9 +4,9 @@
 </h2>
 <p>{{t "resources.role.principal.description"}}</p>
 <Copyable
-  @text={{@model.id}}
+  @text={{@model.role.id}}
   @buttonText={{t "actions.copy-to-clipboard"}}
   @acknowledgeText={{t "states.copied"}}
 >
-  <code>{{@model.id}}</code>
+  <code>{{@model.role.id}}</code>
 </Copyable>

From a5811f0ea7bc4ce0541d8fd9aad2c222465f31a4 Mon Sep 17 00:00:00 2001
From: Randall Morey <randall@randallmorey.com>
Date: Wed, 7 Oct 2020 10:08:07 -0400
Subject: [PATCH 2/4] =?UTF-8?q?fix:=20=F0=9F=90=9B=20ensure=20password=20r?=
 =?UTF-8?q?eset=20is=20always=20called?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

on occassion it could break if axe is running, which is probably only an
issue when developing the UI, but to be safe...
---
 .../form/account/password/change-password/index.hbs |  2 +-
 .../form/account/password/change-password/index.js  | 13 +++++++------
 .../form/account/password/set-password/index.hbs    |  2 +-
 .../form/account/password/set-password/index.js     | 10 +++++-----
 4 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/ui/core/app/components/form/account/password/change-password/index.hbs b/ui/core/app/components/form/account/password/change-password/index.hbs
index 24548e843..954da26c1 100644
--- a/ui/core/app/components/form/account/password/change-password/index.hbs
+++ b/ui/core/app/components/form/account/password/change-password/index.hbs
@@ -1,6 +1,6 @@
 <Rose::Form
   class="full-width"
-  @onSubmit={{fn this.submit @submit}}
+  @onSubmit={{fn this.submit @submit this.currentPassword this.newPassword}}
   @cancel={{fn this.cancel @cancel}}
   @disabled={{@model.isSaving}}
   @error={{@model.errors.base}}
diff --git a/ui/core/app/components/form/account/password/change-password/index.js b/ui/core/app/components/form/account/password/change-password/index.js
index 0375feaea..ba61219ab 100644
--- a/ui/core/app/components/form/account/password/change-password/index.js
+++ b/ui/core/app/components/form/account/password/change-password/index.js
@@ -2,7 +2,7 @@ import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
 import { computed } from '@ember/object';
 import { action } from '@ember/object';
-import { next } from '@ember/runloop';
+import { run } from '@ember/runloop';
 
 export default class FormAccountPasswordChangePasswordIndexComponent extends Component {
 
@@ -50,13 +50,14 @@ export default class FormAccountPasswordChangePasswordIndexComponent extends Com
    * Call passed submit function with passwords.
    * Unset passwords before callack.
    * @param {function} fn
+   * @param {string} currentPassword
+   * @param {string} newPassword
    */
   @action
-  submit(fn) {
-    const currentPassword = this.currentPassword;
-    const newPassword = this.newPassword;
-    next(() => this.resetPasswords());
-    fn(currentPassword, newPassword);
+  submit(fn, currentPassword, newPassword) {
+    console.log(currentPassword, newPassword);
+    run(() => this.resetPasswords());
+    run(() => fn(currentPassword, newPassword));
   }
 
   /**
diff --git a/ui/core/app/components/form/account/password/set-password/index.hbs b/ui/core/app/components/form/account/password/set-password/index.hbs
index b77d6b659..9008a9094 100644
--- a/ui/core/app/components/form/account/password/set-password/index.hbs
+++ b/ui/core/app/components/form/account/password/set-password/index.hbs
@@ -1,5 +1,5 @@
 <Rose::Form
-  @onSubmit={{fn this.submit @submit}}
+  @onSubmit={{fn this.submit @submit this.password}}
   @disabled={{@model.isSaving}}
   @error={{@model.errors.base}}
   as |form|
diff --git a/ui/core/app/components/form/account/password/set-password/index.js b/ui/core/app/components/form/account/password/set-password/index.js
index 2548bca49..62df4d78c 100644
--- a/ui/core/app/components/form/account/password/set-password/index.js
+++ b/ui/core/app/components/form/account/password/set-password/index.js
@@ -2,7 +2,7 @@ import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
 import { computed } from '@ember/object';
 import { action } from '@ember/object';
-import { next } from '@ember/runloop';
+import { run } from '@ember/runloop';
 
 export default class FormAccountPasswordSetPasswordIndexComponent extends Component {
   // =properties
@@ -36,11 +36,11 @@ export default class FormAccountPasswordSetPasswordIndexComponent extends Compon
    * Submit with password value when it is allowed.
    * Callback with no arguments otherwise.
    * @param {function} fn
+   * @param {string} password
    */
   @action
-  submit(fn) {
-    const password = this.password;
-    next(() => this.resetPassword());
-    fn(password);
+  submit(fn, password) {
+    run(() => this.resetPassword());
+    run(() => fn(password));
   }
 }

From 139bf7a437e08e0a4ef91ac664de32122c2acf69 Mon Sep 17 00:00:00 2001
From: Randall Morey <randall@randallmorey.com>
Date: Wed, 7 Oct 2020 10:16:40 -0400
Subject: [PATCH 3/4] =?UTF-8?q?chore:=20=F0=9F=A4=96=20remove=20console.lo?=
 =?UTF-8?q?g=20statement?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../components/form/account/password/change-password/index.js    | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ui/core/app/components/form/account/password/change-password/index.js b/ui/core/app/components/form/account/password/change-password/index.js
index ba61219ab..e2dcd0bac 100644
--- a/ui/core/app/components/form/account/password/change-password/index.js
+++ b/ui/core/app/components/form/account/password/change-password/index.js
@@ -55,7 +55,6 @@ export default class FormAccountPasswordChangePasswordIndexComponent extends Com
    */
   @action
   submit(fn, currentPassword, newPassword) {
-    console.log(currentPassword, newPassword);
     run(() => this.resetPasswords());
     run(() => fn(currentPassword, newPassword));
   }

From d1fcab4712dbf7569dae9599f727e239f35263a7 Mon Sep 17 00:00:00 2001
From: Randall Morey <randall@randallmorey.com>
Date: Wed, 7 Oct 2020 10:33:09 -0400
Subject: [PATCH 4/4] =?UTF-8?q?chore:=20=F0=9F=A4=96=20cleanup=20tone=20in?=
 =?UTF-8?q?=20comments?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 addons/api/addon/models/group.js  | 4 ----
 addons/api/addon/models/role.js   | 4 ----
 addons/api/addon/models/target.js | 4 ----
 addons/api/addon/models/user.js   | 4 ----
 4 files changed, 16 deletions(-)

diff --git a/addons/api/addon/models/group.js b/addons/api/addon/models/group.js
index 4b6535065..59a87a180 100644
--- a/addons/api/addon/models/group.js
+++ b/addons/api/addon/models/group.js
@@ -46,8 +46,6 @@ export default class GroupModel extends GeneratedGroupModel {
       memberIDs,
     };
     // There is no "deep merge" in ES.
-    // All of this nonsense is here to ensure we get
-    // a decent merge of `adapterOptions`.
     return this.save({
       ...options,
       adapterOptions: {
@@ -71,8 +69,6 @@ export default class GroupModel extends GeneratedGroupModel {
       memberIDs,
     };
     // There is no "deep merge" in ES.
-    // All of this nonsense is here to ensure we get
-    // a decent merge of `adapterOptions`.
     return this.save({
       ...options,
       adapterOptions: {
diff --git a/addons/api/addon/models/role.js b/addons/api/addon/models/role.js
index 9e37867ad..adc7778f5 100644
--- a/addons/api/addon/models/role.js
+++ b/addons/api/addon/models/role.js
@@ -53,8 +53,6 @@ export default class RoleModel extends GeneratedRoleModel {
       principalIDs,
     };
     // There is no "deep merge" in ES.
-    // All of this nonsense is here to ensure we get
-    // a decent merge of `adapterOptions`.
     return this.save({
       ...options,
       adapterOptions: {
@@ -78,8 +76,6 @@ export default class RoleModel extends GeneratedRoleModel {
       principalIDs,
     };
     // There is no "deep merge" in ES.
-    // All of this nonsense is here to ensure we get
-    // a decent merge of `adapterOptions`.
     return this.save({
       ...options,
       adapterOptions: {
diff --git a/addons/api/addon/models/target.js b/addons/api/addon/models/target.js
index 086f95f79..c5f80ae4e 100644
--- a/addons/api/addon/models/target.js
+++ b/addons/api/addon/models/target.js
@@ -52,8 +52,6 @@ export default class TargetModel extends GeneratedTargetModel {
       hostSetIDs,
     };
     // There is no "deep merge" in ES.
-    // All of this nonsense is here to ensure we get
-    // a decent merge of `adapterOptions`.
     return this.save({
       ...options,
       adapterOptions: {
@@ -77,8 +75,6 @@ export default class TargetModel extends GeneratedTargetModel {
       hostSetIDs,
     };
     // There is no "deep merge" in ES.
-    // All of this nonsense is here to ensure we get
-    // a decent merge of `adapterOptions`.
     return this.save({
       ...options,
       adapterOptions: {
diff --git a/addons/api/addon/models/user.js b/addons/api/addon/models/user.js
index c2be5cfb0..567ebd81c 100644
--- a/addons/api/addon/models/user.js
+++ b/addons/api/addon/models/user.js
@@ -33,8 +33,6 @@ export default class UserModel extends GeneratedUserModel {
       accountIDs,
     };
     // There is no "deep merge" in ES.
-    // All of this nonsense is here to ensure we get
-    // a decent merge of `adapterOptions`.
     return this.save({
       ...options,
       adapterOptions: {
@@ -58,8 +56,6 @@ export default class UserModel extends GeneratedUserModel {
       accountIDs,
     };
     // There is no "deep merge" in ES.
-    // All of this nonsense is here to ensure we get
-    // a decent merge of `adapterOptions`.
     return this.save({
       ...options,
       adapterOptions: {