From 674882d7bdda930f8dedca31c4aeeb6651d2a0c8 Mon Sep 17 00:00:00 2001
From: Randall Morey <randall@randallmorey.com>
Date: Mon, 10 Aug 2020 16:40:03 -0400
Subject: [PATCH] =?UTF-8?q?feat:=20=F0=9F=8E=B8=20finish=20up=20grants=20U?=
 =?UTF-8?q?I?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../app/components/form/role/grants/index.hbs | 46 +++++++++++++++++++
 .../app/components/form/role/grants/index.js  | 37 +++++++++++++++
 .../routes/scopes/scope/roles/role/grants.js  | 25 +++++++++-
 .../scopes/scope/roles/role/grants.hbs        |  2 +
 ui/core/tests/acceptance/roles-test.js        | 12 +++++
 ui/core/translations/en-us.yaml               |  2 +
 6 files changed, 123 insertions(+), 1 deletion(-)
 create mode 100644 ui/core/app/components/form/role/grants/index.js

diff --git a/ui/core/app/components/form/role/grants/index.hbs b/ui/core/app/components/form/role/grants/index.hbs
index ec731c2fe..098621b45 100644
--- a/ui/core/app/components/form/role/grants/index.hbs
+++ b/ui/core/app/components/form/role/grants/index.hbs
@@ -1,3 +1,39 @@
+<Rose::Form
+  @onSubmit={{fn this.createGrant @addGrant}}
+  @cancel={{@cancel}}
+  @disabled={{@model.isSaving}}
+  as |form|
+>
+  <Rose::List::KeyValue as |list|>
+    {{!-- Add grant field (only one per form) --}}
+    <list.item as |item|>
+      <form.input
+        @contextual={{true}}
+        @name="grant"
+        @type="text"
+        @value={{this.newGrantString}}
+      as |input|>
+        <item.key>
+          <input.label>{{t "titles.new-grant"}}</input.label>
+        </item.key>
+        <item.cell>
+          <input.field />
+        </item.cell>
+        <item.cell>
+          <Rose::Button
+            @submit={{true}}
+            @disabled={{this.cannotSave}}
+            @style="secondary"
+            title={{t "actions.add"}}
+          >
+            {{t "actions.add"}}
+          </Rose::Button>
+        </item.cell>
+      </form.input>
+    </list.item>
+  </Rose::List::KeyValue>
+</Rose::Form>
+
 <Rose::Form
   @onSubmit={{@submit}}
   @cancel={{@cancel}}
@@ -33,6 +69,16 @@
             <input.field />
           </item.cell>
         </form.input>
+        <item.cell>
+          <Rose::Button
+            @style="secondary"
+            @iconOnly="trash"
+            title={{t "actions.remove"}}
+            {{on "click" (fn @removeGrant grant)}}
+          >
+            {{t "actions.remove"}}
+          </Rose::Button>
+        </item.cell>
       </list.item>
     {{/each}}
   </Rose::List::KeyValue>
diff --git a/ui/core/app/components/form/role/grants/index.js b/ui/core/app/components/form/role/grants/index.js
new file mode 100644
index 000000000..509d4356f
--- /dev/null
+++ b/ui/core/app/components/form/role/grants/index.js
@@ -0,0 +1,37 @@
+import Component from '@glimmer/component';
+import { tracked } from '@glimmer/tracking';
+import { computed, action } from '@ember/object';
+
+export default class FormRoleGrantsComponent extends Component {
+
+  // =attributes
+
+  /**
+   * @type {string}
+   */
+  @tracked newGrantString = '';
+
+  /**
+   * True if the grant string field is empty, false otherwise.  This is used
+   * to disable the submit button.
+   * @return {boolean}
+   */
+  @computed('newGrantString')
+  get cannotSave() {
+    return !this.newGrantString;
+  }
+
+  // =actions
+
+  /**
+   * Calls the passed function with the grant string as an argument and then
+   * clears the value of the grant string field.
+   * `@addGrant` should be passed by the context calling this component.
+   * @param {Function} addGrantFn
+   */
+  @action
+  createGrant(addGrantFn) {
+    addGrantFn(this.newGrantString);
+    this.newGrantString = '';
+  }
+}
diff --git a/ui/core/app/routes/scopes/scope/roles/role/grants.js b/ui/core/app/routes/scopes/scope/roles/role/grants.js
index 098de9656..a46277957 100644
--- a/ui/core/app/routes/scopes/scope/roles/role/grants.js
+++ b/ui/core/app/routes/scopes/scope/roles/role/grants.js
@@ -10,7 +10,30 @@ export default class ScopesScopeRolesRoleGrantsRoute extends Route {
   @service notify;
 
   // =methods
-  
+
+  /**
+   * Adds a new grant to the role at the beginning of the grants list.
+   * Grant creation is not immediately permanent; users may rollback the change
+   * via "cancel" or commit it via "save".
+   * @param {RoleModel} role
+   * @param {string} grantString
+   */
+  @action
+  addGrant(role, grantString) {
+    role.grants.unshiftObject({ value: grantString });
+  }
+
+  /**
+   * Removes a grant from the role.  Grant removal is not immediately permanent;
+   * users may rollback the change via "cancel" or commit it via "save".
+   * @param {RoleModel} role
+   * @param {FragmentString} grant
+   */
+  @action
+  removeGrant(role, grant) {
+    role.grants.removeFragment(grant);
+  }
+
   /**
    * Save an role in current scope.
    * @param {RoleModel} role
diff --git a/ui/core/app/templates/scopes/scope/roles/role/grants.hbs b/ui/core/app/templates/scopes/scope/roles/role/grants.hbs
index 81827f673..edb0faf13 100644
--- a/ui/core/app/templates/scopes/scope/roles/role/grants.hbs
+++ b/ui/core/app/templates/scopes/scope/roles/role/grants.hbs
@@ -4,4 +4,6 @@
   @model={{@model}}
   @submit={{route-action "save" @model}}
   @cancel={{route-action "cancel" @model}}
+  @addGrant={{route-action "addGrant" @model}}
+  @removeGrant={{route-action "removeGrant" @model}}
 />
diff --git a/ui/core/tests/acceptance/roles-test.js b/ui/core/tests/acceptance/roles-test.js
index dd8483574..7db363fbe 100644
--- a/ui/core/tests/acceptance/roles-test.js
+++ b/ui/core/tests/acceptance/roles-test.js
@@ -217,4 +217,16 @@ module('Acceptance | roles', function (hooks) {
       'Displays primary error message.'
     );
   });
+
+  test('grants can be updated and saved or canceled', async function (assert) {
+    assert.expect(0);
+  });
+
+  test('grants can be removed and saved or canceled', async function (assert) {
+    assert.expect(0);
+  });
+
+  test('new grants can be added and saved or canceled', async function (assert) {
+    assert.expect(0);
+  });
 });
diff --git a/ui/core/translations/en-us.yaml b/ui/core/translations/en-us.yaml
index c40894096..6e025b4b4 100644
--- a/ui/core/translations/en-us.yaml
+++ b/ui/core/translations/en-us.yaml
@@ -1,4 +1,5 @@
 actions:
+  add: Add
   cancel: Cancel
   delete: Delete
   dismiss: Dismiss
@@ -45,6 +46,7 @@ titles:
   roles-welcome: Welcome to Roles
   groups-welcome: Welcome to Groups
   grants: Permissions
+  new-grant: New Grant
 descriptions:
   host-catalogs: Overview of collections of hosts and host sets.
   empty-set: There are no items to display yet.  You may be able to add items or try back later.