CyberCoveLLC/threshold-ui
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Upgrade HDS dependency to 4.13 & migrate FlightIcon to Hds::Icon (#2540)

Browse Source 
* updated hds and replaced deprecated flight-icon

* removed code trying to import from ember-flight-icons

* fixing linting issue

* fixing linting issue

* fixing dropdown test selectors

* updated dropdown selectors

* updated dropdown selectors

* updated dropdown selectors

* addressing pr feedback

* fixing linting error

* updating dropdown selectors
This commit is contained in:
Zack Moore authored and GitHub committed 2024-11-04 11:29:56 -06:00
1 parent 70aceb1699
commit 6eb83b2a25
45 files changed
+111 -120
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

ui/admin/app/components/info-field/index.hbs
+1 -1
View File
@@ -5,7 +5,7 @@
<div class='info-field{{if @icon " has-icon"}}'>
{{#if @icon}}
<FlightIcon @name={{@icon}} @size='24' />
<Hds::Icon @name={{@icon}} @size='24' @isInline={{true}} />
{{/if}}
<Hds::Form::TextInput::Field
@value={{@value}}
ui/admin/app/components/link-list-panel/item/index.hbs
+2 -2
View File
@@ -18,7 +18,7 @@
</div>
</div>
<FlightIcon @name='arrow-right' />
<Hds::Icon @name='arrow-right' @isInline={{true}} />
</LinkTo>
{{else}}
<LinkTo @route={{@route}} @model={{@model}}>
@@ -33,7 +33,7 @@
</div>
</div>
<FlightIcon @name='arrow-right' />
<Hds::Icon @name='arrow-right' @isInline={{true}} />
</LinkTo>
{{/if}}
{{else}}
ui/admin/app/components/ordered-series-diagram/group/index.hbs
+1 -1
View File
@@ -24,7 +24,7 @@
{{!
Separator icon is not configurable, but potentially could be.
}}
<FlightIcon @name='arrow-right' @size='24' />
<Hds::Icon @name='arrow-right' @size='24' @isInline={{true}} />
</div>
</li>
ui/admin/app/components/ordered-series-diagram/item/index.hbs
+1 -1
View File
@@ -16,7 +16,7 @@
{{!
Separator icon is not configurable, but potentially could be.
}}
<FlightIcon @name='arrow-right' @size='24' />
<Hds::Icon @name='arrow-right' @size='24' @isInline={{true}} />
</div>
</li>
ui/admin/app/styles/app.scss
+3 -3
View File
@@ -368,7 +368,7 @@
}
&.has-icon {
.flight-icon {
.hds-icon {
position: absolute;
transform: translateY(sizing.rems(xl) - sizing.rems(xs));
}
@@ -663,7 +663,7 @@
margin-bottom: 0.25rem;
}
.flight-icon-arrow-right {
.hds-icon-arrow-right {
color: var(--token-color-foreground-faint);
}
}
@@ -913,7 +913,7 @@
.session-recording-status-badge {
/* stylelint-disable selector-class-pattern */
div.hds-badge__icon {
svg.flight-icon-circle-dot {
svg.hds-icon-circle-dot {
color: var(--token-color-palette-red-200);
}
}
ui/admin/app/templates/onboarding/success.hbs
+3 -2
View File
@@ -13,10 +13,11 @@
{{! We have created }}
<div class='create-resources-item'>
<span class='create-resources-item-header'>
<FlightIcon
<Hds::Icon
@name='check-circle'
@size='24'
class='hds-foreground-success'
@isInline={{true}}
/>
<h3>{{t 'onboarding.success.titles.creation-success'}}</h3>
</span>
@@ -26,7 +27,7 @@
{{! Download Desktop client }}
<div class='create-resources-item'>
<span class='create-resources-item-header'>
<FlightIcon @name='boundary-color' @size='24' />
<Hds::Icon @name='boundary-color' @size='24' @isInline={{true}} />
<h3>{{t 'onboarding.success.titles.desktop'}}</h3>
</span>
<p>{{t 'onboarding.success.descriptions.download'}}</p>
ui/admin/app/templates/scopes/scope/aliases/index.hbs
+1 -1
View File
@@ -75,7 +75,7 @@
<B.Td>
{{#if B.data.target.displayName}}
<div class='aliases-list-cell-item'>
<span><FlightIcon @name='target' /></span>
<span><Hds::Icon @name='target' @isInline={{true}} /></span>
<span> {{B.data.target.displayName}} </span>
</div>
{{else}}
ui/admin/app/templates/scopes/scope/session-recordings/index.hbs
+4 -4
View File
@@ -76,7 +76,7 @@
as |orgId items|
}}
<FD.Generic>
<FlightIcon @name='org' />
<Hds::Icon @name='org' @isInline={{true}} />
{{this.orgName orgId}}
</FD.Generic>
{{#each items as |project|}}
@@ -155,7 +155,7 @@
<div
class='session-recording-list-cell-item hds-font-weight-semibold'
>
<span><FlightIcon @name='user' /></span>
<span><Hds::Icon @name='user' @isInline={{true}} /></span>
<span>{{B.data.userDisplayName}}</span>
</div>
</B.Td>
@@ -165,7 +165,7 @@
class='session-recording-list-cell-item target-column hds-font-weight-semibold'
>
<span>
<FlightIcon @name='target' />
<Hds::Icon @name='target' @isInline={{true}} />
{{B.data.create_time_values.target.name}}
</span>
<span>
@@ -182,7 +182,7 @@
<div
class='session-recording-list-cell-item hds-foreground-faint'
>
<span><FlightIcon @name='clock' /></span>
<span><Hds::Icon @name='clock' @isInline={{true}} /></span>
<span>
{{format-time-duration B.data.duration}}
</span>
ui/admin/app/templates/scopes/scope/session-recordings/session-recording/channels-by-connection/channel/loading.hbs
+1 -1
View File
@@ -8,7 +8,7 @@
@model={{@model.sessionRecording.id}}
>
<div class='session-recording-player-loading'>
<FlightIcon @name='loading' @size='24' />
<Hds::Icon @name='loading' @size='24' @isInline={{true}} />
<span>{{t 'resources.session-recording.channel.player.loading'}}</span>
</div>
</SessionRecording::Player>
ui/admin/tests/acceptance/auth-methods/create-test.js
+1 -1
View File
@@ -48,7 +48,7 @@ module('Acceptance | auth-methods | create', function (hooks) {
const TOGGLE_SELECTOR = '[name="prompts"]';
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-auth-method] div:first-child button';
'[data-test-manage-auth-method] button:first-child';
const MAKE_PRIMARY_SELECTOR =
'[data-test-manage-auth-method] ul li:first-child button';
ui/admin/tests/acceptance/auth-methods/delete-test.js
+1 -1
View File
@@ -31,7 +31,7 @@ module('Acceptance | auth-methods | delete', function (hooks) {
const ERROR_MSG_SELECTOR = '.rose-notification-body';
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-auth-method] div:first-child button';
'[data-test-manage-auth-method] button:first-child';
const DELETE_ACTION_SELECTOR =
'[data-test-manage-auth-method] ul li:last-child button';
ui/admin/tests/acceptance/credential-library/delete-test.js
+1 -1
View File
@@ -18,7 +18,7 @@ module('Acceptance | credential-libraries | delete', function (hooks) {
let getCredentialLibraryCount;
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-credential-library-dropdown] div:first-child button';
'[data-test-manage-credential-library-dropdown] button:first-child';
const DELETE_ACTION_SELECTOR =
'[data-test-manage-credential-library-dropdown] ul li button';
ui/admin/tests/acceptance/credential-store/credentials/delete-test.js
+1 -1
View File
@@ -21,7 +21,7 @@ module(
let getJSONCredentialCount;
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-credentials-dropdown] div:first-child button';
'[data-test-manage-credentials-dropdown] button:first-child';
const DELETE_ACTION_SELECTOR =
'[data-test-manage-credentials-dropdown] ul li button';
ui/admin/tests/acceptance/credential-store/credentials/list-test.js
+1 -1
View File
@@ -14,7 +14,7 @@ module('Acceptance | credential-stores | credentials | list', function (hooks) {
setupMirage(hooks);
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-credential-stores-dropdown] div:first-child button';
'[data-test-manage-credential-stores-dropdown] button:first-child';
const ADD_CREDENTIALS_SELECTOR =
'[data-test-manage-credential-stores-dropdown] div ul li a';
ui/admin/tests/acceptance/credential-store/delete-test.js
+1 -1
View File
@@ -21,7 +21,7 @@ module('Acceptance | credential-stores | delete', function (hooks) {
let getStaticCredentialStoresCount;
let getVaultCredentialStoresCount;
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-credential-stores-dropdown] div:first-child button';
'[data-test-manage-credential-stores-dropdown] button:first-child';
const DELETE_ACTION_SELECTOR =
'[data-test-manage-credential-stores-dropdown] ul li button';
ui/admin/tests/acceptance/groups/delete-test.js
+2 -4
View File
@@ -19,10 +19,8 @@ module('Acceptance | groups | delete', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-group-dropdown] div:first-child button';
const DELETE_ACTION_SELECTOR =
'[data-test-manage-group-dropdown] ul li button';
const MANAGE_DROPDOWN_SELECTOR = "[data-test-manage-group-dropdown] button:first-child"
const DELETE_ACTION_SELECTOR = "[data-test-manage-group-dropdown] ul li button"
const instances = {
scopes: {
ui/admin/tests/acceptance/groups/members-test.js
+1 -1
View File
@@ -38,7 +38,7 @@ module('Acceptance | groups | members', function (hooks) {
};
let membersCount;
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-group-dropdown] div:first-child button';
'[data-test-manage-group-dropdown] button:first-child';
const ADD_MEMBERS_ACTION_SELECTOR =
'[data-test-manage-group-dropdown] ul li a';
ui/admin/tests/acceptance/host-catalogs/delete-test.js
+1 -1
View File
@@ -23,7 +23,7 @@ module('Acceptance | host-catalogs | delete', function (hooks) {
let getHostCatalogCount;
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-host-catalogs-dropdown] div:first-child button';
'[data-test-manage-host-catalogs-dropdown] button:first-child';
const DELETE_ACTION_SELECTOR =
'[data-test-manage-host-catalogs-dropdown] ul li button';
ui/admin/tests/acceptance/host-catalogs/host-sets/delete-test.js
+1 -1
View File
@@ -23,7 +23,7 @@ module('Acceptance | host-catalogs | host sets | delete', function (hooks) {
let getHostSetCount;
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-dropdown-host-sets] div:first-child button';
'[data-test-manage-dropdown-host-sets] button:first-child';
const DELETE_ACTION_SELECTOR =
'[data-test-manage-dropdown-host-sets] ul li button';
ui/admin/tests/acceptance/host-catalogs/host-sets/hosts-test.js
+1 -1
View File
@@ -29,7 +29,7 @@ module('Acceptance | host-catalogs | host-sets | hosts', function (hooks) {
let getHostSetHostCount;
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-dropdown-host-sets] div:first-child button';
'[data-test-manage-dropdown-host-sets] button:first-child';
const CREATE_AND_ADD_HOSTS_SELECTOR =
'[data-test-manage-dropdown-host-sets] div ul li:first-child a';
const ADD_EXISTING_HOSTS_SELECTOR =
ui/admin/tests/acceptance/host-catalogs/host-sets/list-test.js
+1 -1
View File
@@ -19,7 +19,7 @@ module('Acceptance | host-catalogs | host sets | list', function (hooks) {
setupMirage(hooks);
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-host-catalogs-dropdown] div:first-child button';
'[data-test-manage-host-catalogs-dropdown] button:first-child';
const instances = {
scopes: {
ui/admin/tests/acceptance/host-catalogs/hosts/delete-test.js
+1 -1
View File
@@ -23,7 +23,7 @@ module('Acceptance | host-catalogs | hosts | delete', function (hooks) {
let getHostCount;
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-hosts-dropdown] div:first-child button';
'[data-test-manage-hosts-dropdown] button:first-child';
const DELETE_ACTION_SELECTOR =
'[data-test-manage-hosts-dropdown] ul li button';
ui/admin/tests/acceptance/host-catalogs/hosts/list-test.js
+1 -1
View File
@@ -19,7 +19,7 @@ module('Acceptance | host-catalogs | hosts | list', function (hooks) {
setupMirage(hooks);
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-host-catalogs-dropdown] div:first-child button';
'[data-test-manage-host-catalogs-dropdown] button:first-child';
const NEW_HOST_SELECTOR =
'[data-test-manage-host-catalogs-dropdown] div ul li a';
ui/admin/tests/acceptance/host-catalogs/hosts/selectors.js
+1 -1
View File
@@ -4,7 +4,7 @@
*/
export const MANAGE_DROPDOWN =
'[data-test-manage-host-catalogs-dropdown] div:first-child button';
'[data-test-manage-host-catalogs-dropdown] button:first-child';
export const FIELD_ADDRESS = '[name=address]';
export const FIELD_ADDRESS_VALUE = 'New address';
ui/admin/tests/acceptance/managed-groups/create-test.js
+1 -1
View File
@@ -30,7 +30,7 @@ module('Acceptance | managed-groups | create', function (hooks) {
const DESC_INPUT_SELECTOR = '[name="description"]';
const ERROR_MSG_SELECTOR = '.rose-notification-body';
const FIELD_ERROR_TEXT_SELECTOR = '.hds-form-error__message';
const MANAGE_DROPDOWN_SELECTOR = '[data-test-manage-auth-method] div button';
const MANAGE_DROPDOWN_SELECTOR = '[data-test-manage-auth-method] button:first-child';
const instances = {
scopes: {
ui/admin/tests/acceptance/managed-groups/delete-test.js
+1 -1
View File
@@ -22,7 +22,7 @@ module('Acceptance | managed-groups | delete', function (hooks) {
let getManagedGroupCount;
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-managed-group-dropdown] div:first-child button';
'[data-test-managed-group-dropdown] button:first-child';
const DELETE_ACTION_SELECTOR =
'[data-test-managed-group-dropdown] ul li button';
const ERROR_MSG_SELECTOR = '.rose-notification-body';
ui/admin/tests/acceptance/managed-groups/list-test.js
+1 -1
View File
@@ -20,7 +20,7 @@ module('Acceptance | managed-groups | list', function (hooks) {
setupIndexedDb(hooks);
let featuresService;
const MANAGE_DROPDOWN_SELECTOR = '[data-test-manage-auth-method] div button';
const MANAGE_DROPDOWN_SELECTOR = '[data-test-manage-auth-method] button:first-child';
const instances = {
scopes: {
ui/admin/tests/acceptance/scopes/delete-test.js
+1 -1
View File
@@ -23,7 +23,7 @@ module('Acceptance | scopes | delete', function (hooks) {
let getScopeCount;
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-projects-dropdown] div:first-child button';
'[data-test-manage-projects-dropdown] button:first-child';
const DELETE_ACTION_SELECTOR =
'[data-test-manage-projects-dropdown] ul li button';
ui/admin/tests/acceptance/scopes/read-test.js
+1 -1
View File
@@ -26,7 +26,7 @@ module('Acceptance | scopes | read', function (hooks) {
const FORM_SELECTOR = 'main .rose-form';
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-projects-dropdown] div:first-child button';
'[data-test-manage-projects-dropdown] button:first-child';
const DELETE_ACTION_SELECTOR =
'[data-test-manage-projects-dropdown] ul li button';
const STORAGE_POLICY_SIDEBAR = '.policy-sidebar';
ui/admin/tests/acceptance/targets/delete-test.js
+1 -1
View File
@@ -23,7 +23,7 @@ module('Acceptance | targets | delete', function (hooks) {
let getTargetCount;
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-targets-dropdown] div:first-child button';
'[data-test-manage-targets-dropdown] button:first-child';
const DELETE_ACTION_SELECTOR =
'[data-test-manage-targets-dropdown] ul li button';
ui/admin/tests/acceptance/targets/host-sources-test.js
+1 -1
View File
@@ -22,7 +22,7 @@ module('Acceptance | targets | host-sources', function (hooks) {
let getTargetHostSetCount;
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-targets-dropdown] div:first-child button';
'[data-test-manage-targets-dropdown] button:first-child';
const ADD_HOSTSOURCE_SELECTOR = '[data-test-manage-targets-dropdown] ul li a';
const instances = {
ui/admin/tests/acceptance/users/accounts-test.js
+1 -1
View File
@@ -28,7 +28,7 @@ module('Acceptance | users | accounts', function (hooks) {
const ADD_ACCOUNTS_ACTION_SELECTOR =
'[data-test-manage-user-dropdown] ul li:first-child a';
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-user-dropdown] div:first-child button';
'[data-test-manage-user-dropdown] button:first-child';
const ERROR_MSG_SELECTOR = '[role="alert"]';
const TABLE_ROWS_SELECTOR = 'tbody tr';
const CHECKBOX_SELECTOR = 'tbody label';
ui/admin/tests/acceptance/users/delete-test.js
+2 -4
View File
@@ -20,10 +20,8 @@ module('Acceptance | users | delete', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);
setupIndexedDb(hooks);
const DELETE_ACTION_SELECTOR =
'[data-test-manage-user-dropdown] ul li button';
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-user-dropdown] div:first-child button';
const DELETE_ACTION_SELECTOR = "[data-test-manage-user-dropdown] ul li button"
const MANAGE_DROPDOWN_SELECTOR = "[data-test-manage-user-dropdown] button:first-child"
const instances = {
scopes: {
global: null,
ui/admin/tests/acceptance/workers/create-tags-test.js
+2 -2
View File
@@ -17,9 +17,9 @@ module('Acceptance | workers | worker | create-tags', function (hooks) {
const SAVE_BUTTON_SELECTOR = '[type="submit"]';
const CANCEL_BUTTON_SELECTOR = '.rose-form-actions [type="button"]';
const MANAGE_DROPDOWN_TOGGLE =
'[data-test-manage-worker-dropdown] div button';
'[data-test-manage-worker-dropdown] button:first-child';
const CREATE_TAGS_BUTTON_SELECTOR =
'[data-test-manage-worker-dropdown] div:first-child a';
'[data-test-manage-worker-dropdown] ul a:first-child';
const KEY_INPUT_SELECTOR = '[name="api_tags"] tr td:first-child input';
const VALUE_INPUT_SELECTOR = '[name="api_tags"] tr td:nth-child(2) input';
const ADD_INPUT_SELECTOR = '[name="api_tags"] tr td:last-child button';
ui/admin/tests/acceptance/workers/delete-test.js
+1 -1
View File
@@ -22,7 +22,7 @@ module('Acceptance | workers | delete', function (hooks) {
setupMirage(hooks);
const MANAGE_DROPDOWN_TOGGLE =
'[data-test-manage-worker-dropdown] div button';
'[data-test-manage-worker-dropdown] button:first-child';
const REMOVE_WORKER_BUTTON =
'[data-test-manage-worker-dropdown] div:nth-child(2) button';
let getWorkerCount;