From 77420d29c65b694d5f25bd5f060e48d1b9f76512 Mon Sep 17 00:00:00 2001 From: Randall Morey Date: Wed, 22 Sep 2021 18:34:35 -0400 Subject: [PATCH] =?UTF-8?q?chore:=20=F0=9F=A4=96=20rename=20credential=20s?= =?UTF-8?q?ource=20custom=20methods?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- addons/api/addon/models/target.js | 10 +++++----- addons/api/mirage/config.js | 4 ++-- addons/api/tests/unit/models/target-test.js | 6 +++--- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/addons/api/addon/models/target.js b/addons/api/addon/models/target.js index 48954ebbd..b50506dcb 100644 --- a/addons/api/addon/models/target.js +++ b/addons/api/addon/models/target.js @@ -152,7 +152,7 @@ export default class TargetModel extends GeneratedTargetModel { } /** - * Adds credential libraries via the `add-credential-libraries` method. + * Adds credential libraries via the `add-credential-sources` method. * See serializer and adapter for more information. * @param {[string]} credentialLibraryIDs * @param {object} options @@ -161,7 +161,7 @@ export default class TargetModel extends GeneratedTargetModel { */ addCredentialSources(credentialLibraryIDs, options = { adapterOptions: {} }) { const defaultAdapterOptions = { - method: 'add-credential-libraries', + method: 'add-credential-sources', credentialLibraryIDs, }; // There is no "deep merge" in ES. @@ -175,7 +175,7 @@ export default class TargetModel extends GeneratedTargetModel { } /** - * Delete credential libraries via the `remove-credential-libraries` method. + * Delete credential libraries via the `remove-credential-sources` method. * See serializer and adapter for more information. * @param {[string]} credentialLibraryIDs * @param {object} options @@ -187,7 +187,7 @@ export default class TargetModel extends GeneratedTargetModel { options = { adapterOptions: {} } ) { const defaultAdapterOptions = { - method: 'remove-credential-libraries', + method: 'remove-credential-sources', credentialLibraryIDs, }; // There is no "deep merge" in ES. @@ -201,7 +201,7 @@ export default class TargetModel extends GeneratedTargetModel { } /** - * Delete a single credential library set via the `remove-credential-libraries` method. + * Delete a single credential library set via the `remove-credential-sources` method. * @param {number} credentialLibraryID * @param {object} options * @return {Promise} diff --git a/addons/api/mirage/config.js b/addons/api/mirage/config.js index 90d290801..b39dff5a2 100644 --- a/addons/api/mirage/config.js +++ b/addons/api/mirage/config.js @@ -384,7 +384,7 @@ export default function () { }); } // If adding credential libraries, push them into the array - if (method === 'add-credential-libraries') { + if (method === 'add-credential-sources') { updatedAttrs.credentialLibraryIds = target.credentialLibraryIds; attrs.applicationCredentialSourceIds.forEach((id) => { if (!updatedAttrs.credentialLibraryIds.includes(id)) { @@ -393,7 +393,7 @@ export default function () { }); } // If deleting credential libraries, filter them out of the array - if (method === 'remove-credential-libraries') { + if (method === 'remove-credential-sources') { updatedAttrs.credentialLibraryIds = target.credentialLibraryIds; updatedAttrs.credentialLibraryIds = updatedAttrs.credentialLibraryIds.filter((id) => { diff --git a/addons/api/tests/unit/models/target-test.js b/addons/api/tests/unit/models/target-test.js index b753188ad..51be507e7 100644 --- a/addons/api/tests/unit/models/target-test.js +++ b/addons/api/tests/unit/models/target-test.js @@ -283,7 +283,7 @@ module('Unit | Model | target', function (hooks) { test('it has an `addCredentialSources` method that targets a specific POST API endpoint and serialization', async function (assert) { assert.expect(1); this.server.post( - '/v1/targets/123abc:add-credential-libraries', + '/v1/targets/123abc:add-credential-sources', (schema, request) => { const body = JSON.parse(request.requestBody); assert.deepEqual(body, { @@ -317,7 +317,7 @@ module('Unit | Model | target', function (hooks) { test('it has a `removeCredentialSources` method that targets a specific POST API endpoint and serialization', async function (assert) { assert.expect(1); this.server.post( - '/v1/targets/123abc:remove-credential-libraries', + '/v1/targets/123abc:remove-credential-sources', (schema, request) => { const body = JSON.parse(request.requestBody); assert.deepEqual(body, { @@ -351,7 +351,7 @@ module('Unit | Model | target', function (hooks) { test('it has a `removeCredentialSource` method that deletes a single credential library using `removeCredentialSources` method', async function (assert) { assert.expect(1); this.server.post( - '/v1/targets/123abc:remove-credential-libraries', + '/v1/targets/123abc:remove-credential-sources', (schema, request) => { const body = JSON.parse(request.requestBody); assert.deepEqual(body, {