From 79596010e9500077d247f2301b635c28a638437f Mon Sep 17 00:00:00 2001
From: Cameron Perera <cameron.perera@hashicorp.com>
Date: Fri, 8 Apr 2022 14:15:32 -0500
Subject: [PATCH] =?UTF-8?q?feat:=20=F0=9F=8E=B8=20Update=20Success=20Dialo?=
 =?UTF-8?q?g=20when=20connecting=20to=20target=20(#1046)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Updated the Success Dialog in desktop app when connecting to a target to
dynamically show target type

✅ Closes: ICU-3647
---
 .../scopes/scope/projects/targets.hbs         |  2 +-
 .../tests/acceptance/projects/targets-test.js | 43 +++++++++++++++++++
 2 files changed, 44 insertions(+), 1 deletion(-)

diff --git a/ui/desktop/app/templates/scopes/scope/projects/targets.hbs b/ui/desktop/app/templates/scopes/scope/projects/targets.hbs
index da18da753..3d785230a 100644
--- a/ui/desktop/app/templates/scopes/scope/projects/targets.hbs
+++ b/ui/desktop/app/templates/scopes/scope/projects/targets.hbs
@@ -20,7 +20,7 @@
           <:body>
             <h3>
               {{t 'resources.target.messages.proxy_url.title'}}
-              ({{t 'resources.target.types.tcp'}})
+              ({{t (concat 'resources.target.types.' target.type)}})
             </h3>
             <p>
               <Copyable
diff --git a/ui/desktop/tests/acceptance/projects/targets-test.js b/ui/desktop/tests/acceptance/projects/targets-test.js
index 2935cef15..7e14124e9 100644
--- a/ui/desktop/tests/acceptance/projects/targets-test.js
+++ b/ui/desktop/tests/acceptance/projects/targets-test.js
@@ -233,6 +233,49 @@ module('Acceptance | projects | targets', function (hooks) {
     );
   });
 
+  test('displays the correct target type (TCP) in the success dialog body', async function (assert) {
+    assert.expect(1);
+    stubs.ipcService.withArgs('cliExists').returns(true);
+    stubs.ipcService.withArgs('connect').returns({
+      session_id: instances.session.id,
+      address: 'a_123',
+      port: 'p_123',
+      protocol: 'tcp',
+    });
+    const confirmService = this.owner.lookup('service:confirm');
+    confirmService.enabled = true;
+    await visit(urls.targets);
+    await click(
+      'tbody tr:first-child td:last-child button',
+      'Activate connect mode'
+    );
+
+    assert.ok(find('.rose-dialog-body h3').textContent.trim().includes('TCP'));
+  });
+
+  test('displays the correct target type (SSH) in the success dialog body', async function (assert) {
+    assert.expect(1);
+    instances.target.update({
+      type: 'ssh',
+    });
+    stubs.ipcService.withArgs('cliExists').returns(true);
+    stubs.ipcService.withArgs('connect').returns({
+      session_id: instances.session.id,
+      address: 'a_123',
+      port: 'p_123',
+      protocol: 'ssh',
+    });
+    const confirmService = this.owner.lookup('service:confirm');
+    confirmService.enabled = true;
+    await visit(urls.targets);
+    await click(
+      'tbody tr:first-child td:last-child button',
+      'Activate connect mode'
+    );
+
+    assert.ok(find('.rose-dialog-body h3').textContent.trim().includes('SSH'));
+  });
+
   // Skipping because this test doesn't make sense.  Users will never even see
   // targets for which they do not have authorize-session.  The only reason this
   // test ever passed was because filtering in target mocks wasn't previously