From 79d024c07c8dacd92a5fda15b9bb1daecb95d445 Mon Sep 17 00:00:00 2001
From: Susmitha Girumala <susmitha@hashicorp.com>
Date: Mon, 27 Jul 2020 16:42:02 -0400
Subject: [PATCH] =?UTF-8?q?chore:=20=F0=9F=A4=96=20Refactor=20group=20CRUD?=
 =?UTF-8?q?+L=20to=20/scopes/:scope=5Fid?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 ui/core/app/router.js                         |  4 ++
 ui/core/app/routes/scopes/scope/groups.js     | 72 +++++++++++++++++++
 .../app/routes/scopes/scope/groups/group.js   | 17 +++++
 .../routes/scopes/scope/groups/group/index.js |  3 +
 .../app/routes/scopes/scope/groups/index.js   |  3 +
 ui/core/app/routes/scopes/scope/groups/new.js | 13 ++++
 ui/core/app/routes/scopes/scope/users.js      |  4 +-
 ui/core/app/templates/scopes/scope.hbs        |  3 +
 ui/core/app/templates/scopes/scope/groups.hbs |  3 +
 .../templates/scopes/scope/groups/group.hbs   |  3 +
 .../scopes/scope/groups/group/index.hbs       | 35 +++++++++
 .../templates/scopes/scope/groups/index.hbs   | 63 ++++++++++++++++
 .../app/templates/scopes/scope/groups/new.hbs | 21 ++++++
 .../unit/routes/scopes/scope/groups-test.js   | 11 +++
 .../routes/scopes/scope/groups/group-test.js  | 11 +++
 .../scopes/scope/groups/group/index-test.js   | 11 +++
 .../routes/scopes/scope/groups/index-test.js  | 11 +++
 .../routes/scopes/scope/groups/new-test.js    | 11 +++
 18 files changed, 297 insertions(+), 2 deletions(-)
 create mode 100644 ui/core/app/routes/scopes/scope/groups.js
 create mode 100644 ui/core/app/routes/scopes/scope/groups/group.js
 create mode 100644 ui/core/app/routes/scopes/scope/groups/group/index.js
 create mode 100644 ui/core/app/routes/scopes/scope/groups/index.js
 create mode 100644 ui/core/app/routes/scopes/scope/groups/new.js
 create mode 100644 ui/core/app/templates/scopes/scope/groups.hbs
 create mode 100644 ui/core/app/templates/scopes/scope/groups/group.hbs
 create mode 100644 ui/core/app/templates/scopes/scope/groups/group/index.hbs
 create mode 100644 ui/core/app/templates/scopes/scope/groups/index.hbs
 create mode 100644 ui/core/app/templates/scopes/scope/groups/new.hbs
 create mode 100644 ui/core/tests/unit/routes/scopes/scope/groups-test.js
 create mode 100644 ui/core/tests/unit/routes/scopes/scope/groups/group-test.js
 create mode 100644 ui/core/tests/unit/routes/scopes/scope/groups/group/index-test.js
 create mode 100644 ui/core/tests/unit/routes/scopes/scope/groups/index-test.js
 create mode 100644 ui/core/tests/unit/routes/scopes/scope/groups/new-test.js

diff --git a/ui/core/app/router.js b/ui/core/app/router.js
index 1c3e3e78b..0e7e5f7f7 100644
--- a/ui/core/app/router.js
+++ b/ui/core/app/router.js
@@ -17,6 +17,10 @@ Router.map(function () {
         this.route('user', { path: ':user_id' }, function () {});
         this.route('new');
       });
+      this.route('groups', function () {
+        this.route('group', { path: ':group_id' }, function () {});
+        this.route('new');
+      });
     });
   });
 
diff --git a/ui/core/app/routes/scopes/scope/groups.js b/ui/core/app/routes/scopes/scope/groups.js
new file mode 100644
index 000000000..0344e53f1
--- /dev/null
+++ b/ui/core/app/routes/scopes/scope/groups.js
@@ -0,0 +1,72 @@
+import Route from '@ember/routing/route';
+import { inject as service } from '@ember/service';
+import { action } from '@ember/object';
+
+export default class ScopesScopeGroupsRoute extends Route {
+  // =services
+
+  @service intl;
+  @service notify;
+
+  // =methods
+
+  /**
+   * Load all groups under current scope
+   * @return {Promise[GroupModel]}
+   */
+  async model() {
+    return this.store.findAll('group', this.scopeAdapterOptions());
+  }
+
+  // =actions
+  /**
+   * Rollback changes on a group.
+   * @param {GroupModel} group
+   */
+  @action
+  cancel(group) {
+    const { isNew } = group;
+    group.rollbackAttributes();
+    if (isNew) this.transitionTo('scopes.scope.groups');
+  }
+
+  /**
+   * Save a group in current scope.
+   * @param {GroupModel} group
+   */
+  @action
+  async save(group) {
+    try {
+      await group.save(this.scopeAdapterOptions());
+      this.refresh();
+      this.notify.success(this.intl.t('notify.save-success'));
+      this.transitionTo('scopes.scope.groups.group', group);
+    } catch (error) {
+      //TODO: replace with translated strings
+      this.notify.error(error.message, { closeAfter: null });
+    }
+  }
+
+  /**
+   * Delete a group in current scope and redirect to index
+   * @param {GroupModel} group
+   */
+  @action
+  async delete(group) {
+    try {
+      await group.destroyRecord(this.scopeAdapterOptions());
+      this.refresh();
+      this.transitionTo('scopes.scope.groups');
+      this.notify.success(this.intl.t('notify.group.delete-success'));
+    } catch (error) {
+      //TODO: replace with translated strings
+      this.notify.error(error.message, { closeAfter: null });
+    }
+  }
+
+  scopeAdapterOptions() {
+    const { id: scope_id } = this.modelFor('scopes.scope');
+    const adapterOptions = { scopeID: scope_id };
+    return { adapterOptions };
+  }
+}
diff --git a/ui/core/app/routes/scopes/scope/groups/group.js b/ui/core/app/routes/scopes/scope/groups/group.js
new file mode 100644
index 000000000..da536ed07
--- /dev/null
+++ b/ui/core/app/routes/scopes/scope/groups/group.js
@@ -0,0 +1,17 @@
+import Route from '@ember/routing/route';
+
+export default class ScopesScopeGroupsGroupRoute extends Route {
+  // =methods
+
+  /**
+   * Load a group in current scope.
+   * @param {object} params
+   * @param {string} params.group_id
+   * @return {groupModel}
+   */
+  async model({ group_id }) {
+    const { id: scope_id } = this.modelFor('scopes.scope');
+    const adapterOptions = { scopeID: scope_id };
+    return this.store.findRecord('group', group_id, { adapterOptions });
+  }
+}
diff --git a/ui/core/app/routes/scopes/scope/groups/group/index.js b/ui/core/app/routes/scopes/scope/groups/group/index.js
new file mode 100644
index 000000000..90f0fb3a1
--- /dev/null
+++ b/ui/core/app/routes/scopes/scope/groups/group/index.js
@@ -0,0 +1,3 @@
+import Route from '@ember/routing/route';
+
+export default class ScopesScopeGroupsGroupIndexRoute extends Route {}
diff --git a/ui/core/app/routes/scopes/scope/groups/index.js b/ui/core/app/routes/scopes/scope/groups/index.js
new file mode 100644
index 000000000..7d2a20fb0
--- /dev/null
+++ b/ui/core/app/routes/scopes/scope/groups/index.js
@@ -0,0 +1,3 @@
+import Route from '@ember/routing/route';
+
+export default class ScopesScopeGroupsIndexRoute extends Route {}
diff --git a/ui/core/app/routes/scopes/scope/groups/new.js b/ui/core/app/routes/scopes/scope/groups/new.js
new file mode 100644
index 000000000..e33233f5f
--- /dev/null
+++ b/ui/core/app/routes/scopes/scope/groups/new.js
@@ -0,0 +1,13 @@
+import Route from '@ember/routing/route';
+
+export default class ScopesScopeGroupsNewRoute extends Route {
+  // =methods
+
+  /**
+   * Creates a new unsaved group.
+   * @return {GroupModel}
+   */
+  model() {
+    return this.store.createRecord('group');
+  }
+}
diff --git a/ui/core/app/routes/scopes/scope/users.js b/ui/core/app/routes/scopes/scope/users.js
index 2720f56b1..bf0ba95c4 100644
--- a/ui/core/app/routes/scopes/scope/users.js
+++ b/ui/core/app/routes/scopes/scope/users.js
@@ -20,7 +20,7 @@ export default class ScopesScopeUsersRoute extends Route {
 
   // =actions
   /**
-   * Rollback changes on user.
+   * Rollback changes on an user.
    * @param {UserModel} user
    */
   @action
@@ -31,7 +31,7 @@ export default class ScopesScopeUsersRoute extends Route {
   }
 
   /**
-   * Save a user in current scope.
+   * Save an user in current scope.
    * @param {UserModel} user
    * @param {Event} e
    */
diff --git a/ui/core/app/templates/scopes/scope.hbs b/ui/core/app/templates/scopes/scope.hbs
index ee969738f..f3199821b 100644
--- a/ui/core/app/templates/scopes/scope.hbs
+++ b/ui/core/app/templates/scopes/scope.hbs
@@ -12,6 +12,9 @@
       <nav.link @route="scopes.scope.users">
         {{t "resources.users"}}
       </nav.link>
+      <nav.link @route="scopes.scope.groups">
+        {{t "resources.groups"}}
+      </nav.link>
     </Rose::Nav::Sidebar>
 
     {{outlet "sidebar"}}
diff --git a/ui/core/app/templates/scopes/scope/groups.hbs b/ui/core/app/templates/scopes/scope/groups.hbs
new file mode 100644
index 000000000..c53da7f4b
--- /dev/null
+++ b/ui/core/app/templates/scopes/scope/groups.hbs
@@ -0,0 +1,3 @@
+{{title (t "resources.groups")}}
+
+{{outlet}}
diff --git a/ui/core/app/templates/scopes/scope/groups/group.hbs b/ui/core/app/templates/scopes/scope/groups/group.hbs
new file mode 100644
index 000000000..d66e83390
--- /dev/null
+++ b/ui/core/app/templates/scopes/scope/groups/group.hbs
@@ -0,0 +1,3 @@
+{{title @model.displayName}}
+
+{{outlet}}
diff --git a/ui/core/app/templates/scopes/scope/groups/group/index.hbs b/ui/core/app/templates/scopes/scope/groups/group/index.hbs
new file mode 100644
index 000000000..ac8915f59
--- /dev/null
+++ b/ui/core/app/templates/scopes/scope/groups/group/index.hbs
@@ -0,0 +1,35 @@
+<Rose::Layout::Page as |page|>
+
+  <page.breadcrumbs>
+    <BreadCrumbs />
+  </page.breadcrumbs>
+
+  <page.header>
+    <h2>{{t "resources.group"}}</h2>
+  </page.header>
+
+  <page.navigation>
+    <Rose::Nav::Tabs as |nav|>
+      <nav.link @route='scopes.scope.groups.group'>
+        {{t 'titles.details'}}
+      </nav.link>
+    </Rose::Nav::Tabs>
+  </page.navigation>
+
+  <page.body>
+    <Form::Project
+      @model={{@model}}
+      @submit={{route-action "save" @model}}
+      @cancel={{route-action "cancel" @model}}
+    />
+    <Rose::Separator />
+    <Rose::Button
+      @style="warning"
+      @disabled={{@model.canSave}}
+      {{on "click" (route-action "delete" @model)}}
+    >
+      {{t 'actions.delete'}}
+    </Rose::Button>
+  </page.body>
+
+</Rose::Layout::Page>
diff --git a/ui/core/app/templates/scopes/scope/groups/index.hbs b/ui/core/app/templates/scopes/scope/groups/index.hbs
new file mode 100644
index 000000000..cddaa478b
--- /dev/null
+++ b/ui/core/app/templates/scopes/scope/groups/index.hbs
@@ -0,0 +1,63 @@
+<Rose::Layout::Page as |page|>
+
+  <page.breadcrumbs>
+    <BreadCrumbs />
+  </page.breadcrumbs>
+
+  <page.header>
+    <h2>{{t "resources.groups"}}</h2>
+  </page.header>
+
+  <page.actions>
+    {{#if @model}}
+      <Rose::LinkButton @route="scopes.scope.groups.new" @style="primary">{{t 'titles.new'}}</Rose::LinkButton>
+    {{/if}}
+  </page.actions>
+
+  <page.body>
+
+    {{#if @model}}
+
+      <Rose::Table as |table|>
+        <table.header as |header|>
+          <header.row as |row|>
+            <row.cell>{{t 'form.label.name'}}</row.cell>
+            <row.cell>{{t 'form.label.description'}}</row.cell>
+          </header.row>
+        </table.header>
+        <table.body as |body|>
+          {{#each @model as |group|}}
+            <body.row as |row|>
+              <row.cell>
+                <LinkTo
+                  @route="scopes.scope.groups.group"
+                  @model={{group}}
+                >
+                  {{group.name}}
+                </LinkTo>
+              </row.cell>
+              <row.cell>{{group.description}}</row.cell>
+            </body.row>
+          {{/each}}
+        </table.body>
+      </Rose::Table>
+
+    {{else}}
+
+      <Rose::Layout::Centered>
+        <Rose::Message @title={{t 'titles.groups-welcome'}} as |message|>
+          <message.description>
+            {{t 'descriptions.groups-welcome'}}
+          </message.description>
+          <message.link @route="scopes.scope.groups.new">
+            <Rose::Icon @name="plus-circle-outline" />
+            {{t 'titles.new'}}
+          </message.link>
+        </Rose::Message>
+      </Rose::Layout::Centered>
+
+    {{/if}}
+
+  </page.body>
+
+</Rose::Layout::Page>
diff --git a/ui/core/app/templates/scopes/scope/groups/new.hbs b/ui/core/app/templates/scopes/scope/groups/new.hbs
new file mode 100644
index 000000000..b8f782b23
--- /dev/null
+++ b/ui/core/app/templates/scopes/scope/groups/new.hbs
@@ -0,0 +1,21 @@
+{{title (t 'titles.new')}}
+
+<Rose::Layout::Page as |page|>
+
+  <page.breadcrumbs>
+    <BreadCrumbs />
+  </page.breadcrumbs>
+
+  <page.header>
+    <h2>{{t "titles.new"}}</h2>
+  </page.header>
+
+  <page.body>
+    <Form::Group
+      @model={{@model}}
+      @submit={{route-action "save" @model}}
+      @cancel={{route-action "cancel" @model}}
+    />
+  </page.body>
+
+</Rose::Layout::Page>
diff --git a/ui/core/tests/unit/routes/scopes/scope/groups-test.js b/ui/core/tests/unit/routes/scopes/scope/groups-test.js
new file mode 100644
index 000000000..879a3925b
--- /dev/null
+++ b/ui/core/tests/unit/routes/scopes/scope/groups-test.js
@@ -0,0 +1,11 @@
+import { module, test } from 'qunit';
+import { setupTest } from 'ember-qunit';
+
+module('Unit | Route | scopes/scope/groups', function (hooks) {
+  setupTest(hooks);
+
+  test('it exists', function (assert) {
+    let route = this.owner.lookup('route:scopes/scope/groups');
+    assert.ok(route);
+  });
+});
diff --git a/ui/core/tests/unit/routes/scopes/scope/groups/group-test.js b/ui/core/tests/unit/routes/scopes/scope/groups/group-test.js
new file mode 100644
index 000000000..8f8cc6713
--- /dev/null
+++ b/ui/core/tests/unit/routes/scopes/scope/groups/group-test.js
@@ -0,0 +1,11 @@
+import { module, test } from 'qunit';
+import { setupTest } from 'ember-qunit';
+
+module('Unit | Route | scopes/scope/groups/group', function (hooks) {
+  setupTest(hooks);
+
+  test('it exists', function (assert) {
+    let route = this.owner.lookup('route:scopes/scope/groups/group');
+    assert.ok(route);
+  });
+});
diff --git a/ui/core/tests/unit/routes/scopes/scope/groups/group/index-test.js b/ui/core/tests/unit/routes/scopes/scope/groups/group/index-test.js
new file mode 100644
index 000000000..3981831ad
--- /dev/null
+++ b/ui/core/tests/unit/routes/scopes/scope/groups/group/index-test.js
@@ -0,0 +1,11 @@
+import { module, test } from 'qunit';
+import { setupTest } from 'ember-qunit';
+
+module('Unit | Route | scopes/scope/groups/group/index', function (hooks) {
+  setupTest(hooks);
+
+  test('it exists', function (assert) {
+    let route = this.owner.lookup('route:scopes/scope/groups/group/index');
+    assert.ok(route);
+  });
+});
diff --git a/ui/core/tests/unit/routes/scopes/scope/groups/index-test.js b/ui/core/tests/unit/routes/scopes/scope/groups/index-test.js
new file mode 100644
index 000000000..f50de2922
--- /dev/null
+++ b/ui/core/tests/unit/routes/scopes/scope/groups/index-test.js
@@ -0,0 +1,11 @@
+import { module, test } from 'qunit';
+import { setupTest } from 'ember-qunit';
+
+module('Unit | Route | scopes/scope/groups/index', function (hooks) {
+  setupTest(hooks);
+
+  test('it exists', function (assert) {
+    let route = this.owner.lookup('route:scopes/scope/groups/index');
+    assert.ok(route);
+  });
+});
diff --git a/ui/core/tests/unit/routes/scopes/scope/groups/new-test.js b/ui/core/tests/unit/routes/scopes/scope/groups/new-test.js
new file mode 100644
index 000000000..6e689bdd3
--- /dev/null
+++ b/ui/core/tests/unit/routes/scopes/scope/groups/new-test.js
@@ -0,0 +1,11 @@
+import { module, test } from 'qunit';
+import { setupTest } from 'ember-qunit';
+
+module('Unit | Route | scopes/scope/groups/new', function (hooks) {
+  setupTest(hooks);
+
+  test('it exists', function (assert) {
+    let route = this.owner.lookup('route:scopes/scope/groups/new');
+    assert.ok(route);
+  });
+});